zoitechat

5,003 Commits 11 Branches 18 Tags

3 Commits

Author	SHA1	Message	Date
Theo Buehler	646ad029f0	Fix clang -Wstrict-prototypes warnings This trivial diff gets rid of noisy warnings such as ``` ./src/common/ignore.c:274:13: warning: a function declaration without a prototype is deprecated in all versions of C [-Wstrict-prototypes] 274 \| ignore_load () \| ^ \| void ``` when building with modern clang. This is cosmetic since these functions are actually prototyped in a header, so if the header is in scope it's not possible to call them with an arbitrary number of arguments.	2026-10-13 09:46:10 +02:00
Theo Buehler	d47963247d	challengeauth_response (): move digest to stack Using HMAC ()'s facility of returning the digest in a static array is not thread safe (this can't be fixed) and it is not portable to the OpenSSL forks: BoringSSL removed support for this a decade ago (so aws-lc doesn't support it either) and LibreSSL followed a few years back. There is no downside to having a 32-byte array on the stack and it would make zoitechat safe to use from other forks without the need of patching it. Add an error check for the HMAC () call and handle the error in the caller.	2026-10-13 09:25:22 +02:00
Theo Buehler	e1c44feb01	Minor simplification of _SSL_get_cert_info () Instead of retrieving the AlgorithmIdentifier and then reaching into it to get the OID, the relevant OID can be obtained directly from the same function.	2026-10-11 17:45:37 +02:00

Author

SHA1

Message

Date

Theo Buehler

646ad029f0

Fix clang -Wstrict-prototypes warnings

This trivial diff gets rid of noisy warnings such as
```
./src/common/ignore.c:274:13: warning: a function declaration without a prototype is deprecated in all versions of C [-Wstrict-prototypes]
  274 | ignore_load ()
      |             ^
      |              void
```
when building with modern clang. This is cosmetic since these functions
are actually prototyped in a header, so if the header is in scope it's
not possible to call them with an arbitrary number of arguments.

2026-10-13 09:46:10 +02:00

Theo Buehler

d47963247d

challengeauth_response (): move digest to stack

Using HMAC ()'s facility of returning the digest in a static array is
not thread safe (this can't be fixed) and it is not portable to the
OpenSSL forks: BoringSSL removed support for this a decade ago (so
aws-lc doesn't support it either) and LibreSSL followed a few years
back.

There is no downside to having a 32-byte array on the stack and it would
make zoitechat safe to use from other forks without the need of patching
it.

Add an error check for the HMAC () call and handle the error in the
caller.

2026-10-13 09:25:22 +02:00

Theo Buehler

e1c44feb01

Minor simplification of _SSL_get_cert_info ()

Instead of retrieving the AlgorithmIdentifier and then reaching into it
to get the OID, the relevant OID can be obtained directly from the same
function.

2026-10-11 17:45:37 +02:00