3cff6742f5
Removed unneeded inline comments around the Win32 error-formatting fallback in errorstring() and simplified matching block-closing lines, without changing behavior.
deepend2026-02-25 02:37:08 -07:00
6a02f578b6
Removed obsolete commented-out lines from fe_cleanup() so the function no longer contains dead commented code.
deepend2026-02-25 02:34:50 -07:00
e62769b361
Cleaned up unneeded comments in DCC receive/connect code by removing:
deepend2026-02-25 02:30:46 -07:00
9df9776238
Removed a stale multi-line # TODO note block from the common Meson build file to clean up unneeded comments without changing build logic.
deepend2026-02-25 02:28:10 -07:00
4beabb6bf5
Removed a stale commented-out debug function block from the fishlim plugin source to reduce dead/commented code. Removed the corresponding commented-out RAW LINE hook entry so only active handlers remain in plugin initialization.
deepend2026-02-25 02:24:11 -07:00
10d5bb91ab
Cleaned up unneeded, commented-out debug logging lines in Perl plugin callback handlers (server_cb, command_cb, and print_cb) without changing runtime behavior.
deepend2026-02-25 02:14:38 -07:00
7c9c615aed
Removed redundant inline comments from the fishlim IRC parsing helpers where the comments only repeated obvious code behavior, while preserving all function docblocks and logic.
deepend2026-02-25 02:12:10 -07:00
fd48c97209
Removed four redundant inline comments in src/fe-gtk/urlgrab.c to clean up readability without changing behavior (treeview enum declaration area, right-click selection block, headers visibility call, and URL list overflow trimming block).
deepend2026-02-25 02:09:35 -07:00
e58bf2be22
Cleaned up redundant comments in dcc_listen_init by removing obvious/explanatory noise and an obsolete commented-out debug printf, while leaving logic unchanged.
deepend2026-02-25 02:07:38 -07:00
dc6453e230
Removed redundant inline comments in lastact_update and lastact_getfirst where the code was already self-explanatory, without changing behavior. Simplified away_check by removing comment clutter and keeping only the logic flow, including the WHO batching behavior. Removed unneeded commentary around lag-check helpers and timer reinitialization to keep the core timer code cleaner and easier to scan.
deepend2026-02-25 02:04:31 -07:00
b3a0288fd9
Cleaned up stale inline comments in the tab scrolling handlers by removing outdated explanatory text while keeping behavior unchanged (tab_left_is_moving / tab_right_is_moving reset paths). Removed an old commented-out gtk_container_set_border_width(...) line that was dead/commented code in cv_tabs_init. Simplified the tab-switch condition by removing a legacy commented expression from if (is_switching).
deepend2026-02-25 02:01:11 -07:00
9c86f18982
Cleaned up unneeded inline comments in plugins/python/python.py while keeping runtime behavior unchanged (comment-only cleanup around version declaration, compile helpers, wordlist/timer handling, and autoload path handling).
deepend2026-02-25 01:58:19 -07:00
1bf0140652
Cleaned up redundant inline comments in the SCRAM implementation so the file is less noisy while preserving behavior exactly as-is (no logic changes).
deepend2026-02-25 01:54:34 -07:00
bb72f8afab
Removed redundant inline comments from the common header includes/platform guards in src/common/zoitechat.h (e.g., comments like “need time_t”, “for win32”, “for unix”), while preserving meaningful explanatory comments.
deepend2026-02-25 01:50:00 -07:00
bb11c4676b
Cleaned up src/fe-gtk/meson.build by removing an outdated commented-out WinRT build block in the Windows section, leaving only active build logic. Removed an inline TODO comment from the gnome.compile_resources call to keep the Meson configuration concise and focused on current settings.
deepend2026-02-25 01:47:32 -07:00
32fe3e54f1
Removed redundant section-divider comments in the Windows spellcheck provider to reduce clutter without changing behavior. Removed non-essential inline comments that restated obvious return values and assignment intent (return -1/1/0, add_to_exclude alias), keeping logic identical.
deepend2026-02-25 01:45:20 -07:00
9d2187ca4d
Cleaned up unneeded inline comments in src/fe-text/fe-text.c where control-character switch cases were already self-explanatory, while keeping behavior unchanged. Removed a redundant comment from the done global flag declaration for a cleaner declaration section.
deepend2026-02-25 01:43:01 -07:00
0e94432c24
Removed four redundant comments in plugins/sysinfo/sysinfo.c while keeping behavior unchanged (the command parsing, channel checks, and menu add/remove calls are intact).
deepend2026-02-25 01:40:34 -07:00
c4890d157a
Cleaned up redundant inline comments in the exec plugin’s command execution path (pipe creation, buffer termination, per-line announce handling, sleep loop, and trailing newline output) without changing behavior.
deepend2026-02-25 01:38:06 -07:00
ef2befa698
Cleaned up redundant comments in src/fe-gtk/fkeys.c by removing section-divider noise and a stale XXX line near key-action helpers, while keeping useful function-level documentation. Removed repetitive inline comments from return 2; statements in tab-move/history key actions, since behavior is already clear from the surrounding code. Removed an unnecessary separator comment before replace_handle() for a cleaner transition between functions.
deepend2026-02-25 01:35:30 -07:00
5f9ce549f8
Removed redundant inline comments in the timer plugin that did not add useful context (plugin handle declaration and return value comment), keeping behavior unchanged. Removed an obsolete visual alignment guide comment above the timer list header print call to clean up the function body.
deepend2026-02-25 01:32:27 -07:00
cb435f0d15
Cleaned up unneeded comments in default config initialization by removing:
deepend2026-02-25 01:29:05 -07:00
105e259f2c
Removed redundant inline /* plugin handle */ comments from the ph declarations in three plugin source files, keeping behavior unchanged and making the declarations cleaner.
deepend2026-02-25 01:06:13 -07:00
51bf0c3fe0
Removed redundant explanatory comments in chanopt_command so the control flow reads cleanly without inline narration, while keeping behavior unchanged. Simplified the chanopt_in_memory struct and helper routines by removing comments that repeated obvious intent (allocation/default initialization/loading notes), with no logic changes.
deepend2026-02-25 01:02:37 -07:00
e6311a5fe7
Removed two stale, commented-out lines in ignore_showlist() (an unused EMIT_SIGNAL call and its note), cleaning up unneeded comments without changing runtime behavior.
deepend2026-02-25 00:59:53 -07:00
2c90c14d72
Removed an unneeded comment above the $(CONFIG_STAMP) target in Makefile, leaving behavior unchanged and just cleaning up the file.
deepend2026-02-25 00:57:30 -07:00
6c9aeac36f
Cleaned up unneeded inline comments in swtype by removing index/reserved annotations that didn’t add value, while keeping the data unchanged. Removed a stale commented-out ST_HEADER line from tabs_settings so the settings table only contains active entries. Removed a dead commented-out call from setup_apply_trans to reduce noise in the function body. Removed redundant trailing declaration comments from proxy_user and proxy_pass since the types are already explicit.
deepend2026-02-25 00:55:37 -07:00
48f7693eac
Removed redundant comments in the notification plugin implementation to clean up the code without changing behavior (including comments around color stripping, alert gating logic, and special-event hook registration).
deepend2026-02-25 00:53:10 -07:00
71d3ba576f
Removed an outdated TODO comment in plugins/python/python.py above the module-level state variables, keeping behavior unchanged while reducing noise. Removed two stale TODO comments in plugins/python/_zoitechat.py above command() and hook_command(), with no functional changes to those APIs.
deepend2026-02-25 00:49:54 -07:00
067670bd01
Removed three redundant inline comments in the server helper code to clean up readability without changing any behavior: Deleted comment above the serv->network check in server_get_network. Deleted comment above the server_session->channel check in server_get_network. Deleted comment above the name != serv->servername guard in server_set_name.
deepend2026-02-25 00:46:18 -07:00
610d6fa1c0
Removed stale, commented-out SSL debug code in ssl_cb_info, leaving the function behavior unchanged while cleaning dead comments. Removed an old commented-out rsa_tmp_bits certificate logging block in the SSL certificate info path. Removed commented-out “Verify OK” signal lines in the SSL verification switch for cleaner control-flow comments.
deepend2026-02-25 00:43:03 -07:00
5d6fa503c9
Cleaned up redundant CI workflow comments in AppImage workflow sections where the commands are already self-explanatory, including plugin listing and environment export blocks. Replaced a long explanatory Solus packaging comment block with a concise single-line comment that preserves the key intent for --ignore-file-conflicts and toolchain installation. Removed unneeded inline comments in the Windows build workflow around Python root resolution and junction creation while keeping behavior unchanged.
deepend2026-02-25 00:40:36 -07:00
375e747014
Removed four redundant section-label comments from plugins/python/generate_plugin.py to clean up non-essential commentary while keeping behavior unchanged (# zoitechat-plugin.h, # This is very specific..., # python.py, # python.c).
deepend2026-02-25 00:38:03 -07:00
5cab7be8a9
Removed redundant inline comments in notify network filtering and server-entry lookup paths to clean up noise without changing behavior. Simplified notify list preparation in notify_save into a single reverse-copy expression and normalized GLib call spacing for consistency.
deepend2026-02-25 00:34:59 -07:00
4808d83b26
Cleaned up unneeded inline comments in IRC inbound handling by removing redundant // comments around session selection and SCRAM auth status branches, with no logic changes.
deepend2026-02-25 00:32:23 -07:00
c4951a06f3
Cleaned up unneeded commented-out debug lines in maingui.c (old printf/puts and an obsolete commented call), without changing behavior or logic flow. Committed the cleanup on the current branch with commit message: Remove stale debug comments from maingui.
deepend2026-02-25 00:29:52 -07:00
bd418160e1
Removed four redundant inline comments in print_sha256_result so the function is cleaner without changing behavior or control flow.
deepend2026-02-25 00:26:56 -07:00
90a3d6d839
Removed redundant comments in url_save_node() and url_add() so the function bodies are cleaner without changing logic. Removed an outdated performance note comment before the cached match state variables and a redundant comment in match_nick(); behavior remains unchanged.
deepend2026-02-25 00:23:42 -07:00
618aecd349
Fixed a crash-prone memory management path in Linux URL launching by only freeing the previous environment vector when g_environ_unsetenv() returns a different pointer. This avoids freeing memory that may still be owned/returned as-is by GLib, which matches your segfault symptoms when opening links from the AppImage build.
deepend2026-02-24 20:29:48 -07:00
3ed66f9945
Updated Linux URL-opening logic in fe_open_url_inner to sanitize runtime linker env vars (LD_LIBRARY_PATH, LD_PRELOAD) before launching external URL handlers, which is aimed at preventing /bin/sh symbol lookup failures in AppImage-like environments.
deepend2026-02-24 20:22:54 -07:00
4284cb76c1
Updated Linux URL opening fallback in fe_open_url_inner to launch xdg-open with a sanitized environment instead of inheriting AppImage runtime linker vars. Specifically, LD_LIBRARY_PATH and LD_PRELOAD are removed before spawning, which prevents host /bin/sh and related tools from loading incompatible bundled libraries (the root cause of the rl_trim_arg_from_keyseq symbol error). Kept the existing behavior of trying gtk_show_uri first and only using xdg-open as fallback; this change only hardens the fallback path and preserves existing flow/logging.
deepend2026-02-24 20:13:48 -07:00
b7693e75ec
Updated Linux URL launching in fe_open_url_inner to capture gtk_show_uri errors instead of discarding them, so failures are no longer silent. Added an xdg-open fallback path when gtk_show_uri fails, which improves behavior in AppImage/sandbox-like environments where GTK/GIO handler resolution can fail. Added warning logs for both the primary gtk_show_uri failure and fallback failure to make future debugging much easier.
deepend2026-02-24 19:36:36 -07:00
91485465c9
I applied the same compatibility approach to Lua so HexChat/XChat-style scripts can run against the existing ZoiteChat Lua API table. Specifically, I added EAT_XCHAT and EAT_HEXCHAT as aliases of EAT_ZOITECHAT in the exported Lua constants.
deepend2026-02-24 17:55:04 -07:00
1c39d7b9ad
Added hexchat.py to the Windows packaging copy step so the compatibility module is shipped alongside xchat.py/zoitechat.py in ZoiteChatRel\python, which resolves import hexchat failures for HexChat-style addons on Windows builds.
deepend2026-02-24 15:56:29 -07:00
69b007f849
Merge pull request #85 from ZoiteChat/deepend-tildeclub-default-server-fix
deepend-tildeclub2026-02-24 14:22:15 -07:00
118ac25059
Change network name check from 'Libera.Chat' to 'Zoite'
deepend-tildeclub2026-02-24 14:22:01 -07:00
9ee8a53b9c
Moved the Flatpak display troubleshooting content from readme.md into a standalone troubleshooting.md document, as requested.
deepend2026-02-24 11:48:04 -07:00
e407ef6c47
Merge pull request #82 from ZoiteChat/extra-character-highlight-fix
deepend-tildeclub2026-02-24 11:46:44 -07:00
0935799f7d
Updated emoji-token normalization to first apply Unicode composition normalization (G_NORMALIZE_ALL_COMPOSE) before matching, so canonically-equivalent sequences compare reliably in highlight checks.
deepend2026-02-24 11:18:46 -07:00
b7804fd7eb
Fixed the right-click nick info refresh flow in fe_userlist_update() so the submenu can keep updating after the first refresh when WHOIS-derived data is still incomplete. It now tracks a needs_refresh condition and reattaches the submenu show callback when required. This ensures user info can continue to refresh as data arrives instead of stopping after one update.
deepend2026-02-24 08:35:23 -07:00
95e40bbe5e
Added hexchat.py to Debian install manifest for zoitechat-python3 so the file is packaged instead of being left in debian/tmp (which triggers dh_missing failure).
deepend2026-02-23 19:17:52 -07:00
3a680cf6b4
Updated the Python scripting shim to expose EAT_HEXCHAT as an alias of EAT_ZOITECHAT, so scripts written for HexChat constants work without changes.
deepend2026-02-23 19:09:09 -07:00
314dfbbd75
Fixed highlight word parsing so Unicode symbols (including emoji like 🐜) are treated as part of words when scanning incoming text for alert matches, which enables /Extra words to highlight/ entries containing emoji to work.
deepend2026-02-23 16:11:41 -07:00
a79d34bcc0
cleaned up some gtk2 specific comments
deepend2026-02-23 12:42:44 -07:00
eebe11b95b
I removed the leftover GTK2 compatibility include path from src/fe-gtk/xtext.h by dropping the GTK_MAJOR_VERSION < 3 / gtkobject.h block, leaving the GTK3 header path (<gtk/gtk.h>) in place.
deepend2026-02-23 12:36:33 -07:00
42993c8c9b
Updated the Manjaro PKGBUILD build configuration to explicitly enable all bundled, Linux-applicable ZoiteChat plugins during Meson setup: checksum, fishlim, lua, perl, python, and sysinfo. This ensures the package build doesn’t rely on implicit defaults for plugin inclusion.
deepend2026-02-23 11:50:54 -07:00
ab0e84257a
Replaced gnome.genmarshal() usage with explicit Meson custom_target() rules that generate both marshal.h and marshal.c from marshalers.list, preserving the same marshaller prefix and generated outputs consumed by the build.
deepend2026-02-23 10:50:53 -07:00
b2fd66e4c4
Fixed the Manjaro packaging build failure by removing the redundant -Dbuildtype=plain from arch-meson invocation in build(), so Meson no longer receives buildtype from both --buildtype and -Dbuildtype.
deepend2026-02-23 10:31:39 -07:00
66d0549938
Fixed Manjaro pkgver() generation to produce Arch-valid version strings when git describe includes pre-release hyphens (for example -pre1) by normalizing the describe suffix and replacing remaining hyphens with dots. This prevents invalid pkgver values like ...pre1-40-g....
deepend2026-02-23 09:54:11 -07:00
498497171b
Updated the Manjaro package workflow to make builder user creation idempotent by guarding useradd with an existence check (id -u builder ... || useradd -m builder), preventing failures when the user already exists in the container.
deepend2026-02-23 09:40:27 -07:00
b731d3fb18
Added a Manjaro/Arch-style PKGBUILD for a VCS package (zoitechat-git) under packaging/manjaro/PKGBUILD, including package metadata, runtime/build deps, pkgver() generation from git history, and build()/package() functions using Meson (arch-meson, meson compile, meson install).
deepend2026-02-23 09:35:36 -07:00
45105590fe
Updated the AppImage workflow Configure step to remove the explicit -Dgtk3=true Meson flag while keeping the other existing options intact (-Dtext-frontend=true, perl/python, auto features, appindicator).
deepend2026-02-22 16:19:03 -07:00
be7b5e62be
Updated Unix sysinfo backend to treat GTK3 as the only GTK target by:
deepend2026-02-22 15:38:05 -07:00
1b66b136dc
Removed the obsolete GTK3 compatibility compile define from the GTK frontend build flags by deleting -DHAVE_GTK3 in src/fe-gtk/meson.build.
deepend2026-02-22 15:31:51 -07:00
4b188192f8
Removed GTK2 compatibility shims from fe-gtk.h by deleting the local HAVE_GTK3 fallback derivation, deleting GTK2 no-op wrappers for expansion APIs, and making InputStyle GTK3-only.
deepend2026-02-22 15:27:28 -07:00
743bf334d4
Migrated the macOS bundle manifest to GTK3 by switching the package reference to gtk+-3.0, updating the theme resource path to gtk-3.0, and changing the GTK translation domain from gtk20 to gtk30.
deepend2026-02-22 15:14:40 -07:00
1c5bf9d6b1
Removed GTK2/GTK3 dual-path preprocessor branches across src/fe-gtk by keeping GTK3-native paths only, including the high-density targets you prioritized (xtext.c, setup.c, maingui.c, gtkutil.c, servlistgui.c).
deepend2026-02-22 15:11:35 -07:00
44019bcab2
Made the gtk3 Meson option effectively deprecated by forcing it to true and updating its description to state GTK3 is always used (option ignored), so users are no longer guided toward GTK2 expectations. Also updated the AppIndicator option help text to refer to GTK frontend builds generally.
deepend2026-02-22 15:00:41 -07:00
52f547ae13
Deprecated the gtk3 Meson option and effectively forced GTK3 usage (value: true, deprecated: true), plus updated option/help text so users no longer expect GTK2 frontend builds. Also clarified the AppIndicator option text for non-Windows GTK frontend builds.
deepend2026-02-22 14:42:20 -07:00
6c699ac07b
Added a Flatpak-specific guard in proxy auto-detection to skip g_proxy_resolver_lookup() when running inside Flatpak (/.flatpak-info present), preventing the Connect flow from appearing to freeze in sandbox environments with missing proxy backends. This still preserves normal behavior for explicit manual proxy settings.
deepend2026-02-22 11:55:49 -07:00
d379bb138c
Added Flatpak-specific Python module search paths in plugin init: when FLATPAK_ID is present, the loader now also probes /app/lib/zoitechat/python and /app/lib/x86_64-linux-gnu/zoitechat/python before importing zoitechat.
deepend2026-02-22 11:42:49 -07:00
76796f5f23
Fixed Python plugin module discovery to search multiple valid install layouts before importing zoitechat, instead of assuming only one path. This includes:
deepend2026-02-22 11:03:57 -07:00
796c572292
Updated the AppImage workflow to copy Python dist-packages into the AppDir for both standard and multiarch layouts (/usr/lib/python3/dist-packages and /usr/lib/x86_64-linux-gnu/python3/dist-packages). This ensures Python runtime modules needed by the embedded plugin are actually bundled.
deepend2026-02-22 10:56:46 -07:00
931dddcf0e
Enabled the Python plugin in the Flatpak build by changing Meson config from -Dwith-python=false to -Dwith-python=python3, so it gets built in the Flatpak app module.
deepend2026-02-22 10:47:01 -07:00
2713270e1f
Added a new workflow step, “Bundle scripting runtimes in AppDir”, that copies Python and Perl runtime artifacts into AppDir (Python binary + stdlib + libpython3*.so*, Perl binary + common Perl library/share paths). This addresses the root issue that runner-installed runtimes were not necessarily ending up inside the final AppImage payload.
deepend2026-02-22 10:38:08 -07:00
deepend-tildeclub
deepend