Wrap topic bar in scroller, bound height

src/fe-gtk/chanview-tabs.c

@@ -27,6 +27,8 @@ typedef struct
 	GtkWidget *b2;		/* button2 */
 } tabview;
 
+#define ICON_CHANVIEW_CLOSE "gtk-close"
+
 static void chanview_populate (chanview *cv);
 
 /* ignore "toggled" signal? */
@@ -332,6 +334,12 @@ tab_scroll_cb (GtkWidget *widget, GdkEventScroll *event, gpointer cv)
 	return FALSE;
 }
 
+static void
+cv_tabs_xclick_cb (GtkWidget *button, chanview *cv)
+{
+	cv->cb_xbutton (cv, cv->focused, cv->focused->tag, cv->focused->userdata);
+}
+
 /* make a Scroll (arrow) button */
 
 static GtkWidget *
@@ -376,6 +384,7 @@ cv_tabs_init (chanview *cv)
 	GtkWidget *box, *hbox = NULL;
 	GtkWidget *viewport;
 	GtkWidget *outer;
+	GtkWidget *button;
 
 	if (cv->vertical)
 	{
@@ -442,6 +451,11 @@ cv_tabs_init (chanview *cv)
 		gtk_box_pack_start (GTK_BOX (outer), ((tabview *)cv)->b1, 0, 0, 0);
 	}
 
+	button = gtkutil_button (outer, ICON_CHANVIEW_CLOSE, NULL, cv_tabs_xclick_cb,
+									 cv, 0);
+	gtk_button_set_relief (GTK_BUTTON (button), GTK_RELIEF_NONE);
+	gtk_widget_set_can_focus (button, FALSE);
+
 	gtk_container_add (GTK_CONTAINER (cv->box), outer);
 }
 
@@ -645,128 +659,20 @@ tab_toggled_cb (GtkToggleButton *tab, chan *ch)
 static gboolean
 tab_click_cb (GtkWidget *wid, GdkEventButton *event, chan *ch)
 {
-	GtkWidget *close_button;
-	gint close_x;
-	gint close_y;
-	GtkAllocation close_alloc;
-
-	if (event->button == 1 && event->type == GDK_BUTTON_PRESS)
-	{
-		close_button = g_object_get_data (G_OBJECT (wid), "tab-close-button");
-		if (close_button &&
-			gtk_widget_translate_coordinates (close_button, wid, 0, 0, &close_x, &close_y))
-		{
-			gtk_widget_get_allocation (close_button, &close_alloc);
-			if (event->x >= close_x && event->x < close_x + close_alloc.width &&
-				event->y >= close_y && event->y < close_y + close_alloc.height)
-			{
-				ch->cv->cb_xbutton (ch->cv, ch, ch->tag, ch->userdata);
-				return TRUE;
-			}
-		}
-	}
-
 	return ch->cv->cb_contextmenu (ch->cv, ch, ch->tag, ch->userdata, event);
 }
 
-static gboolean
-tab_close_motion_cb (GtkWidget *wid, GdkEventMotion *event, chan *ch)
-{
-	GtkWidget *close_button;
-	gint close_x;
-	gint close_y;
-	GtkAllocation close_alloc;
-	gboolean hover = FALSE;
-
-	close_button = g_object_get_data (G_OBJECT (wid), "tab-close-button");
-	if (close_button &&
-		gtk_widget_translate_coordinates (close_button, wid, 0, 0, &close_x, &close_y))
-	{
-		gtk_widget_get_allocation (close_button, &close_alloc);
-		hover = event->x >= close_x && event->x < close_x + close_alloc.width &&
-			event->y >= close_y && event->y < close_y + close_alloc.height;
-	}
-
-	if (hover)
-	{
-		GdkCursor *cursor;
-		gtk_widget_set_state_flags (close_button, GTK_STATE_FLAG_PRELIGHT, TRUE);
-		if (gtk_widget_get_window (wid))
-		{
-			cursor = gdk_cursor_new_for_display (gtk_widget_get_display (wid), GDK_HAND2);
-			gdk_window_set_cursor (gtk_widget_get_window (wid), cursor);
-			g_object_unref (cursor);
-		}
-	}
-	else
-	{
-		gtk_widget_unset_state_flags (close_button, GTK_STATE_FLAG_PRELIGHT);
-		if (gtk_widget_get_window (wid))
-			gdk_window_set_cursor (gtk_widget_get_window (wid), NULL);
-	}
-
-	return FALSE;
-}
-
-static gboolean
-tab_close_leave_cb (GtkWidget *wid, GdkEventCrossing *event, chan *ch)
-{
-	GtkWidget *close_button;
-
-	close_button = g_object_get_data (G_OBJECT (wid), "tab-close-button");
-	if (close_button)
-		gtk_widget_unset_state_flags (close_button, GTK_STATE_FLAG_PRELIGHT);
-	if (gtk_widget_get_window (wid))
-		gdk_window_set_cursor (gtk_widget_get_window (wid), NULL);
-	return FALSE;
-}
-
-static GtkWidget *
-tab_get_label (GtkWidget *tab)
-{
-	GtkWidget *label;
-
-	label = g_object_get_data (G_OBJECT (tab), "tab-label");
-	if (label)
-		return label;
-
-	return gtk_bin_get_child (GTK_BIN (tab));
-}
-
 static void *
 cv_tabs_add (chanview *cv, chan *ch, char *name, GtkTreeIter *parent)
 {
 	GtkWidget *but;
-	GtkWidget *hbox;
-	GtkWidget *label;
-	GtkWidget *close_button;
-	GtkWidget *close_icon;
 
-	but = gtk_toggle_button_new ();
+	but = gtk_toggle_button_new_with_label (name);
 	gtk_widget_set_name (but, "zoitechat-tab");
-	gtk_widget_add_events (but, GDK_POINTER_MOTION_MASK | GDK_LEAVE_NOTIFY_MASK);
-	hbox = gtk_box_new (GTK_ORIENTATION_HORIZONTAL, 4);
-	label = gtk_label_new (name);
-	close_button = gtk_button_new ();
-	gtk_style_context_add_class (gtk_widget_get_style_context (close_button), "flat");
-	close_icon = gtk_image_new_from_icon_name ("window-close-symbolic", GTK_ICON_SIZE_MENU);
-	gtk_image_set_pixel_size (GTK_IMAGE (close_icon), 8);
-	gtk_button_set_always_show_image (GTK_BUTTON (close_button), TRUE);
-	gtk_widget_set_can_focus (close_button, FALSE);
-	gtk_container_add (GTK_CONTAINER (close_button), close_icon);
-	gtk_box_pack_start (GTK_BOX (hbox), label, FALSE, FALSE, 0);
-	gtk_box_pack_start (GTK_BOX (hbox), close_button, FALSE, FALSE, 0);
-	gtk_container_add (GTK_CONTAINER (but), hbox);
-	g_object_set_data (G_OBJECT (but), "tab-label", label);
-	g_object_set_data (G_OBJECT (but), "tab-close-button", close_button);
 	g_object_set_data (G_OBJECT (but), "c", ch);
 	/* used to trap right-clicks */
 	g_signal_connect (G_OBJECT (but), "button-press-event",
 						 	G_CALLBACK (tab_click_cb), ch);
-	g_signal_connect (G_OBJECT (but), "motion-notify-event",
-						 	G_CALLBACK (tab_close_motion_cb), ch);
-	g_signal_connect (G_OBJECT (but), "leave-notify-event",
-						 	G_CALLBACK (tab_close_leave_cb), ch);
 	/* avoid prelights */
 	g_signal_connect (G_OBJECT (but), "enter-notify-event",
 						 	G_CALLBACK (tab_ignore_cb), NULL);
@@ -778,7 +684,6 @@ cv_tabs_add (chanview *cv, chan *ch, char *name, GtkTreeIter *parent)
 	g_signal_connect (G_OBJECT (but), "toggled",
 						 	G_CALLBACK (tab_toggled_cb), ch);
 	g_object_set_data (G_OBJECT (but), "u", ch->userdata);
-	gtk_widget_show_all (hbox);
 
 	tab_add_real (cv, but, ch);
 
@@ -987,7 +892,7 @@ cv_tabs_cleanup (chanview *cv)
 static void
 cv_tabs_set_color (chan *ch, PangoAttrList *list)
 {
-	gtk_label_set_attributes (GTK_LABEL (tab_get_label (ch->impl)), list);
+	gtk_label_set_attributes (GTK_LABEL (gtk_bin_get_child (GTK_BIN (ch->impl))), list);
 }
 
 static void
@@ -996,16 +901,16 @@ cv_tabs_rename (chan *ch, char *name)
 	PangoAttrList *attr;
 	GtkWidget *tab = ch->impl;
 
-	attr = gtk_label_get_attributes (GTK_LABEL (tab_get_label (tab)));
+	attr = gtk_label_get_attributes (GTK_LABEL (gtk_bin_get_child (GTK_BIN (tab))));
 	if (attr)
 		pango_attr_list_ref (attr);
 
-	gtk_label_set_text (GTK_LABEL (tab_get_label (tab)), name);
+	gtk_button_set_label (GTK_BUTTON (tab), name);
 	gtk_widget_queue_resize (gtk_widget_get_parent(gtk_widget_get_parent(gtk_widget_get_parent(tab))));
 
 	if (attr)
 	{
-		gtk_label_set_attributes (GTK_LABEL (tab_get_label (tab)), attr);
+		gtk_label_set_attributes (GTK_LABEL (gtk_bin_get_child (GTK_BIN (tab))), attr);
 		pango_attr_list_unref (attr);
 	}
 }

src/fe-gtk/maingui.c

@@ -2968,10 +2968,41 @@ mg_create_dialogbuttons (GtkWidget *box)
         }
 }
 
+static void
+mg_configure_topic_scroller (GtkWidget *scroller, GtkWidget *topic)
+{
+	PangoContext *context;
+	PangoFontMetrics *metrics;
+	int line_height;
+	int min_height;
+	int max_height;
+
+	context = gtk_widget_get_pango_context (topic);
+	metrics = pango_context_get_metrics (context,
+		pango_context_get_font_description (context),
+		pango_context_get_language (context));
+	line_height = PANGO_PIXELS (pango_font_metrics_get_ascent (metrics) +
+		pango_font_metrics_get_descent (metrics));
+	pango_font_metrics_unref (metrics);
+
+	if (line_height <= 0)
+		line_height = 16;
+
+	min_height = line_height + 8;
+	max_height = line_height * 4 + 8;
+
+	gtk_scrolled_window_set_policy (GTK_SCROLLED_WINDOW (scroller),
+		GTK_POLICY_NEVER, GTK_POLICY_AUTOMATIC);
+	gtk_scrolled_window_set_shadow_type (GTK_SCROLLED_WINDOW (scroller), GTK_SHADOW_NONE);
+	gtk_scrolled_window_set_propagate_natural_height (GTK_SCROLLED_WINDOW (scroller), TRUE);
+	gtk_scrolled_window_set_min_content_height (GTK_SCROLLED_WINDOW (scroller), min_height);
+	gtk_scrolled_window_set_max_content_height (GTK_SCROLLED_WINDOW (scroller), max_height);
+}
+
 static void
 mg_create_topicbar (session *sess, GtkWidget *box)
 {
-	GtkWidget *vbox, *hbox, *mode_hbox, *topic, *bbox;
+	GtkWidget *vbox, *hbox, *mode_hbox, *topic, *bbox, *topic_scroller;
 	session_gui *gui = sess->gui;
 
 	gui->topic_bar = vbox = mg_box_new (GTK_ORIENTATION_VERTICAL, FALSE, 0);
@@ -2984,12 +3015,14 @@ mg_create_topicbar (session *sess, GtkWidget *box)
                 sess->res->tab = NULL;
 
         gui->topic_entry = topic = gtk_text_view_new ();
-        gtk_widget_set_name (topic, "zoitechat-inputbox");
+        gtk_widget_set_name (topic, "zoitechat-topicbox");
-        gtk_text_view_set_wrap_mode (GTK_TEXT_VIEW (topic), GTK_WRAP_WORD_CHAR);
+        gtk_text_view_set_wrap_mode (GTK_TEXT_VIEW (topic), GTK_WRAP_WORD);
         gtk_text_view_set_left_margin (GTK_TEXT_VIEW (topic), 4);
         gtk_text_view_set_right_margin (GTK_TEXT_VIEW (topic), 4);
-        gtk_box_pack_start (GTK_BOX (hbox), topic, TRUE, TRUE, 0);
+        topic_scroller = gtk_scrolled_window_new (NULL, NULL);
-        mg_apply_emoji_fallback_widget (topic);
+        gtk_container_add (GTK_CONTAINER (topic_scroller), topic);
+        mg_configure_topic_scroller (topic_scroller, topic);
+        gtk_box_pack_start (GTK_BOX (hbox), topic_scroller, TRUE, TRUE, 0);
         gtk_widget_add_events (topic, GDK_BUTTON_PRESS_MASK | GDK_BUTTON_RELEASE_MASK |
                                       GDK_POINTER_MOTION_MASK | GDK_LEAVE_NOTIFY_MASK);
         g_signal_connect (G_OBJECT (topic), "key-press-event",

src/fe-gtk/theme/theme-manager.c

@@ -415,24 +415,6 @@ theme_manager_is_kde_wayland (void)
 	return is_kde;
 }
 
-static gint
-theme_manager_get_system_headerbar_height (void)
-{
-	GtkWidget *probe;
-	gint minimum;
-	gint natural;
-
-	probe = gtk_header_bar_new ();
-	gtk_header_bar_set_show_close_button (GTK_HEADER_BAR (probe), TRUE);
-	gtk_header_bar_set_decoration_layout (GTK_HEADER_BAR (probe), "menu:minimize,maximize,close");
-	gtk_widget_show (probe);
-	gtk_widget_get_preferred_height (probe, &minimum, &natural);
-	gtk_widget_destroy (probe);
-	if (natural > 0)
-		return natural;
-	return minimum;
-}
-
 static void
 theme_manager_apply_wayland_kde_csd (GtkWidget *window)
 {
@@ -460,16 +442,10 @@ theme_manager_apply_wayland_kde_csd (GtkWidget *window)
 			headerbar = gtk_header_bar_new ();
 			gtk_header_bar_set_show_close_button (GTK_HEADER_BAR (headerbar), TRUE);
 			gtk_header_bar_set_decoration_layout (GTK_HEADER_BAR (headerbar), "menu:minimize,maximize,close");
-			g_object_set (G_OBJECT (headerbar), "spacing", 0, NULL);
+			icon_pixbuf = gdk_pixbuf_new_from_resource_at_scale ("/icons/zoitechat.svg", 32, 32, TRUE, NULL);
-			gtk_widget_set_size_request (headerbar, -1, theme_manager_get_system_headerbar_height ());
-			icon_pixbuf = gdk_pixbuf_new_from_resource_at_scale ("/icons/zoitechat.svg", 24, 24, TRUE, NULL);
 			if (!icon_pixbuf)
-				icon_pixbuf = gdk_pixbuf_new_from_resource_at_scale ("/icons/zoitechat.png", 24, 24, TRUE, NULL);
+				icon_pixbuf = gdk_pixbuf_new_from_resource_at_scale ("/icons/zoitechat.png", 32, 32, TRUE, NULL);
 			icon_image = icon_pixbuf ? gtk_image_new_from_pixbuf (icon_pixbuf) : gtk_image_new_from_resource ("/icons/zoitechat.png");
-			gtk_widget_set_margin_start (icon_image, 0);
-			gtk_widget_set_margin_end (icon_image, 0);
-			gtk_widget_set_margin_top (icon_image, 0);
-			gtk_widget_set_margin_bottom (icon_image, 0);
 			if (icon_pixbuf)
 				g_object_unref (icon_pixbuf);
 			gtk_header_bar_pack_start (GTK_HEADER_BAR (headerbar), icon_image);