Make magick cmd available across CI envs

.github/ISSUE_TEMPLATE/bug_report.md

@@ -1,132 +0,0 @@
----
-name: Bug report
-about: Report a problem with ZoiteChat
-title: "[Bug]: "
-labels: bug
-assignees: ""
----
-
-```
-+------------------------------------------------------------+
-| ZoiteChat Bug Report                                      |
-| Please fill this out so the bug goblin has enough crumbs. |
-+------------------------------------------------------------+
-```
-
-## Summary
-
-What went wrong?
-
-```text
-Describe the bug clearly and briefly.
-```
-
-## Steps to Reproduce
-
-```text
-1.
-2.
-3.
-4.
-```
-
-## Expected Result
-
-```text
-What should have happened?
-```
-
-## Actual Result
-
-```text
-What happened instead?
-```
-
-## ZoiteChat Version
-
-```text
-ZoiteChat version:
-Build/source: GitHub release / Fedora package / source build / Windows installer / other
-Commit hash, if built from source:
-```
-
-## System Information
-
-```text
-OS:
-OS version:
-Desktop environment:
-Display server: Wayland / X11 / Windows / other
-CPU architecture: x86_64 / aarch64 / other
-```
-
-## IRC / Network Details
-
-```text
-IRC network/server:
-Port:
-TLS/SSL enabled: yes / no
-SASL enabled: yes / no
-Using bouncer/ZNC: yes / no
-Proxy/VPN involved: yes / no
-IRCv3 capabilities involved, if known:
-```
-
-## Plugins, Scripts, and Config
-
-```text
-Plugins enabled:
-Scripts loaded:
-Theme/custom CSS:
-Custom config changes:
-Does the bug still happen with a clean config? yes / no / untested
-```
-
-## Logs / Terminal Output
-
-Paste relevant output below.
-
-```text
-```
-
-## Raw IRC Lines, If Relevant
-
-Remove passwords, tokens, IPs, private channels, private messages, certs, and account details before posting.
-
-```text
-```
-
-## Crash Details, If Relevant
-
-```text
-Did ZoiteChat crash? yes / no
-Crash reporter output:
-Backtrace:
-Core dump available: yes / no
-```
-
-## Screenshots
-
-Attach screenshots or screen recordings if the issue is visual.
-
-## Regression Check
-
-```text
-Did this work in an older version? yes / no / unknown
-Last known working version:
-First broken version:
-```
-
-## Checklist
-
-* [ ] I searched existing issues first.
-* [ ] I tested with the latest ZoiteChat version available to me.
-* [ ] I included steps to reproduce the issue.
-* [ ] I removed private information from logs and raw IRC lines.
-* [ ] I included system and network details where relevant.
-
-## Extra Notes
-
-```text
-Anything else that might help.
-```

.github/ISSUE_TEMPLATE/config.yml

@@ -1 +0,0 @@
-blank_issues_enabled: false

.github/ISSUE_TEMPLATE/feature_request.md

@@ -1,57 +0,0 @@
----
-name: Feature request
-about: Suggest an improvement for ZoiteChat
-title: "[Feature]: "
-labels: enhancement
-assignees: ""
----
-
-## Summary
-
-```text
-Describe the feature or enhancement clearly and briefly.
-```
-
-## Problem
-
-```text
-What problem would this solve?
-```
-
-## Proposed Solution
-
-```text
-How should ZoiteChat behave?
-```
-
-## Alternatives Considered
-
-```text
-Other approaches or workarounds you considered.
-```
-
-## Use Case
-
-```text
-Who benefits from this, and when would they use it?
-```
-
-## Platform Details
-
-```text
-OS:
-ZoiteChat version:
-Build/source: GitHub release / Fedora package / source build / Windows installer / other
-```
-
-## Checklist
-
-* [ ] I searched existing issues first.
-* [ ] I checked whether this already exists in the latest ZoiteChat version available to me.
-* [ ] I explained the problem this would solve.
-
-## Extra Notes
-
-```text
-Anything else that might help.
-```

.github/workflows/appimage-build.yml

@@ -28,16 +28,20 @@ jobs:
           sudo apt-get install -y --no-install-recommends \
             build-essential pkg-config meson ninja-build cmake \
             gettext \
-            libcanberra-dev libglib2.0-dev \
+            libcanberra-dev libdbus-glib-1-dev libglib2.0-dev \
             libarchive-dev \
             libgtk-3-dev \
             libwayland-client0 libwayland-cursor0 libwayland-egl1 \
             libxkbcommon0 \
             libgtk-3-bin libglib2.0-bin shared-mime-info gsettings-desktop-schemas \
-            liblua5.4-dev libpci-dev libperl-dev libssl-dev libayatana-appindicator3-dev \
+            libluajit-5.1-dev libpci-dev libperl-dev libssl-dev libayatana-appindicator3-dev \
             perl python3 python3-minimal python3-dev python3-cffi mono-devel desktop-file-utils \
             fonts-noto-color-emoji breeze-gtk-theme \
-            patchelf file curl
+            patchelf file curl imagemagick
+          if ! command -v magick >/dev/null 2>&1 && command -v convert >/dev/null 2>&1; then
+            printf '%s\n' '#!/bin/sh' 'exec convert "$@"' | sudo tee /usr/local/bin/magick >/dev/null
+            sudo chmod +x /usr/local/bin/magick
+          fi
 
       - name: Configure
         run: |
@@ -86,21 +90,11 @@ jobs:
             cp -a /usr/lib/x86_64-linux-gnu/python3/dist-packages AppDir/usr/lib/x86_64-linux-gnu/python3/
           fi
 
-          if [ -d "/usr/lib/x86_64-linux-gnu/perl-base" ]; then
-            install -d AppDir/usr/lib/x86_64-linux-gnu
-            cp -a /usr/lib/x86_64-linux-gnu/perl-base AppDir/usr/lib/x86_64-linux-gnu/
-          fi
-
           if [ -d "/usr/lib/x86_64-linux-gnu/perl" ]; then
             install -d AppDir/usr/lib/x86_64-linux-gnu
             cp -a /usr/lib/x86_64-linux-gnu/perl AppDir/usr/lib/x86_64-linux-gnu/
           fi
 
-          if [ -d "/usr/lib/x86_64-linux-gnu/perl5" ]; then
-            install -d AppDir/usr/lib/x86_64-linux-gnu
-            cp -a /usr/lib/x86_64-linux-gnu/perl5 AppDir/usr/lib/x86_64-linux-gnu/
-          fi
-
           if [ -d "/usr/share/perl" ]; then
             install -d AppDir/usr/share
             cp -a /usr/share/perl AppDir/usr/share/
@@ -110,10 +104,6 @@ jobs:
             install -d AppDir/usr/share
             cp -a /usr/share/perl5 AppDir/usr/share/
           fi
-
-          perl -MFile::Spec -e 'print "Build host File::Spec: $INC{\"File/Spec.pm\"}\n"'
-          find AppDir/usr -path '*/File/Spec.pm' -print -quit | grep -q .
-
           if compgen -G '/usr/lib/x86_64-linux-gnu/libpython3*.so*' > /dev/null; then
             install -d AppDir/usr/lib/x86_64-linux-gnu
             cp -a /usr/lib/x86_64-linux-gnu/libpython3*.so* AppDir/usr/lib/x86_64-linux-gnu/
@@ -176,7 +166,7 @@ jobs:
 
           APPDIR="${APPDIR:-$(dirname "$(readlink -f "$0")")}"
 
-          export PATH="$APPDIR/usr/bin:${PATH:-/usr/bin:/bin}"
+          export PATH="${PATH:-/usr/bin:/bin}:$APPDIR/usr/bin"
           export LD_LIBRARY_PATH="$APPDIR/usr/lib:$APPDIR/usr/lib/x86_64-linux-gnu:${LD_LIBRARY_PATH:-}"
           export XDG_DATA_DIRS="$APPDIR/usr/share:${XDG_DATA_DIRS:-/usr/local/share:/usr/share}"
           export GTK_EXE_PREFIX="$APPDIR/usr"
@@ -225,23 +215,6 @@ jobs:
 
           unset GTK_MODULES
 
-          perl5lib_entries=""
-          for dir in \
-            "$APPDIR/usr/lib/x86_64-linux-gnu/perl-base" \
-            "$APPDIR/usr/lib/x86_64-linux-gnu/perl"/* \
-            "$APPDIR/usr/lib/x86_64-linux-gnu/perl5"/* \
-            "$APPDIR/usr/share/perl"/* \
-            "$APPDIR/usr/share/perl5"
-          do
-            if [ -d "$dir" ]; then
-              perl5lib_entries="${perl5lib_entries:+$perl5lib_entries:}$dir"
-            fi
-          done
-
-          if [ -n "$perl5lib_entries" ]; then
-            export PERL5LIB="$perl5lib_entries${PERL5LIB:+:$PERL5LIB}"
-          fi
-
           export PYTHONHOME="$APPDIR/usr"
           python_stdlib_dir="$(find "$APPDIR/usr/lib" -maxdepth 1 -type d -name 'python3.*' | head -n 1 || true)"
           pythonpath_entries=""
@@ -287,6 +260,7 @@ jobs:
           EOF
           chmod +x AppRun
 
+
           VERSION="$(git describe --tags --always)"
 
           ./linuxdeploy-x86_64.AppImage \

.github/workflows/flatpak-build.yml

@@ -25,8 +25,14 @@ jobs:
         with:
           submodules: true
 
-      - name: Generate PSL list
-        run: curl -fsSL https://publicsuffix.org/list/public_suffix_list.dat -o src/common/public_suffix_list.dat
+      - name: Install ImageMagick
+        run: |
+          apt-get update
+          apt-get install -y --no-install-recommends imagemagick
+          if ! command -v magick >/dev/null 2>&1 && command -v convert >/dev/null 2>&1; then
+            printf '%s\n' '#!/bin/sh' 'exec convert "$@"' > /usr/local/bin/magick
+            chmod +x /usr/local/bin/magick
+          fi
 
       - name: Build Flatpak
         id: flatpak_builder

.github/workflows/manjaro-package-build.yml

@@ -0,0 +1,86 @@
+name: Manjaro Package Build
+
+on:
+  push:
+    branches: [master, main]
+  pull_request:
+    branches: [master, main]
+  workflow_dispatch:
+
+permissions:
+  contents: read
+
+jobs:
+  manjaro-package:
+    runs-on: ubuntu-latest
+    container:
+      image: manjarolinux/base:latest
+
+    steps:
+      - name: Install packaging toolchain
+        run: |
+          set -euxo pipefail
+          pacman -Syu --noconfirm
+          pacman -S --noconfirm --needed \
+            base-devel \
+            git \
+            namcap \
+            meson \
+            ninja \
+            pkgconf \
+            glib2 \
+            glib2-devel \
+            gtk3 \
+            openssl \
+            dbus-glib \
+            libcanberra \
+            libayatana-appindicator \
+            luajit \
+            iso-codes \
+            lua \
+            perl \
+            python \
+            python-cffi \
+            pciutils \
+            imagemagick
+          if ! command -v magick >/dev/null 2>&1 && command -v convert >/dev/null 2>&1; then
+            printf '%s\n' '#!/bin/sh' 'exec convert "$@"' > /usr/local/bin/magick
+            chmod +x /usr/local/bin/magick
+          fi
+
+      - name: Checkout repository
+        uses: actions/checkout@v5
+        with:
+          fetch-depth: 0
+          submodules: true
+
+      - name: Build package and generate .SRCINFO (non-root)
+        run: |
+          set -euxo pipefail
+          id -u builder >/dev/null 2>&1 || useradd -m builder
+          chown -R builder:builder "$GITHUB_WORKSPACE"
+          su builder -c "cd '$GITHUB_WORKSPACE/packaging/manjaro' && makepkg --noconfirm --syncdeps --cleanbuild"
+          su builder -c "cd '$GITHUB_WORKSPACE/packaging/manjaro' && makepkg --printsrcinfo > .SRCINFO"
+
+      - name: Lint PKGBUILD and package with namcap
+        run: |
+          set -euxo pipefail
+          cd "$GITHUB_WORKSPACE/packaging/manjaro"
+          namcap PKGBUILD
+          pkg_file="$(find . -maxdepth 1 -type f -name '*.pkg.tar.*' | head -n1)"
+          namcap "$pkg_file"
+
+      - name: Collect artifacts
+        run: |
+          set -euxo pipefail
+          mkdir -p artifacts
+          cp -v "$GITHUB_WORKSPACE"/packaging/manjaro/*.pkg.tar.* artifacts/
+          cp -v "$GITHUB_WORKSPACE"/packaging/manjaro/PKGBUILD artifacts/
+          cp -v "$GITHUB_WORKSPACE"/packaging/manjaro/.SRCINFO artifacts/
+
+      - name: Upload package artifacts
+        uses: actions/upload-artifact@v6
+        with:
+          name: zoitechat-manjaro-package
+          path: artifacts/*
+          if-no-files-found: error

.github/workflows/windows-build.yml

@@ -39,6 +39,13 @@ jobs:
           python -m pip install --upgrade pip
           python -m pip install cffi
           python -m pip install zstandard
+          choco install imagemagick -y --no-progress
+          if (-not (Get-Command magick -ErrorAction SilentlyContinue)) {
+            $magickDir = Get-ChildItem 'C:\Program Files\ImageMagick-*' -Directory -ErrorAction SilentlyContinue | Sort-Object LastWriteTime -Descending | Select-Object -First 1
+            if ($magickDir) {
+              $magickDir.FullName | Out-File -FilePath $env:GITHUB_PATH -Encoding utf8 -Append
+            }
+          }
 
           $ProgressPreference = 'SilentlyContinue'
           function Download-WithRetry {
@@ -65,8 +72,8 @@ jobs:
           Download-WithRetry -Url https://github.com/jrsoftware/issrc/releases/download/is-6_7_1/innosetup-6.7.1.exe -OutFile deps\innosetup-unicode.exe
           & deps\innosetup-unicode.exe /VERYSILENT | Out-Null
 
-          Download-WithRetry -Url https://github.com/ZoiteChat/gvsbuild/releases/download/zoitechat-2.18.1/GTK3_Gvsbuild_zoitechat-2.18.1_x64.zip -OutFile deps\gtk-${{ matrix.arch }}.zip
-          Expand-Archive -LiteralPath deps\gtk-${{ matrix.arch }}.zip -DestinationPath C:\gtk-build\gtk\x64\release -Force
+          Download-WithRetry -Url https://github.com/ZoiteChat/gvsbuild/releases/download/zoitechat-2.18.0-pre1/GTK3_Gvsbuild_zoitechat-2.18.0-pre1_${{ matrix.platform }}.7z -OutFile deps\gtk-${{ matrix.arch }}.7z
+          & 7z.exe x deps\gtk-${{ matrix.arch }}.7z -oC:\gtk-build\gtk\x64\release
 
           Download-WithRetry -Url https://repo.msys2.org/mingw/x86_64/mingw-w64-x86_64-hicolor-icon-theme-0.18-1-any.pkg.tar.zst -OutFile deps\hicolor-icon-theme.pkg.tar.zst
           python -c "import tarfile,zstandard,pathlib;archive=pathlib.Path(r'deps\\hicolor-icon-theme.pkg.tar.zst');target=pathlib.Path(r'C:\\gtk-build\\gtk\\x64\\release');dctx=zstandard.ZstdDecompressor();f=archive.open('rb');reader=dctx.stream_reader(f);tf=tarfile.open(fileobj=reader,mode='r|');[tf.extract(m,path=target) for m in tf if m.name.startswith('mingw64/share/icons/hicolor/')];tf.close();reader.close();f.close()"
@@ -113,26 +120,6 @@ jobs:
             New-Item -Path $pyDir -Name "${{ matrix.platform }}" -ItemType Junction -Value $pyRoot | Out-Null
           }
 
-      - uses: actions/setup-python@v6
-        with:
-          python-version: '3.8.10'
-          architecture: ${{ matrix.arch }}
-
-      - name: Prepare Python 3.8
-        run: |
-          python -m pip install --upgrade pip
-          python -m pip install cffi
-
-          $pyRoot = $env:pythonLocation
-          if (-not $pyRoot) { $pyRoot = & python -c "import sys; print(sys.prefix)" }
-
-          foreach ($pyDir in @("C:\gtk-build\python-3.8.10", "C:\gtk-build\python-3.8")) {
-            New-Item -Path $pyDir -ItemType Directory -Force | Out-Null
-            $target = Join-Path $pyDir "${{ matrix.platform }}"
-            if (Test-Path $target) { Remove-Item $target -Recurse -Force }
-            New-Item -Path $pyDir -Name "${{ matrix.platform }}" -ItemType Junction -Value $pyRoot | Out-Null
-          }
-
       - name: Build
         run: |
           call "C:\Program Files\Microsoft Visual Studio\2022\Enterprise\Common7\Tools\VsDevCmd.bat"
@@ -144,33 +131,12 @@ jobs:
             exit /b 1
           )
 
-          set "PYTHON38_DIR=C:\gtk-build\python-3.8\${{ matrix.platform }}"
-          if not exist "%PYTHON38_DIR%\libs\python38.lib" (
-            echo Missing %PYTHON38_DIR%\libs\python38.lib
-            dir "%PYTHON38_DIR%\libs"
-            exit /b 1
-          )
-          if not exist "%PYTHON38_DIR%\Lib\site-packages\_cffi_backend.cp38*.pyd" (
-            echo Missing %PYTHON38_DIR%\Lib\site-packages\_cffi_backend.cp38*.pyd
-            exit /b 1
-          )
-
           set "LIB=%PYTHON_DIR%\libs;%LIB%"
           set "INCLUDE=%PYTHON_DIR%\include;%INCLUDE%"
 
           powershell -NoProfile -ExecutionPolicy Bypass -Command "$archiveLib='C:\gtk-build\gtk\x64\release\lib\libarchive.lib'; if (-not (Test-Path $archiveLib)) { $archiveDll = Get-ChildItem 'C:\gtk-build\gtk\x64\release\bin\libarchive*.dll' | Select-Object -First 1; if ($archiveDll) { Push-Location 'C:\gtk-build\gtk\x64\release\lib'; & 'C:\gtk-build\gendef\gendef.exe' $archiveDll.FullName | Out-Null; $archiveDef = Get-ChildItem 'libarchive*.def' | Select-Object -First 1; if ($archiveDef) { & lib /def:$archiveDef.Name /machine:${{ matrix.platform }} /out:libarchive.lib | Out-Null }; Pop-Location } }"
 
           msbuild win32\zoitechat.sln /m /verbosity:minimal /p:Configuration=Release /p:Platform=${{ matrix.platform }}
-          if errorlevel 1 exit /b 1
-
-          if not exist "..\zoitechat-build\${{ matrix.platform }}\rel\plugins\hcpython38.dll" (
-            echo hcpython38.dll was not built
-            exit /b 1
-          )
-          if not exist "..\zoitechat-build\${{ matrix.platform }}\rel\_cffi_backend.cp38*.pyd" (
-            echo _cffi_backend for Python 3.8 was not staged for the installer
-            exit /b 1
-          )
         shell: cmd
 
       - name: Preparing Artifacts

COPYING

@@ -1,8 +1,8 @@
 		    GNU GENERAL PUBLIC LICENSE
 		       Version 2, June 1991
 
- Copyright (C) 1989, 1991 Free Software Foundation, Inc.,
- <https://fsf.org/>
+ Copyright (C) 1989, 1991 Free Software Foundation, Inc.
+ 51 Franklin St, Fifth Floor, Boston, MA 02110-1301, USA
  Everyone is permitted to copy and distribute verbatim copies
  of this license document, but changing it is not allowed.
 
@@ -15,7 +15,7 @@ software--to make sure the software is free for all its users.  This
 General Public License applies to most of the Free Software
 Foundation's software and to any other program whose authors commit to
 using it.  (Some other Free Software Foundation software is covered by
-the GNU Lesser General Public License instead.)  You can apply it to
+the GNU Library General Public License instead.)  You can apply it to
 your programs, too.
 
   When we speak of free software, we are referring to freedom, not
@@ -55,7 +55,7 @@ patent must be licensed for everyone's free use or not licensed at all.
 
   The precise terms and conditions for copying, distribution and
 modification follow.
-
+
 		    GNU GENERAL PUBLIC LICENSE
    TERMS AND CONDITIONS FOR COPYING, DISTRIBUTION AND MODIFICATION
 
@@ -110,7 +110,7 @@ above, provided that you also meet all of these conditions:
     License.  (Exception: if the Program itself is interactive but
     does not normally print such an announcement, your work based on
     the Program is not required to print an announcement.)
-
+
 These requirements apply to the modified work as a whole.  If
 identifiable sections of that work are not derived from the Program,
 and can be reasonably considered independent and separate works in
@@ -168,7 +168,7 @@ access to copy from a designated place, then offering equivalent
 access to copy the source code from the same place counts as
 distribution of the source code, even though third parties are not
 compelled to copy the source along with the object code.
-
+
   4. You may not copy, modify, sublicense, or distribute the Program
 except as expressly provided under this License.  Any attempt
 otherwise to copy, modify, sublicense or distribute the Program is
@@ -225,7 +225,7 @@ impose that choice.
 
 This section is intended to make thoroughly clear what is believed to
 be a consequence of the rest of this License.
-
+
   8. If the distribution and/or use of the Program is restricted in
 certain countries either by patents or by copyrighted interfaces, the
 original copyright holder who places the Program under this License
@@ -278,7 +278,7 @@ PROGRAMS), EVEN IF SUCH HOLDER OR OTHER PARTY HAS BEEN ADVISED OF THE
 POSSIBILITY OF SUCH DAMAGES.
 
 		     END OF TERMS AND CONDITIONS
-
+
 	    How to Apply These Terms to Your New Programs
 
   If you develop a new program, and you want it to be of the greatest
@@ -291,7 +291,7 @@ convey the exclusion of warranty; and each file should have at least
 the "copyright" line and a pointer to where the full notice is found.
 
     <one line to give the program's name and a brief idea of what it does.>
-    Copyright (C) <year>  <name of author>
+    Copyright (C) 19yy  <name of author>
 
     This program is free software; you can redistribute it and/or modify
     it under the terms of the GNU General Public License as published by
@@ -303,15 +303,17 @@ the "copyright" line and a pointer to where the full notice is found.
     MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
     GNU General Public License for more details.
 
-    You should have received a copy of the GNU General Public License along
-    with this program; if not, see <https://www.gnu.org/licenses/>.
+    You should have received a copy of the GNU General Public License
+    along with this program; if not, write to the Free Software
+    Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA  02111-1307  USA
+
 
 Also add information on how to contact you by electronic and paper mail.
 
 If the program is interactive, make it output a short notice like this
 when it starts in an interactive mode:
 
-    Gnomovision version 69, Copyright (C) year name of author
+    Gnomovision version 69, Copyright (C) 19yy name of author
     Gnomovision comes with ABSOLUTELY NO WARRANTY; for details type `show w'.
     This is free software, and you are welcome to redistribute it
     under certain conditions; type `show c' for details.
@@ -328,11 +330,11 @@ necessary.  Here is a sample; alter the names:
   Yoyodyne, Inc., hereby disclaims all copyright interest in the program
   `Gnomovision' (which makes passes at compilers) written by James Hacker.
 
-  <signature of Moe Ghoul>, 1 April 1989
-  Moe Ghoul, President of Vice
+  <signature of Ty Coon>, 1 April 1989
+  Ty Coon, President of Vice
 
 This General Public License does not permit incorporating your program into
 proprietary programs.  If your program is a subroutine library, you may
 consider it more useful to permit linking proprietary applications with the
-library.  If this is what you want to do, use the GNU Lesser General
+library.  If this is what you want to do, use the GNU Library General
 Public License instead of this License.

changelog.rst

@@ -1,98 +1,6 @@
 ZoiteChat ChangeLog
 =================
 
-2.18.3 (2026-06-29)
--------------------
-
-- Added IRCv3 support for message tags, echo-message, typing notifications, and replies.
-- Restored the accept-invalid-cert TLS bypass behavior.
-- Replaced legacy IPv4 APIs and added support for OpenSSL 4 APIs.
-- Snapshot Python hooks during plugin unload for safer plugin shutdown.
-- Fixed Windows GtkStatusIcon tray menu popup behavior.
-- Fixed self-echoed private messages routing to the target tab.
-- Fixed the lag ping timeout window.
-
-2.18.2 (2026-06-20)
--------------------
-
-- Improved security and connection handling with stronger TLS defaults, 
-  safer certificate/hostname validation, FiSHLiM OpenSSL fixes, keyring support, 
-  and getaddrinfo-based DCC lookups.
-- Expanded FiSHLiM usability with a GTK key manager, context-menu access, and clearer
-  channel/private-message key handling.
-- Improved keyboard and navigation behavior with customizable keybinds, reset support,
-  channel-name switching, /server -noproxy, and configurable stale-link ping checks.
-- Refined the GTK interface with native file chooser dialogs, topic layout preferences, 
-  timestamp/date hover tooltips, better restore-down relayout, text scroll speed controls, 
-  and aligned network meters.
-- Added privacy and display options, including hiding join/part hostmasks and improved 
-  topic/multiline mode layout controls.
-- Fixed several platform/UI edge cases, including tray restore from iconified state, DBus unload
-  handling, GTK3 theme refresh/saving, and tab switcher compatibility.
-
-2.18.1 (2026-05-21)
--------------------
-
-- Migrated D-Bus handling to GDBus.
-- Enabled mouse wheel channel switching by default and consumed handled tab wheel events.
-- Switched main panes to native GTK scrollbars.
-- Tightened userlist button and meter layout.
-- Made the native Windows file chooser modal.
-- Set the Windows AppUserModelID before GTK startup.
-- Updated Windows CI to use the new GTK3 bundle zip.
-- Updated Windows installer architecture checks to use x64-compatible detection.
-- Bumped the Flatpak Perl runtime to 5.42.2.
-- Fixed palette color reads to preserve base GTK state.
-- Fixed auto-replace whole-word matching.
-- Fixed checksum file stream cleanup.
-- Fixed byte handling in the Python console.
-- Guarded GTK drag-and-drop handlers against null windows.
-- Fixed size_t and integer handling issues.
-- Removed the Winamp plugin.
-
-2.18.0 (2026-04-20)
--------------------
-
-- Added optional close buttons on tabs.
-- Added Ctrl+W to close tabs and Ctrl+Shift+T to reopen recently closed tabs.
-- Expanded theme import support with .hct support in colors.conf import.
-- Added pevent import support from .hct theme files and improved import result messaging.
-- Expanded palette and selection CSS styling for better theme consistency.
-- Auto-sizes the topic bar to wrapped text for better multi-line topic handling.
-- Refined command-character parsing when pasting path-like text.
-- Tightened topic link detection and opening rules.
-- Added Public Suffix List validation for host links to reduce bad link matches.
-- Improved channel tree behavior by ignoring collapsed parent selections.
-- Sanitized the Linux open environment for AppImage builds and added safer fallback handling.
-- Labeled Windows installer runtimes with exact versions.
-- Fixed the notification icon and corrected the Flatpak screenshot asset.
-- Improved AppStream metainfo validation.
-
-2.18.0~pre6 (2026-03-30)
-------------------------
-
-- Applied app theme CSS to the menubar consistently across the app.
-- Restored horizontal separator lines in menus.
-- Improved Windows installer VC++ redistributable handling by failing loudly when missing and using the official Microsoft download endpoint.
-- Fixed Windows locale path resolution in both GTK and text frontends.
-- Fixed duplicate dialog buttons persisting in the UI.
-- Fixed GTK auto-replace cursor snapback.
-- Restored hiding of formatting control bytes so only formatted output is shown.
-- Added one-click client SSL certificate tools, including generation with P-256 certificates.
-- Added client SSL certificate import support in the network editor.
-- Added 99-color support.
-- Fixed xtext link hit-testing coordinates.
-- Fixed short-palette fallback clobbering tab colors.
-- Lazy-loads Preferences pages on first open for faster dialog startup.
-- Removed unused UI icons.
-- Added a None option for resetting the GTK3 theme back to system/default behavior.
-- Added channel-only mode to Ctrl+F search.
-- Disabled disk info in sysinfo.
-- Wrapped the topic bar in a scroller with bounded height.
-- Added close buttons to tabs.
-- Fixed fallback GTK menu highlight states.
-- Applied configured font preferences to the topic bar, channel tree, user list, and input box.
-
 2.18.0~pre5 (2026-03-22)
 ------------------------
 - Overhauled preferences/config saving: fully staged and transactional, debounced

data/icons/generate_icons.py

@@ -0,0 +1,121 @@
+#!/usr/bin/env python3
+import argparse
+import contextlib
+import pathlib
+import shutil
+import subprocess
+import tempfile
+
+SIZES = [16, 24, 32, 40, 48, 64, 96, 128, 256]
+
+
+def run(cmd):
+    subprocess.run(cmd, check=True)
+
+
+def try_run(cmd):
+    result = subprocess.run(cmd, text=True, capture_output=True)
+    return result.returncode == 0, result.stderr.strip()
+
+
+def magick_cmd():
+    magick = shutil.which('magick')
+    if not magick:
+        raise RuntimeError('missing tool: install ImageMagick (magick)')
+    return magick
+
+
+@contextlib.contextmanager
+def magick_svg(svg):
+    text = pathlib.Path(svg).read_text(encoding='utf-8')
+    fixed = text.replace('href="image/', 'href="data:image/')
+    fixed = fixed.replace('xlink:href="image/', 'xlink:href="data:image/')
+    if fixed == text:
+        yield str(svg)
+        return
+    with tempfile.NamedTemporaryFile('w', suffix='.svg', delete=False, encoding='utf-8') as tmp:
+        tmp.write(fixed)
+        tmp_path = tmp.name
+    try:
+        yield tmp_path
+    finally:
+        pathlib.Path(tmp_path).unlink(missing_ok=True)
+
+
+def render_png(svg, out_png, size):
+    errors = []
+    rsvg = shutil.which('rsvg-convert')
+    if rsvg:
+        ok, err = try_run([rsvg, '-w', str(size), '-h', str(size), '-o', str(out_png), str(svg)])
+        if ok:
+            return
+        errors.append(err)
+    inkscape = shutil.which('inkscape')
+    if inkscape:
+        ok, err = try_run([
+            inkscape,
+            str(svg),
+            '--export-type=png',
+            '--export-width',
+            str(size),
+            '--export-height',
+            str(size),
+            '--export-filename',
+            str(out_png),
+        ])
+        if ok:
+            return
+        errors.append(err)
+    with magick_svg(svg) as svg_for_magick:
+        ok, err = try_run([
+            magick_cmd(),
+            svg_for_magick,
+            '-background',
+            'none',
+            '-resize',
+            f'{size}x{size}',
+            str(out_png),
+        ])
+    if ok:
+        return
+    errors.append(err)
+    raise RuntimeError('failed to render png: ' + ' | '.join(e for e in errors if e))
+
+
+def build_ico(svg, out_ico):
+    with magick_svg(svg) as svg_for_magick:
+        run([
+            magick_cmd(),
+            svg_for_magick,
+            '-background',
+            'none',
+            '-define',
+            'icon:auto-resize=' + ','.join(str(size) for size in SIZES),
+            str(out_ico),
+        ])
+
+
+def parse_args():
+    parser = argparse.ArgumentParser(prog='generate_icons.py')
+    parser.add_argument('input_svg')
+    parser.add_argument('output_png')
+    parser.add_argument('--ico', dest='output_ico')
+    parser.add_argument('--size', type=int, default=48)
+    return parser.parse_args()
+
+
+def main():
+    args = parse_args()
+    magick_cmd()
+    svg = pathlib.Path(args.input_svg)
+    out_png = pathlib.Path(args.output_png)
+    out_png.parent.mkdir(parents=True, exist_ok=True)
+    render_png(svg, out_png, args.size)
+    if args.output_ico:
+        out_ico = pathlib.Path(args.output_ico)
+        out_ico.parent.mkdir(parents=True, exist_ok=True)
+        build_ico(svg, out_ico)
+
+
+if __name__ == '__main__':
+    main()

data/icons/meson.build

@@ -1,9 +1,24 @@
+icon_gen = find_program('generate_icons.py')
+find_program('magick', required: true)
+
 icondir = join_paths(get_option('datadir'), 'icons/hicolor')
-install_data(
-  'zoitechat.png',
-  rename: 'net.zoite.Zoitechat.png',
-  install_dir: join_paths(icondir, '48x48/apps')
+custom_target('zoitechat_png',
+  input: 'zoitechat.svg',
+  output: 'net.zoite.Zoitechat.png',
+  command: [icon_gen, '@INPUT@', '@OUTPUT@', '--size', '48'],
+  install: true,
+  install_dir: join_paths(icondir, '48x48/apps'),
 )
+
+if host_machine.system() == 'windows'
+  custom_target('zoitechat_ico',
+    input: 'zoitechat.svg',
+    output: 'zoitechat.ico',
+    command: [icon_gen, '@INPUT@', '@PRIVATE_DIR@/zoitechat.png', '--size', '48', '--ico', '@OUTPUT@'],
+    build_by_default: true,
+  )
+endif
+
 install_data(
   'zoitechat.svg',
   rename: 'net.zoite.Zoitechat.svg',

data/misc/meson.build

@@ -13,16 +13,16 @@ if get_option('gtk-frontend')
       install_dir: metainfodir
     )
 
-    appstreamcli = find_program('appstreamcli', required: false)
-    if appstreamcli.found()
-      test('Validate net.zoite.Zoitechat.appdata.xml', appstreamcli,
-        args: ['validate', zoitechat_appdata]
+    appstream_util = find_program('appstream-util', required: false)
+    if appstream_util.found()
+      test('Validate net.zoite.Zoitechat.appdata.xml', appstream_util,
+        args: ['validate-relax', zoitechat_appdata]
       )
     endif
   endif
 
   desktop_conf = configuration_data()
-  if dbus_dep.found()
+  if dbus_glib_dep.found()
     desktop_conf.set('exec_command', 'zoitechat --existing %U')
   else
     desktop_conf.set('exec_command', 'zoitechat %U')
@@ -97,18 +97,11 @@ if get_option('plugin')
     conf.set('SUMMARY', metainfo[1])
     conf.set('LICENSE', metainfo[2])
 
-    plugin_appdata = configure_file(
+    configure_file(
       input: 'net.zoite.Zoitechat.Plugin.metainfo.xml.in',
       output: 'net.zoite.Zoitechat.Plugin.@0@.metainfo.xml'.format(name),
       configuration: conf,
       install_dir: get_option('install-plugin-metainfo') ? metainfodir : '',
     )
-
-    if appstreamcli.found()
-      test('Validate net.zoite.Zoitechat.Plugin.@0@.metainfo.xml'.format(name), appstreamcli,
-        args: ['validate', plugin_appdata]
-    )
-    endif
-
   endforeach
 endif

data/misc/net.zoite.Zoitechat.Plugin.metainfo.xml.in

@@ -4,7 +4,7 @@
   <extends>net.zoite.Zoitechat</extends>
   <name>@NAME@ Plugin</name>
   <summary>@SUMMARY@</summary>
-  <url type="homepage">https://zoitechat.org/</url>
+  <url type="homepage">https://zoitechat.zoite.net/</url>
   <project_license>@LICENSE@</project_license>
   <metadata_license>CC0-1.0</metadata_license>
   <update_contact>deepend_AT_zoite.net</update_contact>

data/misc/net.zoite.Zoitechat.appdata.xml.in

@@ -16,12 +16,12 @@
     <p>ZoiteChat is an easy to use yet extensible IRC Client based on Hexchat. It allows you to securely join multiple networks and talk to users privately or in channels using a customizable interface. You can even transfer files.</p>
     <p>ZoiteChat supports features such as: DCC, SASL, proxies, spellcheck, alerts, logging, custom themes, and Python/Perl scripts.</p>
   </description>
-  <url type="homepage">https://zoitechat.org</url>
+  <url type="homepage">https://zoitechat.zoite.net</url>
   <url type="bugtracker">https://github.com/zoitechat/zoitechat</url>
-  <url type="help">https://docs.zoitechat.org/en/latest/</url>
+  <url type="help">https://docs.zoitechat.zoite.net/en/latest/</url>
   <screenshots>
     <screenshot type="default">
-      <image>https://zoitechat.org/assets/img/zoitechat-screenshot.png</image>
+      <image>https://zoitechat.zoite.net/assets/ZoiteChat.png</image>
       <caption>Main Chat Window</caption>
     </screenshot>
   </screenshots>
@@ -29,134 +29,6 @@
     <id>zoitechat.desktop</id>
   </provides>
 <releases>
-<release date="2026-06-29" version="2.18.3">
-  <description>
-    <ul>
-      <li>Added IRCv3 support for message tags, echo-message, typing notifications, and replies.</li>
-      <li>Restored the accept-invalid-cert TLS bypass behavior.</li>
-      <li>Replaced legacy IPv4 APIs and added support for OpenSSL 4 APIs.</li>
-      <li>Snapshot Python hooks during plugin unload for safer plugin shutdown.</li>
-      <li>Fixed Windows GtkStatusIcon tray menu popup behavior.</li>
-      <li>Fixed self-echoed private messages routing to the target tab.</li>
-      <li>Fixed the lag ping timeout window.</li>
-    </ul>
-  </description>
-</release>
-<release date="2026-06-20" version="2.18.2">
-  <description>
-    <p>Security and connections:</p>
-    <ul>
-      <li>Improved TLS, certificate and hostname validation, FiSHLiM OpenSSL handling, keyring support, and DCC host lookups.</li>
-    </ul>
-    <p>FiSHLiM:</p>
-    <ul>
-      <li>Added a GTK key manager with context-menu access and clearer channel/private-message key handling.</li>
-    </ul>
-    <p>Interface and preferences:</p>
-    <ul>
-      <li>Improved keybind customization, reset support, channel-name switching, <code>/server -noproxy</code>, and stale-link ping checks.</li>
-      <li>Refined GTK behavior with native file choosers, topic layout preferences, timestamp/date tooltips, text scroll controls, and aligned network meters.</li>
-      <li>Added privacy and display options for hiding join/part hostmasks and controlling topic/multiline layout.</li>
-    </ul>
-    <p>Fixes:</p>
-    <ul>
-      <li>Fixed tray restore, DBus unload handling, GTK3 theme refresh/saving, topic relayout, and tab switcher compatibility.</li>
-      <li>Updated project documentation.</li>
-    </ul>
-  </description>
-</release>
-<release date="2026-05-21" version="2.18.1">
-  <description>
-    <ul>
-      <li>Migrated D-Bus handling to GDBus.</li>
-      <li>Enabled mouse wheel channel switching by default and consumed handled tab wheel events.</li>
-      <li>Switched main panes to native GTK scrollbars.</li>
-      <li>Tightened userlist button and meter layout.</li>
-      <li>Made the native Windows file chooser modal.</li>
-      <li>Set the Windows AppUserModelID before GTK startup.</li>
-      <li>Updated Windows CI to use the new GTK3 bundle zip.</li>
-      <li>Updated Windows installer architecture checks to use x64-compatible detection.</li>
-      <li>Bumped the Flatpak Perl runtime to 5.42.2.</li>
-      <li>Fixed palette color reads to preserve base GTK state.</li>
-      <li>Fixed auto-replace whole-word matching.</li>
-      <li>Fixed checksum file stream cleanup.</li>
-      <li>Fixed byte handling in the Python console.</li>
-      <li>Guarded GTK drag-and-drop handlers against null windows.</li>
-      <li>Fixed size_t and integer handling issues.</li>
-      <li>Removed the Winamp plugin.</li>
-    </ul>
-  </description>
-</release>
-<release date="2026-04-20" version="2.18.0">
-  <description>
-    <p>Tabs and navigation:</p>
-    <ul>
-      <li>Added optional close buttons on tabs.</li>
-      <li>Added Ctrl+W to close tabs and Ctrl+Shift+T to reopen recently closed tabs.</li>
-      <li>Improved channel tree behavior by ignoring collapsed parent selections.</li>
-    </ul>
-    <p>Themes and appearance:</p>
-    <ul>
-      <li>Expanded theme import support with .hct support in colors.conf import.</li>
-      <li>Added pevent import support from .hct theme files and improved import result messaging.</li>
-      <li>Expanded palette and selection CSS styling for better theme consistency.</li>
-      <li>Auto-sizes the topic bar to wrapped text for better multi-line topic handling.</li>
-    </ul>
-    <p>Links and text handling:</p>
-    <ul>
-      <li>Refined command-character parsing when pasting path-like text.</li>
-      <li>Tightened topic link detection and opening rules.</li>
-      <li>Added Public Suffix List validation for host links to reduce bad link matches.</li>
-    </ul>
-    <p>Packaging and platform integration:</p>
-    <ul>
-      <li>Sanitized the Linux open environment for AppImage builds and added safer fallback handling.</li>
-      <li>Labeled Windows installer runtimes with exact versions.</li>
-      <li>Fixed the notification icon and corrected the Flatpak screenshot asset.</li>
-      <li>Improved AppStream metainfo validation.</li>
-    </ul>
-  </description>
-</release>
-<release date="2026-03-30" version="2.18.0~pre6">
-  <description>
-    <p>GTK theme and UI:</p>
-    <ul>
-      <li>Applied app theme CSS to the menubar consistently across the app.</li>
-      <li>Restored horizontal separator lines in menus.</li>
-      <li>Fixed duplicate dialog buttons persisting in the UI.</li>
-      <li>Fixed GTK auto-replace cursor snapback.</li>
-      <li>Restored hiding of formatting control bytes so only formatted output is shown.</li>
-      <li>Fixed xtext link hit-testing coordinates.</li>
-      <li>Fixed short-palette fallback clobbering tab colors.</li>
-      <li>Added a None option for resetting the GTK3 theme back to system/default behavior.</li>
-      <li>Wrapped the topic bar in a scroller with bounded height.</li>
-      <li>Fixed fallback GTK menu highlight states.</li>
-      <li>Applied configured font preferences to the topic bar, channel tree, user list, and input box.</li>
-      <li>Removed unused UI icons.</li>
-      <li>Added close buttons to tabs.</li>
-    </ul>
-    <p>Preferences and search:</p>
-    <ul>
-      <li>Lazy-loads Preferences pages on first open for faster dialog startup.</li>
-      <li>Added channel-only mode to Ctrl+F search.</li>
-    </ul>
-    <p>Security and certificates:</p>
-    <ul>
-      <li>Added one-click client SSL certificate tools, including generation with P-256 certificates.</li>
-      <li>Added client SSL certificate import support in the network editor.</li>
-    </ul>
-    <p>Windows and packaging:</p>
-    <ul>
-      <li>Improved Windows installer VC++ redistributable handling by failing loudly when missing and using the official Microsoft download endpoint.</li>
-      <li>Fixed Windows locale path resolution in both GTK and text frontends.</li>
-    </ul>
-    <p>Other changes:</p>
-    <ul>
-      <li>Added 99-color support.</li>
-      <li>Disabled disk info in sysinfo.</li>
-    </ul>
-  </description>
-</release>
   <release date="2026-03-22" version="2.18.0~pre5">
     <description>
       <p>Preferences and config saving:</p>
@@ -188,6 +60,14 @@
       </ul>
     </description>
   </release>
+  <release date="2026-03-22" version="2.18.0~pre5">
+    <description>
+      <p>Version metadata update:</p>
+      <ul>
+        <li>Bumped release version references to <code>2.18.0~pre5</code> across build and packaging files.</li>
+      </ul>
+    </description>
+  </release>
   <release date="2026-03-14" version="2.18.0~pre4">
     <description>
       <p>UI fixes, topic bar improvements, and selection styling updates:</p>

data/zoitechat.gresource.xml.in

@@ -0,0 +1,27 @@
+<?xml version="1.0" encoding="UTF-8"?>
+<gresources>
+	<gresource prefix="/icons">
+		<file alias="zoitechat.png" preprocess="to-pixdata">@ZOITECHAT_PNG@</file>
+		<file alias="zoitechat.svg">icons/zoitechat.svg</file>
+		<file alias="book.png" preprocess="to-pixdata">icons/book.png</file>
+
+		<file alias="ulist_voice.png" preprocess="to-pixdata">icons/ulist_voice.png</file>
+		<file alias="ulist_halfop.png" preprocess="to-pixdata">icons/ulist_halfop.png</file>
+		<file alias="ulist_op.png" preprocess="to-pixdata">icons/ulist_op.png</file>
+		<file alias="ulist_owner.png" preprocess="to-pixdata">icons/ulist_owner.png</file>
+		<file alias="ulist_founder.png" preprocess="to-pixdata">icons/ulist_founder.png</file>
+		<file alias="ulist_netop.png" preprocess="to-pixdata">icons/ulist_netop.png</file>
+
+		<file alias="tray_normal.png" preprocess="to-pixdata">@ZOITECHAT_PNG@</file>
+		<file alias="tray_fileoffer.png" preprocess="to-pixdata">icons/tray_fileoffer.png</file>
+		<file alias="tray_highlight.png" preprocess="to-pixdata">icons/tray_highlight.png</file>
+		<file alias="tray_message.png" preprocess="to-pixdata">icons/tray_message.png</file>
+
+		<file alias="tree_channel.png" preprocess="to-pixdata">icons/tree_channel.png</file>
+		<file alias="tree_dialog.png" preprocess="to-pixdata">icons/tree_dialog.png</file>
+		<file alias="tree_server.png" preprocess="to-pixdata">icons/tree_server.png</file>
+		<file alias="tree_util.png" preprocess="to-pixdata">icons/tree_util.png</file>
+
+
+	</gresource>
+</gresources>

flatpak/net.zoite.Zoitechat.json

@@ -7,13 +7,14 @@
   "command": "zoitechat",
   "finish-args": [
     "--share=ipc",
-    "--socket=wayland",
-    "--socket=fallback-x11",
+    "--socket=x11",
     "--share=network",
     "--socket=pulseaudio",
     "--filesystem=xdg-download",
     "--filesystem=xdg-data/themes:ro",
     "--filesystem=xdg-data/icons:ro",
+    "--filesystem=~/.themes:ro",
+    "--filesystem=~/.icons:ro",
     "--filesystem=xdg-run/tray-icon:create",
     "--env=GTK_CSD=1",
     "--talk-name=org.freedesktop.Notifications",
@@ -33,6 +34,7 @@
     }
   },
   "modules": [
+    "shared-modules/dbus-glib/dbus-glib.json",
     "shared-modules/lua5.4/lua-5.4.json",
     "shared-modules/libcanberra/libcanberra.json",
     "shared-modules/libayatana-appindicator/libayatana-appindicator-gtk3.json",
@@ -43,9 +45,9 @@
       "buildsystem": "meson",
       "sources": [
         {
-          "type": "archive",
-          "url": "https://github.com/pavouk/lgi/archive/c9b8e4473c6421f2a215d8c06c0d94b86eb0b26a.tar.gz",
-          "sha256": "db67b2b7ee89fa566f783486d56be7203552a997bc55f35020b57dd2776b9943"
+          "type": "git",
+          "url": "https://github.com/pavouk/lgi.git",
+          "commit": "c9b8e4473c6421f2a215d8c06c0d94b86eb0b26a"
         }
       ]
     },

flatpak/perl.json

@@ -13,8 +13,8 @@
   "sources": [
     {
       "type": "archive",
-      "url": "https://www.cpan.org/src/5.0/perl-5.42.2.tar.xz",
-      "sha256": "0a585eeb9e363c0f80482ddb3571625250c2c86aeb408853e8ea50805cfb14bb"
+      "url": "https://www.cpan.org/src/5.0/perl-5.40.1.tar.xz",
+      "sha256": "dfa20c2eef2b4af133525610bbb65dd13777ecf998c9c5b1ccf0d308e732ee3f"
     }
   ]
 }

meson.build

@@ -1,5 +1,5 @@
 project('zoitechat', 'c',
-  version: '2.18.3',
+  version: '2.18.0~pre5',
   meson_version: '>= 0.55.0',
   default_options: [
     'c_std=c17',
@@ -18,8 +18,7 @@ libgmodule_dep = dependency('gmodule-2.0')
 
 libcanberra_dep = dependency('libcanberra', version: '>= 0.22',
                              required: get_option('libcanberra'))
-dbus_dep = dependency('gio-2.0', required: get_option('dbus'))
-libsecret_dep = dependency('libsecret-1', required: false)
+dbus_glib_dep = dependency('dbus-glib-1', required: get_option('dbus'))
 
 global_deps = []
 if cc.get_id() == 'msvc'
@@ -40,8 +39,7 @@ config_h.set10('ENABLE_NLS', true)
 # Optional features
 config_h.set('USE_OPENSSL', libssl_dep.found())
 config_h.set('USE_LIBCANBERRA', libcanberra_dep.found())
-config_h.set('USE_DBUS', dbus_dep.found())
-config_h.set('HAVE_LIBSECRET', libsecret_dep.found())
+config_h.set('USE_DBUS', dbus_glib_dep.found())
 config_h.set('USE_PLUGIN', get_option('plugin'))
 config_h.set('USE_GTK_FRONTEND', get_option('gtk-frontend'))
 
@@ -183,7 +181,7 @@ if meson.version().version_compare('>= 0.55.0')
     'GTK Frontend': get_option('gtk-frontend') ? 'enabled (GTK+ 3.22+)' : 'disabled',
     'TLS (openssl)': libssl_dep.found(),
     'Plugin Support': get_option('plugin'),
-    'DBus Support': dbus_dep.found(),
+    'DBus Support': dbus_glib_dep.found(),
     'libcanberra': libcanberra_dep.found(),
   }, section: 'Features')
 

meson_options.txt

@@ -44,7 +44,7 @@ option('with-exec', type: 'boolean',
 option('with-fishlim', type: 'boolean',
   description: 'Fish encryption plugin, requires openssl'
 )
-option('with-lua', type: 'string', value: 'lua-5.4',
+option('with-lua', type: 'string', value: 'luajit',
   description: 'Lua scripting plugin, value is pkg-config name to use or "false"'
 )
 option('with-perl', type: 'string', value: 'perl',
@@ -59,6 +59,9 @@ option('with-sysinfo', type: 'boolean',
 option('with-upd', type: 'boolean',
   description: 'Update plugin, Windows only'
 )
+option('with-winamp', type: 'boolean',
+  description: 'Winamp plugin, Windows only'
+)
 option('with-perl-legacy-api', type: 'boolean', value: false,
   description: 'Enables the legacy IRC perl module for compatibility with old scripts'
 )

packaging/fedora/zoitechat.spec

@@ -1,102 +0,0 @@
-Name:           zoitechat
-Version:        2.18.3
-Release:        %autorelease
-Summary:        HexChat-based IRC client
-License:        GPL-2.0-or-later WITH cryptsetup-OpenSSL-exception
-URL:            https://github.com/ZoiteChat/zoitechat
-Source0:        %{url}/archive/refs/tags/%{name}-%{version}.tar.gz
-
-BuildRequires:  desktop-file-utils
-BuildRequires:  gcc
-BuildRequires:  gettext
-BuildRequires:  libappstream-glib
-BuildRequires:  meson >= 0.55.0
-BuildRequires:  perl
-BuildRequires:  perl-devel
-BuildRequires:  python3
-BuildRequires:  python3-cffi
-BuildRequires:  publicsuffix-list
-BuildRequires:  xwayland-run
-BuildRequires:  weston
-BuildRequires:  pkgconfig(ayatana-appindicator3-0.1)
-BuildRequires:  pkgconfig(dbus-glib-1)
-BuildRequires:  pkgconfig(gio-2.0) >= 2.36.0
-BuildRequires:  pkgconfig(gmodule-2.0)
-BuildRequires:  pkgconfig(gtk+-3.0) >= 3.22
-BuildRequires:  pkgconfig(iso-codes)
-BuildRequires:  pkgconfig(libarchive)
-BuildRequires:  pkgconfig(libcanberra) >= 0.22
-BuildRequires:  pkgconfig(libpci)
-BuildRequires:  pkgconfig(lua)
-BuildRequires:  pkgconfig(openssl) >= 0.9.8
-BuildRequires:  pkgconfig(python3)
-
-Requires:       hicolor-icon-theme
-Requires:       iso-codes
-
-%package devel
-Summary:        Development files for ZoiteChat plugins
-Requires:       %{name}%{?_isa} = %{version}-%{release}
-
-%description devel
-Development files for building ZoiteChat plugins.
-
-%description
-ZoiteChat is a HexChat-based IRC client for Windows and UNIX-like operating
-systems.
-
-%prep
-%autosetup -C
-
-%build
-%meson \
-  -Dtext-frontend=false \
-  -Dwith-checksum=true \
-  -Dwith-fishlim=true \
-  -Dwith-lua=lua \
-  -Dwith-perl=perl \
-  -Dwith-python=python3 \
-  -Dwith-sysinfo=true \
-  -Dinstall-appdata=true \
-  -Dinstall-plugin-metainfo=true
-%meson_build
-
-%install
-%meson_install
-%find_lang %{name}
-
-%check
-desktop-file-validate %{buildroot}%{_datadir}/applications/net.zoite.Zoitechat.desktop
-
-appstream-util validate-relax --nonet %{buildroot}%{_datadir}/metainfo/net.zoite.Zoitechat.appdata.xml
-appstream-util validate-relax --nonet %{buildroot}%{_datadir}/metainfo/net.zoite.Zoitechat*.metainfo.xml
-
-xwfb-run -- /usr/bin/meson test -C %{_vpath_builddir} --num-processes %{_smp_build_ncpus} --print-errorlogs \
-  "Theme Manager Dispatch Routing Tests" \
-  "Validate net.zoite.Zoitechat.desktop" \
-  "Validate translations" \
-  "Fishlim Tests"
-
-%files -f %{name}.lang
-%license COPYING
-%doc readme.md troubleshooting.md
-%{_bindir}/zoitechat
-%{_datadir}/applications/net.zoite.Zoitechat.desktop
-%{_datadir}/dbus-1/services/org.zoitechat.service.service
-%{_datadir}/icons/hicolor/48x48/apps/net.zoite.Zoitechat.png
-%{_datadir}/icons/hicolor/scalable/apps/net.zoite.Zoitechat.svg
-%{_datadir}/metainfo/net.zoite.Zoitechat.appdata.xml
-%{_datadir}/metainfo/net.zoite.Zoitechat*.metainfo.xml
-%dir %{_libdir}/zoitechat
-%dir %{_libdir}/zoitechat/plugins
-%dir %{_libdir}/zoitechat/python
-%{_libdir}/zoitechat/plugins/*.so
-%{_libdir}/zoitechat/python/*.py
-%{_mandir}/man1/zoitechat.1*
-
-%files devel
-%{_includedir}/zoitechat-plugin.h
-%{_libdir}/pkgconfig/zoitechat-plugin.pc
-
-%changelog
-%autochangelog

packaging/manjaro/PKGBUILD

@@ -0,0 +1,70 @@
+# Maintainer: ZoiteChat Maintainers <zoitechat@users.noreply.github.com>
+
+pkgname=zoitechat-git
+pkgver=0
+pkgrel=1
+pkgdesc='IRC client for GNOME (ZoiteChat development snapshot)'
+arch=('x86_64')
+url='https://github.com/zoitechat/zoitechat'
+license=('GPL-2.0-or-later')
+depends=(
+  'dbus-glib'
+  'glib2'
+  'gtk3'
+  'iso-codes'
+  'libayatana-appindicator'
+  'libcanberra'
+  'lua'
+  'openssl'
+  'perl'
+  'python-cffi'
+)
+makedepends=(
+  'git'
+  'meson'
+  'ninja'
+  'pkgconf'
+  'python'
+)
+optdepends=(
+  'pciutils: sysinfo plugin hardware detection details'
+)
+provides=('zoitechat')
+conflicts=('zoitechat')
+
+_repo_root="$(cd "$(dirname "${BASH_SOURCE[0]}")/../.." && pwd)"
+source=("zoitechat::git+file://${_repo_root}")
+sha256sums=('SKIP')
+
+pkgver() {
+  cd "$srcdir/zoitechat"
+
+  if git describe --long --tags --abbrev=7 >/dev/null 2>&1; then
+    git describe --long --tags --abbrev=7 \
+      | sed 's/^v//' \
+      | sed -E 's/([^-]+)-([0-9]+)-g/\1.r\2.g/' \
+      | sed 's/-/./g'
+  else
+    printf '0.r%s.%s\n' \
+      "$(git rev-list --count HEAD)" \
+      "$(git rev-parse --short=7 HEAD)"
+  fi
+}
+
+build() {
+  arch-meson zoitechat build \
+    -Dtext-frontend=false \
+    -Dwith-checksum=true \
+    -Dwith-fishlim=true \
+    -Dwith-lua=lua \
+    -Dwith-perl=perl \
+    -Dwith-python=python3 \
+    -Dwith-sysinfo=true \
+    -Dinstall-plugin-metainfo=true
+
+  meson compile -C build
+}
+
+package() {
+  meson install -C build --destdir "$pkgdir"
+}

plugins/checksum/checksum.c

@@ -104,14 +104,12 @@ thread_sha256_file (GTask *task, GFile *file, gpointer task_data, GCancellable *
 		g_checksum_update (checksum, buffer, ret);
 
 	if (error) {
+		g_checksum_free (checksum);
 		g_task_return_error (task, error);
-		goto cleanup;
+		return;
 	}
 
 	g_task_return_pointer (task, g_strdup (g_checksum_get_string (checksum)), g_free);
-cleanup:
-	g_input_stream_close(G_INPUT_STREAM(istream), NULL, NULL);
-	g_object_unref(istream);
 	g_checksum_free (checksum);
 }
 

plugins/fishlim/fish.c

@@ -91,13 +91,27 @@ static const signed char fish_unbase64[256] = {
 #include <openssl/provider.h>
 static OSSL_PROVIDER *legacy_provider;
 static OSSL_PROVIDER *default_provider;
+static OSSL_LIB_CTX *ossl_ctx;
 #endif
 
 int fish_init(void)
 {
 #if OPENSSL_VERSION_NUMBER >= 0x30000000L
-    legacy_provider = OSSL_PROVIDER_load(NULL, "legacy");
-    default_provider = OSSL_PROVIDER_load(NULL, "default");
+    ossl_ctx = OSSL_LIB_CTX_new();
+    if (!ossl_ctx)
+        return 0;
+
+    legacy_provider = OSSL_PROVIDER_load(ossl_ctx, "legacy");
+    if (!legacy_provider) {
+        fish_deinit();
+        return 0;
+    }
+
+    default_provider = OSSL_PROVIDER_load(ossl_ctx, "default");
+    if (!default_provider) {
+        fish_deinit();
+        return 0;
+    }
 #endif
     return 1;
 }
@@ -115,6 +129,10 @@ void fish_deinit(void)
         default_provider = NULL;
     }
 
+    if (ossl_ctx) {
+        OSSL_LIB_CTX_free(ossl_ctx);
+        ossl_ctx = NULL;
+    }
 #endif
 }
 
@@ -260,9 +278,7 @@ char *fish_cipher(const char *plaintext, size_t plaintext_len, const char *key,
         }
 
 #if OPENSSL_VERSION_NUMBER >= 0x30000000L
-        cipher = EVP_CIPHER_fetch(NULL, "BF-CBC", NULL);
-        if (!cipher)
-            cipher = (EVP_CIPHER *) EVP_bf_cbc();
+        cipher = EVP_CIPHER_fetch(ossl_ctx, "BF-CBC", NULL);
 #else
         cipher = (EVP_CIPHER *) EVP_bf_cbc();
 #endif
@@ -270,9 +286,7 @@ char *fish_cipher(const char *plaintext, size_t plaintext_len, const char *key,
     } else if (mode == EVP_CIPH_ECB_MODE) {
 
 #if OPENSSL_VERSION_NUMBER >= 0x30000000L
-        cipher = EVP_CIPHER_fetch(NULL, "BF-ECB", NULL);
-        if (!cipher)
-            cipher = (EVP_CIPHER *) EVP_bf_ecb();
+        cipher = EVP_CIPHER_fetch(ossl_ctx, "BF-ECB", NULL);
 #else
         cipher = (EVP_CIPHER *) EVP_bf_ecb();
 #endif

plugins/fishlim/fishlim.vcxproj

@@ -26,7 +26,7 @@
   <ItemDefinitionGroup Condition="'$(Configuration)|$(Platform)'=='Release|x64'">
     <ClCompile>
       <PreprocessorDefinitions>WIN32;_WIN64;_AMD64_;NDEBUG;_WINDOWS;_USRDLL;FISHLIM_EXPORTS;HAVE_DH_SET0_PQG;HAVE_DH_GET0_KEY;HAVE_DH_SET0_KEY;%(PreprocessorDefinitions)</PreprocessorDefinitions>
-      <AdditionalIncludeDirectories>$(DepsRoot)\include;$(OpenSslInclude);$(Glib);$(Gtk);..\..\src\common;$(ZoiteChatLib);%(AdditionalIncludeDirectories)</AdditionalIncludeDirectories>
+      <AdditionalIncludeDirectories>$(DepsRoot)\include;$(OpenSslInclude);$(Glib);..\..\src\common;$(ZoiteChatLib);%(AdditionalIncludeDirectories)</AdditionalIncludeDirectories>
     </ClCompile>
     <Link>
       <ModuleDefinitionFile>fishlim.def</ModuleDefinitionFile>

plugins/fishlim/keystore.c

@@ -194,18 +194,6 @@ static gboolean keyfile_save_to_file (GKeyFile *keyfile, char *filename) {
 }
 #endif
 
-
-gchar **keystore_get_targets(gsize *length) {
-    GKeyFile *keyfile;
-    gchar **groups;
-
-    keyfile = getConfigFile();
-    groups = g_key_file_get_groups(keyfile, length);
-    g_key_file_free(keyfile);
-
-    return groups;
-}
-
 /**
  * Writes the key store file to disk.
  */
@@ -229,7 +217,6 @@ G_GNUC_END_IGNORE_DEPRECATIONS
 /**
  * Sets a key in the key store file.
  */
-
 gboolean keystore_store_key(const char *nick, const char *key, enum fish_mode mode) {
     const char *password;
     char *encrypted;

plugins/fishlim/keystore.h

@@ -33,7 +33,6 @@
 char *keystore_get_key(const char *nick, enum fish_mode *mode);
 gboolean keystore_store_key(const char *nick, const char *key, enum fish_mode mode);
 gboolean keystore_delete_nick(const char *nick);
-gchar **keystore_get_targets(gsize *length);
 
 #endif
 

plugins/fishlim/meson.build

@@ -15,7 +15,7 @@ fishlim_sources = [
 ]
 
 shared_module('fishlim', fishlim_sources,
-  dependencies: [libgio_dep, gtk_dep, zoitechat_plugin_dep, libssl_dep],
+  dependencies: [libgio_dep, zoitechat_plugin_dep, libssl_dep],
   c_args: ['-DOPENSSL_API_COMPAT=0x10100000L'],
   install: true,
   install_dir: plugindir,

plugins/fishlim/plugin_zoitechat.c

@@ -27,7 +27,6 @@
 #include "config.h"
 
 #include <glib.h>
-#include <gtk/gtk.h>
 #include <stdlib.h>
 #include <string.h>
 #include "zoitechat-plugin.h"
@@ -45,7 +44,7 @@ static const char plugin_version[] = "1.0.0";
 
 static const char usage_setkey[] = "Usage: SETKEY [<nick or #channel>] [<mode>:]<password>, sets the key for a channel or nick. Modes: ECB, CBC";
 static const char usage_delkey[] = "Usage: DELKEY [<nick or #channel>], deletes the key for a channel or nick";
-static const char usage_keyx[] = "Usage: KEYX [<nick>] [ECB|CBC], performs DH1080 key-exchange with <nick>";
+static const char usage_keyx[] = "Usage: KEYX [<nick>], performs DH1080 key-exchange with <nick>";
 static const char usage_topic[] = "Usage: TOPIC+ <topic>, sets a new encrypted topic for the current channel";
 static const char usage_notice[] = "Usage: NOTICE+ <nick or #channel> <notice>";
 static const char usage_msg[] = "Usage: MSG+ <nick or #channel> <message>";
@@ -53,13 +52,6 @@ static const char usage_msg[] = "Usage: MSG+ <nick or #channel> <message>";
 
 static zoitechat_plugin *ph;
 static GHashTable *pending_exchanges;
-static GtkWidget *fishlim_dialog;
-static GtkWidget *fishlim_target_entry;
-static GtkWidget *fishlim_key_entry;
-static GtkWidget *fishlim_mode_combo;
-static GtkWidget *fishlim_status_label;
-static GtkListStore *fishlim_store;
-static GtkWidget *fishlim_view;
 
 
 /**
@@ -429,7 +421,7 @@ static int handle_keyx_notice(char *word[], char *word_eol[], void *userdata) {
             zoitechat_commandf(ph, "quote NOTICE %s :DH1080_FINISH %s%s", sender, pub_key, (mode == FISH_CBC_MODE) ? " CBC" : "");
             g_free(pub_key);
         } else {
-            zoitechat_printf(ph, "Failed to generate keys");
+            zoitechat_print(ph, "Failed to generate keys");
             goto cleanup;
         }
     } else if (!strcmp (dh_message, "DH1080_FINISH")) {
@@ -454,7 +446,7 @@ static int handle_keyx_notice(char *word[], char *word_eol[], void *userdata) {
         zoitechat_printf(ph, "Stored new key for %s (%s)", sender, fish_modes[mode]);
         g_free(secret_key);
     } else {
-        zoitechat_printf(ph, "Failed to create secret key!");
+        zoitechat_print(ph, "Failed to create secret key!");
     }
 
 cleanup:
@@ -463,314 +455,6 @@ cleanup:
     return ZOITECHAT_EAT_ALL;
 }
 
-
-static const char *fishlim_gui_target(void) {
-    const char *target;
-
-    target = gtk_entry_get_text(GTK_ENTRY(fishlim_target_entry));
-    if (target && *target)
-        return target;
-
-    return zoitechat_get_info(ph, "channel");
-}
-
-static void fishlim_gui_refresh(void) {
-    GtkTreeIter iter;
-    gchar **targets;
-    gsize length, i;
-    const char *target;
-    char *key;
-    enum fish_mode mode;
-
-    if (!fishlim_dialog)
-        return;
-
-    gtk_list_store_clear(fishlim_store);
-    targets = keystore_get_targets(&length);
-
-    for (i = 0; targets && i < length; i++) {
-        key = keystore_get_key(targets[i], &mode);
-        gtk_list_store_append(fishlim_store, &iter);
-        gtk_list_store_set(fishlim_store, &iter, 0, targets[i], 1, fish_modes[mode], 2, key ? "Stored" : "Unreadable", -1);
-        g_free(key);
-    }
-
-    g_strfreev(targets);
-
-    target = fishlim_gui_target();
-    key = target ? keystore_get_key(target, &mode) : NULL;
-
-    if (key) {
-        char *text = g_strdup_printf("Key stored for %s (%s)", target, fish_modes[mode]);
-        gtk_label_set_text(GTK_LABEL(fishlim_status_label), text);
-        gtk_combo_box_set_active(GTK_COMBO_BOX(fishlim_mode_combo), mode == FISH_CBC_MODE ? 1 : 0);
-        g_free(text);
-        g_free(key);
-    } else if (target && *target) {
-        char *text = g_strdup_printf("No key for %s", target);
-        gtk_label_set_text(GTK_LABEL(fishlim_status_label), text);
-        g_free(text);
-    } else {
-        gtk_label_set_text(GTK_LABEL(fishlim_status_label), "No target selected");
-    }
-}
-
-static void fishlim_gui_refresh_cb(GtkWidget *widget, gpointer data) {
-    fishlim_gui_refresh();
-}
-
-static void fishlim_gui_send_channel_key(const char *channel, const char *mode, const char *key) {
-    GtkWidget *dialog, *content, *entry, *label;
-    char **users;
-    int i;
-
-    if (!channel || !*channel || irc_is_query(channel))
-        return;
-
-    dialog = gtk_dialog_new_with_buttons("Share Channel Key", GTK_WINDOW(fishlim_dialog), GTK_DIALOG_MODAL | GTK_DIALOG_DESTROY_WITH_PARENT, "_Skip", GTK_RESPONSE_CANCEL, "_Send", GTK_RESPONSE_OK, NULL);
-    content = gtk_dialog_get_content_area(GTK_DIALOG(dialog));
-    label = gtk_label_new("Send this channel key to users by private message. Enter users separated by commas.");
-    gtk_label_set_line_wrap(GTK_LABEL(label), TRUE);
-    gtk_box_pack_start(GTK_BOX(content), label, FALSE, FALSE, 6);
-    entry = gtk_entry_new();
-    gtk_entry_set_placeholder_text(GTK_ENTRY(entry), "nick1, nick2, nick3");
-    gtk_entry_set_activates_default(GTK_ENTRY(entry), TRUE);
-    gtk_box_pack_start(GTK_BOX(content), entry, FALSE, FALSE, 6);
-    gtk_dialog_set_default_response(GTK_DIALOG(dialog), GTK_RESPONSE_OK);
-    gtk_widget_show_all(dialog);
-
-    if (gtk_dialog_run(GTK_DIALOG(dialog)) == GTK_RESPONSE_OK) {
-        users = g_strsplit(gtk_entry_get_text(GTK_ENTRY(entry)), ",", -1);
-        for (i = 0; users && users[i]; i++) {
-            char *user = g_strstrip(users[i]);
-            if (*user)
-                zoitechat_commandf(ph, "msg %s Encrypted chat invite: join %s, open FiSHLiM Key Manager, add channel %s with %s key: %s. Key exchange is for private messages only.", user, channel, channel, mode, key);
-        }
-        g_strfreev(users);
-    }
-
-    gtk_widget_destroy(dialog);
-}
-
-static void fishlim_gui_set(GtkWidget *widget, gpointer data) {
-    const char *target = fishlim_gui_target();
-    const char *key = gtk_entry_get_text(GTK_ENTRY(fishlim_key_entry));
-    const char *mode = gtk_combo_box_get_active(GTK_COMBO_BOX(fishlim_mode_combo)) == 1 ? "CBC" : "ECB";
-
-    if (!target || !*target || !key || !*key) {
-        zoitechat_printf(ph, "%s\n", usage_setkey);
-        return;
-    }
-
-    zoitechat_commandf(ph, "SETKEY %s %s:%s", target, mode, key);
-    fishlim_gui_send_channel_key(target, mode, key);
-    gtk_entry_set_text(GTK_ENTRY(fishlim_key_entry), "");
-    fishlim_gui_refresh();
-}
-
-static gboolean fishlim_gui_confirm_delete(const char *target) {
-    GtkWidget *dialog;
-    char *message;
-    gboolean confirmed;
-
-    message = g_strdup_printf("Delete the key for %s?", target);
-    dialog = gtk_message_dialog_new(GTK_WINDOW(fishlim_dialog), GTK_DIALOG_MODAL | GTK_DIALOG_DESTROY_WITH_PARENT, GTK_MESSAGE_WARNING, GTK_BUTTONS_NONE, "%s", message);
-    gtk_message_dialog_format_secondary_text(GTK_MESSAGE_DIALOG(dialog), "This cannot be undone.");
-    gtk_dialog_add_buttons(GTK_DIALOG(dialog), "_Cancel", GTK_RESPONSE_CANCEL, "_Delete", GTK_RESPONSE_ACCEPT, NULL);
-    gtk_dialog_set_default_response(GTK_DIALOG(dialog), GTK_RESPONSE_CANCEL);
-    confirmed = gtk_dialog_run(GTK_DIALOG(dialog)) == GTK_RESPONSE_ACCEPT;
-    gtk_widget_destroy(dialog);
-    g_free(message);
-    return confirmed;
-}
-
-static char *fishlim_gui_selected_target(void) {
-    GtkTreeSelection *selection;
-    GtkTreeModel *model;
-    GtkTreeIter iter;
-    char *target = NULL;
-
-    if (!fishlim_view)
-        return NULL;
-
-    selection = gtk_tree_view_get_selection(GTK_TREE_VIEW(fishlim_view));
-    if (gtk_tree_selection_get_selected(selection, &model, &iter))
-        gtk_tree_model_get(model, &iter, 0, &target, -1);
-
-    return target;
-}
-
-static void fishlim_gui_delete(GtkWidget *widget, gpointer data) {
-    char *selected = fishlim_gui_selected_target();
-    const char *target = selected ? selected : fishlim_gui_target();
-
-    if (!target || !*target) {
-        zoitechat_printf(ph, "%s\n", usage_delkey);
-        g_free(selected);
-        return;
-    }
-
-    if (fishlim_gui_confirm_delete(target)) {
-        zoitechat_commandf(ph, "DELKEY %s", target);
-        fishlim_gui_refresh();
-    }
-
-    g_free(selected);
-}
-
-static char *fishlim_gui_prompt_target(const char *title, const char *initial) {
-    GtkWidget *dialog, *content, *entry;
-    char *target = NULL;
-
-    dialog = gtk_dialog_new_with_buttons(title, GTK_WINDOW(fishlim_dialog), GTK_DIALOG_MODAL | GTK_DIALOG_DESTROY_WITH_PARENT, "_Cancel", GTK_RESPONSE_CANCEL, "_OK", GTK_RESPONSE_OK, NULL);
-    content = gtk_dialog_get_content_area(GTK_DIALOG(dialog));
-    entry = gtk_entry_new();
-    if (initial && *initial)
-        gtk_entry_set_text(GTK_ENTRY(entry), initial);
-    gtk_entry_set_activates_default(GTK_ENTRY(entry), TRUE);
-    gtk_box_pack_start(GTK_BOX(content), gtk_label_new("Private message user"), FALSE, FALSE, 6);
-    gtk_box_pack_start(GTK_BOX(content), entry, FALSE, FALSE, 6);
-    gtk_dialog_set_default_response(GTK_DIALOG(dialog), GTK_RESPONSE_OK);
-    gtk_widget_show_all(dialog);
-
-    if (gtk_dialog_run(GTK_DIALOG(dialog)) == GTK_RESPONSE_OK) {
-        const char *text = gtk_entry_get_text(GTK_ENTRY(entry));
-        if (text && *text)
-            target = g_strdup(text);
-    }
-
-    gtk_widget_destroy(dialog);
-    return target;
-}
-
-static void fishlim_gui_keyx(GtkWidget *widget, gpointer data) {
-    char *target;
-    const char *initial = fishlim_gui_target();
-    const char *mode = gtk_combo_box_get_active(GTK_COMBO_BOX(fishlim_mode_combo)) == 1 ? "CBC" : "ECB";
-
-    if (!initial || !*initial || !irc_is_query(initial))
-        initial = NULL;
-
-    target = fishlim_gui_prompt_target("Key Exchange", initial);
-    if (!target)
-        return;
-
-    zoitechat_commandf(ph, "KEYX %s %s", target, mode);
-    g_free(target);
-}
-
-static void fishlim_gui_row_activated(GtkTreeView *tree, GtkTreePath *path, GtkTreeViewColumn *column, gpointer data) {
-    GtkTreeModel *model = gtk_tree_view_get_model(tree);
-    GtkTreeIter iter;
-    char *target;
-
-    if (!gtk_tree_model_get_iter(model, &iter, path))
-        return;
-
-    gtk_tree_model_get(model, &iter, 0, &target, -1);
-    gtk_entry_set_text(GTK_ENTRY(fishlim_target_entry), target);
-    g_free(target);
-    fishlim_gui_refresh();
-}
-
-static void fishlim_gui_destroy(GtkWidget *widget, gpointer data) {
-    fishlim_dialog = NULL;
-    fishlim_target_entry = NULL;
-    fishlim_key_entry = NULL;
-    fishlim_mode_combo = NULL;
-    fishlim_status_label = NULL;
-    fishlim_store = NULL;
-    fishlim_view = NULL;
-}
-
-static int handle_fishlim(char *word[], char *word_eol[], void *userdata) {
-    GtkWidget *content, *grid, *view, *scroll, *buttons, *button;
-    GtkCellRenderer *renderer;
-    const char *target;
-
-    target = *word_eol[2] ? word_eol[2] : zoitechat_get_info(ph, "channel");
-
-    if (fishlim_dialog) {
-        if (target)
-            gtk_entry_set_text(GTK_ENTRY(fishlim_target_entry), target);
-        gtk_window_present(GTK_WINDOW(fishlim_dialog));
-        return ZOITECHAT_EAT_ZOITECHAT;
-    }
-
-    fishlim_dialog = gtk_dialog_new_with_buttons("FiSHLiM Key Manager", NULL, GTK_DIALOG_DESTROY_WITH_PARENT, "_Close", GTK_RESPONSE_CLOSE, NULL);
-    gtk_window_set_default_size(GTK_WINDOW(fishlim_dialog), 520, 360);
-    g_signal_connect(fishlim_dialog, "response", G_CALLBACK(gtk_widget_destroy), NULL);
-    g_signal_connect(fishlim_dialog, "destroy", G_CALLBACK(fishlim_gui_destroy), NULL);
-
-    content = gtk_dialog_get_content_area(GTK_DIALOG(fishlim_dialog));
-    grid = gtk_grid_new();
-    gtk_grid_set_row_spacing(GTK_GRID(grid), 8);
-    gtk_grid_set_column_spacing(GTK_GRID(grid), 8);
-    gtk_container_set_border_width(GTK_CONTAINER(grid), 12);
-    gtk_box_pack_start(GTK_BOX(content), grid, TRUE, TRUE, 0);
-
-    fishlim_target_entry = gtk_entry_new();
-    if (target)
-        gtk_entry_set_text(GTK_ENTRY(fishlim_target_entry), target);
-    gtk_grid_attach(GTK_GRID(grid), gtk_label_new("Target nick or channel"), 0, 0, 1, 1);
-    gtk_grid_attach(GTK_GRID(grid), fishlim_target_entry, 1, 0, 2, 1);
-
-    fishlim_mode_combo = gtk_combo_box_text_new();
-    gtk_combo_box_text_append_text(GTK_COMBO_BOX_TEXT(fishlim_mode_combo), "ECB");
-    gtk_combo_box_text_append_text(GTK_COMBO_BOX_TEXT(fishlim_mode_combo), "CBC");
-    gtk_combo_box_set_active(GTK_COMBO_BOX(fishlim_mode_combo), 1);
-    gtk_grid_attach(GTK_GRID(grid), gtk_label_new("Mode"), 0, 1, 1, 1);
-    gtk_grid_attach(GTK_GRID(grid), fishlim_mode_combo, 1, 1, 2, 1);
-    gtk_grid_attach(GTK_GRID(grid), gtk_label_new("CBC may not work with older clients. Key exchange is private-message only."), 1, 2, 2, 1);
-
-    fishlim_key_entry = gtk_entry_new();
-    gtk_entry_set_visibility(GTK_ENTRY(fishlim_key_entry), FALSE);
-    gtk_grid_attach(GTK_GRID(grid), gtk_label_new("Key"), 0, 3, 1, 1);
-    gtk_grid_attach(GTK_GRID(grid), fishlim_key_entry, 1, 3, 2, 1);
-
-    buttons = gtk_button_box_new(GTK_ORIENTATION_HORIZONTAL);
-    gtk_button_box_set_layout(GTK_BUTTON_BOX(buttons), GTK_BUTTONBOX_END);
-    gtk_grid_attach(GTK_GRID(grid), buttons, 0, 4, 3, 1);
-
-    button = gtk_button_new_with_label("Set Key");
-    g_signal_connect(button, "clicked", G_CALLBACK(fishlim_gui_set), NULL);
-    gtk_container_add(GTK_CONTAINER(buttons), button);
-
-    button = gtk_button_new_with_label("Delete Key");
-    g_signal_connect(button, "clicked", G_CALLBACK(fishlim_gui_delete), NULL);
-    gtk_container_add(GTK_CONTAINER(buttons), button);
-
-    button = gtk_button_new_with_label("Private Message Key Exchange");
-    g_signal_connect(button, "clicked", G_CALLBACK(fishlim_gui_keyx), NULL);
-    gtk_container_add(GTK_CONTAINER(buttons), button);
-
-    fishlim_status_label = gtk_label_new(NULL);
-    gtk_label_set_xalign(GTK_LABEL(fishlim_status_label), 0.0);
-    gtk_grid_attach(GTK_GRID(grid), fishlim_status_label, 0, 5, 3, 1);
-
-    fishlim_store = gtk_list_store_new(3, G_TYPE_STRING, G_TYPE_STRING, G_TYPE_STRING);
-    view = gtk_tree_view_new_with_model(GTK_TREE_MODEL(fishlim_store));
-    fishlim_view = view;
-    renderer = gtk_cell_renderer_text_new();
-    gtk_tree_view_insert_column_with_attributes(GTK_TREE_VIEW(view), -1, "Target", renderer, "text", 0, NULL);
-    renderer = gtk_cell_renderer_text_new();
-    gtk_tree_view_insert_column_with_attributes(GTK_TREE_VIEW(view), -1, "Mode", renderer, "text", 1, NULL);
-    renderer = gtk_cell_renderer_text_new();
-    gtk_tree_view_insert_column_with_attributes(GTK_TREE_VIEW(view), -1, "Status", renderer, "text", 2, NULL);
-    g_signal_connect(view, "row-activated", G_CALLBACK(fishlim_gui_row_activated), NULL);
-
-    scroll = gtk_scrolled_window_new(NULL, NULL);
-    gtk_widget_set_vexpand(scroll, TRUE);
-    gtk_container_add(GTK_CONTAINER(scroll), view);
-    gtk_grid_attach(GTK_GRID(grid), scroll, 0, 6, 3, 1);
-
-    g_signal_connect(fishlim_target_entry, "changed", G_CALLBACK(fishlim_gui_refresh_cb), NULL);
-    fishlim_gui_refresh();
-
-    gtk_widget_show_all(fishlim_dialog);
-    return ZOITECHAT_EAT_ZOITECHAT;
-}
-
 /**
  * Command handler for /setkey
  */
@@ -806,8 +490,6 @@ static int handle_setkey(char *word[], char *word_eol[], void *userdata) {
     /* Set password */
     if (keystore_store_key(nick, key, mode)) {
         zoitechat_printf(ph, "Stored key for %s (%s)\n", nick, fish_modes[mode]);
-        if (mode == FISH_CBC_MODE)
-            zoitechat_printf(ph, "Warning: CBC may not work with older clients.\n");
     } else {
         zoitechat_printf(ph, "\00305Failed to store key in addon_fishlim.conf\n");
     }
@@ -851,18 +533,8 @@ static int handle_keyx(char *word[], char *word_eol[], void *userdata) {
     const char *target = word[2];
     zoitechat_context *query_ctx = NULL;
     char *pub_key, *priv_key;
-    enum fish_mode mode = FISH_CBC_MODE;
     int ctx_type;
 
-    if (*word[3]) {
-        if (g_ascii_strcasecmp(word[3], "ECB") == 0)
-            mode = FISH_ECB_MODE;
-        else if (g_ascii_strcasecmp(word[3], "CBC") != 0) {
-            zoitechat_printf(ph, "%s", usage_keyx);
-            return ZOITECHAT_EAT_ALL;
-        }
-    }
-
     if (*target)
         query_ctx = find_context_on_network(target);
     else {
@@ -876,21 +548,19 @@ static int handle_keyx(char *word[], char *word_eol[], void *userdata) {
     }
 
     if ((query_ctx && ctx_type != 3) || (!query_ctx && !irc_is_query(target))) {
-        zoitechat_printf(ph, "You can only exchange keys with individuals");
+        zoitechat_print(ph, "You can only exchange keys with individuals");
         return ZOITECHAT_EAT_ALL;
     }
 
     if (dh1080_generate_key(&priv_key, &pub_key)) {
         g_hash_table_replace (pending_exchanges, g_ascii_strdown(target, -1), priv_key);
 
-        zoitechat_commandf(ph, "quote NOTICE %s :DH1080_INIT %s%s", target, pub_key, (mode == FISH_CBC_MODE) ? " CBC" : "");
-        zoitechat_printf(ph, "Sent public key to %s (%s), waiting for reply...", target, fish_modes[mode]);
-        if (mode == FISH_CBC_MODE)
-            zoitechat_printf(ph, "Warning: CBC may not work with older clients.");
+        zoitechat_commandf(ph, "quote NOTICE %s :DH1080_INIT %s CBC", target, pub_key);
+        zoitechat_printf(ph, "Sent public key to %s (CBC), waiting for reply...", target);
 
         g_free(pub_key);
     } else {
-        zoitechat_printf(ph, "Failed to generate keys");
+        zoitechat_print(ph, "Failed to generate keys");
     }
 
     return ZOITECHAT_EAT_ALL;
@@ -907,7 +577,7 @@ static int handle_crypt_topic(char *word[], char *word_eol[], void *userdata) {
     GSList *encrypted_list;
 
     if (!*topic) {
-        zoitechat_printf(ph, "%s", usage_topic);
+        zoitechat_print(ph, usage_topic);
         return ZOITECHAT_EAT_ALL;
     }
 
@@ -954,7 +624,7 @@ static int handle_crypt_notice(char *word[], char *word_eol[], void *userdata) {
     GSList *encrypted_list, *encrypted_item;
 
     if (!*target || !*notice) {
-        zoitechat_printf(ph, "%s", usage_notice);
+        zoitechat_print(ph, usage_notice);
         return ZOITECHAT_EAT_ALL;
     }
 
@@ -1006,7 +676,7 @@ static int handle_crypt_msg(char *word[], char *word_eol[], void *userdata) {
     GSList *encrypted_list, *encrypted_item;
 
     if (!*target || !*message) {
-        zoitechat_printf(ph, "%s", usage_msg);
+        zoitechat_print(ph, usage_msg);
         return ZOITECHAT_EAT_ALL;
     }
 
@@ -1119,7 +789,6 @@ int zoitechat_plugin_init(zoitechat_plugin *plugin_handle,
     *version = plugin_version;
 
     /* Register commands */
-    zoitechat_hook_command(ph, "FISHLIM", ZOITECHAT_PRI_NORM, handle_fishlim, "Usage: FISHLIM, opens the FiSHLiM key manager", NULL);
     zoitechat_hook_command(ph, "SETKEY", ZOITECHAT_PRI_NORM, handle_setkey, usage_setkey, NULL);
     zoitechat_hook_command(ph, "DELKEY", ZOITECHAT_PRI_NORM, handle_delkey, usage_delkey, NULL);
     zoitechat_hook_command(ph, "KEYX", ZOITECHAT_PRI_NORM, handle_keyx, usage_keyx, NULL);
@@ -1136,31 +805,20 @@ int zoitechat_plugin_init(zoitechat_plugin *plugin_handle,
     zoitechat_hook_server_attrs(ph, "TOPIC", ZOITECHAT_PRI_NORM, handle_incoming, NULL);
     zoitechat_hook_server_attrs(ph, "332", ZOITECHAT_PRI_NORM, handle_incoming, NULL);
 
-    if (!fish_init()) {
-        zoitechat_printf(ph, "FiSHLiM failed to initialize crypto backend");
+    if (!fish_init())
         return 0;
-    }
 
-    if (!dh1080_init()) {
-        zoitechat_printf(ph, "FiSHLiM failed to initialize DH1080");
+    if (!dh1080_init())
         return 0;
-    }
 
     pending_exchanges = g_hash_table_new_full(g_str_hash, g_str_equal, g_free, g_free);
 
-    zoitechat_command(ph, "MENU ADD \"Window/FiSHLiM Key Manager\" \"FISHLIM\"");
-    zoitechat_command(ph, "MENU ADD \"$NICK/FiSHLiM Key Manager\" \"FISHLIM %s\"");
-
     zoitechat_printf(ph, "%s plugin loaded\n", plugin_name);
     /* Return success */
     return 1;
 }
 
 int zoitechat_plugin_deinit(void) {
-    zoitechat_command(ph, "MENU DEL \"Window/FiSHLiM Key Manager\"");
-    zoitechat_command(ph, "MENU DEL \"$NICK/FiSHLiM Key Manager\"");
-    if (fishlim_dialog)
-        gtk_widget_destroy(fishlim_dialog);
     g_clear_pointer(&pending_exchanges, g_hash_table_destroy);
     dh1080_deinit();
     fish_deinit();

plugins/lua/meson.build

@@ -1,19 +1,7 @@
 if cc.get_id() == 'msvc'
   lua_dep = cc.find_library('lua51')
 else
-  lua_opt = get_option('with-lua')
-  lua_dep = dependency(lua_opt, required: false)
-  if not lua_dep.found() and lua_opt == 'lua-5.4'
-    foreach lua_name : ['lua5.4', 'lua-5.3', 'lua5.3', 'lua']
-      lua_dep = dependency(lua_name, required: false)
-      if lua_dep.found()
-        break
-      endif
-    endforeach
-  endif
-  if not lua_dep.found()
-    error('Dependency "' + lua_opt + '" not found')
-  endif
+  lua_dep = dependency(get_option('with-lua'))
 endif
 
 shared_module('lua', 'lua.c',

plugins/meson.build

@@ -9,6 +9,9 @@ if host_machine.system() == 'windows'
     subdir('upd')
   endif
 
+  if get_option('with-winamp')
+    subdir('winamp')
+  endif
 endif
 
 if get_option('with-checksum')

plugins/perl/perl.c

@@ -1457,14 +1457,14 @@ perl_load_file (char *filename)
 									 "You must have a Visual C++ build of Perl "
 									 PERL_REQUIRED_VERSION " installed in order to\n"
 									 "run Perl scripts. A reboot may be required.\n\n"
-									 "http://zoitechat.org/downloads.html\n\n"
+									 "http://zoitechat.zoite.net/downloads.html\n\n"
 									 "I have found Perl 5.6, but that is too old.");
 				} else {
 					thread_mbox ("Cannot open " PERL_DLL "!\n\n"
 									 "You must have a Visual C++ build of Perl "
 									 PERL_REQUIRED_VERSION " installed in order to\n"
 									 "run Perl scripts. A reboot may be required.\n\n"
-									 "http://zoitechat.org/downloads.html\n\n"
+									 "http://zoitechat.zoite.net/downloads.html\n\n"
 									 "Make sure Perl's bin directory is in your PATH.");
 				}
 			}

plugins/python/generate_plugin.py

@@ -53,16 +53,6 @@ builder.set_source('_zoitechat_embedded', '''
 #include "config.h"
 #include "zoitechat-plugin.h"
 
-#ifdef _WIN32
-#ifndef WIN32_LEAN_AND_MEAN
-#define WIN32_LEAN_AND_MEAN
-#endif
-#ifndef NOMINMAX
-#define NOMINMAX
-#endif
-#include <windows.h>
-#endif
-
 static zoitechat_plugin *ph;
 CFFI_DLLEXPORT int _on_plugin_init(char **, char **, char **, char *, char *);
 CFFI_DLLEXPORT int _on_plugin_deinit(void);
@@ -71,20 +61,6 @@ int zoitechat_plugin_init(zoitechat_plugin *plugin_handle,
                         char **name_out, char **description_out,
                         char **version_out, char *arg)
 {
-#ifdef _WIN32
-    /* CPython cannot be removed from a process once Py_Initialize has run.
-       If the embedded interpreter fails to start (e.g. _cffi_backend is
-       missing), the host responds to our 0 return by g_module_close()ing
-       this plugin, which would also drop the last reference to pythonXY.dll
-       and unload it mid-flight; the leftover process-global state then
-       crashes the process later, e.g. when a server connection spawns the
-       next thread.  Pin this module so FreeLibrary can never unload it. */
-    HMODULE self_handle;
-    GetModuleHandleExW (GET_MODULE_HANDLE_EX_FLAG_PIN |
-                        GET_MODULE_HANDLE_EX_FLAG_FROM_ADDRESS,
-                        (LPCWSTR)&zoitechat_plugin_init, &self_handle);
-#endif
-
     if (ph != NULL)
     {
         puts ("Python plugin already loaded\\n");

plugins/python/python.py

@@ -19,7 +19,7 @@ else:
 if not hasattr(sys, 'argv'):
     sys.argv = ['<zoitechat>']
 
-VERSION = b'2.18.3'
+VERSION = b'2.18.0~pre5'
 PLUGIN_NAME = ffi.new('char[]', b'Python')
 PLUGIN_DESC = ffi.new('char[]', b'Python %d.%d scripting interface' % (sys.version_info[0], sys.version_info[1]))
 PLUGIN_VERSION = ffi.new('char[]', VERSION)
@@ -173,7 +173,7 @@ class Plugin:
 
     def __del__(self):
         log('unloading', self.filename)
-        for hook in list(self.hooks):
+        for hook in self.hooks:
             if hook.is_unload is True:
                 try:
                     hook.callback(hook.userdata)
@@ -320,9 +320,9 @@ def _on_say_command(word, word_eol, userdata):
         return 0
 
     try:
-        python = __decode(_cstr(word_eol[1]))
+        python = _cstr(word_eol[1])
     except Exception:
-        python = ''
+        python = b''
 
     if not python:
         return 1

plugins/python/python38.vcxproj

@@ -1,64 +0,0 @@
-<?xml version="1.0" encoding="utf-8"?>
-<Project DefaultTargets="Build" ToolsVersion="12.0" xmlns="http://schemas.microsoft.com/developer/msbuild/2003">
-  <PropertyGroup Label="Configuration">
-    <PlatformToolset>v142</PlatformToolset>
-    <ConfigurationType>DynamicLibrary</ConfigurationType>
-  </PropertyGroup>
-  <ItemGroup Label="ProjectConfigurations">
-    <ProjectConfiguration Include="Release|Win32">
-      <Configuration>Release</Configuration>
-      <Platform>Win32</Platform>
-    </ProjectConfiguration>
-    <ProjectConfiguration Include="Release|x64">
-      <Configuration>Release</Configuration>
-      <Platform>x64</Platform>
-    </ProjectConfiguration>
-  </ItemGroup>
-  <PropertyGroup Label="Globals">
-    <ProjectGuid>{D58924D2-1492-4AC3-B058-7A214424EEDC}</ProjectGuid>
-    <Keyword>Win32Proj</Keyword>
-    <RootNamespace>python38</RootNamespace>
-  </PropertyGroup>
-  <Import Project="$(VCTargetsPath)\Microsoft.Cpp.Default.props" />
-  <Import Project="$(VCTargetsPath)\Microsoft.Cpp.props" />
-  <Import Project="$(UserRootDir)\Microsoft.Cpp.$(Platform).user.props" Condition="exists('$(UserRootDir)\Microsoft.Cpp.$(Platform).user.props')" Label="LocalAppDataPlatform" />
-  <Import Project="..\..\win32\zoitechat.props" />
-  <PropertyGroup>
-    <TargetName>$(Python38Output)</TargetName>
-    <OutDir>$(ZoiteChatRel)plugins\</OutDir>
-  </PropertyGroup>
-   <ItemDefinitionGroup Condition="'$(Configuration)|$(Platform)'=='Release|x64'">
-    <ClCompile>
-      <PreprocessorDefinitions>WIN32;_WIN64;_AMD64_;NDEBUG;_WINDOWS;_USRDLL;PYTHON_EXPORTS;Py_NO_LINK_LIB;$(OwnFlags);%(PreprocessorDefinitions)</PreprocessorDefinitions>
-      <UndefinePreprocessorDefinitions>_DEBUG;Py_DEBUG;Py_REF_DEBUG;Py_TRACE_REFS;%(UndefinePreprocessorDefinitions)</UndefinePreprocessorDefinitions>
-      <AdditionalOptions>/U_DEBUG /UPy_DEBUG /UPy_REF_DEBUG /UPy_TRACE_REFS %(AdditionalOptions)</AdditionalOptions>
-      <RuntimeLibrary>MultiThreadedDLL</RuntimeLibrary>
-      <AdditionalIncludeDirectories>$(Glib);$(Python38Path)\include;..\..\src\common;$(ZoiteChatLib);%(AdditionalIncludeDirectories)</AdditionalIncludeDirectories>
-    </ClCompile>
-    <Link>
-      <ModuleDefinitionFile>python.def</ModuleDefinitionFile>
-      <AdditionalDependencies>"$(Python38Lib).lib";$(DepLibs);%(AdditionalDependencies)</AdditionalDependencies>
-      <AdditionalLibraryDirectories>$(DepsRoot)\lib;$(Python38Path)\libs;%(AdditionalLibraryDirectories)</AdditionalLibraryDirectories>
-    </Link>
-    <PreBuildEvent>
-      <Command>"$(Python38Path)\python.exe" generate_plugin.py ..\..\src\common\zoitechat-plugin.h python.py "$(IntDir)python.c"</Command>
-    </PreBuildEvent>
-  </ItemDefinitionGroup>
-  <ItemGroup>
-    <None Include="generate_plugin.py" />
-    <None Include="zoitechat.py" />
-    <None Include="python.def" />
-    <None Include="python.py" />
-    <None Include="xchat.py" />
-    <None Include="hexchat.py" />
-    <None Include="_zoitechat.py" />
-  </ItemGroup>
-  <ItemGroup>
-    <ClCompile Include="$(IntDir)python.c" />
-  </ItemGroup>
-  <Import Project="$(VCTargetsPath)\Microsoft.Cpp.targets" />
-</Project>
-
-
-
-

plugins/sysinfo/sysinfo.c

@@ -41,7 +41,7 @@ static zoitechat_plugin *ph;
 static char name[] = "Sysinfo";
 static char desc[] = "Display info about your hardware and OS";
 static char version[] = "1.0";
-static char sysinfo_help[] = "SysInfo Usage:\n  /SYSINFO [-e|-o] [CLIENT|UI|OS|CPU|RAM|STORAGE|GPU|CHIPSET|SOUND|ETHERNET|UPTIME], print various details about your system or print a summary without arguments\n  /SYSINFO SET <variable>\n";
+static char sysinfo_help[] = "SysInfo Usage:\n  /SYSINFO [-e|-o] [CLIENT|UI|OS|CPU|RAM|DISK|GPU|CHIPSET|SOUND|ETHERNET|UPTIME], print various details about your system or print a summary without arguments\n  /SYSINFO SET <variable>\n";
 
 typedef struct
 {
@@ -68,7 +68,7 @@ static hwinfo hwinfos[] = {
 	{"os", "OS", sysinfo_backend_get_os},
 	{"cpu", "CPU", sysinfo_backend_get_cpu},
 	{"memory", "Memory", sysinfo_backend_get_memory},
-	{"storage", "Storage", sysinfo_backend_get_disk, TRUE},
+	{"storage", "Storage", sysinfo_backend_get_disk},
 	{"gpu", "GPU", sysinfo_backend_get_gpu},
 	{"chipset", "CHIPSET", sysinfo_backend_get_chipset, TRUE},
 	{"sound", "Sound", sysinfo_backend_get_sound, TRUE},

plugins/upd/upd.c

@@ -24,7 +24,7 @@
 
 #include "zoitechat-plugin.h"
 
-#define APPCAST_URL "https://zoitechat.org/appcast.xml"
+#define APPCAST_URL "https://zoitechat.zoite.net/appcast.xml"
 
 static zoitechat_plugin *ph;
 static char name[] = "Update Checker";

plugins/winamp/meson.build

@@ -0,0 +1,7 @@
+shared_module('winamp', 'winamp.c',
+  dependencies: [libgio_dep, zoitechat_plugin_dep],
+  install: true,
+  install_dir: plugindir,
+  name_prefix: '',
+  vs_module_defs: 'winamp.def',
+)

plugins/winamp/winamp.c

@@ -0,0 +1,153 @@
+/********************* Winamp Plugin 0.3******************************
+ *
+ *   Distribution: GPL
+ *
+ *   Originally written by: Leo - leo.nard@free.fr
+ *   Modified by: SilvereX - SilvereX@karklas.mif.vu.lt
+ *   Modified again by: Derek Buitenhuis - daemon404@gmail.com
+ *   Modified yet again by: Berke Viktor - berkeviktor@aol.com
+ *********************************************************************/
+
+#include "windows.h"
+
+#include <stdio.h>
+#include <stdlib.h>
+#include <string.h>
+#include <glib.h>
+
+#include "zoitechat-plugin.h"
+
+#define PLAYING 1
+#define PAUSED 3
+
+static zoitechat_plugin *ph;
+
+static int
+winamp(char *word[], char *word_eol[], void *userdata)
+{
+	HWND hwndWinamp = FindWindowW(L"Winamp v1.x",NULL);
+
+	if (hwndWinamp)
+	{
+		if (!stricmp("PAUSE", word[2]))
+		{
+			if (SendMessage(hwndWinamp,WM_USER, 0, 104))
+			{
+				SendMessage(hwndWinamp, WM_COMMAND, 40046, 0);
+			
+				if (SendMessage(hwndWinamp, WM_USER, 0, 104) == PLAYING)
+					zoitechat_printf(ph, "Winamp: playing");
+				else
+					zoitechat_printf(ph, "Winamp: paused");
+			}
+		}
+		else if (!stricmp("STOP", word[2]))
+		{
+			SendMessage(hwndWinamp, WM_COMMAND, 40047, 0);
+			zoitechat_printf(ph, "Winamp: stopped");
+		}
+		else if (!stricmp("PLAY", word[2]))
+		{
+			SendMessage(hwndWinamp, WM_COMMAND, 40045, 0);
+			zoitechat_printf(ph, "Winamp: playing");
+		}
+		else if (!stricmp("NEXT", word[2]))
+		{
+			SendMessage(hwndWinamp, WM_COMMAND, 40048, 0);
+			zoitechat_printf(ph, "Winamp: next playlist entry");
+		}
+		else if (!stricmp("PREV", word[2]))
+		{
+			SendMessage(hwndWinamp, WM_COMMAND, 40044, 0);
+			zoitechat_printf(ph, "Winamp: previous playlist entry");
+		}
+		else if (!stricmp("START", word[2]))
+		{
+			SendMessage(hwndWinamp, WM_COMMAND, 40154, 0);
+			zoitechat_printf(ph, "Winamp: playlist start");
+		}
+		else if (!word_eol[2][0])
+		{
+			wchar_t wcurrent_play[2048];
+			char *current_play, *p;
+			int len = GetWindowTextW(hwndWinamp, wcurrent_play, G_N_ELEMENTS(wcurrent_play));
+
+			current_play = g_utf16_to_utf8 (wcurrent_play, len, NULL, NULL, NULL);
+			if (!current_play)
+			{
+				zoitechat_print (ph, "Winamp: Error getting song information.");
+				return ZOITECHAT_EAT_ALL;
+			}
+
+			if (strchr(current_play, '-'))
+			{
+				/* Remove any trailing text and whitespace */
+				p = current_play + strlen(current_play) - 8;
+				while (p >= current_play)
+				{
+					if (!strnicmp(p, "- Winamp", 8))
+						break;
+					p--;
+				}
+
+				if (p >= current_play)
+					p--;
+
+				while (p >= current_play && *p == ' ')
+					p--;
+				*++p = '\0';
+
+				/* Ignore any leading track number */
+				p = strstr (current_play, ". ");
+				if (p)
+					p += 2;
+				else
+					p = current_play;
+
+				if (*p != '\0')
+					zoitechat_commandf (ph, "me is now playing: %s", p);
+				else
+					zoitechat_print (ph, "Winamp: No song information found.");
+				g_free (current_play);
+			}
+			else
+				zoitechat_print(ph, "Winamp: Nothing being played.");
+		}
+		else
+			zoitechat_printf(ph, "Usage: /WINAMP [PAUSE|PLAY|STOP|NEXT|PREV|START]\n");
+	}
+	else
+	{
+		zoitechat_print(ph, "Winamp not found.\n");
+	}
+	return ZOITECHAT_EAT_ALL;
+}
+
+int
+zoitechat_plugin_init(zoitechat_plugin *plugin_handle,
+					  char **plugin_name,
+					  char **plugin_desc,
+					  char **plugin_version,
+					  char *arg)
+{
+	ph = plugin_handle;
+
+	*plugin_name = "Winamp";
+	*plugin_desc = "Winamp plugin for ZoiteChat";
+	*plugin_version = "0.6";
+
+	zoitechat_hook_command (ph, "WINAMP", ZOITECHAT_PRI_NORM, winamp, "Usage: /WINAMP [PAUSE|PLAY|STOP|NEXT|PREV|START] - control Winamp or show what's currently playing", 0);
+   	zoitechat_command (ph, "MENU -ishare\\music.png ADD \"Window/Display Current Song (Winamp)\" \"WINAMP\"");
+
+	zoitechat_print (ph, "Winamp plugin loaded\n");
+
+	return 1;
+}
+
+int
+zoitechat_plugin_deinit(void)
+{
+	zoitechat_command (ph, "MENU DEL \"Window/Display Current Song (Winamp)\"");
+	zoitechat_print (ph, "Winamp plugin unloaded\n");
+	return 1;
+}

plugins/winamp/winamp.def

@@ -0,0 +1,3 @@
+EXPORTS 
+zoitechat_plugin_init 
+zoitechat_plugin_deinit 

plugins/winamp/winamp.vcxproj

@@ -0,0 +1,48 @@
+<?xml version="1.0" encoding="utf-8"?>
+<Project DefaultTargets="Build" ToolsVersion="12.0" xmlns="http://schemas.microsoft.com/developer/msbuild/2003">
+  <PropertyGroup Label="Configuration">
+    <PlatformToolset>v142</PlatformToolset>
+    <ConfigurationType>DynamicLibrary</ConfigurationType>
+  </PropertyGroup>
+  <ItemGroup Label="ProjectConfigurations">
+    <ProjectConfiguration Include="Release|x64">
+      <Configuration>Release</Configuration>
+      <Platform>x64</Platform>
+    </ProjectConfiguration>
+  </ItemGroup>
+  <PropertyGroup Label="Globals">
+    <ProjectGuid>{E78C0D9A-798E-4BF6-B0CC-6FECB8CA2FCE}</ProjectGuid>
+    <Keyword>Win32Proj</Keyword>
+    <RootNamespace>winamp</RootNamespace>
+  </PropertyGroup>
+  <Import Project="$(VCTargetsPath)\Microsoft.Cpp.Default.props" />
+  <Import Project="$(VCTargetsPath)\Microsoft.Cpp.props" />
+  <Import Project="$(UserRootDir)\Microsoft.Cpp.$(Platform).user.props" Condition="exists('$(UserRootDir)\Microsoft.Cpp.$(Platform).user.props')" Label="LocalAppDataPlatform" />
+  <Import Project="..\..\win32\zoitechat.props" />
+  <PropertyGroup>
+    <TargetName>hcwinamp</TargetName>
+    <OutDir>$(ZoiteChatRel)plugins\</OutDir>
+  </PropertyGroup>
+  <ItemDefinitionGroup Condition="'$(Configuration)|$(Platform)'=='Release|x64'">
+    <ClCompile>
+      <PreprocessorDefinitions>WIN32;_WIN64;_AMD64_;NDEBUG;_WINDOWS;_USRDLL;WINAMP_EXPORTS;%(PreprocessorDefinitions)</PreprocessorDefinitions>
+    </ClCompile>
+  </ItemDefinitionGroup>
+  <ItemDefinitionGroup>
+    <ClCompile>
+      <AdditionalIncludeDirectories>$(DepsRoot)\include;$(OpenSslInclude);$(Glib);..\..\src\common;%(AdditionalIncludeDirectories)</AdditionalIncludeDirectories>
+    </ClCompile>
+    <Link>
+      <ModuleDefinitionFile>winamp.def</ModuleDefinitionFile>
+      <AdditionalDependencies>$(DepLibs);%(AdditionalDependencies)</AdditionalDependencies>
+      <AdditionalLibraryDirectories>$(DepsRoot)\lib;%(AdditionalLibraryDirectories)</AdditionalLibraryDirectories>
+    </Link>
+  </ItemDefinitionGroup>
+  <ItemGroup>
+    <None Include="winamp.def" />
+  </ItemGroup>
+  <ItemGroup>
+    <ClCompile Include="winamp.c" />
+  </ItemGroup>
+  <Import Project="$(VCTargetsPath)\Microsoft.Cpp.targets" />
+</Project>

plugins/winamp/winamp.vcxproj.filters

@@ -0,0 +1,23 @@
+<?xml version="1.0" encoding="utf-8"?>
+<Project ToolsVersion="4.0" xmlns="http://schemas.microsoft.com/developer/msbuild/2003">
+  <ItemGroup>
+    <Filter Include="Source Files">
+      <UniqueIdentifier>{4FC737F1-C7A5-4376-A066-2A32D752A2FF}</UniqueIdentifier>
+      <Extensions>cpp;c;cc;cxx;def;odl;idl;hpj;bat;asm;asmx</Extensions>
+    </Filter>
+    <Filter Include="Resource Files">
+      <UniqueIdentifier>{67DA6AB6-F800-4c08-8B7A-83BB121AAD01}</UniqueIdentifier>
+      <Extensions>rc;ico;cur;bmp;dlg;rc2;rct;bin;rgs;gif;jpg;jpeg;jpe;resx;tiff;tif;png;wav;mfcribbon-ms</Extensions>
+    </Filter>
+  </ItemGroup>
+  <ItemGroup>
+    <None Include="winamp.def">
+      <Filter>Resource Files</Filter>
+    </None>
+  </ItemGroup>
+  <ItemGroup>
+    <ClCompile Include="winamp.c">
+      <Filter>Source Files</Filter>
+    </ClCompile>
+  </ItemGroup>
+</Project>

readme.md

@@ -8,7 +8,7 @@
 
 [![Version][github-version-img]][github-version-uri] [![Downloads][github-downloads-img]][github-downloads-uri] [![Size][github-size-img]][github-size-img] [![Last Commit][github-commit-img]][github-commit-img] [![Contributors][contribs-all-img]](#contributors-)
 
-[![View Official Documentation](https://img.shields.io/badge/View_Official_Documentation-526CFE?style=for-the-badge&logo=MaterialForMkDocs&logoColor=white)](https://docs.zoitechat.org)
+[![View Official Documentation](https://img.shields.io/badge/View_Official_Documentation-526CFE?style=for-the-badge&logo=MaterialForMkDocs&logoColor=white)](https://docs.zoitechat.zoite.net)
 
   </div>
 
@@ -31,19 +31,12 @@
 <br />
 
 
-ZoiteChat is a GTK3 IRC client based on HexChat, available for Windows and UNIX-like operating systems.  
-
-Features include HexChat-compatible Python, Perl and Lua scripting support, a plugin API,
-multiple server/channel windows, spell checking, multiple authentication methods including SASL,
-and customizable notifications.
-
+ZoiteChat is an HexChat based IRC client for Windows and UNIX-like operating systems.  
 See [IRCHelp.org](http://irchelp.org) for information about IRC in general.  
+For more information on ZoiteChat please read our [documentation](https://docs.zoitechat.zoite.net/):
+- [Downloads](https://zoitechat.zoite.net/download)
 
-For more information on ZoiteChat:
-
-- [Main Documentation](https://docs.zoitechat.org/) and [FAQ](https://docs.zoitechat.org/en/latest/faq.html)
-
-- [Downloads](https://zoitechat.org/download.php)
+- [Troubleshooting](troubleshooting.md)
 
 
 ---

src/common/cfgfiles.c

@@ -428,7 +428,6 @@ const struct prefs vars[] =
 	{"gui_lagometer", P_OFFINT (hex_gui_lagometer), TYPE_INT},
 	{"gui_lang", P_OFFINT (hex_gui_lang), TYPE_INT},
 	{"gui_mode_buttons", P_OFFINT (hex_gui_mode_buttons), TYPE_BOOL},
-	{"gui_mode_buttons_inline", P_OFFINT (hex_gui_mode_buttons_inline), TYPE_BOOL},
 	{"gui_pane_divider_position", P_OFFINT (hex_gui_pane_divider_position), TYPE_INT},
 	{"gui_pane_left_size", P_OFFINT (hex_gui_pane_left_size), TYPE_INT},
 	{"gui_pane_right_size", P_OFFINT (hex_gui_pane_right_size), TYPE_INT},
@@ -446,9 +445,7 @@ const struct prefs vars[] =
 	{"gui_dark_mode", P_OFFINT (hex_gui_dark_mode), TYPE_INT},
 	{"gui_gtk3_variant", P_OFFINT (hex_gui_gtk3_variant), TYPE_INT},
 	{"gui_tab_layout", P_OFFINT (hex_gui_tab_layout), TYPE_INT},
-	{"gui_tab_closebuttons", P_OFFINT (hex_gui_tab_closebuttons), TYPE_BOOL},
 	{"gui_tab_middleclose", P_OFFINT (hex_gui_tab_middleclose), TYPE_BOOL},
-	{"gui_mouse_scroll_speed", P_OFFINT (hex_gui_mouse_scroll_speed), TYPE_INT},
 	{"gui_tab_newtofront", P_OFFINT (hex_gui_tab_newtofront), TYPE_INT},
 	{"gui_tab_pos", P_OFFINT (hex_gui_tab_pos), TYPE_INT},
 	{"gui_tab_scrollchans", P_OFFINT (hex_gui_tab_scrollchans), TYPE_BOOL},
@@ -459,7 +456,6 @@ const struct prefs vars[] =
 	{"gui_tab_utils", P_OFFINT (hex_gui_tab_utils), TYPE_BOOL},
 	{"gui_throttlemeter", P_OFFINT (hex_gui_throttlemeter), TYPE_INT},
 	{"gui_topicbar", P_OFFINT (hex_gui_topicbar), TYPE_BOOL},
-	{"gui_topicbar_multiline", P_OFFINT (hex_gui_topicbar_multiline), TYPE_BOOL},
 	{"gui_transparency", P_OFFINT (hex_gui_transparency), TYPE_INT},
 	{"gui_tray", P_OFFINT (hex_gui_tray), TYPE_BOOL},
 	{"gui_tray_away", P_OFFINT (hex_gui_tray_away), TYPE_BOOL},
@@ -520,7 +516,6 @@ const struct prefs vars[] =
 	{"irc_conf_mode", P_OFFINT (hex_irc_conf_mode), TYPE_BOOL},
 	{"irc_extra_hilight", P_OFFSET (hex_irc_extra_hilight), TYPE_STR},
 	{"irc_hide_nickchange", P_OFFINT (hex_irc_hide_nickchange), TYPE_BOOL},
-	{"irc_hide_join_part_hostmask", P_OFFINT (hex_irc_hide_join_part_hostmask), TYPE_BOOL},
 	{"irc_hide_version", P_OFFINT (hex_irc_hide_version), TYPE_BOOL},
 	{"irc_hidehost", P_OFFINT (hex_irc_hidehost), TYPE_BOOL},
 	{"irc_id_ntext", P_OFFSET (hex_irc_id_ntext), TYPE_STR},
@@ -552,10 +547,6 @@ const struct prefs vars[] =
 #endif
 	{"net_bind_host", P_OFFSET (hex_net_bind_host), TYPE_STR},
 	{"net_ping_timeout", P_OFFINT (hex_net_ping_timeout), TYPE_INT, zoitechat_reinit_timers},
-	{"net_lag_check", P_OFFINT (hex_net_lag_check), TYPE_INT, zoitechat_reinit_timers},
-	{"net_keepalive_idle", P_OFFINT (hex_net_keepalive_idle), TYPE_INT},
-	{"net_keepalive_interval", P_OFFINT (hex_net_keepalive_interval), TYPE_INT},
-	{"net_keepalive_count", P_OFFINT (hex_net_keepalive_count), TYPE_INT},
 	{"net_proxy_auth", P_OFFINT (hex_net_proxy_auth), TYPE_BOOL},
 	{"net_proxy_host", P_OFFSET (hex_net_proxy_host), TYPE_STR},
 	{"net_proxy_pass", P_OFFSET (hex_net_proxy_pass), TYPE_STR},
@@ -786,18 +777,13 @@ load_default_config(void)
 	prefs.hex_gui_tab_chans = 1;
 	prefs.hex_gui_tab_dialogs = 1;
 	prefs.hex_gui_tab_icons = 1;
-	prefs.hex_gui_tab_closebuttons = 1;
 	prefs.hex_gui_tab_middleclose = 1;
 	prefs.hex_gui_tab_server = 1;
 	prefs.hex_gui_tab_sort = 1;
-	prefs.hex_gui_tab_scrollchans = 1;
-	prefs.hex_gui_mouse_scroll_speed = 10;
 	prefs.hex_gui_topicbar = 1;
-	prefs.hex_gui_topicbar_multiline = 1;
 	prefs.hex_gui_transparency = 255;
 	prefs.hex_gui_tray = 1;
 	prefs.hex_gui_tray_blink = 1;
-	prefs.hex_gui_ulist_color = 1;
 	prefs.hex_gui_ulist_count = 1;
 	prefs.hex_gui_ulist_icons = 1;
 	prefs.hex_gui_ulist_style = 1;
@@ -868,10 +854,6 @@ load_default_config(void)
 	prefs.hex_irc_ban_type = 1;
 	prefs.hex_irc_join_delay = 5;
 	prefs.hex_net_ping_timeout = 60;
-	prefs.hex_net_lag_check = 60;
-	prefs.hex_net_keepalive_idle = 60;
-	prefs.hex_net_keepalive_interval = 20;
-	prefs.hex_net_keepalive_count = 3;
 	prefs.hex_net_reconnect_delay = 10;
 	prefs.hex_notify_timeout = 15;
 	prefs.hex_text_max_indent = 256;
@@ -1182,10 +1164,7 @@ set_showval (session *sess, const struct prefs *var, char *tbuf)
 	switch (var->type)
 	{
 		case TYPE_STR:
-		{
-			const char *value = (char *) &prefs + var->offset;
-			sprintf (tbuf + len, "\0033:\017 %s\n", value ? value : "");
-		}
+			sprintf (tbuf + len, "\0033:\017 %s\n", (char *) &prefs + var->offset);
 			break;
 		case TYPE_INT:
 			sprintf (tbuf + len, "\0033:\017 %d\n", *((int *) &prefs + var->offset));

src/common/common.vcxproj

@@ -29,10 +29,8 @@
     <ClInclude Include="plugin-timer.h" />
     <ClInclude Include="plugin.h" />
     <ClInclude Include="proto-irc.h" />
-    <ClInclude Include="public_suffix_data.h" />
     <ClInclude Include="server.h" />
     <ClInclude Include="servlist.h" />
-    <ClInclude Include="secretstore.h" />
     <ClInclude Include="ssl.h" />
     <ClInclude Include="scram.h" />
     <ClInclude Include="sysinfo\sysinfo.h" />
@@ -69,7 +67,6 @@
     <ClCompile Include="proto-irc.c" />
     <ClCompile Include="server.c" />
     <ClCompile Include="servlist.c" />
-    <ClCompile Include="secretstore.c" />
     <ClCompile Include="ssl.c" />
     <ClCompile Include="scram.c" />
     <ClCompile Include="sts.c" />
@@ -112,7 +109,6 @@
       <Command><![CDATA[
 SET SOLUTIONDIR=$(SolutionDir)..\
 "$(Python3Path)\python.exe" $(ProjectDir)make-te.py "$(ProjectDir)textevents.in" "$(ZoiteChatLib)textevents.h" "$(ZoiteChatLib)textenums.h"
-"$(Python3Path)\python.exe" $(ProjectDir)gen-public-suffix.py "$(ZoiteChatLib)public_suffix_data.h"
 powershell -File "$(SolutionDir)..\win32\version-template.ps1" "$(SolutionDir)..\win32\config.h.tt" "$(ZoiteChatLib)config.h"
 $(GlibGenMarshal) --prefix=_zoitechat_marshal --header "$(ProjectDir)marshalers.list" --output "$(ZoiteChatLib)marshal.h"
 $(GlibGenMarshal) --prefix=_zoitechat_marshal --body "$(ProjectDir)marshalers.list" --output "$(ZoiteChatLib)marshal.c"

src/common/common.vcxproj.filters

@@ -65,18 +65,12 @@
     <ClInclude Include="proto-irc.h">
       <Filter>Header Files</Filter>
     </ClInclude>
-    <ClInclude Include="public_suffix_data.h">
-      <Filter>Header Files</Filter>
-    </ClInclude>
     <ClInclude Include="server.h">
       <Filter>Header Files</Filter>
     </ClInclude>
     <ClInclude Include="servlist.h">
       <Filter>Header Files</Filter>
     </ClInclude>
-    <ClInclude Include="secretstore.h">
-      <Filter>Header Files</Filter>
-    </ClInclude>
     <ClInclude Include="ssl.h">
       <Filter>Header Files</Filter>
     </ClInclude>
@@ -181,9 +175,6 @@
     <ClCompile Include="servlist.c">
       <Filter>Source Files</Filter>
     </ClCompile>
-    <ClCompile Include="secretstore.c">
-      <Filter>Source Files</Filter>
-    </ClCompile>
     <ClCompile Include="ssl.c">
       <Filter>Source Files</Filter>
     </ClCompile>

src/common/dbus/dbus-client.c

@@ -82,6 +82,10 @@ has_theme_argument (void)
 
 void
 zoitechat_remote (void)
+/* TODO: dbus_g_connection_unref (connection) are commented because it makes
+ * dbus to crash. Fixed in dbus >=0.70 ?!?
+ * https://launchpad.net/distros/ubuntu/+source/dbus/+bug/54375
+ */
 {
 	GDBusConnection *connection;
 	GDBusProxy *dbus = NULL;

src/common/dbus/example.c

@@ -1,122 +1,203 @@
-#include <gio/gio.h>
-#include <glib.h>
+/* example.c - program to demonstrate some D-BUS stuffs.
+ * Copyright (C) 2006 Claessens Xavier
+ *
+ * This program is free software; you can redistribute it and/or modify
+ * it under the terms of the GNU General Public License as published by
+ * the Free Software Foundation; either version 2 of the License, or
+ * (at your option) any later version.
+ *
+ * This program is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+ * GNU General Public License for more details.
+ *
+ * You should have received a copy of the GNU General Public License
+ * along with this program; if not, write to the Free Software
+ * Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301, USA
+ *
+ * Claessens Xavier
+ * xclaesse@gmail.com
+ */
+
+#include <config.h>
+#include <dbus/dbus-glib.h>
 #include <stdlib.h>
+#include "../marshal.c"
 
 #define DBUS_SERVICE "org.zoitechat.service"
-#define DBUS_CONNECTION_PATH "/org/zoitechat"
-#define DBUS_CONNECTION_INTERFACE "org.zoitechat.connection"
-#define DBUS_PLUGIN_INTERFACE "org.zoitechat.plugin"
+#define DBUS_REMOTE "/org/zoitechat/Remote"
+#define DBUS_REMOTE_CONNECTION_INTERFACE "org.zoitechat.connection"
+#define DBUS_REMOTE_PLUGIN_INTERFACE "org.zoitechat.plugin"
 
-static gboolean
-call_sync (GDBusProxy *proxy, const char *method, GVariant *params, GVariant **out)
-{
-	GError *error = NULL;
-	GVariant *result;
+guint command_id;
+guint server_id;
 
-	result = g_dbus_proxy_call_sync (proxy,
-		method,
-		params,
-		G_DBUS_CALL_FLAGS_NONE,
-		-1,
-		NULL,
-		&error);
-	if (!result)
+static void
+write_error (const char *message,
+	     GError **error)
 {
-		g_printerr ("%s failed: %s\n", method, error->message);
-		g_clear_error (&error);
-		return FALSE;
+	if (error == NULL || *error == NULL) {
+		return;
+	}
+	g_printerr ("%s: %s\n", message, (*error)->message);
+	g_clear_error (error);
 }
 
-	if (out)
-		*out = result;
-	else
-		g_variant_unref (result);
+static void
+test_server_cb (DBusGProxy *proxy,
+		char *word[],
+		char *word_eol[],
+		guint hook_id,
+		guint context_id,
+		gpointer user_data)
+{
+	if (hook_id == server_id) {
+		g_print ("message: %s\n", word_eol[0]);
+	}
+}
 
-	return TRUE;
+static void
+test_command_cb (DBusGProxy *proxy,
+		 char *word[],
+		 char *word_eol[],
+		 guint hook_id,
+		 guint context_id,
+		 gpointer user_data)
+{
+	GError *error = NULL;
+
+	if (hook_id == command_id) {
+		if (!dbus_g_proxy_call (proxy, "Unhook",
+					&error,
+					G_TYPE_UINT, hook_id,
+					G_TYPE_INVALID, G_TYPE_INVALID)) {
+			write_error ("Failed to complete unhook", &error);
+		}
+		/* Now if you write "/test blah" again in the ZoiteChat window
+		 * you'll get a "Unknown command" error message */
+		g_print ("test command received: %s\n", word_eol[1]);
+		if (!dbus_g_proxy_call (proxy, "Print",
+					&error,
+					G_TYPE_STRING, "test command succeed",
+					G_TYPE_INVALID,
+					G_TYPE_INVALID)) {
+			write_error ("Failed to complete Print", &error);
+		}
+	}
+}
+
+static void
+unload_cb (void)
+{
+	g_print ("Good bye !\n");
+	exit (EXIT_SUCCESS);
 }
 
 int
 main (int argc, char **argv)
 {
-	GDBusConnection *connection;
-	GDBusProxy *connection_proxy;
-	GDBusProxy *plugin_proxy;
-	GVariant *connect_result = NULL;
-	gchar *remote_path = NULL;
-	gchar *command = NULL;
-	const char *path_tmp;
-	int status = EXIT_FAILURE;
+	DBusGConnection *connection;
+	DBusGProxy *remote_object;
+	GMainLoop *mainloop;
+	gchar *path;
 	GError *error = NULL;
 
-	connection = g_bus_get_sync (G_BUS_TYPE_SESSION, NULL, &error);
-	if (!connection)
-	{
-		g_printerr ("Bus connection failed: %s\n", error->message);
-		g_clear_error (&error);
+#if ! GLIB_CHECK_VERSION (2, 36, 0)
+	g_type_init ();
+#endif
+
+	connection = dbus_g_bus_get (DBUS_BUS_SESSION, &error);
+	if (connection == NULL) {
+		write_error ("Couldn't connect to session bus", &error);
 		return EXIT_FAILURE;
 	}
   
-	connection_proxy = g_dbus_proxy_new_sync (connection,
-		G_DBUS_PROXY_FLAGS_NONE,
-		NULL,
+	remote_object = dbus_g_proxy_new_for_name (connection,
 						   DBUS_SERVICE,
-		DBUS_CONNECTION_PATH,
-		DBUS_CONNECTION_INTERFACE,
-		NULL,
-		&error);
-	if (!connection_proxy)
-	{
-		g_printerr ("Connection proxy failed: %s\n", error->message);
-		g_clear_error (&error);
-		g_object_unref (connection);
+						   DBUS_REMOTE,
+						   DBUS_REMOTE_CONNECTION_INTERFACE);
+	if (!dbus_g_proxy_call (remote_object, "Connect",
+				&error,
+				G_TYPE_STRING, argv[0],
+				G_TYPE_STRING, "example",
+				G_TYPE_STRING, "Example of a D-Bus client",
+				G_TYPE_STRING, "1.0",
+				G_TYPE_INVALID,
+				G_TYPE_STRING, &path, G_TYPE_INVALID)) {
+		write_error ("Failed to complete Connect", &error);
 		return EXIT_FAILURE;
 	}
+	g_object_unref (remote_object);
 
-	if (!call_sync (connection_proxy,
-		"Connect",
-		g_variant_new ("(ssss)", "example", "example", "GDBus example", "1.0"),
-		&connect_result))
-		goto cleanup;
-
-	g_variant_get (connect_result, "(&s)", &path_tmp);
-	remote_path = g_strdup (path_tmp);
-	g_variant_unref (connect_result);
-	connect_result = NULL;
-
-	plugin_proxy = g_dbus_proxy_new_sync (connection,
-		G_DBUS_PROXY_FLAGS_NONE,
-		NULL,
+	remote_object = dbus_g_proxy_new_for_name (connection,
 						   DBUS_SERVICE,
-		remote_path,
-		DBUS_PLUGIN_INTERFACE,
-		NULL,
-		&error);
-	if (!plugin_proxy)
-	{
-		g_printerr ("Plugin proxy failed: %s\n", error->message);
-		g_clear_error (&error);
-		goto cleanup;
+						   path,
+						   DBUS_REMOTE_PLUGIN_INTERFACE);
+	g_free (path);
+
+	if (!dbus_g_proxy_call (remote_object, "HookCommand",
+				&error,
+				G_TYPE_STRING, "test",
+				G_TYPE_INT, 0,
+				G_TYPE_STRING, "Simple D-BUS example",
+				G_TYPE_INT, 1, G_TYPE_INVALID,
+				G_TYPE_UINT, &command_id, G_TYPE_INVALID)) {
+		write_error ("Failed to complete HookCommand", &error);
+		return EXIT_FAILURE;
 	}
+	g_print ("Command hook id=%d\n", command_id);
 
-	if (argc > 1)
-		command = g_strjoinv (" ", &argv[1]);
-	else
-		command = g_strdup ("gui focus");
-
-	if (!call_sync (plugin_proxy, "Command", g_variant_new ("(s)", command), NULL))
-	{
-		g_object_unref (plugin_proxy);
-		goto cleanup;
+	if (!dbus_g_proxy_call (remote_object, "HookServer",
+				&error,
+				G_TYPE_STRING, "RAW LINE",
+				G_TYPE_INT, 0,
+				G_TYPE_INT, 0, G_TYPE_INVALID,
+				G_TYPE_UINT, &server_id, G_TYPE_INVALID)) {
+		write_error ("Failed to complete HookServer", &error);
+		return EXIT_FAILURE;
 	}
+	g_print ("Server hook id=%d\n", server_id);
 
-	call_sync (connection_proxy, "Disconnect", g_variant_new ("()"), NULL);
-	status = EXIT_SUCCESS;
-	g_object_unref (plugin_proxy);
+	dbus_g_object_register_marshaller (
+		_zoitechat_marshal_VOID__POINTER_POINTER_UINT_UINT,
+		G_TYPE_NONE,
+		G_TYPE_STRV, G_TYPE_STRV, G_TYPE_UINT, G_TYPE_UINT,
+		G_TYPE_INVALID);
 
-cleanup:
-	g_free (command);
-	g_free (remote_path);
-	g_object_unref (connection_proxy);
-	g_object_unref (connection);
-	return status;
+	dbus_g_object_register_marshaller (
+		g_cclosure_marshal_VOID__VOID,
+		G_TYPE_NONE,
+		G_TYPE_INVALID);
+
+	dbus_g_proxy_add_signal (remote_object, "CommandSignal",
+				 G_TYPE_STRV,
+				 G_TYPE_STRV,
+				 G_TYPE_UINT,
+				 G_TYPE_UINT,
+				 G_TYPE_INVALID);
+	dbus_g_proxy_connect_signal (remote_object, "CommandSignal",
+				     G_CALLBACK (test_command_cb),
+				     NULL, NULL);
+
+	dbus_g_proxy_add_signal (remote_object, "ServerSignal",
+				 G_TYPE_STRV,
+				 G_TYPE_STRV,
+				 G_TYPE_UINT,
+				 G_TYPE_UINT,
+				 G_TYPE_INVALID);
+	dbus_g_proxy_connect_signal (remote_object, "ServerSignal",
+				     G_CALLBACK (test_server_cb),
+				     NULL, NULL);
+
+	dbus_g_proxy_add_signal (remote_object, "UnloadSignal",
+				 G_TYPE_INVALID);
+	dbus_g_proxy_connect_signal (remote_object, "UnloadSignal",
+				     G_CALLBACK (unload_cb),
+				     NULL, NULL);
+
+	/* Now you can write on the ZoiteChat windows: "/test arg1 arg2 ..." */
+	mainloop = g_main_loop_new (NULL, FALSE);
+	g_main_loop_run (mainloop);
+
+	return EXIT_SUCCESS;
 }

src/common/dbus/meson.build

@@ -1,4 +1,6 @@
-dbus_deps = []
+dbus_deps = [
+  dbus_glib_dep
+]
 
 dbus_sources = [
   'dbus-plugin.c',
@@ -33,8 +35,16 @@ configure_file(
   install_dir: dbus_service_dir
 )
 
+dbus_binding_tool = find_program('dbus-binding-tool')
+dbus_remote_object = custom_target('remote-object-glue',
+  input: 'remote-object.xml',
+  output: 'remote-object-glue.h',
+  command: [dbus_binding_tool, '--prefix=remote_object', '--mode=glib-server',
+            '--output=@OUTPUT@', '@INPUT@']
+)
+
 zoitechat_dbus = static_library('zoitechatdbus',
-  sources: marshal + dbus_sources,
+  sources: [dbus_remote_object, marshal] + dbus_sources,
   c_args: dbus_cargs,
   dependencies: common_deps + dbus_deps,
   include_directories: dbus_includes,

src/common/dcc.c

@@ -304,24 +304,29 @@ dcc_check_timeouts (void)
 static int
 dcc_lookup_proxy (char *host, struct sockaddr_in *addr)
 {
+	struct hostent *h;
 	static char *cache_host = NULL;
 	static guint32 cache_addr;
 
+	/* too lazy to thread this, so we cache results */
 	if (cache_host)
 	{
 		if (strcmp (host, cache_host) == 0)
 		{
-			addr->sin_addr.s_addr = cache_addr;
+			memcpy (&addr->sin_addr, &cache_addr, 4);
 			return TRUE;
 		}
 		g_free (cache_host);
 		cache_host = NULL;
 	}
 
-	if (net_lookup_ipv4 (host, &addr->sin_addr.s_addr))
+	h = gethostbyname (host);
+	if (h != NULL && h->h_length == 4 && h->h_addr_list[0] != NULL)
 	{
-		cache_addr = addr->sin_addr.s_addr;
+		memcpy (&addr->sin_addr, h->h_addr_list[0], 4);
+		memcpy (&cache_addr, h->h_addr_list[0], 4);
 		cache_host = g_strdup (host);
+		/* cppcheck-suppress memleak */
 		return TRUE;
 	}
 
@@ -1609,14 +1614,25 @@ dcc_accept (GIOChannel *source, GIOCondition condition, struct DCC *dcc)
 }
 
 guint32
-dcc_get_my_address (session *sess)
+dcc_get_my_address (session *sess)	/* the address we'll tell the other person */
 {
+	struct hostent *dns_query;
 	guint32 addr = 0;
 
 	if (prefs.hex_dcc_ip_from_server && sess->server->dcc_ip)
 		addr = sess->server->dcc_ip;
 	else if (prefs.hex_dcc_ip[0])
-		net_lookup_ipv4 ((const char *) prefs.hex_dcc_ip, &addr);
+	{
+	   dns_query = gethostbyname ((const char *) prefs.hex_dcc_ip);
+
+	   if (dns_query != NULL &&
+	       dns_query->h_length == 4 &&
+	       dns_query->h_addr_list[0] != NULL)
+		{
+			/*we're offered at least one IPv4 address: we take the first*/
+			addr = *((guint32*) dns_query->h_addr_list[0]);
+		}
+	}
 
 	return addr;
 }

src/common/fe.h

@@ -78,7 +78,6 @@ int fe_input_add (int sok, int flags, void *func, void *data);
 void fe_input_remove (int tag);
 void fe_idle_add (void *func, void *data);
 void fe_set_topic (struct session *sess, char *topic, char *stripped_topic);
-void fe_set_typing (struct session *sess, const char *nick, const char *state);
 typedef enum
 {
 	FE_COLOR_NONE = 0,
@@ -142,7 +141,6 @@ void fe_set_away (server *serv);
 void fe_serverlist_open (session *sess);
 void fe_get_bool (char *title, char *prompt, void *callback, void *userdata);
 void fe_get_str (char *prompt, char *def, void *callback, void *ud);
-void fe_get_password (char *prompt, void *callback, void *ud);
 void fe_get_int (char *prompt, int def, void *callback, void *ud);
 #define FRF_WRITE 1				/* save file */
 #define FRF_MULTIPLE 2			/* multi-select */

src/common/gen-public-suffix.py

@@ -1,71 +0,0 @@
-#!/usr/bin/env python3
-import sys
-import urllib.request
-from pathlib import Path
-
-URLS = (
-    "https://raw.githubusercontent.com/publicsuffix/list/main/public_suffix_list.dat",
-    "https://publicsuffix.org/list/public_suffix_list.dat",
-)
-
-
-def parse_rules(text: str):
-    rules = []
-    for raw in text.splitlines():
-        line = raw.strip()
-        if not line or line.startswith("//"):
-            continue
-        if " " in line or "\t" in line:
-            line = line.split()[0]
-        rules.append(line.lower())
-    return sorted(set(rules))
-
-
-def emit_header(path: str, rules):
-    with open(path, "w", encoding="utf-8", newline="\n") as out:
-        out.write("#pragma once\n")
-        out.write("static const char * const public_suffix_rules[] = {\n")
-        for rule in rules:
-            escaped = rule.replace("\\", "\\\\").replace('"', '\\"')
-            out.write(f'\t"{escaped}",\n')
-        out.write("};\n")
-        out.write(
-            "static const unsigned int public_suffix_rules_len = sizeof(public_suffix_rules) / sizeof(public_suffix_rules[0]);\n"
-        )
-
-
-def main():
-    if len(sys.argv) not in (2, 3):
-        raise SystemExit("usage: gen-public-suffix.py <output> [source]")
-    output = Path(sys.argv[1])
-    sources = []
-    if len(sys.argv) == 3:
-        sources.append(Path(sys.argv[2]))
-    sources.extend(
-        [
-            Path(__file__).with_name("public_suffix_list.dat"),
-            Path("/usr/share/publicsuffix/public_suffix_list.dat"),
-            Path("/app/share/publicsuffix/public_suffix_list.dat"),
-        ]
-    )
-    data = None
-    for url in URLS:
-        try:
-            with urllib.request.urlopen(url, timeout=30) as resp:
-                data = resp.read().decode("utf-8")
-            break
-        except Exception:
-            pass
-    if data is None:
-        for source in sources:
-            if source.exists():
-                data = source.read_text(encoding="utf-8")
-                break
-    if data is None:
-        raise SystemExit("unable to load public suffix list")
-    rules = parse_rules(data)
-    emit_header(str(output), rules)
-
-
-if __name__ == "__main__":
-    main()

src/common/gtk3-theme-service.c

@@ -315,59 +315,6 @@ resolve_parent_theme_root (const char *child_theme_root, const char *parent_name
 		return home_local;
 	g_free (home_local);
 
-	{
-		const char *xdg_data_home = g_getenv ("XDG_DATA_HOME");
-
-		if (xdg_data_home && xdg_data_home[0])
-		{
-			candidate = g_build_filename (xdg_data_home, "themes", parent_name, NULL);
-			if (path_exists_as_dir (candidate))
-				return candidate;
-			g_free (candidate);
-		}
-	}
-
-	candidate = g_build_filename (g_get_user_data_dir (), "themes", parent_name, NULL);
-	if (path_exists_as_dir (candidate))
-		return candidate;
-	g_free (candidate);
-
-	{
-		const char *xdg_data_dirs = g_getenv ("XDG_DATA_DIRS");
-		guint i;
-
-		if (xdg_data_dirs && xdg_data_dirs[0])
-		{
-			char **data_dirs = g_strsplit (xdg_data_dirs, G_SEARCHPATH_SEPARATOR_S, -1);
-
-			for (i = 0; data_dirs && data_dirs[i]; i++)
-			{
-				if (!data_dirs[i][0])
-					continue;
-				candidate = g_build_filename (data_dirs[i], "themes", parent_name, NULL);
-				if (path_exists_as_dir (candidate))
-				{
-					g_strfreev (data_dirs);
-					return candidate;
-				}
-				g_free (candidate);
-			}
-			g_strfreev (data_dirs);
-		}
-		else
-		{
-			const char *const *system_data_dirs = g_get_system_data_dirs ();
-
-			for (i = 0; system_data_dirs && system_data_dirs[i]; i++)
-			{
-				candidate = g_build_filename (system_data_dirs[i], "themes", parent_name, NULL);
-				if (path_exists_as_dir (candidate))
-					return candidate;
-				g_free (candidate);
-			}
-		}
-	}
-
 	user_dir = zoitechat_gtk3_theme_service_get_user_themes_dir ();
 	candidate = g_build_filename (user_dir, parent_name, NULL);
 	g_free (user_dir);
@@ -685,47 +632,12 @@ zoitechat_gtk3_theme_service_discover (void)
 
 	g_mkdir_with_parents (user_dir, 0700);
 
-	/* Prefer the live XDG environment over GLib's process-cached copies so
-	 * theme lookup matches what GTK resolves for the running session. */
-	{
-		const char *xdg_data_home = g_getenv ("XDG_DATA_HOME");
-
-		if (xdg_data_home && xdg_data_home[0])
-			user_data_themes = g_build_filename (xdg_data_home, "themes", NULL);
-		else
 	user_data_themes = g_build_filename (g_get_user_data_dir (), "themes", NULL);
-	}
-	/* Scan the app's own themes dir first: imported themes get a symlink
-	 * under the XDG data themes dir so GTK can resolve gtk-theme-name, and
-	 * scanning that link first would make the canonical-root dedup keep
-	 * the symlink path - changing the theme's path-derived id and breaking
-	 * the saved gui_gtk3_theme reference on the next start. */
-	add_theme_root (user_roots, seen_user_roots, user_dir);
 	add_theme_root (user_roots, seen_user_roots, user_data_themes);
 	g_free (user_data_themes);
 	add_theme_root (user_roots, seen_user_roots, home_themes);
+	add_theme_root (user_roots, seen_user_roots, user_dir);
 
-	{
-		const char *xdg_data_dirs = g_getenv ("XDG_DATA_DIRS");
-
-		if (xdg_data_dirs && xdg_data_dirs[0])
-		{
-			char **data_dirs = g_strsplit (xdg_data_dirs, G_SEARCHPATH_SEPARATOR_S, -1);
-
-			for (i = 0; data_dirs && data_dirs[i]; i++)
-			{
-				char *system_themes;
-
-				if (!data_dirs[i][0])
-					continue;
-				system_themes = g_build_filename (data_dirs[i], "themes", NULL);
-				add_theme_root (system_roots, seen_system_roots, system_themes);
-				g_free (system_themes);
-			}
-			g_strfreev (data_dirs);
-		}
-		else
-		{
 	system_data_dirs = g_get_system_data_dirs ();
 	for (i = 0; system_data_dirs && system_data_dirs[i]; i++)
 	{
@@ -733,8 +645,6 @@ zoitechat_gtk3_theme_service_discover (void)
 		add_theme_root (system_roots, seen_system_roots, system_themes);
 		g_free (system_themes);
 	}
-		}
-	}
 
 	for (i = 0; i < system_roots->len; i++)
 		discover_dir (themes, seen_theme_roots, g_ptr_array_index (system_roots, i), ZOITECHAT_GTK3_THEME_SOURCE_SYSTEM);
@@ -1012,7 +922,7 @@ static gboolean
 validate_theme_root_for_import (const char *theme_root, GError **error)
 {
 	char *index_theme;
-	GKeyFile *keyfile = NULL;
+	GKeyFile *keyfile;
 	char *css_dir;
 	char *css_path;
 	char *raw_inherits;
@@ -1020,12 +930,16 @@ validate_theme_root_for_import (const char *theme_root, GError **error)
 	guint i;
 	GError *load_error = NULL;
 
-	/* index.theme is optional for GTK3 CSS themes (GTK only needs
-	 * gtk-3.x/gtk.css), but when it is present it must be well formed so
-	 * broken archives are rejected up front. */
 	index_theme = g_build_filename (theme_root, "index.theme", NULL);
-	if (g_file_test (index_theme, G_FILE_TEST_IS_REGULAR))
+	if (!g_file_test (index_theme, G_FILE_TEST_IS_REGULAR))
 	{
+		g_set_error (error, G_FILE_ERROR, G_FILE_ERROR_INVAL,
+					 "Invalid GTK3 theme at '%s': missing required index.theme at '%s'.",
+			   theme_root, index_theme);
+		g_free (index_theme);
+		return FALSE;
+	}
+
 	keyfile = g_key_file_new ();
 	if (!g_key_file_load_from_file (keyfile, index_theme, G_KEY_FILE_NONE, &load_error))
 	{
@@ -1047,7 +961,6 @@ validate_theme_root_for_import (const char *theme_root, GError **error)
 		g_free (index_theme);
 		return FALSE;
 	}
-	}
 
 	css_dir = zoitechat_gtk3_theme_pick_css_dir (theme_root);
 	if (!css_dir)
@@ -1055,7 +968,6 @@ validate_theme_root_for_import (const char *theme_root, GError **error)
 		g_set_error (error, G_FILE_ERROR, G_FILE_ERROR_INVAL,
 					 "Invalid GTK3 theme at '%s': could not resolve a GTK CSS directory (expected gtk-3.x/gtk.css).",
 					 theme_root);
-		if (keyfile)
 		g_key_file_unref (keyfile);
 		g_free (index_theme);
 		return FALSE;
@@ -1069,7 +981,6 @@ validate_theme_root_for_import (const char *theme_root, GError **error)
 			   theme_root, css_path);
 		g_free (css_path);
 		g_free (css_dir);
-		if (keyfile)
 		g_key_file_unref (keyfile);
 		g_free (index_theme);
 		return FALSE;
@@ -1077,12 +988,8 @@ validate_theme_root_for_import (const char *theme_root, GError **error)
 	g_free (css_path);
 	g_free (css_dir);
 
-	raw_inherits = NULL;
-	if (keyfile)
-	{
 	raw_inherits = g_key_file_get_string (keyfile, "Desktop Entry", "Inherits", NULL);
 	g_key_file_unref (keyfile);
-	}
 	g_free (index_theme);
 	if (!raw_inherits)
 		return TRUE;
@@ -1314,94 +1221,6 @@ extract_archive (const char *source, GError **error)
 	#endif
 }
 
-static char *
-path_find_first_file_recursive (const char *root, const char *name, int depth)
-{
-	GDir *dir;
-	const char *entry;
-
-	if (!root || !name || depth < 0 || !g_file_test (root, G_FILE_TEST_IS_DIR))
-		return NULL;
-
-	{
-		char *candidate = g_build_filename (root, name, NULL);
-		if (g_file_test (candidate, G_FILE_TEST_IS_REGULAR))
-			return candidate;
-		g_free (candidate);
-	}
-
-	if (depth == 0)
-		return NULL;
-
-	dir = g_dir_open (root, 0, NULL);
-	if (!dir)
-		return NULL;
-
-	while ((entry = g_dir_read_name (dir)) != NULL)
-	{
-		char *child = g_build_filename (root, entry, NULL);
-		char *found = NULL;
-
-		if (g_file_test (child, G_FILE_TEST_IS_DIR))
-			found = path_find_first_file_recursive (child, name, depth - 1);
-		g_free (child);
-		if (found)
-		{
-			g_dir_close (dir);
-			return found;
-		}
-	}
-
-	g_dir_close (dir);
-	return NULL;
-}
-
-gboolean
-zoitechat_gtk3_theme_service_read_archive_text_file (const char *archive_path, const char *name, char **contents, GError **error)
-{
-	char *root;
-	char *path;
-	gboolean ok;
-	GError *local_error = NULL;
-
-	if (contents)
-		*contents = NULL;
-	if (!archive_path || !*archive_path)
-		return g_set_error_literal (error, G_FILE_ERROR, G_FILE_ERROR_INVAL, "No archive path provided."), FALSE;
-	if (!name || !*name)
-		return g_set_error_literal (error, G_FILE_ERROR, G_FILE_ERROR_INVAL, "No file name provided."), FALSE;
-	if (!contents)
-		return g_set_error_literal (error, G_FILE_ERROR, G_FILE_ERROR_INVAL, "No output buffer provided."), FALSE;
-
-	root = extract_archive (archive_path, error);
-	if (!root)
-		return FALSE;
-
-	path = path_find_first_file_recursive (root, name, 8);
-	if (!path)
-	{
-		remove_tree (root);
-		g_free (root);
-		return g_set_error_literal (error, G_FILE_ERROR, G_FILE_ERROR_NOENT, "Requested file was not found in archive."), FALSE;
-	}
-
-	ok = g_file_get_contents (path, contents, NULL, &local_error);
-	g_free (path);
-	remove_tree (root);
-	g_free (root);
-
-	if (!ok)
-	{
-		if (error)
-			*error = local_error;
-		else
-			g_clear_error (&local_error);
-		return FALSE;
-	}
-
-	return TRUE;
-}
-
 gboolean
 zoitechat_gtk3_theme_service_import (const char *source_path, char **imported_id, GError **error)
 {

src/common/gtk3-theme-service.h

@@ -48,6 +48,5 @@ gboolean zoitechat_gtk3_theme_service_remove_user_theme (const char *theme_id, G
 char *zoitechat_gtk3_theme_pick_css_dir_for_minor (const char *theme_root, int preferred_minor);
 char *zoitechat_gtk3_theme_pick_css_dir (const char *theme_root);
 GPtrArray *zoitechat_gtk3_theme_build_inheritance_chain (const char *theme_root);
-gboolean zoitechat_gtk3_theme_service_read_archive_text_file (const char *archive_path, const char *name, char **contents, GError **error);
 
 #endif

src/common/inbound.c

@@ -38,7 +38,6 @@
 #include "ignore.h"
 #include "fe.h"
 #include "modes.h"
-#include "network.h"
 #include "notify.h"
 #include "outbound.h"
 #include "inbound.h"
@@ -46,155 +45,6 @@
 #include "servlist.h"
 #include "sts.h"
 #include "text.h"
-
-void reply_state_clear (session *sess);
-
-gboolean
-reply_msgid_valid (const char *msgid)
-{
-	const char *p;
-
-	if (!msgid || !*msgid || *msgid == ':')
-		return FALSE;
-
-	for (p = msgid; *p; p++)
-	{
-		if (*p == ' ' || *p == '\r' || *p == '\n')
-			return FALSE;
-	}
-
-	return TRUE;
-}
-
-static void
-reply_item_free (reply_item *item)
-{
-	if (!item)
-		return;
-	g_free (item->msgid);
-	g_free (item->nick);
-	g_free (item->text);
-	g_free (item);
-}
-
-void
-reply_cache_free (session *sess)
-{
-	if (!sess)
-		return;
-	g_slist_free_full (sess->reply_items, (GDestroyNotify) reply_item_free);
-	sess->reply_items = NULL;
-	reply_state_clear (sess);
-}
-
-reply_item *
-reply_cache_find (session *sess, const char *msgid)
-{
-	GSList *list;
-
-	if (!sess || !reply_msgid_valid (msgid))
-		return NULL;
-
-	for (list = sess->reply_items; list; list = list->next)
-	{
-		reply_item *item = list->data;
-		if (!strcmp (item->msgid, msgid))
-			return item;
-	}
-
-	return NULL;
-}
-
-reply_item *
-reply_cache_latest_from (session *sess, const char *nick)
-{
-	GSList *list;
-
-	if (!sess || !nick || !*nick)
-		return NULL;
-
-	for (list = sess->reply_items; list; list = list->next)
-	{
-		reply_item *item = list->data;
-		if (!sess->server->p_cmp (item->nick, nick))
-			return item;
-	}
-
-	return NULL;
-}
-
-void
-reply_state_clear (session *sess)
-{
-	if (!sess)
-		return;
-	g_clear_pointer (&sess->reply_msgid, g_free);
-	g_clear_pointer (&sess->reply_target, g_free);
-	g_clear_pointer (&sess->reply_nick, g_free);
-	g_clear_pointer (&sess->reply_text, g_free);
-}
-
-void
-reply_state_set (session *sess, const char *msgid, const char *target, const char *nick, const char *text)
-{
-	if (!sess || !reply_msgid_valid (msgid))
-		return;
-	reply_state_clear (sess);
-	sess->reply_msgid = g_strdup (msgid);
-	sess->reply_target = g_strdup (target && *target ? target : sess->channel);
-	sess->reply_nick = g_strdup (nick && *nick ? nick : _("message"));
-	sess->reply_text = g_strdup (text && *text ? text : _("Original message unavailable"));
-}
-
-static void
-reply_cache_add (session *sess, const char *msgid, const char *nick, const char *text, time_t timestamp)
-{
-	reply_item *item;
-
-	if (!sess || !reply_msgid_valid (msgid) || !nick || !text)
-		return;
-
-	item = reply_cache_find (sess, msgid);
-	if (item)
-	{
-		g_free (item->nick);
-		g_free (item->text);
-		item->nick = g_strdup (nick);
-		item->text = g_strdup (text);
-		item->timestamp = timestamp;
-		return;
-	}
-
-	item = g_new0 (reply_item, 1);
-	item->msgid = g_strdup (msgid);
-	item->nick = g_strdup (nick);
-	item->text = g_strdup (text);
-	item->timestamp = timestamp;
-	sess->reply_items = g_slist_prepend (sess->reply_items, item);
-
-	if (g_slist_length (sess->reply_items) > 200)
-	{
-		GSList *last = g_slist_last (sess->reply_items);
-		item = last->data;
-		sess->reply_items = g_slist_delete_link (sess->reply_items, last);
-		reply_item_free (item);
-	}
-}
-
-static void
-reply_context_print (session *sess, const message_tags_data *tags_data)
-{
-	reply_item *item;
-
-	if (!sess || !tags_data || !tags_data->reply)
-		return;
-
-	item = reply_cache_find (sess, tags_data->reply);
-	if (item)
-		PrintTextTimeStampf (sess, tags_data->timestamp, "\00314│ ↪ %s: %.180s\017\n", item->nick, item->text);
-	else
-		PrintTextTimeStamp (sess, "\00314│ ↪ Original message unavailable\017\n", tags_data->timestamp);
-}
 #include "ctcp.h"
 #include "zoitechatc.h"
 #include "chanopt.h"
@@ -599,9 +449,6 @@ inbound_action (session *sess, char *chan, char *from, char *ip, char *text,
 			fromme = TRUE;
 	}
 
-	if (!fromme)
-		fe_set_typing (sess, from, "done");
-
 	inbound_make_idtext (serv, idtext, sizeof (idtext), id);
 
 	if (!fromme && !privaction)
@@ -670,17 +517,12 @@ inbound_chanmsg (server *serv, session *sess, char *chan, char *from,
 			fromme = TRUE;
 	}
 
-	if (!fromme)
-		fe_set_typing (sess, from, "done");
-
 	if (fromme)
 	{
 		if (prefs.hex_away_auto_unmark && serv->is_away && !tags_data->timestamp)
 			sess->server->p_set_back (sess->server);
-		reply_context_print (sess, tags_data);
 		EMIT_SIGNAL_TIMESTAMP (XP_TE_UCHANMSG, sess, from, text, nickchar, NULL,
 									  0, tags_data->timestamp);
-		reply_cache_add (sess, tags_data->msgid, from, text, tags_data->timestamp);
 		return;
 	}
 
@@ -689,8 +531,6 @@ inbound_chanmsg (server *serv, session *sess, char *chan, char *from,
 	if (is_hilight (from, text, sess, serv))
 		hilight = TRUE;
 
-	reply_context_print (sess, tags_data);
-
 	if (sess->type == SESS_DIALOG)
 		EMIT_SIGNAL_TIMESTAMP (XP_TE_DPRIVMSG, sess, from, text, idtext, NULL, 0,
 									  tags_data->timestamp);
@@ -700,8 +540,6 @@ inbound_chanmsg (server *serv, session *sess, char *chan, char *from,
 	else
 		EMIT_SIGNAL_TIMESTAMP (XP_TE_CHANMSG, sess, from, text, nickchar, idtext,
 									  0, tags_data->timestamp);
-
-	reply_cache_add (sess, tags_data->msgid, from, text, tags_data->timestamp);
 }
 
 void
@@ -1638,13 +1476,14 @@ inbound_uback (server *serv, const message_tags_data *tags_data)
 void
 inbound_foundip (session *sess, char *ip, const message_tags_data *tags_data)
 {
-	struct in_addr addr;
+	struct hostent *HostAddr;
 
-	if (net_lookup_ipv4 (ip, &addr.s_addr))
+	HostAddr = gethostbyname (ip);
+	if (HostAddr)
 	{
-		sess->server->dcc_ip = addr.s_addr;
+		sess->server->dcc_ip = ((struct in_addr *) HostAddr->h_addr_list[0])->s_addr;
 		EMIT_SIGNAL_TIMESTAMP (XP_TE_FOUNDIP, sess->server->server_session,
-									  net_ip (ntohl (addr.s_addr)),
+									  inet_ntoa (*((struct in_addr *) HostAddr->h_addr_list[0])),
 									  NULL, NULL, NULL, 0, tags_data->timestamp);
 	}
 }
@@ -1815,14 +1654,14 @@ inbound_login_end (session *sess, char *text, const message_tags_data *tags_data
 			return;
 
 		/* send nickserv password */
-		if (net && serv->password[0] && inbound_nickserv_login (serv))
+		if (net && net->pass && inbound_nickserv_login (serv))
 		{
-			serv->p_ns_identify (serv, serv->password);
+			serv->p_ns_identify (serv, net->pass);
 		}
 
 		/* wait for join if command or nickserv set */
 		if (net && prefs.hex_irc_join_delay
-			&& ((serv->password[0] && inbound_nickserv_login (serv))
+			&& ((net->pass && inbound_nickserv_login (serv))
 				|| net->commandlist))
 		{
 			serv->joindelay_tag = fe_timeout_add_seconds (prefs.hex_irc_join_delay, check_autojoin_channels, serv);
@@ -1903,10 +1742,6 @@ inbound_toggle_caps (server *serv, const char *extensions_str, gboolean enable)
 			serv->have_awaynotify = enable;
 		else if (!strcmp (extension, "account-tag"))
 			serv->have_account_tag = enable;
-		else if (!strcmp (extension, "message-tags"))
-			serv->have_message_tags = enable;
-		else if (!strcmp (extension, "echo-message"))
-			serv->have_echo_message = enable;
 		else if (!strcmp (extension, "sasl"))
 		{
 			serv->have_sasl = enable;
@@ -2038,8 +1873,6 @@ static const char * const supported_caps[] = {
 	"account-tag",
 	"extended-monitor",
 	"standard-replies",
-	"message-tags",
-	"echo-message",
 
 	/* ZNC */
 	"znc.in/server-time-iso",

src/common/inbound.h

@@ -78,13 +78,6 @@ void inbound_login_end (session *sess, char *text,
 void inbound_chanmsg (server *serv, session *sess, char *chan, char *from,
 							 char *text, char fromme, int id, 
 							 const message_tags_data *tags_data);
-gboolean reply_msgid_valid (const char *msgid);
-void reply_cache_free (session *sess);
-reply_item *reply_cache_find (session *sess, const char *msgid);
-reply_item *reply_cache_latest_from (session *sess, const char *nick);
-void reply_state_set (session *sess, const char *msgid, const char *target,
-							 const char *nick, const char *text);
-void reply_state_clear (session *sess);
 void clear_channel (session *sess);
 void set_topic (session *sess, char *topic, char *stripped_topic);
 void inbound_privmsg (server *serv, char *from, char *ip, char *text, int id, 

src/common/meson.build

@@ -27,8 +27,6 @@ common_sources = [
   'util.c'
 ]
 
-secretstore_sources = files('secretstore.c')
-
 common_sysinfo_deps = []
 libarchive_dep = dependency('libarchive', required: host_machine.system() != 'windows')
 
@@ -40,9 +38,6 @@ common_deps = [
 if libarchive_dep.found()
   common_deps += libarchive_dep
 endif
-if libsecret_dep.found()
-  common_deps += libsecret_dep
-endif
 
 common_includes = [
   config_h_include,
@@ -101,14 +96,6 @@ marshal = [
 
 make_te = find_program('make-te.py')
 
-
-python3 = find_program('python3', required: true)
-
-public_suffix_data = custom_target('public_suffix_data_h',
-  output: 'public_suffix_data.h',
-  command: [python3, files('gen-public-suffix.py'), '@OUTPUT@']
-)
-
 textevents = custom_target('textevents',
   input: 'textevents.in',
   output: ['textevents.h', 'textenums.h'],
@@ -120,7 +107,7 @@ if libssl_dep.found()
   common_deps += libssl_dep
 endif
 
-if dbus_dep.found()
+if dbus_glib_dep.found()
   subdir('dbus')
   common_deps += zoitechat_dbus_dep
   common_includes += include_directories('dbus')
@@ -132,7 +119,7 @@ if get_option('plugin')
 endif
 
 zoitechat_common = static_library('zoitechatcommon',
-  sources: [textevents, public_suffix_data] + marshal + common_sources + secretstore_sources,
+  sources: [textevents] + marshal + common_sources,
   include_directories: config_h_include,
   dependencies: common_deps + common_sysinfo_deps,
   c_args: common_cflags,
@@ -140,7 +127,7 @@ zoitechat_common = static_library('zoitechatcommon',
 )
 
 zoitechat_common_dep = declare_dependency(
-  sources: [textevents, public_suffix_data] + marshal,
+  sources: [textevents] + marshal,
   link_with: zoitechat_common,
   include_directories: common_includes,
   compile_args: common_cflags,

src/common/modes.c

@@ -907,10 +907,6 @@ inbound_005 (server * serv, char *word[], const message_tags_data *tags_data)
 		{
 			if (g_strcmp0 (tokvalue, "ascii") == 0)
 				serv->p_cmp = (void *)g_ascii_strcasecmp;
-		} else if (g_strcmp0 (tokname, "CLIENTTAGDENY") == 0)
-		{
-			g_free (serv->clienttagdeny);
-			serv->clienttagdeny = tokadding ? g_strdup (tokvalue) : NULL;
 		} else if (g_strcmp0 (tokname, "CHARSET") == 0)
 		{
 			if (g_ascii_strcasecmp (tokvalue, "UTF-8") == 0)

src/common/network.c

@@ -34,9 +34,6 @@
 
 #ifndef WIN32
 #include <unistd.h>
-#ifdef HAVE_NETINET_TCP_H
-#include <netinet/tcp.h>
-#endif
 #endif
 
 #define WANTSOCKET
@@ -46,9 +43,6 @@
 
 #define NETWORK_PRIVATE
 #include "network.h"
-#include "zoitechat.h"
-
-extern struct zoitechatprefs prefs;
 
 #define RAND_INT(n) ((int)(rand() / (RAND_MAX + 1.0) * (n)))
 
@@ -64,76 +58,15 @@ net_set_socket_options (int sok)
 	setsockopt (sok, SOL_SOCKET, SO_REUSEADDR, (char *) &sw, sizeof (sw));
 	sw = 1;
 	setsockopt (sok, SOL_SOCKET, SO_KEEPALIVE, (char *) &sw, sizeof (sw));
-#ifdef TCP_KEEPIDLE
-	{
-		int keepidle = prefs.hex_net_keepalive_idle;
-		if (keepidle > 0)
-			setsockopt (sok, IPPROTO_TCP, TCP_KEEPIDLE, (char *) &keepidle, sizeof (keepidle));
-	}
-#endif
-#ifdef TCP_KEEPINTVL
-	{
-		int keepintvl = prefs.hex_net_keepalive_interval;
-		if (keepintvl > 0)
-			setsockopt (sok, IPPROTO_TCP, TCP_KEEPINTVL, (char *) &keepintvl, sizeof (keepintvl));
-	}
-#endif
-#ifdef TCP_KEEPCNT
-	{
-		int keepcnt = prefs.hex_net_keepalive_count;
-		if (keepcnt > 0)
-			setsockopt (sok, IPPROTO_TCP, TCP_KEEPCNT, (char *) &keepcnt, sizeof (keepcnt));
-	}
-#endif
 }
 
 char *
 net_ip (uint32_t addr)
 {
-	static char buf[INET_ADDRSTRLEN];
 	struct in_addr ia;
 
 	ia.s_addr = htonl (addr);
-	if (!inet_ntop (AF_INET, &ia, buf, sizeof (buf)))
-		buf[0] = 0;
-
-	return buf;
-}
-
-int
-net_parse_ipv4 (const char *hostname, uint32_t *addr)
-{
-	struct in_addr ia;
-
-	if (inet_pton (AF_INET, hostname, &ia) != 1)
-		return FALSE;
-
-	*addr = ia.s_addr;
-	return TRUE;
-}
-
-int
-net_lookup_ipv4 (const char *hostname, uint32_t *addr)
-{
-	struct addrinfo hints;
-	struct addrinfo *res;
-	struct sockaddr_in *sin;
-	int ret;
-
-	memset (&hints, 0, sizeof (hints));
-	hints.ai_family = AF_INET;
-	hints.ai_socktype = SOCK_STREAM;
-	hints.ai_flags = AI_ADDRCONFIG;
-
-	ret = getaddrinfo (hostname, NULL, &hints, &res);
-	if (ret != 0)
-		return FALSE;
-
-	sin = (struct sockaddr_in *) res->ai_addr;
-	*addr = sin->sin_addr.s_addr;
-	freeaddrinfo (res);
-
-	return TRUE;
+	return inet_ntoa (ia);
 }
 
 void

src/common/network.h

@@ -39,8 +39,6 @@ int net_connect (netstore *ns, int sok4, int sok6, int *sok_return);
 char *net_resolve (netstore *ns, char *hostname, int port, char **real_host);
 void net_bind (netstore *tobindto, int sok4, int sok6);
 char *net_ip (uint32_t addr);
-int net_parse_ipv4 (const char *hostname, uint32_t *addr);
-int net_lookup_ipv4 (const char *hostname, uint32_t *addr);
 void net_sockets (int *sok4, int *sok6);
 
 #endif

src/common/outbound.c

@@ -468,7 +468,7 @@ create_mask (session * sess, char *mask, char *mode, char *typestr, int deop)
 			type = prefs.hex_irc_ban_type;
 
 		buf[0] = 0;
-		if (net_parse_ipv4 (fullhost, &(guint32){0}))	/* "fullhost" is really a IP number */
+		if (inet_addr (fullhost) != (guint32) -1)	/* "fullhost" is really a IP number */
 		{
 			lastdot = strrchr (fullhost, '.');
 			if (!lastdot)
@@ -2744,7 +2744,7 @@ cmd_me (struct session *sess, char *tbuf, char *word[], char *word_eol[])
 			while ((split_text = split_up_text (sess, act + offset, cmd_length, split_text)))
 			{
 				sess->server->p_action (sess->server, sess->channel, split_text);
-				if (!sess->server->have_echo_message)
+				/* print it to screen */
 				inbound_action (sess, sess->channel, sess->server->nick, "",
 									 split_text, TRUE, FALSE,
 									 &no_tags);
@@ -2756,7 +2756,7 @@ cmd_me (struct session *sess, char *tbuf, char *word[], char *word_eol[])
 			}
 
 			sess->server->p_action (sess->server, sess->channel, act + offset);
-			if (!sess->server->have_echo_message)
+			/* print it to screen */
 			inbound_action (sess, sess->channel, sess->server->nick, "",
 								 act + offset, TRUE, FALSE, &no_tags);
 		} else
@@ -2821,137 +2821,6 @@ cmd_mop (struct session *sess, char *tbuf, char *word[], char *word_eol[])
 	return TRUE;
 }
 
-
-static gboolean
-client_tag_allowed (server *serv, const char *tag)
-{
-	char **deny;
-	int i;
-
-	if (!serv->have_message_tags)
-		return FALSE;
-
-	if (!serv->clienttagdeny || !*serv->clienttagdeny)
-		return TRUE;
-
-	deny = g_strsplit (serv->clienttagdeny, ",", 0);
-	for (i = 0; deny[i]; i++)
-	{
-		if (!strcmp (deny[i], "*") || !strcmp (deny[i], tag) || (deny[i][0] == '+' && !strcmp (deny[i] + 1, tag)))
-		{
-			g_strfreev (deny);
-			return FALSE;
-		}
-	}
-
-	g_strfreev (deny);
-	return TRUE;
-}
-
-static char *
-client_tag_escape (const char *text)
-{
-	GString *out;
-	const char *p;
-
-	out = g_string_sized_new (strlen (text));
-	for (p = text; *p; p++)
-	{
-		switch (*p)
-		{
-		case ';':
-			g_string_append (out, "\\:");
-			break;
-		case ' ':
-			g_string_append (out, "\\s");
-			break;
-		case '\\':
-			g_string_append (out, "\\\\");
-			break;
-		case '\r':
-			g_string_append (out, "\\r");
-			break;
-		case '\n':
-			g_string_append (out, "\\n");
-			break;
-		default:
-			g_string_append_c (out, *p);
-			break;
-		}
-	}
-
-	return g_string_free (out, FALSE);
-}
-
-static int
-cmd_reply (struct session *sess, char *tbuf, char *word[], char *word_eol[])
-{
-	char *msgid = word[2];
-	char *target = sess->channel;
-	char *text = word_eol[3];
-	char *escaped;
-	char *tags;
-
-	if (!reply_msgid_valid (msgid) || !*target || !*text)
-		return FALSE;
-
-	if (*text == ':')
-		text++;
-
-	if (!sess->server->connected || !client_tag_allowed (sess->server, "reply"))
-	{
-		notc_msg (sess);
-		return TRUE;
-	}
-
-	escaped = client_tag_escape (msgid);
-	tags = g_strdup_printf ("+reply=%s", escaped);
-	sess->server->p_message_tagged (sess->server, tags, target, text);
-	if (!sess->server->have_echo_message)
-	{
-		session *target_sess = find_dialog (sess->server, target);
-		message_tags_data no_tags = MESSAGE_TAGS_DATA_INIT;
-		no_tags.reply = msgid;
-
-		if (!target_sess)
-			target_sess = find_channel (sess->server, target);
-		if (target_sess)
-			inbound_chanmsg (target_sess->server, target_sess, target_sess->channel, target_sess->server->nick, text, TRUE, FALSE, &no_tags);
-	}
-	g_free (tags);
-	g_free (escaped);
-
-	return TRUE;
-}
-
-static int
-cmd_typing (struct session *sess, char *tbuf, char *word[], char *word_eol[])
-{
-	char *state = word[2];
-	char *target = word[3];
-	char tags[32];
-
-	if (!*state)
-		state = "active";
-
-	if (!*target)
-		target = sess->channel;
-
-	if (!*target || (strcmp (state, "active") && strcmp (state, "paused") && strcmp (state, "done")))
-		return FALSE;
-
-	if (!sess->server->connected || !client_tag_allowed (sess->server, "typing"))
-	{
-		notc_msg (sess);
-		return TRUE;
-	}
-
-	g_snprintf (tags, sizeof (tags), "+typing=%s", state);
-	sess->server->p_tagmsg (sess->server, tags, target);
-
-	return TRUE;
-}
-
 static int
 cmd_msg (struct session *sess, char *tbuf, char *word[], char *word_eol[])
 {
@@ -3006,7 +2875,7 @@ cmd_msg (struct session *sess, char *tbuf, char *word[], char *word_eol[])
 			newsess = find_dialog (sess->server, nick);
 			if (!newsess)
 				newsess = find_channel (sess->server, nick);
-			if (newsess && !sess->server->have_echo_message)
+			if (newsess)
 			{
 				message_tags_data no_tags = MESSAGE_TAGS_DATA_INIT;
 
@@ -3593,45 +3462,28 @@ cmd_server (struct session *sess, char *tbuf, char *word[], char *word_eol[])
 	int use_ssl = FALSE;
 #endif
 	int is_url = TRUE;
-	int no_proxy = FALSE;
 	server *serv = sess->server;
 	ircnet *net = NULL;
 
-	while (TRUE)
-	{
 #ifdef USE_OPENSSL
-		if (g_strcmp0 (word[2 + offset], "-ssl") == 0 || g_strcmp0 (word[2 + offset], "-e") == 0)
+	/* BitchX uses -ssl, mIRC uses -e, let's support both */
+	if (g_strcmp0 (word[2], "-ssl") == 0 || g_strcmp0 (word[2], "-e") == 0)
 	{
 		use_ssl = TRUE;
-			use_ssl_noverify = FALSE;
-			offset++;
+		offset++;	/* args move up by 1 word */
 	}
-		else if (g_strcmp0 (word[2 + offset], "-ssl-noverify") == 0)
+	else if (g_strcmp0 (word[2], "-ssl-noverify") == 0)
 	{
 		use_ssl = TRUE;
 		use_ssl_noverify = TRUE;
-			offset++;
+		offset++;	/* args move up by 1 word */
 	}
-		else if (g_strcmp0 (word[2 + offset], "-insecure") == 0)
+	else if (g_strcmp0 (word[2], "-insecure") == 0)
 	{
 		use_ssl = FALSE;
-			use_ssl_noverify = FALSE;
-			offset++;
+		offset++;	/* args move up by 1 word */
 	}
-		else
 #endif
-		if (g_strcmp0 (word[2 + offset], "-noproxy") == 0)
-		{
-			no_proxy = TRUE;
-			offset++;
-		}
-		else
-		{
-			break;
-		}
-	}
-
-	serv->dont_use_proxy = no_proxy;
 
 	if (!parse_irc_url (word[2 + offset], &server_name, &port, &channel, &key, &use_ssl))
 	{
@@ -3732,18 +3584,10 @@ cmd_servchan (struct session *sess, char *tbuf, char *word[],
 {
 	int offset = 0;
 
-	while (TRUE)
-	{
 #ifdef USE_OPENSSL
-		if (g_strcmp0 (word[2 + offset], "-ssl") == 0 || g_strcmp0 (word[2 + offset], "-ssl-noverify") == 0 || g_strcmp0 (word[2 + offset], "-insecure") == 0)
+	if (g_strcmp0 (word[2], "-ssl") == 0 || g_strcmp0 (word[2], "-ssl-noverify") == 0 || g_strcmp0 (word[2], "-insecure") == 0)
 		offset++;
-		else
 #endif
-		if (g_strcmp0 (word[2 + offset], "-noproxy") == 0)
-			offset++;
-		else
-			break;
-	}
 
 	if (*word[4 + offset])
 	{
@@ -4226,7 +4070,7 @@ const struct commands xc_cmds[] = {
 	{"ME", cmd_me, 0, 0, 1,
 	 N_("ME <action>, sends the action to the current channel (actions are written in the 3rd person, like /me jumps)")},
 	{"MENU", cmd_menu, 0, 0, 1, "MENU [-eX] [-i<ICONFILE>] [-k<mod>,<key>] [-m] [-pX] [-r<X,group>] [-tX] {ADD|DEL} <path> [command] [unselect command]\n"
-										 "       See https://docs.zoitechat.org/en/latest/en/latest/plugins.html#controlling-the-gui for more details."},
+										 "       See https://docs.zoitechat.zoite.net/en/latest/en/latest/plugins.html#controlling-the-gui for more details."},
 	{"MHOP", cmd_mhop, 1, 1, 1,
 	 N_("MHOP, Mass hop's all users in the current channel (needs chanop)")},
 	{"MKICK", cmd_mkick, 1, 1, 1,
@@ -4270,24 +4114,22 @@ const struct commands xc_cmds[] = {
 #endif
 	{"RECV", cmd_recv, 1, 0, 1, N_("RECV <text>, send raw data to ZoiteChat, as if it was received from the IRC server")},
 	{"RELOAD", cmd_reload, 0, 0, 1, N_("RELOAD <name>, reloads a plugin or script")},
-	{"REPLY", cmd_reply, 0, 0, 1, N_("REPLY <msgid> <message>, sends a reply-tagged message to the current channel or dialog")},
 	{"SAY", cmd_say, 0, 0, 1,
 	 N_("SAY <text>, sends the text to the object in the current window")},
 	{"SEND", cmd_send, 0, 0, 1, N_("SEND <nick> [<file>]")},
-	{"TYPING", cmd_typing, 0, 0, 1, N_("TYPING [active|paused|done] [target], sends a typing notification")},
 #ifdef USE_OPENSSL
 	{"SERVCHAN", cmd_servchan, 0, 0, 1,
-	 N_("SERVCHAN [-noproxy] [-insecure|-ssl|-ssl-noverify] <host> <port> <channel>, connects and joins a channel using ssl unless otherwise specified")},
+	 N_("SERVCHAN [-insecure|-ssl|-ssl-noverify] <host> <port> <channel>, connects and joins a channel using ssl unless otherwise specified")},
 #else
 	{"SERVCHAN", cmd_servchan, 0, 0, 1,
-	 N_("SERVCHAN [-noproxy] <host> <port> <channel>, connects and joins a channel")},
+	 N_("SERVCHAN <host> <port> <channel>, connects and joins a channel")},
 #endif
 #ifdef USE_OPENSSL
 	{"SERVER", cmd_server, 0, 0, 1,
-	 N_("SERVER [-noproxy] [-insecure|-ssl|-ssl-noverify] <host> [<port>] [<password>], connects to a server using ssl unless otherwise specified, the default port is 6697 for ssl connections and 6667 for insecure connections")},
+	 N_("SERVER [-insecure|-ssl|-ssl-noverify] <host> [<port>] [<password>], connects to a server using ssl unless otherwise specified, the default port is 6697 for ssl connections and 6667 for insecure connections")},
 #else
 	{"SERVER", cmd_server, 0, 0, 1,
-	 N_("SERVER [-noproxy] <host> [<port>] [<password>], connects to a server, the default port is 6667")},
+	 N_("SERVER <host> [<port>] [<password>], connects to a server, the default port is 6667")},
 #endif
 	{"SET", cmd_set, 0, 0, 1, N_("SET [-e] [-off|-on] [-quiet] <variable> [<value>]")},
 	{"SETCURSOR", cmd_setcursor, 0, 0, 1, N_("SETCURSOR [-|+]<position>, reposition the cursor in the inputbox")},
@@ -4324,10 +4166,10 @@ const struct commands xc_cmds[] = {
 static int
 command_compare (const void *a, const void *b)
 {
-	return g_ascii_strcasecmp (a, ((const struct commands *)b)->name);
+	return g_ascii_strcasecmp (a, ((struct commands *)b)->name);
 }
 
-static const struct commands *
+static struct commands *
 find_internal_command (char *name)
 {
 	/* the "-1" is to skip the NULL terminator */
@@ -4363,7 +4205,7 @@ usercommand_show_help (session *sess, char *name)
 static void
 help (session *sess, char *tbuf, char *helpcmd, int quiet)
 {
-	const struct commands *cmd;
+	struct commands *cmd;
 
 	if (plugin_show_help (sess, helpcmd))
 		return;
@@ -4555,7 +4397,7 @@ void
 check_special_chars (char *cmd, int do_ascii) /* check for %X */
 {
 	int occur = 0;
-	size_t len = strlen (cmd);
+	int len = strlen (cmd);
 	char *buf, *utf;
 	char tbuf[4];
 	int i = 0, j = 0;
@@ -4807,7 +4649,6 @@ handle_say (session *sess, char *text, int check_spch)
 
 		while ((split_text = split_up_text (sess, text + offset, cmd_length, split_text)))
 		{
-			if (!sess->server->have_echo_message)
 			inbound_chanmsg (sess->server, sess, sess->channel, sess->server->nick,
 								  split_text, TRUE, FALSE, &no_tags);
 			sess->server->p_message (sess->server, sess->channel, split_text);
@@ -4818,7 +4659,6 @@ handle_say (session *sess, char *text, int check_spch)
 			g_free (split_text);
 		}
 
-		if (!sess->server->have_echo_message)
 		inbound_chanmsg (sess->server, sess, sess->channel, sess->server->nick,
 							  text + offset, TRUE, FALSE, &no_tags);
 		sess->server->p_message (sess->server, sess->channel, text + offset);
@@ -4868,9 +4708,9 @@ command_insert_vars (session *sess, char *cmd)
 				break;
 
 			case 'p':
-				if (sess->server->password[0])
+				if (mynet->pass)
 				{
-					g_string_append (expanded, sess->server->password);
+					g_string_append (expanded, mynet->pass);
 				}
 				cmd++;
 				break;
@@ -4923,7 +4763,7 @@ handle_command (session *sess, char *cmd, int check_spch)
 	char *word[PDIWORDS+1];
 	char *word_eol[PDIWORDS+1];
 	static int command_level = 0;
-	const struct commands *int_cmd;
+	struct commands *int_cmd;
 	char *pdibuf;
 	char *tbuf;
 	int len;
@@ -5043,9 +4883,6 @@ xit:
 static int
 handle_user_input (session *sess, char *text, int history, int nocommand)
 {
-	char cmd_char = prefs.hex_input_command_char[0];
-	unsigned int i;
-
 	if (*text == '\0')
 		return 1;
 
@@ -5053,22 +4890,50 @@ handle_user_input (session *sess, char *text, int history, int nocommand)
 		history_add (&sess->history, text);
 
 	/* is it NOT a command, just text? */
-	if (nocommand || text[0] != cmd_char)
+	if (nocommand || text[0] != prefs.hex_input_command_char[0])
 	{
 		handle_say (sess, text, TRUE);
 		return 1;
 	}
 
-	for (i = 1; text[i]; i++)
+	/* check for // */
+	if (text[0] == prefs.hex_input_command_char[0] && text[1] == prefs.hex_input_command_char[0])
 	{
-		if (text[i] == cmd_char)
+		handle_say (sess, text + 1, TRUE);
+		return 1;
+	}
+
+#if 0 /* Who would remember all this? */
+	if (prefs.hex_input_command_char[0] == '/')
+	{
+		int i;
+		const char *unix_dirs [] = {
+			"/bin/",
+			"/boot/",
+			"/dev/",
+			"/etc/",
+			"/home/",
+			"/lib/",
+			"/lost+found/",
+			"/mnt/",
+			"/opt/",
+			"/proc/",
+			"/root/",
+			"/sbin/",
+			"/tmp/",
+			"/usr/",
+			"/var/",
+			"/gnome/",
+			NULL
+		};
+		for (i = 0; unix_dirs[i] != NULL; i++)
+			if (strncmp (text, unix_dirs[i], strlen (unix_dirs[i]))==0)
 			{
 				handle_say (sess, text, TRUE);
 				return 1;
 			}
-		if (text[i] == ' ')
-			break;
 	}
+#endif
 
 	return handle_command (sess, text + 1, TRUE);
 }

src/common/plugin.c

@@ -25,7 +25,6 @@
 
 #ifdef WIN32
 #include <io.h>
-#include <windows.h>
 #else
 #include <unistd.h>
 #endif
@@ -57,36 +56,6 @@ typedef struct session zoitechat_context;
 #endif
 
 #define DEBUG(x) {x;}
-#ifdef WIN32
-
-/* Python >= 3.9 dropped support for Windows versions before 10, so those
- * systems get a Python 3.8 build of the plugin instead.  RtlGetVersion is
- * used because GetVersionEx reports a version capped by the compatibility
- * manifest rather than the real one. */
-static gboolean
-plugin_windows_needs_python38 (void)
-{
-	typedef LONG (WINAPI *rtl_get_version_func) (PRTL_OSVERSIONINFOW);
-	rtl_get_version_func rtl_get_version;
-	RTL_OSVERSIONINFOW version;
-	HMODULE ntdll;
-
-	ntdll = GetModuleHandleW (L"ntdll.dll");
-	if (ntdll == NULL)
-		return FALSE;
-
-	rtl_get_version = (rtl_get_version_func) GetProcAddress (ntdll, "RtlGetVersion");
-	if (rtl_get_version == NULL)
-		return FALSE;
-
-	memset (&version, 0, sizeof (version));
-	version.dwOSVersionInfoSize = sizeof (version);
-	if (rtl_get_version (&version) != 0)
-		return FALSE;
-
-	return version.dwMajorVersion < 10;
-}
-#endif
 
 /* crafted to be an even 32 bytes */
 struct _zoitechat_hook
@@ -522,11 +491,9 @@ plugin_auto_load (session *sess)
 	for_files (lib_dir, "hcfishlim.dll", plugin_auto_load_cb);
 	for_files(lib_dir, "hclua.dll", plugin_auto_load_cb);
 	for_files (lib_dir, "hcperl.dll", plugin_auto_load_cb);
-	if (plugin_windows_needs_python38 ())
-		for_files (lib_dir, "hcpython38.dll", plugin_auto_load_cb);
-	else
 	for_files (lib_dir, "hcpython3.dll", plugin_auto_load_cb);
 	for_files (lib_dir, "hcupd.dll", plugin_auto_load_cb);
+	for_files (lib_dir, "hcwinamp.dll", plugin_auto_load_cb);
 	for_files (lib_dir, "hcsysinfo.dll", plugin_auto_load_cb);
 #else
 	for_files (lib_dir, "*."PLUGIN_SUFFIX, plugin_auto_load_cb);
@@ -1247,6 +1214,8 @@ zoitechat_get_info (zoitechat_plugin *ph, const char *id)
 
 	case 0x4889ba9b: /* password */
 	case 0x438fdf9: /* nickserv */
+		if (sess->server->network)
+			return ((ircnet *)sess->server->network)->pass;
 		return NULL;
 
 	case 0xca022f43: /* server */

src/common/proto-irc.c

@@ -362,18 +362,6 @@ irc_message (server *serv, char *channel, char *text)
 	tcp_sendf (serv, "PRIVMSG %s :%s\r\n", channel, text);
 }
 
-static void
-irc_message_tagged (server *serv, char *tags, char *channel, char *text)
-{
-	tcp_sendf (serv, "@%s PRIVMSG %s :%s\r\n", tags, channel, text);
-}
-
-static void
-irc_tagmsg (server *serv, char *tags, char *target)
-{
-	tcp_sendf (serv, "@%s TAGMSG %s\r\n", tags, target);
-}
-
 static void
 irc_action (server *serv, char *channel, char *act)
 {
@@ -437,7 +425,7 @@ static int
 irc_raw (server *serv, char *raw)
 {
 	int len;
-	char tbuf[8704];
+	char tbuf[4096];
 	if (*raw)
 	{
 		len = strlen (raw);
@@ -1021,40 +1009,6 @@ process_numeric (session * sess, int n,
 
 /* handle named messages that starts with a ':' */
 
-
-static void
-emit_standard_reply (session *sess, const char *type, char *command, char *code, char *text, const message_tags_data *tags_data)
-{
-	int is_global = g_strcmp0 (command, "*") == 0;
-
-	if (!text)
-		text = "";
-	if (*text == ':')
-		text++;
-
-	if (!strcmp (type, "FAIL"))
-	{
-		if (is_global)
-			EMIT_SIGNAL_TIMESTAMP (XP_TE_FAIL, sess, code, text, NULL, NULL, NULL, tags_data->timestamp);
-		else
-			EMIT_SIGNAL_TIMESTAMP (XP_TE_FAILCMD, sess, command, code, text, NULL, NULL, tags_data->timestamp);
-	}
-	else if (!strcmp (type, "WARN"))
-	{
-		if (is_global)
-			EMIT_SIGNAL_TIMESTAMP (XP_TE_WARN, sess, code, text, NULL, NULL, NULL, tags_data->timestamp);
-		else
-			EMIT_SIGNAL_TIMESTAMP (XP_TE_WARNCMD, sess, command, code, text, NULL, NULL, tags_data->timestamp);
-	}
-	else if (!strcmp (type, "NOTE"))
-	{
-		if (is_global)
-			EMIT_SIGNAL_TIMESTAMP (XP_TE_NOTE, sess, code, text, NULL, NULL, NULL, tags_data->timestamp);
-		else
-			EMIT_SIGNAL_TIMESTAMP (XP_TE_NOTECMD, sess, command, code, text, NULL, NULL, tags_data->timestamp);
-	}
-}
-
 static void
 process_named_msg (session *sess, char *type, char *word[], char *word_eol[],
 						 const message_tags_data *tags_data)
@@ -1063,7 +1017,7 @@ process_named_msg (session *sess, char *type, char *word[], char *word_eol[],
 	char *account;
 	char ip[128], nick[NICKLEN];
 	char *text, *ex;
-	size_t len = strlen (type);
+	int len = strlen (type);
 
 	/* fill in the "ip" and "nick" buffers */
 	ex = strchr (word[1], '!');
@@ -1368,24 +1322,11 @@ process_named_msg (session *sess, char *type, char *word[], char *word_eol[],
 						{
 							if (ignore_check (word[1], IG_PRIV))
 								return;
-							if (serv->have_echo_message && !serv->p_cmp (nick, serv->nick))
-							{
-								session *target_sess = find_dialog (serv, to);
-
-								if (!target_sess)
-									target_sess = find_channel (serv, to);
-								if (target_sess)
-									inbound_chanmsg (serv, target_sess, target_sess->channel, nick, text, TRUE, tags_data->identified, tags_data);
-								else if (serv->front_session)
-									EMIT_SIGNAL_TIMESTAMP (XP_TE_MSGSEND, serv->front_session, to, text, NULL, NULL, 0, tags_data->timestamp);
-							} else
-							{
 							inbound_privmsg (serv, nick, ip, text, tags_data->identified, tags_data);
 						}
 					}
 				}
 			}
-			}
 			return;
 
 		case WORDL('T','O','P','I'):
@@ -1394,29 +1335,6 @@ process_named_msg (session *sess, char *type, char *word[], char *word_eol[],
 									tags_data);
 			return;
 
-		case WORDL('T','A','G','M'):
-			if (tags_data->typing)
-			{
-				session *typing_sess = NULL;
-				char *to = word[3];
-
-				if (is_channel (serv, to))
-					typing_sess = find_channel (serv, to);
-				else if (!serv->p_cmp (to, serv->nick))
-					typing_sess = find_dialog (serv, nick);
-				if (!typing_sess)
-					typing_sess = sess;
-				if (!serv->p_cmp (nick, serv->nick))
-					return;
-				if (!strcmp (tags_data->typing, "done"))
-					fe_set_typing (typing_sess, nick, "done");
-				else if (!strcmp (tags_data->typing, "paused"))
-					fe_set_typing (typing_sess, nick, "paused");
-				else if (!strcmp (tags_data->typing, "active"))
-					fe_set_typing (typing_sess, nick, "active");
-			}
-			return;
-
 		case WORDL('W','A','L','L'):
 			text = word_eol[3];
 			if (*text == ':')
@@ -1513,11 +1431,6 @@ process_named_servermsg (session *sess, char *buf, char *rawname, char *word_eol
 		inbound_sasl_authenticate (sess->server, word_eol[2]);
 		return;
 	}
-	if (!strncmp (buf, "FAIL ", 5) || !strncmp (buf, "WARN ", 5) || !strncmp (buf, "NOTE ", 5))
-	{
-		emit_standard_reply (sess, word_eol[1], word_eol[2], word_eol[3], word_eol[4], tags_data);
-		return;
-	}
 
 	EMIT_SIGNAL_TIMESTAMP (XP_TE_SERVTEXT, sess, buf, sess->server->servername,
 								  rawname, NULL, 0, tags_data->timestamp);
@@ -1620,130 +1533,39 @@ handle_message_tag_time (const char *time, message_tags_data *tags_data)
  *
  * See http://ircv3.atheme.org/specification/message-tags-3.2 
  */
-static char *
-message_tag_unescape (const char *value)
-{
-	GString *out;
-	const char *p;
-
-	if (!*value)
-		return NULL;
-
-	out = g_string_sized_new (strlen (value));
-
-	for (p = value; *p; p++)
-	{
-		if (*p != '\\')
-		{
-			g_string_append_c (out, *p);
-			continue;
-		}
-
-		p++;
-		if (!*p)
-			break;
-
-		switch (*p)
-		{
-		case ':':
-			g_string_append_c (out, ';');
-			break;
-		case 's':
-			g_string_append_c (out, ' ');
-			break;
-		case '\\':
-			g_string_append_c (out, '\\');
-			break;
-		case 'r':
-			g_string_append_c (out, '\r');
-			break;
-		case 'n':
-			g_string_append_c (out, '\n');
-			break;
-		default:
-			g_string_append_c (out, *p);
-			break;
-		}
-	}
-
-	value = out->str;
-	if (!g_utf8_validate (value, -1, NULL))
-	{
-		g_string_free (out, TRUE);
-		return NULL;
-	}
-
-	return g_string_free (out, FALSE);
-}
-
 static void
 handle_message_tags (server *serv, const char *tags_str,
 							message_tags_data *tags_data)
 {
 	char **tags;
-	char *time = NULL;
 	int i;
 
+	/* FIXME We might want to avoid the allocation overhead here since 
+	 * this might be called for every message from the server.
+	 */
 	tags = g_strsplit (tags_str, ";", 0);
 
 	for (i=0; tags[i]; i++)
 	{
 		char *key = tags[i];
-		char *raw_value = strchr (tags[i], '=');
-		char *value = NULL;
+		char *value = strchr (tags[i], '=');
 
-		if (!*key)
+		if (!value)
 			continue;
 
-		if (raw_value)
-		{
-			*raw_value = '\0';
-			raw_value++;
-			value = message_tag_unescape (raw_value);
-		}
+		*value = '\0';
+		value++;
 
 		if (serv->have_account_tag && !strcmp (key, "account"))
-		{
-			g_free (tags_data->account);
-			tags_data->account = value;
-			value = NULL;
-		}
-		else if (serv->have_idmsg && !strcmp (key, "solanum.chat/identified"))
-		{
+			tags_data->account = g_strdup (value);
+
+		if (serv->have_idmsg && strcmp (key, "solanum.chat/identified"))
 			tags_data->identified = TRUE;
-		}
-		else if (serv->have_server_time && !strcmp (key, "time"))
-		{
-			g_free (time);
-			time = value;
-			value = NULL;
-		}
-		else if (!strcmp (key, "msgid"))
-		{
-			g_free (tags_data->msgid);
-			tags_data->msgid = value;
-			value = NULL;
-		}
-		else if (!strcmp (key, "+reply"))
-		{
-			g_free (tags_data->reply);
-			tags_data->reply = value;
-			value = NULL;
-		}
-		else if (!strcmp (key, "+typing"))
-		{
-			g_free (tags_data->typing);
-			tags_data->typing = value;
-			value = NULL;
+
+		if (serv->have_server_time && !strcmp (key, "time"))
+			handle_message_tag_time (value, tags_data);
 	}
 	
-		g_free (value);
-	}
-
-	if (time)
-		handle_message_tag_time (time, tags_data);
-
-	g_free (time);
 	g_strfreev (tags);
 }
 
@@ -1845,9 +1667,6 @@ void
 message_tags_data_free (message_tags_data *tags_data)
 {
 	g_clear_pointer (&tags_data->account, g_free);
-	g_clear_pointer (&tags_data->msgid, g_free);
-	g_clear_pointer (&tags_data->reply, g_free);
-	g_clear_pointer (&tags_data->typing, g_free);
 }
 
 void
@@ -1877,8 +1696,6 @@ proto_fill_her_up (server *serv)
 	serv->p_set_back = irc_set_back;
 	serv->p_set_away = irc_set_away;
 	serv->p_message = irc_message;
-	serv->p_message_tagged = irc_message_tagged;
-	serv->p_tagmsg = irc_tagmsg;
 	serv->p_action = irc_action;
 	serv->p_notice = irc_notice;
 	serv->p_topic = irc_topic;

src/common/proto-irc.h

@@ -28,9 +28,6 @@
 		NULL, /* account name */		\
 		FALSE, /* identified to nick */ \
 		(time_t)0, /* timestamp */		\
-		NULL,						\
-		NULL,						\
-		NULL,						\
 	}
 
 #define STRIP_COLON(word, word_eol, idx) (word)[(idx)][0] == ':' ? (word_eol)[(idx)]+1 : (word)[(idx)]
@@ -44,9 +41,6 @@ typedef struct
 	char *account;
 	gboolean identified;
 	time_t timestamp;
-	char *msgid;
-	char *reply;
-	char *typing;
 } message_tags_data;
 
 void message_tags_data_free (message_tags_data *tags_data);

src/common/secretstore.c

@@ -1,173 +0,0 @@
-#include "zoitechat.h"
-#include "cfgfiles.h"
-#include "secretstore.h"
-
-#include <string.h>
-
-#ifdef WIN32
-#include <windows.h>
-#include <wincred.h>
-#endif
-
-#ifdef HAVE_LIBSECRET
-#include <libsecret/secret.h>
-#endif
-
-static char *secretstore_target (const char *network_name)
-{
-	return g_strdup_printf ("zoitechat/network/%s", network_name ? network_name : "default");
-}
-
-int secretstore_is_keyring_available (void)
-{
-#ifdef WIN32
-	return TRUE;
-#elif defined(HAVE_LIBSECRET)
-	return TRUE;
-#else
-	return FALSE;
-#endif
-}
-
-char *secretstore_get_network_password (const char *network_name)
-{
-	char *target;
-	target = secretstore_target (network_name);
-#ifdef WIN32
-	{
-		PCREDENTIALA cred = NULL;
-		char *ret = NULL;
-		if (CredReadA (target, CRED_TYPE_GENERIC, 0, &cred))
-		{
-			ret = g_strndup ((const char *) cred->CredentialBlob, cred->CredentialBlobSize);
-			CredFree (cred);
-		}
-		g_free (target);
-		return ret;
-	}
-#elif defined(HAVE_LIBSECRET)
-	{
-		static const SecretSchema schema = {
-			"net.zoite.ZoiteChat.Network", SECRET_SCHEMA_NONE,
-			{
-				{ "network", SECRET_SCHEMA_ATTRIBUTE_STRING },
-				{ NULL, 0 },
-			}
-		};
-		char *ret = secret_password_lookup_sync (&schema, NULL, NULL, "network", target, NULL);
-		g_free (target);
-		return ret;
-	}
-#else
-	g_free (target);
-	return NULL;
-#endif
-}
-
-int secretstore_set_network_password (const char *network_name, const char *password)
-{
-	char *target;
-	target = secretstore_target (network_name);
-#ifdef WIN32
-	{
-		CREDENTIALA cred;
-		memset (&cred, 0, sizeof (cred));
-		cred.Type = CRED_TYPE_GENERIC;
-		cred.TargetName = target;
-		cred.CredentialBlobSize = (DWORD) strlen (password);
-		cred.CredentialBlob = (LPBYTE) password;
-		cred.Persist = CRED_PERSIST_LOCAL_MACHINE;
-		cred.UserName = "zoitechat";
-		if (!CredWriteA (&cred, 0))
-		{
-			g_free (target);
-			return FALSE;
-		}
-		g_free (target);
-		return TRUE;
-	}
-#elif defined(HAVE_LIBSECRET)
-	{
-		static const SecretSchema schema = {
-			"net.zoite.ZoiteChat.Network", SECRET_SCHEMA_NONE,
-			{
-				{ "network", SECRET_SCHEMA_ATTRIBUTE_STRING },
-				{ NULL, 0 },
-			}
-		};
-		gboolean ok = secret_password_store_sync (&schema, SECRET_COLLECTION_DEFAULT,
-			"ZoiteChat network password", password, NULL, NULL, "network", target, NULL);
-		g_free (target);
-		return ok;
-	}
-#else
-	g_free (target);
-	return FALSE;
-#endif
-}
-
-int secretstore_delete_network_password (const char *network_name)
-{
-	char *target;
-	target = secretstore_target (network_name);
-#ifdef WIN32
-	{
-		gboolean ok = CredDeleteA (target, CRED_TYPE_GENERIC, 0);
-		g_free (target);
-		return ok;
-	}
-#elif defined(HAVE_LIBSECRET)
-	{
-		static const SecretSchema schema = {
-			"net.zoite.ZoiteChat.Network", SECRET_SCHEMA_NONE,
-			{
-				{ "network", SECRET_SCHEMA_ATTRIBUTE_STRING },
-				{ NULL, 0 },
-			}
-		};
-		gboolean ok = secret_password_clear_sync (&schema, NULL, NULL, "network", target, NULL);
-		g_free (target);
-		return ok;
-	}
-#else
-	g_free (target);
-	return FALSE;
-#endif
-}
-
-int secretstore_require_unlock (const char *network_name)
-{
-#ifdef WIN32
-	return TRUE;
-#elif defined(HAVE_LIBSECRET)
-	{
-		static const SecretSchema schema = {
-			"net.zoite.ZoiteChat.Network", SECRET_SCHEMA_NONE,
-			{
-				{ "network", SECRET_SCHEMA_ATTRIBUTE_STRING },
-				{ NULL, 0 },
-			}
-		};
-		char *target;
-		char *password;
-		GError *error = NULL;
-		target = secretstore_target (network_name);
-		password = secret_password_lookup_sync (&schema, NULL, &error, "network", target, NULL);
-		g_free (target);
-		if (password)
-		{
-			memset (password, 0, strlen (password));
-			g_free (password);
-			return TRUE;
-		}
-		if (error)
-		{
-			g_error_free (error);
-			return FALSE;
-		}
-		return TRUE;
-	}
-#else
-	return TRUE;
-#endif
-}

src/common/secretstore.h

@@ -1,10 +0,0 @@
-#ifndef ZOITECHAT_SECRETSTORE_H
-#define ZOITECHAT_SECRETSTORE_H
-
-char *secretstore_get_network_password (const char *network_name);
-int secretstore_set_network_password (const char *network_name, const char *password);
-int secretstore_delete_network_password (const char *network_name);
-int secretstore_is_keyring_available (void);
-int secretstore_require_unlock (const char *network_name);
-
-#endif

src/common/server.c

@@ -109,58 +109,6 @@ static void server_disconnect (session * sess, int sendquit, int err);
 static int server_cleanup (server * serv);
 static void server_connect (server *serv, char *hostname, int port, int no_login);
 
-typedef struct
-{
-	server *serv;
-	char hostname[128];
-	int port;
-} reconnect_password_prompt;
-
-static gboolean
-server_login_uses_password_sasl (int logintype)
-{
-	return logintype == LOGIN_SASL ||
-		logintype == LOGIN_SASL_SCRAM_SHA_1 ||
-		logintype == LOGIN_SASL_SCRAM_SHA_256 ||
-		logintype == LOGIN_SASL_SCRAM_SHA_512;
-}
-
-static void
-server_reconnect_password_cb (int cancel, char *text, void *userdata)
-{
-	reconnect_password_prompt *prompt = userdata;
-
-	if (!cancel && is_server (prompt->serv) && !prompt->serv->connected && !prompt->serv->connecting && prompt->serv->server_session)
-	{
-		prompt->serv->password[0] = 0;
-		if (text && *text)
-			safe_strcpy (prompt->serv->password, text, sizeof (prompt->serv->password));
-		server_connect (prompt->serv, prompt->hostname, prompt->port, FALSE);
-	}
-
-	g_free (prompt);
-}
-
-static gboolean
-server_prompt_reconnect_password (server *serv)
-{
-	reconnect_password_prompt *prompt;
-	char *msg;
-	ircnet *net = serv->network;
-
-	if (!net || !(net->flags & FLAG_PROMPT_PASSWORD) || !server_login_uses_password_sasl (serv->loginmethod))
-		return FALSE;
-
-	prompt = g_new0 (reconnect_password_prompt, 1);
-	prompt->serv = serv;
-	safe_strcpy (prompt->hostname, serv->hostname, sizeof (prompt->hostname));
-	prompt->port = serv->port;
-	msg = g_strdup_printf (_("Enter SASL password for %s:"), net->name ? net->name : _("this network"));
-	fe_get_password (msg, server_reconnect_password_cb, prompt);
-	g_free (msg);
-	return TRUE;
-}
-
 static void
 write_error (char *message, GError **error)
 {
@@ -574,7 +522,7 @@ ssl_cb_verify (int ok, X509_STORE_CTX * ctx)
 	X509 *current_cert = X509_STORE_CTX_get_current_cert (ctx);
 
 	if (!current_cert)
-		return ok;
+		return TRUE;
 
 	X509_NAME_oneline (X509_get_subject_name (current_cert),
 	                   subject, sizeof (subject));
@@ -586,24 +534,13 @@ ssl_cb_verify (int ok, X509_STORE_CTX * ctx)
 	g_snprintf (buf, sizeof (buf), "* Issuer: %s", issuer);
 	EMIT_SIGNAL (XP_TE_SSLMESSAGE, g_sess, buf, NULL, NULL, NULL, 0);
 
-	if (!ok)
-	{
-		int err = X509_STORE_CTX_get_error (ctx);
-		g_snprintf (buf, sizeof (buf), "* Verify E: %s (%d)",
-					 X509_verify_cert_error_string (err), err);
-		EMIT_SIGNAL (XP_TE_SSLMESSAGE, g_sess, buf, NULL, NULL, NULL, 0);
-
-		if (g_sess && g_sess->server->accept_invalid_cert)
-			return 1;
-	}
-
-	return ok;
+	return TRUE;
 }
 
 static int
 ssl_do_connect (server * serv)
 {
-	char buf[256];
+	char buf[256]; // ERR_error_string() MUST have this size
 
 	g_sess = serv->server_session;
 
@@ -622,10 +559,9 @@ ssl_do_connect (server * serv)
 	if (SSL_connect (serv->ssl) <= 0)
 	{
 		char err_buf[128];
-		int err, ssl_err;
+		int err;
 
 		g_sess = NULL;
-		ssl_err = SSL_get_error (serv->ssl, -1);
 		if ((err = ERR_get_error ()) > 0)
 		{
 			ERR_error_string (err, err_buf);
@@ -635,8 +571,6 @@ ssl_do_connect (server * serv)
 
 			if (ERR_GET_REASON (err) == SSL_R_WRONG_VERSION_NUMBER)
 				PrintText (serv->server_session, _("Are you sure this is a SSL capable server and port?\n"));
-			else if (ssl_err == SSL_ERROR_SSL)
-				EMIT_SIGNAL (XP_TE_SSLMESSAGE, serv->server_session, "* TLS handshake rejected by protocol/certificate/cipher policy", NULL, NULL, NULL, 0);
 
 			server_cleanup (serv);
 
@@ -715,18 +649,30 @@ ssl_do_connect (server * serv)
 				int hostname_err;
 				if ((hostname_err = _SSL_check_hostname(cert, serv->hostname)) != 0)
 				{
-					g_snprintf (buf, sizeof (buf), "* Verify E: Failed to validate hostname (%d)",
-							 hostname_err);
+					g_snprintf (buf, sizeof (buf), "* Verify E: Failed to validate hostname? (%d)%s",
+							 hostname_err, serv->accept_invalid_cert ? " -- Ignored" : "");
+					if (serv->accept_invalid_cert)
 						EMIT_SIGNAL (XP_TE_SSLMESSAGE, serv->server_session, buf, NULL, NULL, NULL, 0);
-					if (!serv->accept_invalid_cert)
+					else
 						goto conn_fail;
 				}
 				break;
 			}
-		default:
+		case X509_V_ERR_UNABLE_TO_GET_ISSUER_CERT_LOCALLY:
+		case X509_V_ERR_UNABLE_TO_VERIFY_LEAF_SIGNATURE:
+		case X509_V_ERR_DEPTH_ZERO_SELF_SIGNED_CERT:
+		case X509_V_ERR_SELF_SIGNED_CERT_IN_CHAIN:
+		case X509_V_ERR_CERT_HAS_EXPIRED:
 			if (serv->accept_invalid_cert)
+			{
+				g_snprintf (buf, sizeof (buf), "* Verify E: %s.? (%d) -- Ignored",
+							 X509_verify_cert_error_string (verify_error),
+							 verify_error);
+				EMIT_SIGNAL (XP_TE_SSLMESSAGE, serv->server_session, buf, NULL, NULL,
+								 NULL, 0);
 				break;
-
+			}
+		default:
 			g_snprintf (buf, sizeof (buf), "%s.? (%d)",
 						 X509_verify_cert_error_string (verify_error),
 						 verify_error);
@@ -786,7 +732,6 @@ timeout_auto_reconnect (server *serv)
 		serv->recondelay_tag = 0;
 		if (!serv->connected && !serv->connecting && serv->server_session)
 		{
-			if (!server_prompt_reconnect_password (serv))
 			server_connect (serv, serv->hostname, serv->port, FALSE);
 		}
 	}
@@ -936,7 +881,7 @@ server_read_child (GIOChannel *source, GIOCondition condition, server *serv)
 			if (prefs.hex_net_auto_reconnectonfail)
 				auto_reconnect (serv, FALSE, -1);
 		break;
-	case '3':						  /* resolver finished */
+	case '3':						  /* gethostbyname finished */
 		waitline2 (source, host, sizeof host);
 		waitline2 (source, ip, sizeof ip);
 		waitline2 (source, outbuf, sizeof outbuf);
@@ -985,9 +930,9 @@ server_read_child (GIOChannel *source, GIOCondition condition, server *serv)
 		break;
 	case '5':						  /* prefs ip discovered */
 		waitline2 (source, tbuf, sizeof tbuf);
-		net_parse_ipv4 (tbuf, &prefs.local_ip);
+		prefs.local_ip = inet_addr (tbuf);
 		break;
-	case '7':						  /* prefs.hex_net_bind_host resolve failed */
+	case '7':						  /* gethostbyname (prefs.hex_net_bind_host) failed */
 		sprintf (outbuf,
 					_("Cannot resolve hostname %s\nCheck your IP Settings!\n"),
 					prefs.hex_net_bind_host);
@@ -1159,7 +1104,7 @@ traverse_socks (int print_fd, int sok, char *serverAddr, int port)
 	sc.version = 4;
 	sc.type = 1;
 	sc.port = htons (port);
-	net_parse_ipv4 (serverAddr, &sc.address);
+	sc.address = inet_addr (serverAddr);
 	g_strlcpy (sc.username, prefs.hex_irc_user_name, sizeof (sc.username));
 
 	send (sok, (char *) &sc, 8 + strlen (sc.username) + 1, 0);
@@ -1874,7 +1819,6 @@ void
 server_set_defaults (server *serv)
 {
 	g_free (serv->chantypes);
-	g_clear_pointer (&serv->clienttagdeny, g_free);
 	g_free (serv->chanmodes);
 	g_free (serv->nick_prefixes);
 	g_free (serv->nick_modes);
@@ -1909,8 +1853,6 @@ server_set_defaults (server *serv)
 	serv->have_extjoin = FALSE;
 	serv->have_account_tag = FALSE;
 	serv->have_server_time = FALSE;
-	serv->have_message_tags = FALSE;
-	serv->have_echo_message = FALSE;
 	serv->have_sasl = FALSE;
 	serv->have_except = FALSE;
 	serv->have_invite = FALSE;
@@ -2041,7 +1983,6 @@ server_free (server *serv)
 	g_free (serv->nick_prefixes);
 	g_free (serv->chanmodes);
 	g_free (serv->chantypes);
-	g_free (serv->clienttagdeny);
 	g_free (serv->bad_nick_prefixes);
 	g_free (serv->last_away_reason);
 	g_free (serv->encoding);

src/common/servlist.c

@@ -33,152 +33,9 @@
 #include "text.h"
 #include "util.h" /* token_foreach */
 #include "zoitechatc.h"
-#include "secretstore.h"
 
 #include "servlist.h"
 
-#ifdef USE_OPENSSL
-#include <openssl/evp.h>
-#include <openssl/rand.h>
-#endif
-
-char *
-servlist_password_encrypt_for_storage (const char *pass)
-{
-	gchar *material;
-	unsigned char salt[16];
-	unsigned char iv[16];
-	unsigned char key[32];
-	unsigned char *ciphertext;
-	int outlen1;
-	int outlen2;
-	int inlen;
-	int cipherlen;
-	EVP_CIPHER_CTX *ctx;
-	char *b64;
-	char *ret;
-	if (!pass || !*pass)
-		return NULL;
-#ifdef USE_OPENSSL
-	if (RAND_bytes (salt, sizeof (salt)) != 1 || RAND_bytes (iv, sizeof (iv)) != 1)
-		return NULL;
-	material = g_strdup_printf ("%s|%s", g_get_user_name (), get_xdir ());
-	if (!PKCS5_PBKDF2_HMAC (material, -1, salt, sizeof (salt), 300000, EVP_sha256 (), sizeof (key), key))
-	{
-		g_free (material);
-		return NULL;
-	}
-	g_free (material);
-	inlen = (int) strlen (pass);
-	ciphertext = g_malloc (inlen + EVP_MAX_BLOCK_LENGTH);
-	ctx = EVP_CIPHER_CTX_new ();
-	if (!ctx)
-	{
-		memset (key, 0, sizeof (key));
-		g_free (ciphertext);
-		return NULL;
-	}
-	if (EVP_EncryptInit_ex (ctx, EVP_aes_256_cbc (), NULL, key, iv) != 1 ||
-		EVP_EncryptUpdate (ctx, ciphertext, &outlen1, (const unsigned char *) pass, inlen) != 1 ||
-		EVP_EncryptFinal_ex (ctx, ciphertext + outlen1, &outlen2) != 1)
-	{
-		EVP_CIPHER_CTX_free (ctx);
-		memset (key, 0, sizeof (key));
-		g_free (ciphertext);
-		return NULL;
-	}
-	EVP_CIPHER_CTX_free (ctx);
-	cipherlen = outlen1 + outlen2;
-	{
-		gsize payload_len = sizeof (salt) + sizeof (iv) + (gsize) cipherlen;
-		unsigned char *payload = g_malloc (payload_len);
-		memcpy (payload, salt, sizeof (salt));
-		memcpy (payload + sizeof (salt), iv, sizeof (iv));
-		memcpy (payload + sizeof (salt) + sizeof (iv), ciphertext, cipherlen);
-		b64 = g_base64_encode (payload, payload_len);
-		memset (payload, 0, payload_len);
-		g_free (payload);
-	}
-	memset (key, 0, sizeof (key));
-	memset (ciphertext, 0, inlen + EVP_MAX_BLOCK_LENGTH);
-	g_free (ciphertext);
-#else
-	b64 = g_base64_encode ((const guchar *) pass, strlen (pass));
-#endif
-	ret = g_strdup_printf ("enc:%s", b64);
-	g_free (b64);
-	return ret;
-}
-
-gboolean
-servlist_password_is_encrypted (const char *pass)
-{
-	return pass && g_str_has_prefix (pass, "enc:");
-}
-
-char *
-servlist_password_decrypt_for_storage (const char *enc)
-{
-	guchar *raw;
-	gsize len;
-	char *ret;
-	if (!enc || !*enc)
-		return NULL;
-	if (!g_str_has_prefix (enc, "enc:"))
-		return g_strdup (enc);
-	raw = g_base64_decode (enc + 4, &len);
-#ifdef USE_OPENSSL
-	if (len <= 32)
-	{
-		g_free (raw);
-		return NULL;
-	}
-	{
-		unsigned char *salt = raw;
-		unsigned char *iv = raw + 16;
-		unsigned char *ciphertext = raw + 32;
-		int cipherlen = (int) (len - 32);
-		unsigned char key[32];
-		gchar *material = g_strdup_printf ("%s|%s", g_get_user_name (), get_xdir ());
-		unsigned char *plaintext = g_malloc ((gsize) cipherlen + 1);
-		int outlen1;
-		int outlen2;
-		EVP_CIPHER_CTX *ctx = EVP_CIPHER_CTX_new ();
-		if (!ctx || !PKCS5_PBKDF2_HMAC (material, -1, salt, 16, 300000, EVP_sha256 (), sizeof (key), key))
-		{
-			g_free (material);
-			if (ctx)
-				EVP_CIPHER_CTX_free (ctx);
-			g_free (plaintext);
-			g_free (raw);
-			return NULL;
-		}
-		g_free (material);
-		if (EVP_DecryptInit_ex (ctx, EVP_aes_256_cbc (), NULL, key, iv) != 1 ||
-			EVP_DecryptUpdate (ctx, plaintext, &outlen1, ciphertext, cipherlen) != 1 ||
-			EVP_DecryptFinal_ex (ctx, plaintext + outlen1, &outlen2) != 1)
-		{
-			EVP_CIPHER_CTX_free (ctx);
-			memset (key, 0, sizeof (key));
-			memset (plaintext, 0, (gsize) cipherlen + 1);
-			g_free (plaintext);
-			g_free (raw);
-			return NULL;
-		}
-		EVP_CIPHER_CTX_free (ctx);
-		memset (key, 0, sizeof (key));
-		plaintext[outlen1 + outlen2] = 0;
-		ret = g_strdup ((const char *) plaintext);
-		memset (plaintext, 0, (gsize) cipherlen + 1);
-		g_free (plaintext);
-	}
-#else
-	ret = g_strndup ((const char *) raw, len);
-#endif
-	g_free (raw);
-	return ret;
-}
-
 
 struct defaultserver
 {
@@ -439,99 +296,8 @@ servlist_favchan_copy (favchannel *fav)
 	return newfav;
 }
 
-static void servlist_connect_with_password (session *sess, ircnet *net, gboolean join, const char *password);
-
-typedef struct
-{
-	session *sess;
-	ircnet *net;
-	gboolean join;
-} servlist_password_prompt;
-
-static gboolean
-servlist_login_uses_password_sasl (int logintype)
-{
-	return logintype == LOGIN_SASL ||
-		logintype == LOGIN_SASL_SCRAM_SHA_1 ||
-		logintype == LOGIN_SASL_SCRAM_SHA_256 ||
-		logintype == LOGIN_SASL_SCRAM_SHA_512;
-}
-
-static void servlist_prompt_sasl_password (servlist_password_prompt *prompt);
-
-static void
-servlist_connect_without_password_cb (int value, void *userdata)
-{
-	servlist_password_prompt *prompt = userdata;
-
-	if (value)
-	{
-		servlist_connect_with_password (prompt->sess, prompt->net, prompt->join, NULL);
-		g_free (prompt);
-	}
-	else
-	{
-		servlist_prompt_sasl_password (prompt);
-	}
-}
-
-static void
-servlist_connect_password_cb (int cancel, char *text, void *userdata)
-{
-	servlist_password_prompt *prompt = userdata;
-	char *msg;
-
-	if (cancel)
-	{
-		fe_serverlist_open (prompt->sess);
-		g_free (prompt);
-		return;
-	}
-
-	if (text && *text)
-	{
-		servlist_connect_with_password (prompt->sess, prompt->net, prompt->join, text);
-		g_free (prompt);
-		return;
-	}
-
-	msg = g_strdup_printf (_("Continue connecting to %s without a SASL password?"), prompt->net->name ? prompt->net->name : _("this network"));
-	fe_get_bool (_("No SASL password"), msg, servlist_connect_without_password_cb, prompt);
-	g_free (msg);
-}
-
-static void
-servlist_prompt_sasl_password (servlist_password_prompt *prompt)
-{
-	char *msg;
-
-	msg = g_strdup_printf (_("Enter SASL password for %s:"), prompt->net->name ? prompt->net->name : _("this network"));
-	fe_get_password (msg, servlist_connect_password_cb, prompt);
-	g_free (msg);
-}
-
 void
 servlist_connect (session *sess, ircnet *net, gboolean join)
-{
-	int logintype;
-	servlist_password_prompt *prompt;
-
-	logintype = net && net->logintype ? net->logintype : LOGIN_DEFAULT_REAL;
-	if (net && (net->flags & FLAG_PROMPT_PASSWORD) && servlist_login_uses_password_sasl (logintype))
-	{
-		prompt = g_new0 (servlist_password_prompt, 1);
-		prompt->sess = sess;
-		prompt->net = net;
-		prompt->join = join;
-		servlist_prompt_sasl_password (prompt);
-		return;
-	}
-
-	servlist_connect_with_password (sess, net, join, NULL);
-}
-
-static void
-servlist_connect_with_password (session *sess, ircnet *net, gboolean join, const char *password)
 {
 	ircserver *ircserv;
 	GSList *list;
@@ -578,33 +344,10 @@ servlist_connect_with_password (session *sess, ircnet *net, gboolean join, const
 	}
 
 	serv->password[0] = 0;
-	if (password && *password)
+
+	if (net->pass)
 	{
-		safe_strcpy (serv->password, password, sizeof (serv->password));
-	}
-	else if ((net->flags & FLAG_USE_KEYRING) && net->name)
-	{
-		char *stored_pass = secretstore_get_network_password (net->name);
-		if (stored_pass && *stored_pass)
-		{
-			safe_strcpy (serv->password, stored_pass, sizeof (serv->password));
-		}
-		if (stored_pass)
-		{
-			memset (stored_pass, 0, strlen (stored_pass));
-			g_free (stored_pass);
-		}
-	}
-	else if (net->pass)
-	{
-		char *plain = servlist_password_decrypt_for_storage (net->pass);
-		if (plain && *plain)
-			safe_strcpy (serv->password, plain, sizeof (serv->password));
-		if (plain)
-		{
-			memset (plain, 0, strlen (plain));
-			g_free (plain);
-		}
+		safe_strcpy (serv->password, net->pass, sizeof (serv->password));
 	}
 
 	if (net->flags & FLAG_USE_GLOBAL)
@@ -1239,6 +982,24 @@ servlist_load (void)
 			 *
 			 * Should be removed at some point.
 			 */
+			case 'A':
+				if (!net->pass)
+				{
+					net->pass = g_strdup (buf + 2);
+					if (!net->logintype)
+					{
+						net->logintype = LOGIN_SASL;
+					}
+				}
+			case 'B':
+				if (!net->pass)
+				{
+					net->pass = g_strdup (buf + 2);
+					if (!net->logintype)
+					{
+						net->logintype = LOGIN_NICKSERV;
+					}
+				}
 			}
 		}
 		if (buf[0] == 'N')

src/common/servlist.h

@@ -62,9 +62,7 @@ extern GSList *network_list;
 #define FLAG_USE_PROXY			16
 #define FLAG_ALLOW_INVALID		32
 #define FLAG_FAVORITE			64
-#define FLAG_USE_KEYRING		128
-#define FLAG_PROMPT_PASSWORD	256
-#define FLAG_COUNT				9
+#define FLAG_COUNT				7
 
 /* Login methods. Use server password by default - if we had a NickServ password, it'd be set to 2 already by servlist_load() */
 #define LOGIN_DEFAULT_REAL		LOGIN_PASS		/* this is to set the default login method for unknown servers */
@@ -126,8 +124,5 @@ favchannel *servlist_favchan_copy (favchannel *fav);
 GSList *servlist_favchan_listadd (GSList *chanlist, char *channel, char *key);
 
 gboolean joinlist_is_in_list (server *serv, char *channel);
-char *servlist_password_encrypt_for_storage (const char *pass);
-char *servlist_password_decrypt_for_storage (const char *pass);
-gboolean servlist_password_is_encrypted (const char *pass);
 
 #endif

src/common/ssl.c

@@ -86,17 +86,15 @@ _SSL_context_init (void (*info_cb_func))
 
 	SSLeay_add_ssl_algorithms ();
 	SSL_load_error_strings ();
-	ctx = SSL_CTX_new (TLS_client_method ());
+	ctx = SSL_CTX_new (SSLv23_client_method ());
 
 	SSL_CTX_set_session_cache_mode (ctx, SSL_SESS_CACHE_BOTH);
 	SSL_CTX_set_timeout (ctx, 300);
-	SSL_CTX_set_options (ctx, SSL_OP_NO_COMPRESSION
+	SSL_CTX_set_options (ctx, SSL_OP_NO_SSLv2|SSL_OP_NO_SSLv3
+							  |SSL_OP_NO_COMPRESSION
 							  |SSL_OP_SINGLE_DH_USE|SSL_OP_SINGLE_ECDH_USE
 							  |SSL_OP_NO_TICKET
-							  |SSL_OP_NO_RENEGOTIATION);
-	SSL_CTX_set_min_proto_version (ctx, TLS1_2_VERSION);
-	SSL_CTX_set_cipher_list (ctx, "HIGH:!aNULL:!eNULL:!EXPORT:!DES:!RC4:!MD5:!PSK:!SRP:!DSS");
-	SSL_CTX_set_ciphersuites (ctx, "TLS_AES_256_GCM_SHA384:TLS_CHACHA20_POLY1305_SHA256:TLS_AES_128_GCM_SHA256");
+							  |SSL_OP_CIPHER_SERVER_PREFERENCE);
 
 #if OPENSSL_VERSION_NUMBER >= 0x00908000L && !defined (OPENSSL_NO_COMP) /* workaround for OpenSSL 0.9.8 */
 	sk_SSL_COMP_zero(SSL_COMP_get_compression_methods());
@@ -154,7 +152,7 @@ int
 _SSL_get_cert_info (struct cert_info *cert_info, SSL * ssl)
 {
 	X509 *peer_cert;
-	const X509_PUBKEY *key;
+	X509_PUBKEY *key;
 	X509_ALGOR *algor = NULL;
 	EVP_PKEY *peer_pkey;
 	char notBefore[64];
@@ -313,7 +311,7 @@ _SSL_socket (SSL_CTX *ctx, int sd)
 #else
 	method = SSL_CTX_get_ssl_method (ctx);
 #endif
-	if (method == TLS_client_method())
+	if (method == SSLv23_client_method())
 		SSL_set_connect_state (ssl);
 	else
 	        SSL_set_accept_state(ssl);
@@ -350,13 +348,14 @@ _SSL_close (SSL * ssl)
 {
 	SSL_set_shutdown (ssl, SSL_SENT_SHUTDOWN | SSL_RECEIVED_SHUTDOWN);
 	SSL_free (ssl);
-#if !defined(OPENSSL_VERSION_MAJOR) && OPENSSL_VERSION_NUMBER < 0x10100000L
 #ifdef HAVE_ERR_REMOVE_THREAD_STATE
+#if OPENSSL_VERSION_NUMBER >= 0x10000000L && OPENSSL_VERSION_NUMBER < 0x10100000L
+	/* OpenSSL handles this itself in 1.1+ and this is a no-op */
 	ERR_remove_thread_state (NULL);
+#endif
 #else
 	ERR_remove_state (0);
 #endif
-#endif
 }
 
 /* Hostname validation code based on OpenBSD's libtls. */
@@ -507,12 +506,9 @@ _SSL_check_subject_altname (X509 *cert, const char *host)
 static int
 _SSL_check_common_name (X509 *cert, const char *host)
 {
-	const X509_NAME *name;
-	const X509_NAME_ENTRY *entry;
-	const ASN1_STRING *common_name_asn1;
-	const unsigned char *common_name;
+	X509_NAME *name;
+	char *common_name = NULL;
 	int common_name_len;
-	int common_name_index;
 	int rv = -1;
 	GInetAddress *addr;
 
@@ -520,27 +516,16 @@ _SSL_check_common_name (X509 *cert, const char *host)
 	if (name == NULL)
 		return -1;
 
-	common_name_index = X509_NAME_get_index_by_NID (name, NID_commonName, -1);
-	if (common_name_index < 0)
+	common_name_len = X509_NAME_get_text_by_NID (name, NID_commonName, NULL, 0);
+	if (common_name_len < 0)
 		return -1;
 
-	entry = X509_NAME_get_entry (name, common_name_index);
-	if (entry == NULL)
-		return -1;
+	common_name = g_malloc0 (common_name_len + 1);
 
-	common_name_asn1 = X509_NAME_ENTRY_get_data (entry);
-	if (common_name_asn1 == NULL)
-		return -1;
-
-#ifdef HAVE_ASN1_STRING_GET0_DATA
-	common_name = ASN1_STRING_get0_data (common_name_asn1);
-#else
-	common_name = ASN1_STRING_data (common_name_asn1);
-#endif
-	common_name_len = ASN1_STRING_length (common_name_asn1);
+	X509_NAME_get_text_by_NID (name, NID_commonName, common_name, common_name_len + 1);
 
 	/* NUL bytes in CN? */
-	if (common_name_len != (int)strlen((const char *)common_name))
+	if (common_name_len != (int)strlen(common_name))
 	{
 		g_warning ("NUL byte in Common Name field, probably a malicious certificate.\n");
 		rv = -2;
@@ -553,17 +538,18 @@ _SSL_check_common_name (X509 *cert, const char *host)
 		 * We don't want to attempt wildcard matching against IP
 		 * addresses, so perform a simple comparison here.
 		 */
-		if (g_strcmp0 ((const char *)common_name, host) == 0)
+		if (g_strcmp0 (common_name, host) == 0)
 			rv = 0;
 		else
 			rv = -1;
 
 		g_object_unref (addr);
 	}
-	else if (_SSL_match_hostname ((const char *)common_name, host) == 0)
+	else if (_SSL_match_hostname (common_name, host) == 0)
 		rv = 0;
 
 out:
+	g_free(common_name);
 	return rv;
 }
 

src/common/sysinfo/win32/backend.c

@@ -22,7 +22,6 @@
 
 #include <ctype.h>
 #include <inttypes.h>
-#include <limits.h>
 #include <stdarg.h>
 #include <stdbool.h>
 #include <stdint.h>
@@ -75,18 +74,6 @@ typedef struct
 static bool string_builder_init (StringBuilder *builder);
 static void string_builder_free (StringBuilder *builder);
 static bool string_builder_append (StringBuilder *builder, const char *text);
-static int size_to_int (size_t value);
-
-static int
-size_to_int (size_t value)
-{
-	if (value > (size_t) INT_MAX)
-	{
-		return INT_MAX;
-	}
-
-	return (int) value;
-}
 
 char *
 sysinfo_get_cpu (void)
@@ -524,7 +511,6 @@ static char *read_hdd_info (IWbemClassObject *object)
 static char *bstr_to_utf8 (BSTR bstr)
 {
 	int utf8_len;
-	int wide_len;
 	char *utf8;
 
 	if (bstr == NULL)
@@ -532,8 +518,7 @@ static char *bstr_to_utf8 (BSTR bstr)
 		return NULL;
 	}
 
-	wide_len = size_to_int ((size_t) SysStringLen (bstr));
-	utf8_len = WideCharToMultiByte (CP_UTF8, 0, bstr, wide_len, NULL, 0, NULL, NULL);
+	utf8_len = WideCharToMultiByte (CP_UTF8, 0, bstr, SysStringLen (bstr), NULL, 0, NULL, NULL);
 	if (utf8_len <= 0)
 	{
 		return NULL;
@@ -545,7 +530,7 @@ static char *bstr_to_utf8 (BSTR bstr)
 		return NULL;
 	}
 
-	if (WideCharToMultiByte (CP_UTF8, 0, bstr, wide_len, utf8, utf8_len, NULL, NULL) <= 0)
+	if (WideCharToMultiByte (CP_UTF8, 0, bstr, SysStringLen (bstr), utf8, utf8_len, NULL, NULL) <= 0)
 	{
 		free (utf8);
 		return NULL;

src/common/tests/test-gtk3-theme-service.c

@@ -381,10 +381,9 @@ test_archive_without_theme_reports_css_error (void)
 	}
 	archive_path = g_build_filename (tmp_root, "invalid-theme.zip", NULL);
 
-	command = g_strdup_printf ("sh -c \"cd '%s' && zip -qr '%s' .\"", archive_root, archive_path);
+	command = g_strdup_printf ("cd %s && zip -qr %s .", archive_root, archive_path);
 	g_assert_true (g_spawn_command_line_sync (command, NULL, NULL, NULL, NULL));
 	g_free (command);
-	g_assert_true (g_file_test (archive_path, G_FILE_TEST_IS_REGULAR));
 
 	g_assert_false (zoitechat_gtk3_theme_service_import (archive_path, &imported_id, &error));
 	g_assert_null (imported_id);
@@ -398,31 +397,25 @@ test_archive_without_theme_reports_css_error (void)
 }
 
 static void
-test_import_accepts_theme_missing_index_theme (void)
+test_import_rejects_theme_missing_index_theme (void)
 {
 	char *tmp_root;
 	char *src_root;
 	char *theme_root;
 	char *imported_id = NULL;
 	GError *error = NULL;
-	ZoitechatGtk3Theme *found;
 
 	setup_test_xdir (&tmp_root);
 	src_root = g_build_filename (tmp_root, "src", NULL);
 	g_mkdir_with_parents (src_root, 0700);
 	theme_root = make_theme_dir (src_root, "NoIndex", FALSE, FALSE);
 
-	/* index.theme is optional for GTK3 CSS themes: gtk-3.x/gtk.css alone
-	 * makes a loadable theme. */
-	g_assert_true (zoitechat_gtk3_theme_service_import (theme_root, &imported_id, &error));
-	g_assert_no_error (error);
-	g_assert_nonnull (imported_id);
-
-	found = zoitechat_gtk3_theme_find_by_id (imported_id);
-	g_assert_nonnull (found);
-	g_assert_true (g_str_has_suffix (found->path, "NoIndex"));
-	zoitechat_gtk3_theme_free (found);
-	g_free (imported_id);
+	g_assert_false (zoitechat_gtk3_theme_service_import (theme_root, &imported_id, &error));
+	g_assert_null (imported_id);
+	g_assert_error (error, G_FILE_ERROR, G_FILE_ERROR_INVAL);
+	g_assert_nonnull (g_strstr_len (error->message, -1, "missing required index.theme"));
+	g_assert_nonnull (g_strstr_len (error->message, -1, "NoIndex"));
+	g_error_free (error);
 
 	g_free (theme_root);
 	g_free (src_root);
@@ -670,10 +663,9 @@ test_zip_import_nested_root (void)
 	theme = make_theme_dir (nested, "Juno-ocean", TRUE, FALSE);
 	archive_path = g_build_filename (tmp_root, "themes.zip", NULL);
 
-	command = g_strdup_printf ("sh -c \"cd '%s' && zip -qr '%s' .\"", zip_root, archive_path);
+	command = g_strdup_printf ("cd %s && zip -qr %s .", zip_root, archive_path);
 	g_assert_true (g_spawn_command_line_sync (command, NULL, NULL, NULL, NULL));
 	g_free (command);
-	g_assert_true (g_file_test (archive_path, G_FILE_TEST_IS_REGULAR));
 
 	g_assert_true (zoitechat_gtk3_theme_service_import (archive_path, &imported_id, NULL));
 	found = zoitechat_gtk3_theme_find_by_id (imported_id);
@@ -705,7 +697,7 @@ main (int argc, char **argv)
 	g_test_add_func ("/gtk3-theme-service/zip-import-nested-root", test_zip_import_nested_root);
 	g_test_add_func ("/gtk3-theme-service/invalid-archive-extract-error", test_invalid_archive_reports_extract_error);
 	g_test_add_func ("/gtk3-theme-service/archive-without-theme-css-error", test_archive_without_theme_reports_css_error);
-	g_test_add_func ("/gtk3-theme-service/import-missing-index-theme", test_import_accepts_theme_missing_index_theme);
+	g_test_add_func ("/gtk3-theme-service/import-missing-index-theme", test_import_rejects_theme_missing_index_theme);
 	g_test_add_func ("/gtk3-theme-service/import-missing-desktop-entry", test_import_rejects_index_without_desktop_entry);
 	g_test_add_func ("/gtk3-theme-service/import-unresolved-inherits", test_import_rejects_unresolved_inherits);
 	return g_test_run ();

src/common/text.c

@@ -1695,97 +1695,6 @@ pevent_load (char *filename)
 	return 0;
 }
 
-
-static gboolean
-text_event_uses_color (const char *text, int color)
-{
-	const char *p;
-
-	if (!text || color < 0 || color > 31)
-		return FALSE;
-
-	for (p = text; *p; p++)
-	{
-		int value;
-		int digits;
-
-		if ((unsigned char) *p == 3)
-			p++;
-		else if (*p == '%' && p[1] == 'C')
-			p += 2;
-		else
-			continue;
-
-		if (!g_ascii_isdigit (*p))
-		{
-			p--;
-			continue;
-		}
-
-		value = *p - '0';
-		digits = 1;
-		if (g_ascii_isdigit (p[1]))
-		{
-			value = value * 10 + p[1] - '0';
-			digits = 2;
-		}
-
-		if (value == color)
-			return TRUE;
-
-		p += digits - 1;
-		if (*p == ',' && g_ascii_isdigit (p[1]))
-		{
-			p++;
-			value = *p - '0';
-			if (g_ascii_isdigit (p[1]))
-			{
-				value = value * 10 + p[1] - '0';
-				p++;
-			}
-			if (value == color)
-				return TRUE;
-		}
-	}
-
-	return FALSE;
-}
-
-char **
-text_color_event_names (int color, int *count)
-{
-	GPtrArray *names;
-	int found = 0;
-	int i;
-
-	if (count)
-		*count = 0;
-
-	names = g_ptr_array_new ();
-
-	for (i = 0; i < NUM_XP; i++)
-	{
-		const char *text = pntevts_text[i] ? pntevts_text[i] : te[i].def;
-
-		if (!text_event_uses_color (text, color))
-			continue;
-
-		g_ptr_array_add (names, g_strdup (_(te[i].name)));
-		found++;
-	}
-
-	if (!found)
-	{
-		g_ptr_array_free (names, TRUE);
-		return NULL;
-	}
-
-	g_ptr_array_add (names, NULL);
-	if (count)
-		*count = found;
-	return (char **) g_ptr_array_free (names, FALSE);
-}
-
 static void
 pevent_check_all_loaded (void)
 {
@@ -1900,97 +1809,12 @@ format_event (session *sess, int index, char **args, char *o, gsize sizeofo, uns
 		o[0] = 0;
 }
 
-static char *
-text_event_without_hostmask_format (const char *format, int host_arg)
-{
-	char token[3];
-	const char *arg;
-	const char *open;
-	const char *close;
-	const char *start;
-	char *out;
-	gsize prefix_len;
-
-	g_snprintf (token, sizeof (token), "$%d", host_arg);
-	arg = strstr (format, token);
-	if (!arg)
-		return NULL;
-
-	open = arg;
-	while (open > format && *open != '(' && *open != '\n')
-		open--;
-
-	close = arg + strlen (token);
-	while (*close && *close != ')' && *close != '\n')
-		close++;
-
-	if (*open != '(' || *close != ')')
-		return NULL;
-
-	start = open;
-	if (start > format && start[-1] == ' ')
-		start--;
-
-	prefix_len = start - format;
-	out = g_malloc (prefix_len + strlen (close + 1) + 1);
-	memcpy (out, format, prefix_len);
-	strcpy (out + prefix_len, close + 1);
-	return out;
-}
-
-static void
-display_event_string (session *sess, int event, char **args, char *format,
-						  unsigned int stripcolor_args, time_t timestamp)
-{
-	char *compiled;
-	char *saved;
-	char o[4096];
-	int max_arg;
-
-	if (pevt_build_string (format, &compiled, &max_arg) != 0)
-		return;
-
-	saved = pntevts[event];
-	pntevts[event] = compiled;
-	format_event (sess, event, args, o, sizeof (o), stripcolor_args);
-	pntevts[event] = saved;
-	g_free (compiled);
-
-	if (o[0])
-		PrintTextTimeStamp (sess, o, timestamp);
-}
-
 static void
 display_event (session *sess, int event, char **args, 
 					unsigned int stripcolor_args, time_t timestamp)
 {
 	char o[4096];
-	char *format;
-	char *host;
-	int host_arg;
-
-	if (prefs.hex_irc_hide_join_part_hostmask &&
-		(event == XP_TE_JOIN || event == XP_TE_PART || event == XP_TE_PARTREASON))
-	{
-		host_arg = event == XP_TE_JOIN ? 3 : 2;
-		format = text_event_without_hostmask_format (pntevts_text[event], host_arg);
-		if (format)
-		{
-			display_event_string (sess, event, args, format, stripcolor_args, timestamp);
-			g_free (format);
-			return;
-		}
-
-		host = args[host_arg];
-		args[host_arg] = "";
 	format_event (sess, event, args, o, sizeof (o), stripcolor_args);
-		args[host_arg] = host;
-	}
-	else
-	{
-		format_event (sess, event, args, o, sizeof (o), stripcolor_args);
-	}
-
 	if (o[0])
 		PrintTextTimeStamp (sess, o, timestamp);
 }

src/common/text.h

@@ -53,7 +53,6 @@ int pevt_build_string (const char *input, char **output, int *max_arg);
 int pevent_load (char *filename);
 void pevent_make_pntevts (void);
 int text_color_of (char *name);
-char **text_color_event_names (int color, int *count);
 void text_emit (int index, session *sess, char *a, char *b, char *c, char *d,
 		time_t timestamp);
 int text_emit_by_name (char *name, session *sess, time_t timestamp,

src/common/url.c

@@ -20,14 +20,12 @@
 #include <stdlib.h>
 #include <string.h>
 #include <ctype.h>
-#include <glib.h>
 #include "zoitechat.h"
 #include "zoitechatc.h"
 #include "cfgfiles.h"
 #include "fe.h"
 #include "tree.h"
 #include "url.h"
-#include "public_suffix_data.h"
 #ifdef HAVE_STRINGS_H
 #include <strings.h>
 #endif
@@ -37,7 +35,6 @@ GTree *url_btree = NULL;
 static gboolean regex_match (const GRegex *re, const char *word,
 							 int *start, int *end);
 static const GRegex *re_url (void);
-static const GRegex *re_url_no_scheme (void);
 static const GRegex *re_email (void);
 static const GRegex *re_nick (void);
 static const GRegex *re_channel (void);
@@ -45,8 +42,6 @@ static gboolean match_nick (const char *word, int *start, int *end);
 static gboolean match_channel (const char *word, int *start, int *end);
 static gboolean match_url (const char *word, int *start, int *end);
 static gboolean match_email (const char *word, int *start, int *end);
-static gboolean host_has_public_suffix (const char *host);
-static gboolean host_has_public_suffix_range (const char *word, int start, int end);
 
 static int
 url_free (char *url, void *data)
@@ -271,16 +266,7 @@ match_channel (const char *word, int *start, int *end)
 static gboolean
 match_url (const char *word, int *start, int *end)
 {
-	if (regex_match (re_url (), word, start, end))
-		return TRUE;
-
-	if (!regex_match (re_url_no_scheme (), word, start, end))
-		return FALSE;
-
-	if (*start > 0 && word[*start - 1] == '@')
-		return FALSE;
-
-	return host_has_public_suffix_range (word, *start, *end);
+	return regex_match (re_url (), word, start, end);
 }
 
 static gboolean
@@ -321,7 +307,7 @@ url_check_line (char *buf)
 	for (i = 0; i < ARRAY_SIZE (commands); i++)
 	{
 		char *cmd = commands[i];
-		size_t len = strlen (cmd);
+		int len = strlen (cmd);
 
 		if (strncmp (cmd, po, len) == 0)
 		{
@@ -407,114 +393,6 @@ regex_match (const GRegex *re, const char *word, int *start, int *end)
 	return found;
 }
 
-static gboolean
-host_has_public_suffix_range (const char *word, int start, int end)
-{
-	char *candidate;
-	const char *host_start;
-	const char *host_end;
-	const char *host_colon;
-	gboolean ok;
-	int host_len;
-	char *host;
-
-	candidate = g_strndup (word + start, end - start);
-	host_start = candidate;
-	host_end = candidate + strlen (candidate);
-	if (*host_start == '[')
-	{
-		g_free (candidate);
-		return FALSE;
-	}
-	host_colon = strchr (host_start, ':');
-	if (host_colon)
-		host_end = host_colon;
-	host_colon = strchr (host_start, '/');
-	if (host_colon && host_colon < host_end)
-		host_end = host_colon;
-	host_len = (int)(host_end - host_start);
-	if (host_len <= 0)
-	{
-		g_free (candidate);
-		return FALSE;
-	}
-	host = g_strndup (host_start, host_len);
-	ok = host_has_public_suffix (host);
-	g_free (host);
-	g_free (candidate);
-	return ok;
-}
-
-static GHashTable *
-public_suffix_table (void)
-{
-	static GHashTable *table = NULL;
-	unsigned int i;
-
-	if (table)
-		return table;
-
-	table = g_hash_table_new (g_str_hash, g_str_equal);
-	for (i = 0; i < public_suffix_rules_len; i++)
-	{
-		g_hash_table_add (table, (gpointer)public_suffix_rules[i]);
-	}
-	return table;
-}
-
-static gboolean
-host_has_public_suffix (const char *host)
-{
-	GHashTable *table;
-	gchar **labels;
-	int i;
-	int n;
-	gboolean matched = FALSE;
-
-	if (!strchr (host, '.'))
-		return FALSE;
-
-	labels = g_strsplit (host, ".", -1);
-	for (n = 0; labels[n]; n++)
-	{
-		if (labels[n][0] == '\0')
-		{
-			g_strfreev (labels);
-			return FALSE;
-		}
-	}
-
-	table = public_suffix_table ();
-	for (i = 0; i < n; i++)
-	{
-		char *tail = g_strjoinv (".", &labels[i]);
-		if (g_hash_table_contains (table, tail))
-			matched = TRUE;
-		if (i + 1 < n)
-		{
-			char *tail_wild = g_strjoinv (".", &labels[i + 1]);
-			char *wild = g_strconcat ("*.", tail_wild, NULL);
-			if (g_hash_table_contains (table, wild))
-				matched = TRUE;
-			g_free (tail_wild);
-			g_free (wild);
-		}
-		if (i > 0)
-		{
-			char *exc = g_strconcat ("!", tail, NULL);
-			if (g_hash_table_contains (table, exc))
-				matched = TRUE;
-			g_free (exc);
-		}
-		g_free (tail);
-		if (matched)
-			break;
-	}
-
-	g_strfreev (labels);
-	return matched;
-}
-
 /*	Miscellaneous description --- */
 #define DOMAIN_LABEL "[\\pL\\pN](?:[-\\pL\\pN]{0,61}[\\pL\\pN])?"
 #define DOMAIN DOMAIN_LABEL "(\\." DOMAIN_LABEL ")*"
@@ -599,28 +477,6 @@ re_url (void)
 	return url_ret;
 }
 
-static const GRegex *
-re_url_no_scheme (void)
-{
-	static GRegex *url_ret = NULL;
-	GString *grist_gstr;
-	char *grist;
-
-	if (url_ret) return url_ret;
-
-	grist_gstr = g_string_new (NULL);
-	g_string_append (grist_gstr, "(");
-	g_string_append (grist_gstr, HOST_URL_OPT_TLD OPT_PORT);
-	g_string_append_printf (grist_gstr, "(/" PATH ")?");
-	g_string_append (grist_gstr, ")");
-
-	grist = g_string_free (grist_gstr, FALSE);
-	url_ret = make_re (grist);
-	g_free (grist);
-
-	return url_ret;
-}
-
 #define EMAIL_LOCAL_ATOM "[\\pL\\pN!#$%&'*+/=?^_`{|}~-]+"
 #define EMAIL_LOCAL EMAIL_LOCAL_ATOM "(\\." EMAIL_LOCAL_ATOM ")*"
 #define EMAIL EMAIL_LOCAL "@" DOMAIN TLD

src/common/userlist.h

@@ -31,7 +31,6 @@ struct User
 	char *servername;
 	char *account;
 	time_t lasttalk;
-	time_t typing_time;
 	unsigned int access;	/* axs bit field */
 	char prefix[2]; /* @ + % */
 	unsigned int op:1;
@@ -40,7 +39,6 @@ struct User
 	unsigned int me:1;
 	unsigned int away:1;
 	unsigned int selected:1;
-	unsigned int typing:2;
 };
 
 #define USERACCESS_SIZE 12

src/common/util.c

@@ -98,7 +98,7 @@ path_part (char *file, char *path, int pathlen)
 char *				/* like strstr(), but nocase */
 nocasestrstr (const char *s, const char *wanted)
 {
-	register const size_t len = strlen (wanted);
+	register const int len = strlen (wanted);
 
 	if (len == 0)
 		return (char *)s;

src/common/zoitechat-plugin.h

@@ -2,10 +2,10 @@
  * Copyright (C) 1998-2010 Peter Zelezny.
  * Copyright (C) 2009-2013 Berke Viktor.
  *
- * This program is free software; you can redistribute it and/or
- * modify it under the terms of the GNU General Public License
- * as published by the Free Software Foundation; either version 2
- * of the License, or (at your option) any later version.
+ * This program is free software; you can redistribute it and/or modify
+ * it under the terms of the GNU General Public License as published by
+ * the Free Software Foundation; either version 2 of the License, or
+ * (at your option) any later version.
  *
  * This program is distributed in the hope that it will be useful,
  * but WITHOUT ANY WARRANTY; without even the implied warranty of
@@ -13,8 +13,8 @@
  * GNU General Public License for more details.
  *
  * You should have received a copy of the GNU General Public License
- * along with this program; if not, see
- * <https://www.gnu.org/licenses/>.
+ * along with this program; if not, write to the Free Software
+ * Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301, USA
  */
 
 /* You can distribute this header with your plugins for easy compilation */

src/common/zoitechat.c

@@ -379,8 +379,6 @@ lag_check (void)
 	char tbuf[128];
 	time_t now = time (0);
 	time_t lag;
-	time_t ping_age;
-	unsigned long ping_timeout;
 
 	tim = make_ping_time ();
 
@@ -390,11 +388,8 @@ lag_check (void)
 		if (serv->connected && serv->end_of_motd)
 		{
 			lag = now - serv->ping_recv;
-			ping_timeout = (unsigned long) prefs.hex_net_ping_timeout * 1000;
-			if (serv->lag_sent && prefs.hex_net_ping_timeout != 0
-				 && tim - serv->lag_sent > ping_timeout)
+			if (prefs.hex_net_ping_timeout != 0 && lag > prefs.hex_net_ping_timeout && lag > 0)
 			{
-				lag = (tim - serv->lag_sent) / 1000;
 				sprintf (tbuf, "%" G_GINT64_FORMAT, (gint64) lag);
 				EMIT_SIGNAL (XP_TE_PINGTIMEOUT, serv->server_session, tbuf, NULL,
 								 NULL, NULL, 0);
@@ -402,12 +397,12 @@ lag_check (void)
 					serv->auto_reconnect (serv, FALSE, -1);
 			}
 			else
-			{
-				ping_age = now - serv->ping_recv;
-				if (!serv->lag_sent && prefs.hex_net_lag_check > 0 && ping_age >= prefs.hex_net_lag_check)
 			{
 				g_snprintf (tbuf, sizeof (tbuf), "LAG%lu", tim);
 				serv->p_ping (serv, "", tbuf);
+				
+				if (!serv->lag_sent)
+				{
 					serv->lag_sent = tim;
 					fe_set_lag (serv, -1);
 				}
@@ -530,7 +525,7 @@ zoitechat_reinit_timers (void)
 	if ((prefs.hex_net_ping_timeout != 0 || prefs.hex_gui_lagometer)
 	    && lag_check_tag == 0)
 	{
-		lag_check_tag = fe_timeout_add_seconds (1, zoitechat_lag_check, NULL);
+		lag_check_tag = fe_timeout_add_seconds (30, zoitechat_lag_check, NULL);
 	}
 	else if ((!prefs.hex_net_ping_timeout && !prefs.hex_gui_lagometer)
 					 && lag_check_tag != 0)
@@ -797,13 +792,7 @@ session_free (session *killsess)
 
 	send_quit_or_part (killsess);
 
-	if (killsess->typing_timeout_tag)
-		fe_timeout_remove (killsess->typing_timeout_tag);
-	if (killsess->typing_animation_tag)
-		fe_timeout_remove (killsess->typing_animation_tag);
-
 	history_free (&killsess->history);
-	reply_cache_free (killsess);
 	g_free (killsess->topic);
 	g_free (killsess->current_modes);
 

src/common/zoitechat.h

@@ -133,7 +133,6 @@ struct zoitechatprefs
 	unsigned int hex_gui_input_style;
 	unsigned int hex_gui_join_dialog;
 	unsigned int hex_gui_mode_buttons;
-	unsigned int hex_gui_mode_buttons_inline;
 	unsigned int hex_gui_quit_dialog;
 	/* unsigned int hex_gui_single; */
 	unsigned int hex_gui_slist_fav;
@@ -149,7 +148,6 @@ struct zoitechatprefs
 	unsigned int hex_gui_tab_sort;
 	unsigned int hex_gui_tab_utils;
 	unsigned int hex_gui_topicbar;
-	unsigned int hex_gui_topicbar_multiline;
 	unsigned int hex_gui_tray;
 	unsigned int hex_gui_tray_away;
 	unsigned int hex_gui_tray_blink;
@@ -190,7 +188,6 @@ struct zoitechatprefs
 	unsigned int hex_irc_conf_mode;
 	unsigned int hex_irc_hidehost;
 	unsigned int hex_irc_hide_nickchange;
-	unsigned int hex_irc_hide_join_part_hostmask;
 	unsigned int hex_irc_hide_version;
 	unsigned int hex_irc_invisible;
 	unsigned int hex_irc_logging;
@@ -268,9 +265,7 @@ struct zoitechatprefs
 	int hex_gui_search_pos;
 	int hex_gui_slist_select;
 	int hex_gui_tab_layout;
-	int hex_gui_tab_closebuttons;
 	int hex_gui_tab_middleclose;
-	int hex_gui_mouse_scroll_speed;
 	int hex_gui_tab_newtofront;
 	int hex_gui_tab_pos;
 	int hex_gui_tab_small;
@@ -293,10 +288,6 @@ struct zoitechatprefs
 	int hex_irc_join_delay;
 	int hex_irc_notice_pos;
 	int hex_net_ping_timeout;
-	int hex_net_lag_check;
-	int hex_net_keepalive_idle;
-	int hex_net_keepalive_interval;
-	int hex_net_keepalive_count;
 	int hex_net_proxy_port;
 	int hex_net_proxy_type;				/* 0=disabled, 1=wingate 2=socks4, 3=socks5, 4=http */
 	int hex_net_proxy_use;				/* 0=all 1=IRC_ONLY 2=DCC_ONLY */
@@ -388,14 +379,6 @@ typedef enum {
 	TAB_STATE_NEW_HILIGHT = (1 << 2),
 } tab_state_flags;
 
-typedef struct reply_item
-{
-	char *msgid;
-	char *nick;
-	char *text;
-	time_t timestamp;
-} reply_item;
-
 typedef struct session
 {
 	/* Per-Channel Alerts */
@@ -437,17 +420,8 @@ typedef struct session
 	char *quitreason;
 	char *topic;
 	char *current_modes;					/* free() me */
-	GSList *reply_items;
-	char *reply_msgid;
-	char *reply_target;
-	char *reply_nick;
-	char *reply_text;
 
 	int mode_timeout_tag;
-	int typing_timeout_tag;
-	int typing_status;
-	int typing_animation_tag;
-	int typing_animation_frame;
 
 	struct session *lastlog_sess;
 	struct nbexec *running_exec;
@@ -511,8 +485,6 @@ typedef struct server
 	void (*p_set_back)(struct server *);
 	void (*p_set_away)(struct server *, char *reason);
 	void (*p_message)(struct server *, char *channel, char *text);
-	void (*p_message_tagged)(struct server *, char *tags, char *channel, char *text);
-	void (*p_tagmsg)(struct server *, char *tags, char *target);
 	void (*p_action)(struct server *, char *channel, char *act);
 	void (*p_notice)(struct server *, char *channel, char *text);
 	void (*p_topic)(struct server *, char *channel, char *topic);
@@ -562,7 +534,6 @@ typedef struct server
 	int loginmethod;					/* see login_types[] */
 
 	char *chantypes;					/* for 005 numeric - free me */
-	char *clienttagdeny;
 	char *chanmodes;					/* for 005 numeric - free me */
 	char *nick_prefixes;				/* e.g. "*@%+" */
 	char *nick_modes;					/* e.g. "aohv" */
@@ -625,8 +596,6 @@ typedef struct server
 	unsigned int have_extjoin:1;	/* cap extended-join */
 	unsigned int have_account_tag:1;	/* cap account-tag */
 	unsigned int have_server_time:1;	/* cap server-time */
-	unsigned int have_message_tags:1;
-	unsigned int have_echo_message:1;
 	unsigned int have_sasl:1;		/* SASL capability */
 	unsigned int have_except:1;	/* ban exemptions +e */
 	unsigned int have_invite:1;	/* invite exemptions +I */

src/fe-gtk/chanlist.c

@@ -452,7 +452,7 @@ void
 fe_add_chan_list (server *serv, char *chan, char *users, char *topic)
 {
 	chanlistrow *next_row;
-	size_t len = strlen (chan) + 1;
+	int len = strlen (chan) + 1;
 
 	/* we allocate the struct and channel string in one go */
 	next_row = g_malloc (sizeof (chanlistrow) + len);

src/fe-gtk/chanview-tabs.c

@@ -27,6 +27,8 @@ typedef struct
 	GtkWidget *b2;		/* button2 */
 } tabview;
 
+#define ICON_CHANVIEW_CLOSE "gtk-close"
+
 static void chanview_populate (chanview *cv);
 
 /* ignore "toggled" signal? */
@@ -61,19 +63,28 @@ static tab_scroll_animation *tab_right_animation;
  */
 
 static inline gint
-cv_tabs_get_viewport_size (GtkAdjustment *adj)
+cv_tabs_get_viewport_size (GdkWindow *parent_win, gboolean vertical)
 {
-	return (gint) gtk_adjustment_get_page_size (adj);
+	gint viewport_size = 0;
+
+	if (vertical)
+		viewport_size = gdk_window_get_height (parent_win);
+	else
+		viewport_size = gdk_window_get_width (parent_win);
+
+	return viewport_size;
 }
 
 static void
 cv_tabs_sizealloc (GtkWidget *widget, GtkAllocation *allocation, chanview *cv)
 {
+	GdkWindow *parent_win;
 	GtkAdjustment *adj;
 	GtkWidget *inner;
 	gint viewport_size;
 
 	inner = ((tabview *)cv)->inner;
+	parent_win = gtk_widget_get_window (gtk_widget_get_parent (inner));
 
 	if (cv->vertical)
 	{
@@ -83,19 +94,15 @@ cv_tabs_sizealloc (GtkWidget *widget, GtkAllocation *allocation, chanview *cv)
 		adj = gtk_scrollable_get_hadjustment (GTK_SCROLLABLE (gtk_widget_get_parent (inner)));
 	}
 
-	viewport_size = cv_tabs_get_viewport_size (adj);
+	viewport_size = cv_tabs_get_viewport_size (parent_win, cv->vertical);
 
 	if (gtk_adjustment_get_upper (adj) <= viewport_size)
 	{
-		if (((tabview *)cv)->b1)
 		gtk_widget_hide (((tabview *)cv)->b1);
-		if (((tabview *)cv)->b2)
 		gtk_widget_hide (((tabview *)cv)->b2);
 	} else
 	{
-		if (((tabview *)cv)->b1)
 		gtk_widget_show (((tabview *)cv)->b1);
-		if (((tabview *)cv)->b2)
 		gtk_widget_show (((tabview *)cv)->b2);
 	}
 }
@@ -236,8 +243,10 @@ tab_scroll_left_up_clicked (GtkWidget *widget, chanview *cv)
 	gint viewport_size;
 	gfloat new_value;
 	GtkWidget *inner;
+	GdkWindow *parent_win;
 
 	inner = ((tabview *)cv)->inner;
+	parent_win = gtk_widget_get_window (gtk_widget_get_parent (inner));
 
 	if (cv->vertical)
 	{
@@ -247,7 +256,7 @@ tab_scroll_left_up_clicked (GtkWidget *widget, chanview *cv)
 		adj = gtk_scrollable_get_hadjustment (GTK_SCROLLABLE (gtk_widget_get_parent(inner)));
 	}
 
-	viewport_size = cv_tabs_get_viewport_size (adj);
+	viewport_size = cv_tabs_get_viewport_size (parent_win, cv->vertical);
 
 	new_value = tab_search_offset (inner, gtk_adjustment_get_value (adj), 0, cv->vertical);
 
@@ -272,8 +281,10 @@ tab_scroll_right_down_clicked (GtkWidget *widget, chanview *cv)
 	gint viewport_size;
 	gfloat new_value;
 	GtkWidget *inner;
+	GdkWindow *parent_win;
 
 	inner = ((tabview *)cv)->inner;
+	parent_win = gtk_widget_get_window (gtk_widget_get_parent (inner));
 
 	if (cv->vertical)
 	{
@@ -283,7 +294,7 @@ tab_scroll_right_down_clicked (GtkWidget *widget, chanview *cv)
 		adj = gtk_scrollable_get_hadjustment (GTK_SCROLLABLE (gtk_widget_get_parent(inner)));
 	}
 
-	viewport_size = cv_tabs_get_viewport_size (adj);
+	viewport_size = cv_tabs_get_viewport_size (parent_win, cv->vertical);
 
 	new_value = tab_search_offset (inner, gtk_adjustment_get_value (adj), 1, cv->vertical);
 
@@ -304,44 +315,76 @@ tab_scroll_right_down_clicked (GtkWidget *widget, chanview *cv)
 static gboolean
 tab_scroll_cb (GtkWidget *widget, GdkEventScroll *event, gpointer cv)
 {
-	int direction = cv_scroll_direction (event);
-	int i;
-
 	if (prefs.hex_gui_tab_scrollchans)
 	{
-		if (direction != 0)
-		{
-			for (i = 0; i < cv_scroll_step_count (); i++)
-				mg_switch_page (1, direction);
-			return TRUE;
-		}
+		if (event->direction == GDK_SCROLL_DOWN)
+			mg_switch_page (1, 1);
+		else if (event->direction == GDK_SCROLL_UP)
+			mg_switch_page (1, -1);
 	}
 	else
 	{
-		if (direction < 0)
-		{
-			for (i = 0; i < cv_scroll_step_count (); i++)
+		/* mouse wheel scrolling */
+		if (event->direction == GDK_SCROLL_UP)
 			tab_scroll_left_up_clicked (widget, cv);
-			return TRUE;
-		}
-		else if (direction > 0)
-		{
-			for (i = 0; i < cv_scroll_step_count (); i++)
+		else if (event->direction == GDK_SCROLL_DOWN)
 			tab_scroll_right_down_clicked (widget, cv);
-			return TRUE;
-		}
 	}
 
 	return FALSE;
 }
 
+static void
+cv_tabs_xclick_cb (GtkWidget *button, chanview *cv)
+{
+	cv->cb_xbutton (cv, cv->focused, cv->focused->tag, cv->focused->userdata);
+}
+
+/* make a Scroll (arrow) button */
+
+static GtkWidget *
+make_sbutton (GtkArrowType type, void *click_cb, void *userdata)
+{
+	GtkWidget *button, *arrow;
+	const char *icon_name = "pan-end-symbolic";
+
+	button = gtk_button_new ();
+	switch (type)
+	{
+	case GTK_ARROW_UP:
+		icon_name = "pan-up-symbolic";
+		break;
+	case GTK_ARROW_DOWN:
+		icon_name = "pan-down-symbolic";
+		break;
+	case GTK_ARROW_LEFT:
+		icon_name = "pan-start-symbolic";
+		break;
+	case GTK_ARROW_RIGHT:
+	default:
+		icon_name = "pan-end-symbolic";
+		break;
+	}
+
+	arrow = gtk_image_new_from_icon_name (icon_name, GTK_ICON_SIZE_BUTTON);
+	gtk_container_add (GTK_CONTAINER (button), arrow);
+	gtk_button_set_relief (GTK_BUTTON (button), GTK_RELIEF_NONE);
+	g_signal_connect (G_OBJECT (button), "clicked",
+							G_CALLBACK (click_cb), userdata);
+	g_signal_connect (G_OBJECT (button), "scroll-event",
+							G_CALLBACK (tab_scroll_cb), userdata);
+	gtk_widget_show (arrow);
+
+	return button;
+}
+
 static void
 cv_tabs_init (chanview *cv)
 {
-	GtkWidget *box;
+	GtkWidget *box, *hbox = NULL;
 	GtkWidget *viewport;
 	GtkWidget *outer;
-	GtkWidget *tree;
+	GtkWidget *button;
 
 	if (cv->vertical)
 	{
@@ -356,19 +399,12 @@ cv_tabs_init (chanview *cv)
 							G_CALLBACK (cv_tabs_sizealloc), cv);
 	gtk_widget_show (outer);
 
-	viewport = gtk_scrolled_window_new (0, 0);
-	gtk_scrolled_window_set_shadow_type (GTK_SCROLLED_WINDOW (viewport), GTK_SHADOW_NONE);
+	viewport = gtk_viewport_new (0, 0);
+	gtk_viewport_set_shadow_type (GTK_VIEWPORT (viewport), GTK_SHADOW_NONE);
 	if (cv->vertical)
-		gtk_scrolled_window_set_policy (GTK_SCROLLED_WINDOW (viewport),
-												  GTK_POLICY_NEVER, GTK_POLICY_AUTOMATIC);
+		gtk_widget_set_size_request (viewport, -1, 1);
 	else
-		gtk_scrolled_window_set_policy (GTK_SCROLLED_WINDOW (viewport),
-												  GTK_POLICY_AUTOMATIC, GTK_POLICY_NEVER);
-	gtk_scrolled_window_set_min_content_width (GTK_SCROLLED_WINDOW (viewport), 1);
-	gtk_scrolled_window_set_min_content_height (GTK_SCROLLED_WINDOW (viewport), 1);
-	gtk_widget_set_hexpand (viewport, TRUE);
-	gtk_widget_set_vexpand (viewport, TRUE);
-	cv_add_scroll_events (viewport);
+		gtk_widget_set_size_request (viewport, 1, -1);
 	g_signal_connect (G_OBJECT (viewport), "scroll-event",
 							G_CALLBACK (tab_scroll_cb), cv);
 	gtk_box_pack_start (GTK_BOX (outer), viewport, 1, 1, 0);
@@ -386,10 +422,39 @@ cv_tabs_init (chanview *cv)
 	gtk_container_add (GTK_CONTAINER (viewport), box);
 	gtk_widget_show (box);
 
-	tree = gtk_tree_view_new_with_model (GTK_TREE_MODEL (cv->store));
-	gtk_widget_set_name (tree, "zoitechat-tree");
-	gtk_widget_set_no_show_all (tree, TRUE);
-	gtk_box_pack_start (GTK_BOX (outer), tree, 0, 0, 0);
+	/* if vertical, the buttons can be side by side */
+	if (cv->vertical)
+	{
+		hbox = gtkutil_box_new (GTK_ORIENTATION_HORIZONTAL, FALSE, 0);
+		gtk_box_pack_start (GTK_BOX (outer), hbox, 0, 0, 0);
+		gtk_widget_show (hbox);
+	}
+
+	/* make the Scroll buttons */
+	((tabview *)cv)->b2 = make_sbutton (cv->vertical ?
+													GTK_ARROW_UP : GTK_ARROW_LEFT,
+													tab_scroll_left_up_clicked,
+													cv);
+
+	((tabview *)cv)->b1 = make_sbutton (cv->vertical ?
+													GTK_ARROW_DOWN : GTK_ARROW_RIGHT,
+													tab_scroll_right_down_clicked,
+													cv);
+
+	if (hbox)
+	{
+		gtk_container_add (GTK_CONTAINER (hbox), ((tabview *)cv)->b2);
+		gtk_container_add (GTK_CONTAINER (hbox), ((tabview *)cv)->b1);
+	} else
+	{
+		gtk_box_pack_start (GTK_BOX (outer), ((tabview *)cv)->b2, 0, 0, 0);
+		gtk_box_pack_start (GTK_BOX (outer), ((tabview *)cv)->b1, 0, 0, 0);
+	}
+
+	button = gtkutil_button (outer, ICON_CHANVIEW_CLOSE, NULL, cv_tabs_xclick_cb,
+									 cv, 0);
+	gtk_button_set_relief (GTK_BUTTON (button), GTK_RELIEF_NONE);
+	gtk_widget_set_can_focus (button, FALSE);
 
 	gtk_container_add (GTK_CONTAINER (cv->box), outer);
 }
@@ -594,135 +659,20 @@ tab_toggled_cb (GtkToggleButton *tab, chan *ch)
 static gboolean
 tab_click_cb (GtkWidget *wid, GdkEventButton *event, chan *ch)
 {
-	GtkWidget *close_button;
-	gint close_x;
-	gint close_y;
-	GtkAllocation close_alloc;
-
-	if (event->button == 1 && event->type == GDK_BUTTON_PRESS)
-	{
-		close_button = g_object_get_data (G_OBJECT (wid), "tab-close-button");
-		if (prefs.hex_gui_tab_closebuttons && close_button &&
-			gtk_widget_translate_coordinates (close_button, wid, 0, 0, &close_x, &close_y))
-		{
-			gtk_widget_get_allocation (close_button, &close_alloc);
-			if (event->x >= close_x && event->x < close_x + close_alloc.width &&
-				event->y >= close_y && event->y < close_y + close_alloc.height)
-			{
-				ch->cv->cb_xbutton (ch->cv, ch, ch->tag, ch->userdata);
-				return TRUE;
-			}
-		}
-	}
-
 	return ch->cv->cb_contextmenu (ch->cv, ch, ch->tag, ch->userdata, event);
 }
 
-static gboolean
-tab_close_motion_cb (GtkWidget *wid, GdkEventMotion *event, chan *ch)
-{
-	GtkWidget *close_button;
-	gint close_x;
-	gint close_y;
-	GtkAllocation close_alloc;
-	gboolean hover = FALSE;
-
-	close_button = g_object_get_data (G_OBJECT (wid), "tab-close-button");
-	if (prefs.hex_gui_tab_closebuttons && close_button &&
-		gtk_widget_translate_coordinates (close_button, wid, 0, 0, &close_x, &close_y))
-	{
-		gtk_widget_get_allocation (close_button, &close_alloc);
-		hover = event->x >= close_x && event->x < close_x + close_alloc.width &&
-			event->y >= close_y && event->y < close_y + close_alloc.height;
-	}
-
-	if (hover)
-	{
-		GdkCursor *cursor;
-		gtk_widget_set_state_flags (close_button, GTK_STATE_FLAG_PRELIGHT, TRUE);
-		if (gtk_widget_get_window (wid))
-		{
-			cursor = gdk_cursor_new_for_display (gtk_widget_get_display (wid), GDK_HAND2);
-			gdk_window_set_cursor (gtk_widget_get_window (wid), cursor);
-			g_object_unref (cursor);
-		}
-	}
-	else
-	{
-		gtk_widget_unset_state_flags (close_button, GTK_STATE_FLAG_PRELIGHT);
-		if (gtk_widget_get_window (wid))
-			gdk_window_set_cursor (gtk_widget_get_window (wid), NULL);
-	}
-
-	return FALSE;
-}
-
-static gboolean
-tab_close_leave_cb (GtkWidget *wid, GdkEventCrossing *event, chan *ch)
-{
-	GtkWidget *close_button;
-
-	close_button = g_object_get_data (G_OBJECT (wid), "tab-close-button");
-	if (prefs.hex_gui_tab_closebuttons && close_button)
-		gtk_widget_unset_state_flags (close_button, GTK_STATE_FLAG_PRELIGHT);
-	if (gtk_widget_get_window (wid))
-		gdk_window_set_cursor (gtk_widget_get_window (wid), NULL);
-	return FALSE;
-}
-
-static GtkWidget *
-tab_get_label (GtkWidget *tab)
-{
-	GtkWidget *label;
-
-	label = g_object_get_data (G_OBJECT (tab), "tab-label");
-	if (label)
-		return label;
-
-	return gtk_bin_get_child (GTK_BIN (tab));
-}
-
 static void *
 cv_tabs_add (chanview *cv, chan *ch, char *name, GtkTreeIter *parent)
 {
 	GtkWidget *but;
-	GtkWidget *hbox;
-	GtkWidget *label;
-	GtkWidget *close_button;
-	GtkWidget *close_icon;
 
-	but = gtk_toggle_button_new ();
+	but = gtk_toggle_button_new_with_label (name);
 	gtk_widget_set_name (but, "zoitechat-tab");
-	gtk_widget_set_size_request (but, -1, 14);
-	gtk_widget_add_events (but, GDK_POINTER_MOTION_MASK | GDK_LEAVE_NOTIFY_MASK);
-	cv_add_scroll_events (but);
-	hbox = gtk_box_new (GTK_ORIENTATION_HORIZONTAL, 2);
-	label = gtk_label_new (name);
-	close_button = gtk_button_new ();
-	cv_add_scroll_events (close_button);
-	gtk_style_context_add_class (gtk_widget_get_style_context (close_button), "flat");
-	close_icon = gtk_image_new_from_icon_name ("window-close-symbolic", GTK_ICON_SIZE_MENU);
-	gtk_image_set_pixel_size (GTK_IMAGE (close_icon), 8);
-	gtk_button_set_always_show_image (GTK_BUTTON (close_button), TRUE);
-	gtk_widget_set_can_focus (close_button, FALSE);
-	gtk_container_add (GTK_CONTAINER (close_button), close_icon);
-	gtk_box_pack_start (GTK_BOX (hbox), label, TRUE, TRUE, 0);
-	gtk_box_pack_end (GTK_BOX (hbox), close_button, FALSE, FALSE, 0);
-	gtk_container_add (GTK_CONTAINER (but), hbox);
-	g_object_set_data (G_OBJECT (but), "tab-label", label);
-	g_object_set_data (G_OBJECT (but), "tab-close-button", close_button);
 	g_object_set_data (G_OBJECT (but), "c", ch);
 	/* used to trap right-clicks */
 	g_signal_connect (G_OBJECT (but), "button-press-event",
 						 	G_CALLBACK (tab_click_cb), ch);
-	g_signal_connect (G_OBJECT (but), "scroll-event",
-							G_CALLBACK (tab_scroll_cb), cv);
-	g_signal_connect (G_OBJECT (close_button), "scroll-event",
-							G_CALLBACK (tab_scroll_cb), cv);
-	g_signal_connect (G_OBJECT (but), "motion-notify-event",
-						 	G_CALLBACK (tab_close_motion_cb), ch);
-	g_signal_connect (G_OBJECT (but), "leave-notify-event",
-						 	G_CALLBACK (tab_close_leave_cb), ch);
 	/* avoid prelights */
 	g_signal_connect (G_OBJECT (but), "enter-notify-event",
 						 	G_CALLBACK (tab_ignore_cb), NULL);
@@ -734,9 +684,6 @@ cv_tabs_add (chanview *cv, chan *ch, char *name, GtkTreeIter *parent)
 	g_signal_connect (G_OBJECT (but), "toggled",
 						 	G_CALLBACK (tab_toggled_cb), ch);
 	g_object_set_data (G_OBJECT (but), "u", ch->userdata);
-	gtk_widget_show_all (hbox);
-	if (!prefs.hex_gui_tab_closebuttons)
-		gtk_widget_hide (close_button);
 
 	tab_add_real (cv, but, ch);
 
@@ -945,7 +892,7 @@ cv_tabs_cleanup (chanview *cv)
 static void
 cv_tabs_set_color (chan *ch, PangoAttrList *list)
 {
-	gtk_label_set_attributes (GTK_LABEL (tab_get_label (ch->impl)), list);
+	gtk_label_set_attributes (GTK_LABEL (gtk_bin_get_child (GTK_BIN (ch->impl))), list);
 }
 
 static void
@@ -954,16 +901,16 @@ cv_tabs_rename (chan *ch, char *name)
 	PangoAttrList *attr;
 	GtkWidget *tab = ch->impl;
 
-	attr = gtk_label_get_attributes (GTK_LABEL (tab_get_label (tab)));
+	attr = gtk_label_get_attributes (GTK_LABEL (gtk_bin_get_child (GTK_BIN (tab))));
 	if (attr)
 		pango_attr_list_ref (attr);
 
-	gtk_label_set_text (GTK_LABEL (tab_get_label (tab)), name);
+	gtk_button_set_label (GTK_BUTTON (tab), name);
 	gtk_widget_queue_resize (gtk_widget_get_parent(gtk_widget_get_parent(gtk_widget_get_parent(tab))));
 
 	if (attr)
 	{
-		gtk_label_set_attributes (GTK_LABEL (tab_get_label (tab)), attr);
+		gtk_label_set_attributes (GTK_LABEL (gtk_bin_get_child (GTK_BIN (tab))), attr);
 		pango_attr_list_unref (attr);
 	}
 }

src/fe-gtk/chanview-tree.c

@@ -45,8 +45,6 @@ cv_tree_sel_cb (GtkTreeSelection *sel, chanview *cv)
 	GtkTreeModel *model;
 	GtkTreeIter prev_iter;
 	GtkTreeIter iter;
-	GtkTreePath *path;
-	GtkTreeView *view;
 	chan *ch;
 	chan *prev_ch;
 	gboolean has_prev;
@@ -62,20 +60,6 @@ cv_tree_sel_cb (GtkTreeSelection *sel, chanview *cv)
 		if (has_prev)
 		{
 			gtk_tree_model_get (model, &prev_iter, COL_CHAN, &prev_ch, -1);
-			if (prev_ch != ch && gtk_tree_store_is_ancestor (cv->store, &iter, &prev_iter))
-			{
-				view = gtk_tree_selection_get_tree_view (sel);
-				path = gtk_tree_model_get_path (model, &iter);
-				if (path)
-				{
-					if (!gtk_tree_view_row_expanded (view, path))
-					{
-						gtk_tree_path_free (path);
-						return;
-					}
-					gtk_tree_path_free (path);
-				}
-			}
 			if (prev_ch != ch)
 				gtk_tree_store_set (cv->store, &prev_iter, COL_UNDERLINE, PANGO_UNDERLINE_NONE, -1);
 		}
@@ -111,14 +95,12 @@ cv_tree_scroll_event_cb (GtkWidget *widget, GdkEventScroll *event, gpointer user
 {
 	if (prefs.hex_gui_tab_scrollchans)
 	{
-		int direction = cv_scroll_direction (event);
-		int i;
+		if (event->direction == GDK_SCROLL_DOWN)
+			mg_switch_page (1, 1);
+		else if (event->direction == GDK_SCROLL_UP)
+			mg_switch_page (1, -1);
 
-		if (direction != 0)
-			for (i = 0; i < cv_scroll_step_count (); i++)
-				mg_switch_page (1, direction);
-
-		return direction != 0;
+		return TRUE;
 	}
 
 	return FALSE;
@@ -143,7 +125,6 @@ cv_tree_init (chanview *cv)
 	win = gtk_scrolled_window_new (0, 0);
 	gtk_widget_set_hexpand (win, TRUE);
 	gtk_widget_set_vexpand (win, TRUE);
-	cv_add_scroll_events (win);
 
 	/*gtk_container_set_border_width (GTK_CONTAINER (win), 1);*/
 	gtk_scrolled_window_set_shadow_type (GTK_SCROLLED_WINDOW (win),
@@ -157,7 +138,6 @@ cv_tree_init (chanview *cv)
 	view = gtk_tree_view_new_with_model (GTK_TREE_MODEL (cv->store));
 	gtk_widget_set_hexpand (view, TRUE);
 	gtk_widget_set_vexpand (view, TRUE);
-	cv_add_scroll_events (view);
 	gtk_widget_set_name (view, "zoitechat-tree");
 	{
 		ThemeWidgetStyleValues style_values;

src/fe-gtk/chanview.c

@@ -79,8 +79,6 @@ struct _chanview
 	guint theme_listener_id;
 };
 
-static void chanview_set_font_desc (chanview *cv, const PangoFontDescription *font_desc);
-
 struct _chan
 {
 	chanview *cv;	/* our owner */
@@ -97,46 +95,6 @@ static chan *cv_find_chan_by_number (chanview *cv, int num);
 static int cv_find_number_of_chan (chanview *cv, chan *find_ch);
 static void cv_find_neighbors_for_removal (chanview *cv, chan *find_ch, chan **left_ch, chan **first_ch);
 
-static void
-cv_add_scroll_events (GtkWidget *widget)
-{
-	gtk_widget_add_events (widget, GDK_SCROLL_MASK | GDK_SMOOTH_SCROLL_MASK);
-}
-
-static int
-cv_scroll_direction (GdkEventScroll *event)
-{
-	gdouble dx;
-	gdouble dy;
-
-	if (event->direction == GDK_SCROLL_SMOOTH && gdk_event_get_scroll_deltas ((GdkEvent *) event, &dx, &dy))
-	{
-		if (dy > 0)
-			return 1;
-		if (dy < 0)
-			return -1;
-	}
-
-	switch (event->direction)
-	{
-	case GDK_SCROLL_DOWN:
-		return 1;
-	case GDK_SCROLL_UP:
-		return -1;
-	default:
-		return 0;
-	}
-}
-
-static int
-cv_scroll_step_count (void)
-{
-	int speed = prefs.hex_gui_mouse_scroll_speed;
-	if (speed < 1)
-		speed = 1;
-	return (speed + 9) / 10;
-}
-
 
 /* ======= TABS ======= */
 
@@ -171,10 +129,9 @@ chanview_apply_theme (chanview *cv)
 	w = GTK_WIDGET (tv->tree);
 	if (input_style)
 		font = input_style->font_desc;
-	chanview_set_font_desc (cv, font);
 
 	theme_manager_apply_channel_tree_style (w,
-			theme_manager_get_channel_tree_palette_behavior (cv->font_desc));
+			theme_manager_get_channel_tree_palette_behavior (font));
 }
 
 static void
@@ -316,14 +273,6 @@ chanview_free_ch (chanview *cv, GtkTreeIter *iter)
 	g_free (ch);
 }
 
-static void
-chanview_set_font_desc (chanview *cv, const PangoFontDescription *font_desc)
-{
-	if (cv->font_desc)
-		pango_font_description_free (cv->font_desc);
-	cv->font_desc = font_desc ? pango_font_description_copy (font_desc) : NULL;
-}
-
 static void
 chanview_destroy_store (chanview *cv)	/* free every (chan *) in the store */
 {
@@ -346,9 +295,6 @@ chanview_destroy (chanview *cv)
 	if (cv->box)
 		gtk_widget_destroy (cv->box);
 
-	if (cv->font_desc)
-		pango_font_description_free (cv->font_desc);
-
 	chanview_destroy_store (cv);
 	g_free (cv);
 }
@@ -370,7 +316,7 @@ chanview_new (int type, int trunc_len, gboolean sort, gboolean use_icons,
 	cv = g_new0 (chanview, 1);
 	cv->store = gtk_tree_store_new (5, G_TYPE_STRING, G_TYPE_POINTER,
 							  PANGO_TYPE_ATTR_LIST, GDK_TYPE_PIXBUF, G_TYPE_INT);
-	cv->font_desc = font_desc ? pango_font_description_copy (font_desc) : NULL;
+	cv->font_desc = font_desc;
 	cv->box = gtk_box_new (GTK_ORIENTATION_HORIZONTAL, 0);
 	cv->trunc_len = trunc_len;
 	cv->sorted = sort;

src/fe-gtk/fe-gtk.c

@@ -124,25 +124,6 @@ create_msg_dialog (gchar *title, gchar *message)
 
 static char *win32_argv0_dir;
 
-static void
-win32_set_appusermodelid (void)
-{
-	HMODULE shell32;
-	HRESULT (WINAPI *set_appid) (PCWSTR);
-
-	shell32 = GetModuleHandleW (L"shell32.dll");
-	if (!shell32)
-		shell32 = LoadLibraryW (L"shell32.dll");
-	if (!shell32)
-		return;
-
-	set_appid = (HRESULT (WINAPI *) (PCWSTR)) GetProcAddress (shell32, "SetCurrentProcessExplicitAppUserModelID");
-	if (!set_appid)
-		return;
-
-	set_appid (L"ZoiteChat.Desktop.Notify");
-}
-
 static void
 win32_set_gsettings_schema_dir (void)
 {
@@ -441,7 +422,6 @@ fe_args (int argc, char *argv[])
 
 #ifdef WIN32
 	win32_set_gsettings_schema_dir ();
-	win32_set_appusermodelid ();
 	win32_configure_pixbuf_loaders ();
 
 	/* this is mainly for irc:// URL handling. When windows calls us from */
@@ -812,19 +792,18 @@ fe_set_topic (session *sess, char *topic, char *stripped_topic)
 {
 	if (!sess->gui->is_tab || sess == current_tab)
 	{
-		GtkTextBuffer *topic_buffer;
-		GtkTextIter start;
-
-		topic_buffer = gtk_text_view_get_buffer (GTK_TEXT_VIEW (sess->gui->topic_entry));
 		if (prefs.hex_text_stripcolor_topic)
-			gtk_text_buffer_set_text (topic_buffer, stripped_topic, -1);
+		{
+			gtk_text_buffer_set_text (
+				gtk_text_view_get_buffer (GTK_TEXT_VIEW (sess->gui->topic_entry)),
+				stripped_topic, -1);
+		}
 		else
-			gtk_text_buffer_set_text (topic_buffer, topic, -1);
-
-		gtk_text_buffer_get_start_iter (topic_buffer, &start);
-		gtk_text_buffer_place_cursor (topic_buffer, &start);
-		gtk_text_view_scroll_to_iter (GTK_TEXT_VIEW (sess->gui->topic_entry),
-			&start, 0.0, FALSE, 0.0, 0.0);
+		{
+			gtk_text_buffer_set_text (
+				gtk_text_view_get_buffer (GTK_TEXT_VIEW (sess->gui->topic_entry)),
+				topic, -1);
+		}
 		mg_set_topic_tip (sess);
 	}
 	else
@@ -1329,33 +1308,16 @@ maybe_escape_uri (const char *uri)
 	return g_strdup (uri);
 }
 
-#ifndef WIN32
-static gchar **
-fe_open_url_env_sanitized (void)
-{
-	gchar **env = g_get_environ ();
-	const char *vars[] = {"LD_LIBRARY_PATH", "LD_PRELOAD", "APPDIR", "APPIMAGE", "ARGV0", NULL};
-	int i;
-
-	for (i = 0; vars[i]; i++)
-	{
-		gchar **tmp_env = env;
-		env = g_environ_unsetenv (tmp_env, vars[i]);
-		if (env != tmp_env)
-			g_strfreev (tmp_env);
-	}
-
-	return env;
-}
-#endif
-
 static void
 fe_open_url_inner (const char *url)
 {
 	GError *error = NULL;
 	char *escaped_url = maybe_escape_uri (url);
-	gboolean opened = FALSE;
+	gboolean opened = g_app_info_launch_default_for_uri (escaped_url, NULL, &error);
 
+	if (!opened)
+	{
+		g_clear_error (&error);
 #ifdef WIN32
 		gunichar2 *url_utf16 = g_utf8_to_utf16 (escaped_url, -1, NULL, NULL, NULL);
 
@@ -1364,17 +1326,22 @@ fe_open_url_inner (const char *url)
 			opened = ((INT_PTR) ShellExecuteW (0, L"open", url_utf16, NULL, NULL, SW_SHOWNORMAL)) > 32;
 			g_free (url_utf16);
 		}
-
-	if (!opened)
-	{
-		opened = g_app_info_launch_default_for_uri (escaped_url, NULL, &error);
-		if (!opened)
-			g_clear_error (&error);
-	}
 #else
-	{
 		gchar *xdg_open_argv[] = {(gchar *) "xdg-open", escaped_url, NULL};
-		gchar **spawn_env = fe_open_url_env_sanitized ();
+		gchar **spawn_env = NULL;
+
+		spawn_env = g_get_environ ();
+		{
+			gchar **tmp_env = spawn_env;
+			spawn_env = g_environ_unsetenv (tmp_env, "LD_LIBRARY_PATH");
+			if (spawn_env != tmp_env)
+				g_strfreev (tmp_env);
+
+			tmp_env = spawn_env;
+			spawn_env = g_environ_unsetenv (tmp_env, "LD_PRELOAD");
+			if (spawn_env != tmp_env)
+				g_strfreev (tmp_env);
+		}
 
 		if (g_spawn_async (NULL, xdg_open_argv, spawn_env,
 							 G_SPAWN_SEARCH_PATH | G_SPAWN_STDOUT_TO_DEV_NULL | G_SPAWN_STDERR_TO_DEV_NULL,
@@ -1387,16 +1354,6 @@ fe_open_url_inner (const char *url)
 			g_clear_error (&error);
 		}
 
-		g_strfreev (spawn_env);
-	}
-
-	if (!opened)
-	{
-		opened = g_app_info_launch_default_for_uri (escaped_url, NULL, &error);
-		if (!opened)
-			g_clear_error (&error);
-	}
-
 		if (!opened && gtk_show_uri_on_window (NULL, escaped_url, GDK_CURRENT_TIME, &error))
 		{
 			opened = TRUE;
@@ -1405,7 +1362,10 @@ fe_open_url_inner (const char *url)
 		{
 			g_clear_error (&error);
 		}
+
+		g_strfreev (spawn_env);
 #endif
+	}
 
 	if (!opened)
 	{

src/fe-gtk/fe-gtk.h

@@ -163,8 +163,6 @@ typedef struct session_gui
 		*op_xpm,			/* icon to the left of nickname */
 		*namelistinfo,	/* label above userlist */
 		*input_box,
-		*reply_box,
-		*reply_label,
 		*flag_wid[NUM_FLAG_WIDS],		/* channelmode buttons */
 		*limit_entry,		  /* +l */
 		*key_entry;		  /* +k */

src/fe-gtk/fkeys.c

@@ -60,7 +60,6 @@
 #define ICON_FKEYS_DELETE "edit-delete"
 #define ICON_FKEYS_CANCEL "dialog-cancel"
 #define ICON_FKEYS_SAVE "document-save"
-#define ICON_FKEYS_RESET "edit-undo"
 
 static void replace_handle (GtkWidget * wid);
 void key_check_replace_on_change (GtkEditable *editable, gpointer data);
@@ -81,7 +80,7 @@ void key_action_tab_clean (void);
  */
 
 /* Remember that the *number* of actions is this *plus* 1 --AGL */
-#define KEY_MAX_ACTIONS 16
+#define KEY_MAX_ACTIONS 14
 
 struct key_binding
 {
@@ -106,10 +105,7 @@ struct gcomp_data
 };
 
 static int key_load_kbs (void);
-static int key_load_kbs_from_buffer (char *ibuf, off_t size, GSList **out_list);
 static int key_save_kbs (void);
-static void key_dialog_load (GtkListStore *store);
-static void key_dialog_reset (GtkWidget *wid, gpointer userdata);
 static int key_action_handle_command (GtkWidget * wid, GdkEventKey * evt,
 												  char *d1, char *d2,
 												  struct session *sess);
@@ -146,13 +142,6 @@ static int key_action_move_tab_family_right (GtkWidget * wid, GdkEventKey * evt,
 static int key_action_put_history (GtkWidget * wid, GdkEventKey * evt,
 												  char *d1, char *d2,
 												  struct session *sess);
-static int key_action_menu_shortcut (GtkWidget * wid, GdkEventKey * evt,
-											 char *d1, char *d2,
-											 struct session *sess);
-static int key_action_reopen_closed_tab (GtkWidget * wid, GdkEventKey * evt,
-												char *d1, char *d2,
-												struct session *sess);
-
 
 static GSList *keybind_list = NULL;
 
@@ -271,7 +260,7 @@ static const struct key_action key_actions[KEY_MAX_ACTIONS + 1] = {
 	{key_action_handle_command, "Run Command",
 	 N_("The \002Run Command\002 action runs the data in Data 1 as if it had been typed into the entry box where you pressed the key sequence. Thus it can contain text (which will be sent to the channel/person), commands or user commands. Escapes in Data 1 are interpreted (for example \002\\n\002, \002\\r\002, \002\\t\002, \002\\xNN\002 and \002\\\\\002), so it is possible to run more than one command by using newlines.")},
 	{key_action_page_switch, "Change Page",
-	 N_("The \002Change Page\002 command switches between pages in the notebook. Set Data 1 to the page number, channel name, network/channel, or auto. If Data 2 is set to anything then numeric switches are relative to the current position. Auto switches to the page with the most recent and important activity (queries first, then channels with hilight, channels with dialogue, channels with other data)")},
+	 N_("The \002Change Page\002 command switches between pages in the notebook. Set Data 1 to the page you want to switch to. If Data 2 is set to anything then the switch will be relative to the current position. Set Data 1 to auto to switch to the page with the most recent and important activity (queries first, then channels with hilight, channels with dialogue, channels with other data)")},
 	{key_action_insert, "Insert in Buffer",
 	 N_("The \002Insert in Buffer\002 command will insert the contents of Data 1 into the entry where the key sequence was pressed at the current cursor position. Escapes in Data 1 are interpreted (for example \002\\n\002, \002\\r\002, \002\\t\002, \002\\xNN\002 and \002\\\\\002).")},
 	{key_action_scroll_page, "Scroll Page",
@@ -298,10 +287,6 @@ static const struct key_action key_actions[KEY_MAX_ACTIONS + 1] = {
 	 N_("This command moves the current tab family to the right")},
 	{key_action_put_history, "Push input line into history",
 	 N_("Push input line into history but doesn't send to server")},
-	{key_action_menu_shortcut, "Menu Shortcut",
-	 N_("Runs one of the built-in menu shortcuts. Set Data 1 to: network-list, new-server-tab, new-server-window, close, quit, menu-toggle, user-list-toggle, fullscreen-toggle, away-toggle, reset-marker, move-marker, copy-selection, search-text, search-next, search-previous or contents.")},
-	{key_action_reopen_closed_tab, "Reopen Closed Tab",
-	 N_("Reopens the most recently closed channel tab")},
 };
 
 #define default_kb_cfg \
@@ -344,86 +329,7 @@ static const struct key_action key_actions[KEY_MAX_ACTIONS + 1] = {
 	"ACCEL=<Alt>Right\nMove front tab right\nD1!\nD2!\n\n"\
 	"ACCEL=<Primary><Shift>Page_Up\nMove tab family left\nD1!\nD2!\n\n"\
 	"ACCEL=<Primary><Shift>Page_Down\nMove tab family right\nD1!\nD2!\n\n"\
-	"ACCEL=<Primary>s\nMenu Shortcut\nD1:network-list\nD2!\n\n"\
-	"ACCEL=<Primary>t\nMenu Shortcut\nD1:new-server-tab\nD2!\n\n"\
-	"ACCEL=<Primary>n\nMenu Shortcut\nD1:new-server-window\nD2!\n\n"\
-	"ACCEL=<Primary>w\nMenu Shortcut\nD1:close\nD2!\n\n"\
-	"ACCEL=<Primary>q\nMenu Shortcut\nD1:quit\nD2!\n\n"\
-	"ACCEL=<Primary>F9\nMenu Shortcut\nD1:menu-toggle\nD2!\n\n"\
-	"ACCEL=F7\nMenu Shortcut\nD1:user-list-toggle\nD2!\n\n"\
-	"ACCEL=F11\nMenu Shortcut\nD1:fullscreen-toggle\nD2!\n\n"\
-	"ACCEL=<Alt>a\nMenu Shortcut\nD1:away-toggle\nD2!\n\n"\
-	"ACCEL=<Primary>m\nMenu Shortcut\nD1:reset-marker\nD2!\n\n"\
-	"ACCEL=<Primary><Shift>M\nMenu Shortcut\nD1:move-marker\nD2!\n\n"\
-	"ACCEL=<Primary><Shift>C\nMenu Shortcut\nD1:copy-selection\nD2!\n\n"\
-	"ACCEL=<Primary>f\nMenu Shortcut\nD1:search-text\nD2!\n\n"\
-	"ACCEL=<Primary>g\nMenu Shortcut\nD1:search-next\nD2!\n\n"\
-	"ACCEL=<Primary><Shift>G\nMenu Shortcut\nD1:search-previous\nD2!\n\n"\
-	"ACCEL=F1\nMenu Shortcut\nD1:contents\nD2!\n\n"\
-	"ACCEL=<Primary><Shift>T\nReopen Closed Tab\nD1!\nD2!\n\n"
-
-static gboolean
-key_builtin_data_match (char *line, char *data)
-{
-	if (line[2] == '!')
-		return data == NULL || data[0] == 0;
-
-	if (line[2] == ':')
-		return !strcmp (&line[3], data ? data : "");
-
-	return FALSE;
-}
-
-static gboolean
-key_binding_is_builtin (struct key_binding *kb)
-{
-	char *buf, *ibuf;
-	char *action;
-	int pnt = 0;
-	int state = 0;
-	gboolean match = FALSE;
-	gboolean d1_match = FALSE;
-	off_t size;
-
-	if (kb->action < 0 || kb->action > KEY_MAX_ACTIONS)
-		return FALSE;
-
-	action = key_actions[kb->action].name;
-	ibuf = g_strdup (default_kb_cfg);
-	size = strlen (default_kb_cfg);
-
-	while (buf_get_line (ibuf, &buf, &pnt, size))
-	{
-		if (strlen (buf) == 0)
-			continue;
-
-		switch (state)
-		{
-		case 0:
-			state = 1;
-			break;
-		case 1:
-			match = !strcmp (buf, action);
-			state = 2;
-			break;
-		case 2:
-			d1_match = match && key_builtin_data_match (buf, kb->data1);
-			state = 3;
-			break;
-		case 3:
-			if (d1_match && key_builtin_data_match (buf, kb->data2))
-			{
-				g_free (ibuf);
-				return TRUE;
-			}
-			state = 0;
-			break;
-		}
-	}
-
-	g_free (ibuf);
-	return FALSE;
-}
+	"ACCEL=F9\nRun Command\nD1:/GUI MENU TOGGLE\nD2!\n\n"
 
 void
 key_init ()
@@ -537,6 +443,7 @@ key_handle_key_press (GtkWidget *wid, GdkEventKey *evt, session *sess)
 	if (!list)
 		return FALSE;
 	current_sess = sess;
+
 	if (plugin_emit_keypress (sess, evt->state, evt->keyval, gdk_keyval_to_unicode (evt->keyval)))
 		return 1;
 
@@ -580,31 +487,6 @@ key_handle_key_press (GtkWidget *wid, GdkEventKey *evt, session *sess)
 	return 0;
 }
 
-gboolean
-key_get_menu_accel (const char *name, guint *keyval, GdkModifierType *mod)
-{
-	struct key_binding *kb;
-	GSList *list;
-
-	if (!name)
-		return FALSE;
-
-	list = keybind_list;
-	while (list)
-	{
-		kb = (struct key_binding*)list->data;
-		if (kb->action >= 0 && kb->action <= KEY_MAX_ACTIONS && kb->keyval != 0 && !strcmp (key_actions[kb->action].name, "Menu Shortcut") && kb->data1 && !strcmp (kb->data1, name))
-		{
-			*keyval = kb->keyval;
-			*mod = kb->mod;
-			return TRUE;
-		}
-		list = g_slist_next (list);
-	}
-
-	return FALSE;
-}
-
 
 /* ***** GUI code here ******************* */
 
@@ -615,7 +497,6 @@ enum
 	ACTION_COLUMN,
 	D1_COLUMN,
 	D2_COLUMN,
-	CUSTOM_COLUMN,
 	N_COLUMNS
 };
 
@@ -740,31 +621,15 @@ key_dialog_keypress (GtkWidget *wid, GdkEventKey *evt, gpointer userdata)
 
 	if (handled)
 	{
-		gboolean custom1, custom2;
-
 		sel = gtk_tree_view_get_selection (view);
-		if (!gtk_tree_selection_get_selected (sel, &store, &iter1))
-			return FALSE;
-
+		gtk_tree_selection_get_selected (sel, &store, &iter1);
 		path = gtk_tree_model_get_path (store, &iter1);
 		if (delta == 1)
 			gtk_tree_path_next (path);
-		else if (!gtk_tree_path_prev (path))
-		{
+		else
+			gtk_tree_path_prev (path);
+		gtk_tree_model_get_iter (store, &iter2, path);
 		gtk_tree_path_free (path);
-			return FALSE;
-		}
-
-		if (!gtk_tree_model_get_iter (store, &iter2, path))
-		{
-			gtk_tree_path_free (path);
-			return FALSE;
-		}
-
-		gtk_tree_path_free (path);
-		gtk_tree_model_get (store, &iter1, CUSTOM_COLUMN, &custom1, -1);
-		gtk_tree_model_get (store, &iter2, CUSTOM_COLUMN, &custom2, -1);
-		if (custom1 && custom2)
 		gtk_list_store_swap (GTK_LIST_STORE (store), &iter1, &iter2);
 	}
 
@@ -777,23 +642,14 @@ key_dialog_selection_changed (GtkTreeSelection *sel, gpointer userdata)
 	GtkTreeModel *model;
 	GtkTreeIter iter;
 	GtkXText *xtext;
-	GtkWidget *delete_button;
 	char *actiontext;
-	gboolean custom;
 	int action;
 
-	delete_button = g_object_get_data (G_OBJECT (key_dialog), "delete_button");
 	if (!gtk_tree_selection_get_selected (sel, &model, &iter) || model == NULL)
-	{
-		if (delete_button)
-			gtk_widget_set_sensitive (delete_button, FALSE);
 		return;
-	}
 
 	xtext = GTK_XTEXT (g_object_get_data (G_OBJECT (key_dialog), "xtext"));
-	gtk_tree_model_get (model, &iter, ACTION_COLUMN, &actiontext, CUSTOM_COLUMN, &custom, -1);
-	if (delete_button)
-		gtk_widget_set_sensitive (delete_button, custom);
+	gtk_tree_model_get (model, &iter, ACTION_COLUMN, &actiontext, -1);
 
 	if (actiontext)
 	{
@@ -868,11 +724,8 @@ key_dialog_save (GtkWidget *wid, gpointer userdata)
 	}
 
 	if (key_save_kbs () == 0)
-	{
-		menu_update_quit_accel ();
 		key_dialog_close (wid, NULL);
 }
-}
 
 static void
 key_dialog_add (GtkWidget *wid, gpointer userdata)
@@ -884,7 +737,6 @@ key_dialog_add (GtkWidget *wid, gpointer userdata)
 	GtkTreePath *path;
 
 	gtk_list_store_append (store, &iter);
-	gtk_list_store_set (store, &iter, CUSTOM_COLUMN, TRUE, -1);
 
 	/* make sure the new row is visible and selected */
 	path = gtk_tree_model_get_path (GTK_TREE_MODEL (store), &iter);
@@ -894,134 +746,6 @@ key_dialog_add (GtkWidget *wid, gpointer userdata)
 	gtk_tree_path_free (path);
 }
 
-static char *
-key_binding_signature (const char *action, const char *data1, const char *data2)
-{
-	return g_strdup_printf ("%s\\n%s\\n%s", action ? action : "", data1 ? data1 : "", data2 ? data2 : "");
-}
-
-static int
-key_dialog_reset_count (GHashTable *table, const char *key)
-{
-	return GPOINTER_TO_INT (g_hash_table_lookup (table, key));
-}
-
-static void
-key_dialog_reset_increment (GHashTable *table, char *key)
-{
-	g_hash_table_replace (table, key, GINT_TO_POINTER (key_dialog_reset_count (table, key) + 1));
-}
-
-static void
-key_dialog_reset (GtkWidget *wid, gpointer userdata)
-{
-	GtkListStore *store = GTK_LIST_STORE (get_store ());
-	GtkListStore *custom_store;
-	GtkTreeIter iter, custom_iter;
-	GtkWidget *delete_button;
-	GHashTable *default_counts, *seen_counts;
-	GSList *list = NULL, *old_list, *default_iter;
-	struct key_binding *kb;
-	gboolean custom, keep;
-	char *key, *accel, *action, *data1, *data2, *signature;
-
-	if (key_load_kbs_from_buffer (g_strdup (default_kb_cfg), strlen (default_kb_cfg), &list) != 0)
-		return;
-
-	default_counts = g_hash_table_new_full (g_str_hash, g_str_equal, g_free, NULL);
-	seen_counts = g_hash_table_new_full (g_str_hash, g_str_equal, g_free, NULL);
-	for (default_iter = list; default_iter; default_iter = g_slist_next (default_iter))
-	{
-		kb = default_iter->data;
-		signature = key_binding_signature (key_actions[kb->action].name, kb->data1, kb->data2);
-		key_dialog_reset_increment (default_counts, signature);
-	}
-
-	custom_store = gtk_list_store_new (N_COLUMNS, G_TYPE_STRING, G_TYPE_STRING, G_TYPE_STRING,
-								G_TYPE_STRING, G_TYPE_STRING, G_TYPE_BOOLEAN);
-
-	if (gtk_tree_model_get_iter_first (GTK_TREE_MODEL (store), &iter))
-	{
-		do
-		{
-			gtk_tree_model_get (GTK_TREE_MODEL (store), &iter,
-								KEY_COLUMN, &key,
-								ACCEL_COLUMN, &accel,
-								ACTION_COLUMN, &action,
-								D1_COLUMN, &data1,
-								D2_COLUMN, &data2,
-								CUSTOM_COLUMN, &custom,
-								-1);
-			signature = key_binding_signature (action, data1, data2);
-			keep = custom || key_dialog_reset_count (seen_counts, signature) >= key_dialog_reset_count (default_counts, signature);
-			if (!custom)
-				key_dialog_reset_increment (seen_counts, g_strdup (signature));
-			if (keep)
-			{
-				gtk_list_store_append (custom_store, &custom_iter);
-				gtk_list_store_set (custom_store, &custom_iter,
-								KEY_COLUMN, key,
-								ACCEL_COLUMN, accel,
-								ACTION_COLUMN, action,
-								D1_COLUMN, data1,
-								D2_COLUMN, data2,
-								CUSTOM_COLUMN, TRUE,
-								-1);
-			}
-			g_free (signature);
-			g_free (key);
-			g_free (accel);
-			g_free (action);
-			g_free (data1);
-			g_free (data2);
-		}
-		while (gtk_tree_model_iter_next (GTK_TREE_MODEL (store), &iter));
-	}
-
-	old_list = keybind_list;
-	keybind_list = list;
-	gtk_list_store_clear (store);
-	key_dialog_load (store);
-	keybind_list = old_list;
-
-	if (gtk_tree_model_get_iter_first (GTK_TREE_MODEL (custom_store), &iter))
-	{
-		do
-		{
-			gtk_tree_model_get (GTK_TREE_MODEL (custom_store), &iter,
-								KEY_COLUMN, &key,
-								ACCEL_COLUMN, &accel,
-								ACTION_COLUMN, &action,
-								D1_COLUMN, &data1,
-								D2_COLUMN, &data2,
-								-1);
-			gtk_list_store_append (store, &custom_iter);
-			gtk_list_store_set (store, &custom_iter,
-							KEY_COLUMN, key,
-							ACCEL_COLUMN, accel,
-							ACTION_COLUMN, action,
-							D1_COLUMN, data1,
-							D2_COLUMN, data2,
-							CUSTOM_COLUMN, TRUE,
-							-1);
-			g_free (key);
-			g_free (accel);
-			g_free (action);
-			g_free (data1);
-			g_free (data2);
-		}
-		while (gtk_tree_model_iter_next (GTK_TREE_MODEL (custom_store), &iter));
-	}
-
-	delete_button = g_object_get_data (G_OBJECT (key_dialog), "delete_button");
-	if (delete_button)
-		gtk_widget_set_sensitive (delete_button, FALSE);
-	g_hash_table_destroy (default_counts);
-	g_hash_table_destroy (seen_counts);
-	g_object_unref (custom_store);
-	g_slist_free_full (list, key_free);
-}
-
 static void
 key_dialog_delete (GtkWidget *wid, gpointer userdata)
 {
@@ -1029,14 +753,9 @@ key_dialog_delete (GtkWidget *wid, gpointer userdata)
 	GtkListStore *store = GTK_LIST_STORE (gtk_tree_view_get_model (view));
 	GtkTreeIter iter;
 	GtkTreePath *path;
-	gboolean custom;
 
 	if (gtkutil_treeview_get_selected (view, &iter, -1))
 	{
-		gtk_tree_model_get (GTK_TREE_MODEL (store), &iter, CUSTOM_COLUMN, &custom, -1);
-		if (!custom)
-			return;
-
 		/* delete this row, select next one */
 		if (gtk_list_store_remove (store, &iter))
 		{
@@ -1063,13 +782,13 @@ key_dialog_treeview_new (GtkWidget *box)
 	gtk_scrolled_window_set_shadow_type (GTK_SCROLLED_WINDOW (scroll), GTK_SHADOW_IN);
 
 	store = gtk_list_store_new (N_COLUMNS, G_TYPE_STRING, G_TYPE_STRING, G_TYPE_STRING,
-								G_TYPE_STRING, G_TYPE_STRING, G_TYPE_BOOLEAN);
+								G_TYPE_STRING, G_TYPE_STRING);
 	g_return_val_if_fail (store != NULL, NULL);
 
 	view = gtk_tree_view_new_with_model (GTK_TREE_MODEL (store));
 	gtk_tree_view_set_fixed_height_mode (GTK_TREE_VIEW (view), TRUE);
 	gtk_tree_view_set_enable_search (GTK_TREE_VIEW (view), FALSE);
-	gtk_tree_view_set_reorderable (GTK_TREE_VIEW (view), FALSE);
+	gtk_tree_view_set_reorderable (GTK_TREE_VIEW (view), TRUE);
 
 	g_signal_connect (G_OBJECT (view), "key-press-event",
 					G_CALLBACK (key_dialog_keypress), NULL);
@@ -1140,7 +859,6 @@ key_dialog_treeview_new (GtkWidget *box)
 	gtk_tree_view_insert_column_with_attributes (GTK_TREE_VIEW (view), ACTION_COLUMN,
 													"Action", render,
 													"text", ACTION_COLUMN, 
-													"editable", CUSTOM_COLUMN,
 													NULL);
 
 	render = gtk_cell_renderer_text_new ();
@@ -1151,7 +869,6 @@ key_dialog_treeview_new (GtkWidget *box)
 							GTK_TREE_VIEW (view), D1_COLUMN,
 							"Data1", render,
 							"text", D1_COLUMN,
-							"editable", CUSTOM_COLUMN,
 							NULL);
 
 	render = gtk_cell_renderer_text_new ();
@@ -1162,7 +879,6 @@ key_dialog_treeview_new (GtkWidget *box)
 							GTK_TREE_VIEW (view), D2_COLUMN,
 							"Data2", render,
 							"text", D2_COLUMN,
-							"editable", CUSTOM_COLUMN,
 							NULL);
 
 	col = gtk_tree_view_get_column (GTK_TREE_VIEW (view), KEY_COLUMN);
@@ -1208,8 +924,7 @@ key_dialog_load (GtkListStore *store)
 							ACCEL_COLUMN, accel_text,
 							ACTION_COLUMN, key_actions[kb->action].name,
 							D1_COLUMN, kb->data1,
-							D2_COLUMN, kb->data2,
-							CUSTOM_COLUMN, !key_binding_is_builtin (kb), -1);
+							D2_COLUMN, kb->data2, -1);
 
 		g_free (accel_text);
 		g_free (label_text);
@@ -1222,7 +937,7 @@ void
 key_dialog_show ()
 {
 	GtkWidget *vbox, *box;
-	GtkWidget *view, *xtext, *delete_button;
+	GtkWidget *view, *xtext;
 	GtkListStore *store;
 	XTextColor xtext_palette[XTEXT_COLS];
 	char buf[128];
@@ -1256,12 +971,8 @@ key_dialog_show ()
 
 	gtkutil_button (box, ICON_FKEYS_NEW, NULL, key_dialog_add,
 					NULL, _("Add"));
-	delete_button = gtkutil_button (box, ICON_FKEYS_DELETE, NULL, key_dialog_delete,
+	gtkutil_button (box, ICON_FKEYS_DELETE, NULL, key_dialog_delete,
 					NULL, _("Delete"));
-	g_object_set_data (G_OBJECT (key_dialog), "delete_button", delete_button);
-	gtk_widget_set_sensitive (delete_button, FALSE);
-	gtkutil_button (box, ICON_FKEYS_RESET, NULL, key_dialog_reset,
-					NULL, _("Reset"));
 	gtkutil_button (box, ICON_FKEYS_CANCEL, NULL, key_dialog_close,
 					NULL, _("Cancel"));
 	gtkutil_button (box, ICON_FKEYS_SAVE, NULL, key_dialog_save,
@@ -1369,14 +1080,41 @@ key_load_kbs_helper_mod (char *buf, GdkModifierType *out)
 }
 
 static int
-key_load_kbs_from_buffer (char *ibuf, off_t size, GSList **out_list)
+key_load_kbs (void)
 {
-	char *buf;
+	char *buf, *ibuf;
+	struct stat st;
 	struct key_binding *kb = NULL;
-	int len, state = 0, pnt = 0;
+	int fd, len, state = 0, pnt = 0;
 	guint keyval;
 	GdkModifierType mod = 0;
-	GSList *list = NULL;
+	off_t size;
+
+	fd = zoitechat_open_file ("keybindings.conf", O_RDONLY, 0, 0);
+	if (fd < 0)
+	{
+		ibuf = g_strdup (default_kb_cfg);
+		size = strlen (default_kb_cfg);
+	}
+	else
+	{
+		if (fstat (fd, &st) != 0)
+		{
+			close (fd);
+			return 1;
+		}
+
+		ibuf = g_malloc(st.st_size);
+		read (fd, ibuf, st.st_size);
+		size = st.st_size;
+		close (fd);
+	}
+
+	if (keybind_list)
+	{
+		g_slist_free_full (keybind_list, key_free);
+		keybind_list = NULL;
+	}
 
 	while (buf_get_line (ibuf, &buf, &pnt, size))
 	{		
@@ -1390,12 +1128,14 @@ key_load_kbs_from_buffer (char *ibuf, off_t size, GSList **out_list)
 		case KBSTATE_MOD:
 			kb = g_new0 (struct key_binding, 1);
 
+			/* New format */
 			if (strncmp (buf, "ACCEL=", 6) == 0)
 			{
 				buf += 6;
 
 				gtk_accelerator_parse (buf, &keyval, &mod);
 
+
 				kb->keyval = keyval;
 				kb->mod = key_modifier_get_valid (mod);
 
@@ -1418,8 +1158,6 @@ key_load_kbs_from_buffer (char *ibuf, off_t size, GSList **out_list)
 			if (keyval == 0)
 			{
 				g_free (ibuf);
-				key_free (kb);
-				g_slist_free_full (list, key_free);
 				return 2;
 			}
 
@@ -1436,8 +1174,6 @@ key_load_kbs_from_buffer (char *ibuf, off_t size, GSList **out_list)
 			if (kb->action == KEY_MAX_ACTIONS + 1)
 			{
 				g_free (ibuf);
-				key_free (kb);
-				g_slist_free_full (list, key_free);
 				return 3;
 			}
 
@@ -1455,8 +1191,6 @@ key_load_kbs_from_buffer (char *ibuf, off_t size, GSList **out_list)
 			if (buf[0] != 'D')
 			{
 				g_free (ibuf);
-				key_free (kb);
-				g_slist_free_full (list, key_free);
 				return 4;
 			}
 
@@ -1477,6 +1211,7 @@ key_load_kbs_from_buffer (char *ibuf, off_t size, GSList **out_list)
 			if (buf[2] == ':')
 			{
 				len = strlen (buf);
+				/* Add one for the NULL, subtract 3 for the "Dx:" */
 				len++;
 				len -= 3;
 				if (state == KBSTATE_DT1)
@@ -1499,8 +1234,7 @@ key_load_kbs_from_buffer (char *ibuf, off_t size, GSList **out_list)
 				continue;
 			} else
 			{
-				list = g_slist_append (list, kb);
-				kb = NULL;
+				keybind_list = g_slist_append (keybind_list, kb);
 
 				state = KBSTATE_MOD;
 			}
@@ -1509,56 +1243,14 @@ key_load_kbs_from_buffer (char *ibuf, off_t size, GSList **out_list)
 		}
 	}
 	g_free (ibuf);
-	*out_list = list;
 	return 0;
 
 corrupt_file:
 	g_free (ibuf);
-	key_free (kb);
-	g_slist_free_full (list, key_free);
+	g_free (kb);
 	return 5;
 }
 
-static int
-key_load_kbs (void)
-{
-	char *ibuf;
-	struct stat st;
-	int fd, result;
-	off_t size;
-	GSList *list = NULL;
-
-	fd = zoitechat_open_file ("keybindings.conf", O_RDONLY, 0, 0);
-	if (fd < 0)
-	{
-		ibuf = g_strdup (default_kb_cfg);
-		size = strlen (default_kb_cfg);
-	}
-	else
-	{
-		if (fstat (fd, &st) != 0)
-		{
-			close (fd);
-			return 1;
-		}
-
-		ibuf = g_malloc(st.st_size);
-		read (fd, ibuf, st.st_size);
-		size = st.st_size;
-		close (fd);
-	}
-
-	result = key_load_kbs_from_buffer (ibuf, size, &list);
-	if (result != 0)
-		return result;
-
-	if (keybind_list)
-		g_slist_free_full (keybind_list, key_free);
-	keybind_list = list;
-
-	return 0;
-}
-
 static int
 key_action_handle_command (GtkWidget * wid, GdkEventKey * evt, char *d1,
 									char *d2, struct session *sess)
@@ -1576,24 +1268,6 @@ key_action_handle_command (GtkWidget * wid, GdkEventKey * evt, char *d1,
 	return 0;
 }
 
-static int
-key_action_menu_shortcut (GtkWidget * wid, GdkEventKey * evt, char *d1,
-									 char *d2, struct session *sess)
-{
-	if (menu_key_action (d1, evt->keyval, evt->state))
-		return 2;
-
-	return 0;
-}
-
-static int
-key_action_reopen_closed_tab (GtkWidget * wid, GdkEventKey * evt, char *d1,
-										 char *d2, struct session *sess)
-{
-	mg_reopen_closed_channel_tab ();
-	return 2;
-}
-
 /*
  * Check if the given session is inside the main window. This predicate
  * is passed to lastact_getfirst() as a way to filter out detached sessions.
@@ -1612,9 +1286,6 @@ key_action_page_switch (GtkWidget * wid, GdkEventKey * evt, char *d1,
 								char *d2, struct session *sess)
 {
 	session *newsess;
-	char *network;
-	char *channel;
-	char *slash;
 	int len, i, num;
 
 	if (!d1)
@@ -1626,13 +1297,21 @@ key_action_page_switch (GtkWidget * wid, GdkEventKey * evt, char *d1,
 
 	if (g_ascii_strcasecmp(d1, "auto") == 0)
 	{
+		/* Auto switch makes no sense in detached sessions */
 		if (!sess->gui->is_tab)
 			return 1;
 
+		/* Obtain a session with recent activity */
 		newsess = lastact_getfirst(session_check_is_tab);
 
 		if (newsess)
 		{
+			/*
+			 * Only sessions in the current window should be considered (i.e.
+			 * we don't want to move the focus on a different window). This
+			 * call could, in theory, do this, but we checked before that
+			 * newsess->gui->is_tab and sess->gui->is_tab.
+			 */
 			mg_bring_tofront_sess(newsess);
 			return 0;
 		}
@@ -1646,26 +1325,7 @@ key_action_page_switch (GtkWidget * wid, GdkEventKey * evt, char *d1,
 		{
 			if (i == 0 && (d1[i] == '+' || d1[i] == '-'))
 				continue;
-
-			network = NULL;
-			channel = d1;
-			slash = strchr (d1, '/');
-
-			if (slash && slash[1])
-			{
-				network = g_strndup (d1, slash - d1);
-				channel = slash + 1;
-			}
-
-			newsess = plugin_find_context (network, channel, sess->server);
-			g_free (network);
-
-			if (newsess && newsess->gui)
-			{
-				mg_bring_tofront_sess(newsess);
-				return 0;
-			}
-
+			else
 				return 1;
 		}
 	}
@@ -2292,37 +1952,8 @@ replace_handle (GtkWidget *t)
 			{
 				ptrdiff_t found_offset = found - text;
 				ptrdiff_t found_end_offset = found_offset + (ptrdiff_t) pop_len;
-				gboolean start_ok;
-				gboolean end_ok;
 				int rank;
 				ptrdiff_t distance;
-				const char *before = found;
-				const char *after = found + pop_len;
-
-				if (before > text)
-				{
-					before = g_utf8_find_prev_char (text, before);
-					start_ok = !before || (!g_unichar_isalnum (g_utf8_get_char (before)) && g_utf8_get_char (before) != '_');
-				}
-				else
-				{
-					start_ok = TRUE;
-				}
-
-				if (*after != '\0')
-				{
-					end_ok = !g_unichar_isalnum (g_utf8_get_char (after)) && g_utf8_get_char (after) != '_';
-				}
-				else
-				{
-					end_ok = TRUE;
-				}
-
-				if (!start_ok || !end_ok)
-				{
-					found++;
-					continue;
-				}
 
 				if (cursor_byte_offset >= found_offset && cursor_byte_offset <= found_end_offset)
 				{

src/fe-gtk/fkeys.h

@@ -35,6 +35,5 @@ int key_handle_key_press (GtkWidget * wid, GdkEventKey * evt, session *sess);
 int key_action_insert (GtkWidget * wid, GdkEventKey * evt, char *d1, char *d2,
 						 session *sess);
 void key_check_replace_on_change (GtkEditable *editable, gpointer data);
-gboolean key_get_menu_accel (const char *name, guint *keyval, GdkModifierType *mod);
 
 #endif

src/fe-gtk/gtkutil.c

@@ -272,6 +272,13 @@ gtkutil_apply_palette (GtkWidget *widget, const GdkRGBA *bg, const GdkRGBA *fg,
 	theme_manager_apply_palette_widget (widget, bg, fg, font_desc);
 }
 
+static void
+gtkutil_file_req_destroy (GtkWidget * wid, struct file_req *freq)
+{
+	freq->callback (freq->userdata, NULL);
+	g_free (freq);
+}
+
 static void
 gtkutil_check_file (char *filename, struct file_req *freq)
 {
@@ -383,6 +390,26 @@ gtkutil_file_req_done_chooser (GtkFileChooser *fs, struct file_req *freq)
 
 }
 
+static void
+gtkutil_file_req_done (GtkWidget * wid, struct file_req *freq)
+{
+	gtkutil_file_req_done_chooser (GTK_FILE_CHOOSER (freq->dialog), freq);
+	gtk_widget_destroy (freq->dialog);
+}
+
+static void
+gtkutil_file_req_response (GtkWidget *dialog, gint res, struct file_req *freq)
+{
+	if (res == GTK_RESPONSE_ACCEPT)
+	{
+		gtkutil_file_req_done (dialog, freq);
+		return;
+	}
+
+	gtk_widget_destroy (dialog);
+}
+
+#ifdef WIN32
 static gboolean
 gtkutil_native_dialog_unref_idle (gpointer native)
 {
@@ -396,16 +423,27 @@ gtkutil_native_file_req_response (GtkNativeDialog *dialog, gint res, struct file
 	if (res == GTK_RESPONSE_ACCEPT)
 		gtkutil_file_req_done_chooser (GTK_FILE_CHOOSER (dialog), freq);
 
+	/* Match gtk dialog flow by always sending NULL to indicate completion. */
 	freq->callback (freq->userdata, NULL);
 	g_free (freq);
+
+	/*
+	 * Defer unref until idle to avoid disposing the native chooser while
+	 * still in the button-release signal stack on Windows.
+	 */
 	g_idle_add (gtkutil_native_dialog_unref_idle, dialog);
 }
+#endif
 
 void
 gtkutil_file_req (GtkWindow *parent, const char *title, void *callback, void *userdata, char *filter, char *extensions,
 						int flags)
 {
 	struct file_req *freq;
+	GtkWidget *dialog;
+	GtkFileFilter *filefilter;
+	char *token;
+	char *tokenbuffer;
 	const char *xdir;
 	GtkWindow *effective_parent = parent;
 
@@ -415,6 +453,7 @@ gtkutil_file_req (GtkWindow *parent, const char *title, void *callback, void *us
 
 	xdir = get_xdir ();
 
+#ifdef WIN32
 	{
 		GtkFileChooserNative *native = gtk_file_chooser_native_new (
 			title,
@@ -483,14 +522,110 @@ gtkutil_file_req (GtkWindow *parent, const char *title, void *callback, void *us
 
 		g_signal_connect (native, "response",
 						G_CALLBACK (gtkutil_native_file_req_response), freq);
-
-		if (flags & FRF_MODAL)
-			gtk_native_dialog_set_modal (GTK_NATIVE_DIALOG (native), TRUE);
-
 		gtk_native_dialog_show (GTK_NATIVE_DIALOG (native));
 		return;
 	}
+#endif
 
+	if (flags & FRF_WRITE)
+	{
+		dialog = gtk_file_chooser_dialog_new (title, NULL,
+												GTK_FILE_CHOOSER_ACTION_SAVE,
+												_("_Cancel"), GTK_RESPONSE_CANCEL,
+												_("_Save"), GTK_RESPONSE_ACCEPT,
+												NULL);
+
+		if (!(flags & FRF_NOASKOVERWRITE))
+			gtk_file_chooser_set_do_overwrite_confirmation (GTK_FILE_CHOOSER (dialog), TRUE);
+	}
+	else
+		dialog = gtk_file_chooser_dialog_new (title, NULL,
+												GTK_FILE_CHOOSER_ACTION_OPEN,
+												_("_Cancel"), GTK_RESPONSE_CANCEL,
+												_("_Open"), GTK_RESPONSE_ACCEPT,
+												NULL);
+
+	theme_manager_attach_window (dialog);
+
+	if (filter && filter[0] && (flags & FRF_FILTERISINITIAL))
+	{
+		if (flags & FRF_WRITE)
+		{
+			char temp[1024];
+			path_part (filter, temp, sizeof (temp));
+			if (temp[0] && g_file_test (temp, G_FILE_TEST_IS_DIR))
+				gtk_file_chooser_set_current_folder (GTK_FILE_CHOOSER (dialog), temp);
+			else if (xdir && xdir[0] && g_file_test (xdir, G_FILE_TEST_IS_DIR))
+				gtk_file_chooser_set_current_folder (GTK_FILE_CHOOSER (dialog), xdir);
+			gtk_file_chooser_set_current_name (GTK_FILE_CHOOSER (dialog), file_part (filter));
+		}
+		else
+		{
+			if (g_file_test (filter, G_FILE_TEST_IS_DIR))
+				gtk_file_chooser_set_current_folder (GTK_FILE_CHOOSER (dialog), filter);
+			else if (xdir && xdir[0] && g_file_test (xdir, G_FILE_TEST_IS_DIR))
+				gtk_file_chooser_set_current_folder (GTK_FILE_CHOOSER (dialog), xdir);
+		}
+	}
+	else if (!(flags & FRF_RECENTLYUSED))
+	{
+		if (xdir && xdir[0] && g_file_test (xdir, G_FILE_TEST_IS_DIR))
+			gtk_file_chooser_set_current_folder (GTK_FILE_CHOOSER (dialog), xdir);
+	}
+
+	if (flags & FRF_MULTIPLE)
+		gtk_file_chooser_set_select_multiple (GTK_FILE_CHOOSER (dialog), TRUE);
+	if (flags & FRF_CHOOSEFOLDER)
+		gtk_file_chooser_set_action (GTK_FILE_CHOOSER (dialog), GTK_FILE_CHOOSER_ACTION_SELECT_FOLDER);
+
+	if ((flags & FRF_EXTENSIONS || flags & FRF_MIMETYPES) && extensions != NULL)
+	{
+		filefilter = gtk_file_filter_new ();
+		tokenbuffer = g_strdup (extensions);
+		token = strtok (tokenbuffer, ";");
+
+		while (token != NULL)
+		{
+			if (flags & FRF_EXTENSIONS)
+				gtk_file_filter_add_pattern (filefilter, token);
+			else
+				gtk_file_filter_add_mime_type (filefilter, token);
+			token = strtok (NULL, ";");
+		}
+
+		g_free (tokenbuffer);
+		gtk_file_chooser_set_filter (GTK_FILE_CHOOSER (dialog), filefilter);
+	}
+
+	if (xdir && xdir[0] && g_file_test (xdir, G_FILE_TEST_IS_DIR))
+	{
+		GError *shortcut_error = NULL;
+
+		gtk_file_chooser_add_shortcut_folder (GTK_FILE_CHOOSER (dialog), xdir, &shortcut_error);
+		if (shortcut_error)
+			g_error_free (shortcut_error);
+	}
+	freq = g_new (struct file_req, 1);
+	freq->dialog = dialog;
+	freq->flags = flags;
+	freq->callback = callback;
+	freq->userdata = userdata;
+
+	g_signal_connect (G_OBJECT (dialog), "response",
+							G_CALLBACK (gtkutil_file_req_response), freq);
+	g_signal_connect (G_OBJECT (dialog), "destroy",
+						   G_CALLBACK (gtkutil_file_req_destroy), (gpointer) freq);
+
+	if (effective_parent)
+		gtk_window_set_transient_for (GTK_WINDOW (dialog), effective_parent);
+
+	if (flags & FRF_MODAL)
+	{
+		g_assert (effective_parent);
+		gtk_window_set_modal (GTK_WINDOW (dialog), TRUE);
+	}
+
+	gtk_widget_show (dialog);
 }
 
 static gboolean
@@ -527,43 +662,6 @@ gtkutil_destroy (GtkWidget * igad, GtkWidget * dgad)
 	gtk_widget_destroy (dgad);
 }
 
-static void
-gtkutil_place_dialog (GtkWidget *dialog)
-{
-	GList *list;
-	GList *item;
-	GtkWindow *anchor = NULL;
-	gint x;
-	gint y;
-	extern GtkWidget *parent_window;
-
-	list = gtk_window_list_toplevels ();
-	for (item = list; item; item = item->next)
-	{
-		if (item->data != dialog && GTK_IS_WINDOW (item->data) &&
-			gtk_widget_get_visible (GTK_WIDGET (item->data)) &&
-			gtk_window_is_active (GTK_WINDOW (item->data)))
-		{
-			anchor = GTK_WINDOW (item->data);
-			break;
-		}
-	}
-	g_list_free (list);
-
-	if (!anchor && parent_window && parent_window != dialog && GTK_IS_WINDOW (parent_window))
-		anchor = GTK_WINDOW (parent_window);
-
-	if (anchor)
-	{
-		gtk_window_get_position (anchor, &x, &y);
-		gtk_window_move (GTK_WINDOW (dialog), x, y);
-	}
-	else
-	{
-		gtk_window_set_position (GTK_WINDOW (dialog), GTK_WIN_POS_MOUSE);
-	}
-}
-
 static void
 gtkutil_get_str_response (GtkDialog *dialog, gint arg1, gpointer entry)
 {
@@ -577,15 +675,15 @@ gtkutil_get_str_response (GtkDialog *dialog, gint arg1, gpointer entry)
 
 	switch (arg1)
 	{
+	case GTK_RESPONSE_REJECT:
+		callback (TRUE, text, user_data);
+		gtk_widget_destroy (GTK_WIDGET (dialog));
+		break;
 	case GTK_RESPONSE_ACCEPT:
 		callback (FALSE, text, user_data);
-		break;
-	default:
-		callback (TRUE, text, user_data);
+		gtk_widget_destroy (GTK_WIDGET (dialog));
 		break;
 	}
-
-	gtk_widget_destroy (GTK_WIDGET (dialog));
 }
 
 static void
@@ -594,8 +692,8 @@ gtkutil_str_enter (GtkWidget *entry, GtkWidget *dialog)
 	gtk_dialog_response (GTK_DIALOG (dialog), GTK_RESPONSE_ACCEPT);
 }
 
-static void
-gtkutil_get_str (char *msg, char *def, void *callback, void *userdata, gboolean visible)
+void
+fe_get_str (char *msg, char *def, void *callback, void *userdata)
 {
 	GtkWidget *dialog;
 	GtkWidget *entry;
@@ -609,11 +707,18 @@ gtkutil_get_str (char *msg, char *def, void *callback, void *userdata, gboolean
 										NULL);
 	theme_manager_attach_window (dialog);
 
-	if (parent_window && GTK_IS_WINDOW (parent_window))
 	gtk_window_set_transient_for (GTK_WINDOW (dialog), GTK_WINDOW (parent_window));
-	gtkutil_place_dialog (dialog);
 	gtk_box_set_homogeneous (GTK_BOX (gtk_dialog_get_content_area (GTK_DIALOG (dialog))), TRUE);
 
+	if (userdata == (void *)1)	/* nick box is usually on the very bottom, make it centered */
+	{
+		gtk_window_set_position (GTK_WINDOW (dialog), GTK_WIN_POS_CENTER);
+	}
+	else
+	{
+		gtk_window_set_position (GTK_WINDOW (dialog), GTK_WIN_POS_MOUSE);
+	}
+
 	hbox = gtkutil_box_new (GTK_ORIENTATION_HORIZONTAL, TRUE, 0);
 
 	g_object_set_data (G_OBJECT (dialog), "cb", callback);
@@ -622,8 +727,7 @@ gtkutil_get_str (char *msg, char *def, void *callback, void *userdata, gboolean
 	entry = gtk_entry_new ();
 	g_signal_connect (G_OBJECT (entry), "activate",
 						 	G_CALLBACK (gtkutil_str_enter), dialog);
-	gtk_entry_set_text (GTK_ENTRY (entry), def ? def : "");
-	gtk_entry_set_visibility (GTK_ENTRY (entry), visible);
+	gtk_entry_set_text (GTK_ENTRY (entry), def);
 	gtk_box_pack_end (GTK_BOX (hbox), entry, 0, 0, 0);
 
 	label = gtk_label_new (msg);
@@ -637,18 +741,6 @@ gtkutil_get_str (char *msg, char *def, void *callback, void *userdata, gboolean
 	gtk_widget_show_all (dialog);
 }
 
-void
-fe_get_str (char *msg, char *def, void *callback, void *userdata)
-{
-	gtkutil_get_str (msg, def, callback, userdata, TRUE);
-}
-
-void
-fe_get_password (char *msg, void *callback, void *userdata)
-{
-	gtkutil_get_str (msg, "", callback, userdata, FALSE);
-}
-
 static void
 gtkutil_get_number_response (GtkDialog *dialog, gint arg1, gpointer spin)
 {
@@ -684,15 +776,15 @@ gtkutil_get_bool_response (GtkDialog *dialog, gint arg1, gpointer spin)
 
 	switch (arg1)
 	{
+	case GTK_RESPONSE_REJECT:
+		callback (0, user_data);
+		gtk_widget_destroy (GTK_WIDGET (dialog));
+		break;
 	case GTK_RESPONSE_ACCEPT:
 		callback (1, user_data);
-		break;
-	default:
-		callback (0, user_data);
+		gtk_widget_destroy (GTK_WIDGET (dialog));
 		break;
 	}
-
-	gtk_widget_destroy (GTK_WIDGET (dialog));
 }
 
 void
@@ -710,10 +802,9 @@ fe_get_int (char *msg, int def, void *callback, void *userdata)
 										_("_OK"), GTK_RESPONSE_ACCEPT,
 										NULL);
 	theme_manager_attach_window (dialog);
-	if (parent_window && GTK_IS_WINDOW (parent_window))
-		gtk_window_set_transient_for (GTK_WINDOW (dialog), GTK_WINDOW (parent_window));
-	gtkutil_place_dialog (dialog);
 	gtk_box_set_homogeneous (GTK_BOX (gtk_dialog_get_content_area (GTK_DIALOG (dialog))), TRUE);
+	gtk_window_set_position (GTK_WINDOW (dialog), GTK_WIN_POS_MOUSE);
+	gtk_window_set_transient_for (GTK_WINDOW (dialog), GTK_WINDOW (parent_window));
 
 	hbox = gtkutil_box_new (GTK_ORIENTATION_HORIZONTAL, TRUE, 0);
 
@@ -751,10 +842,10 @@ fe_get_bool (char *title, char *prompt, void *callback, void *userdata)
 		_("_Yes"), GTK_RESPONSE_ACCEPT,
 		NULL);
 	theme_manager_attach_window (dialog);
-	if (parent_window && GTK_IS_WINDOW (parent_window))
-		gtk_window_set_transient_for (GTK_WINDOW (dialog), GTK_WINDOW (parent_window));
-	gtkutil_place_dialog (dialog);
 	gtk_box_set_homogeneous (GTK_BOX (gtk_dialog_get_content_area (GTK_DIALOG (dialog))), TRUE);
+	gtk_window_set_position (GTK_WINDOW (dialog), GTK_WIN_POS_MOUSE);
+	gtk_window_set_transient_for (GTK_WINDOW (dialog), GTK_WINDOW (parent_window));
+
 
 	g_object_set_data (G_OBJECT (dialog), "cb", callback);
 	g_object_set_data (G_OBJECT (dialog), "ud", userdata);
@@ -881,7 +972,7 @@ gtkutil_copy_to_clipboard (GtkWidget *widget, GdkAtom selection,
 	win = gtk_widget_get_toplevel (GTK_WIDGET (widget));
 	if (gtk_widget_is_toplevel (win))
 	{
-		gint len = (gint) strlen (str);
+		int len = strlen (str);
 
 		if (selection)
 		{

src/fe-gtk/maingui.h

@@ -37,10 +37,8 @@ GtkWidget *mg_create_generic_tab (char *name, char *title, int force_toplevel, i
 void mg_set_title (GtkWidget *button, char *title);
 void mg_set_access_icon (session_gui *gui, GdkPixbuf *pix, gboolean away);
 void mg_apply_setup (void);
-void mg_apply_session_font_prefs (session_gui *gui);
 void mg_close_sess (session *);
 void mg_tab_close (session *sess);
-void mg_reopen_closed_channel_tab (void);
 void mg_detach (session *sess, int mode);
 void mg_progressbar_create (session_gui *gui);
 void mg_progressbar_destroy (session_gui *gui);
@@ -48,7 +46,6 @@ void mg_dnd_drop_file (session *sess, char *target, char *uri);
 void mg_change_layout (int type);
 void mg_update_meters (session_gui *);
 void mg_inputbox_cb (GtkWidget *igad, session_gui *gui);
-void mg_reply_update (session *sess);
 void mg_create_icon_item (char *label, char *stock, GtkWidget *menu, void *callback, void *userdata);
 GtkWidget *mg_submenu (GtkWidget *menu, char *text);
 /* DND */

src/fe-gtk/menu.c

@@ -36,7 +36,6 @@
 #include "../common/zoitechatc.h"
 #include "../common/cfgfiles.h"
 #include "../common/outbound.h"
-#include "../common/inbound.h"
 #include "../common/ignore.h"
 #include "../common/fe.h"
 #include "../common/server.h"
@@ -785,25 +784,6 @@ fe_userlist_update (session *sess, struct User *user)
 	}
 }
 
-
-static void
-menu_reply_to_latest_cb (GtkWidget *wid, gpointer data)
-{
-	reply_item *item;
-
-	item = reply_cache_latest_from (current_sess, str_copy);
-	if (!item)
-	{
-		PrintText (current_sess, _("No recent message to reply to.\n"));
-		return;
-	}
-
-	reply_state_set (current_sess, item->msgid, current_sess->channel, item->nick, item->text);
-	mg_reply_update (current_sess);
-	if (current_sess->gui && current_sess->gui->input_box)
-		gtk_widget_grab_focus (current_sess->gui->input_box);
-}
-
 void
 menu_nickmenu (session *sess, GdkEventButton *event, char *nick, int num_sel)
 {
@@ -847,12 +827,6 @@ menu_nickmenu (session *sess, GdkEventButton *event, char *nick, int num_sel)
 	else
 		menu_create (menu, popup_list, str_copy, FALSE);
 
-	if (num_sel <= 1)
-	{
-		menu_quick_item_with_callback (menu_reply_to_latest_cb, _("Reply"), menu, 0);
-		menu_quick_item (0, 0, menu, XCMENU_SHADED, 0, 0);
-	}
-
 	if (num_sel == 0)	/* xtext click */
 		menu_add_plugin_items (menu, "\x5$NICK", str_copy);
 	else	/* userlist treeview click */
@@ -1743,7 +1717,7 @@ menu_ctcpguiopen (void)
 static void
 menu_docs (GtkWidget *wid, gpointer none)
 {
-	fe_open_url ("https://docs.zoitechat.org/en/latest/");
+	fe_open_url ("https://docs.zoitechat.zoite.net/en/latest/");
 }
 
 /*static void
@@ -1781,6 +1755,44 @@ menu_change_layout (void)
 	}
 }
 
+void
+menu_update_quit_accel (void)
+{
+	GSList *list;
+
+	list = sess_list;
+	while (list)
+	{
+		session *sess = list->data;
+		session_gui *gui = sess->gui;
+		GtkWidget *item;
+		GtkAccelGroup *accel_group;
+		int enabled;
+
+		list = list->next;
+		if (!gui)
+			continue;
+
+		item = gui->menu_item[MENU_ID_QUIT];
+		if (!item)
+			continue;
+
+		enabled = GPOINTER_TO_INT (g_object_get_data (G_OBJECT (item), "zc-ctrlq-enabled"));
+		if (enabled == (int)prefs.hex_gui_ctrlq_quit)
+			continue;
+
+		accel_group = g_object_get_data (G_OBJECT (item), "zc-quit-accel-group");
+		if (!accel_group)
+			continue;
+
+		if (prefs.hex_gui_ctrlq_quit)
+			gtk_widget_add_accelerator (item, "activate", accel_group, GDK_KEY_q, STATE_CTRL, GTK_ACCEL_VISIBLE);
+		else
+			gtk_widget_remove_accelerator (item, accel_group, GDK_KEY_q, STATE_CTRL);
+		g_object_set_data (G_OBJECT (item), "zc-ctrlq-enabled", GINT_TO_POINTER (prefs.hex_gui_ctrlq_quit));
+	}
+}
+
 static void
 menu_layout_cb (GtkWidget *item, gpointer none)
 {
@@ -1850,7 +1862,7 @@ about_dialog_response (GtkDialog *dialog, int response, gpointer data)
 {
 	if (response == GTK_RESPONSE_HELP)
 	{
-		fe_open_url ("http://zoitechat.org");
+		fe_open_url ("http://zoitechat.zoite.net");
 		return;
 	}
 	if (response == GTK_RESPONSE_APPLY)
@@ -1903,7 +1915,14 @@ menu_about (GtkWidget *wid, gpointer sess)
 	gtk_about_dialog_set_website_label (dialog, NULL);
 	gtk_about_dialog_set_license (dialog, NULL);
 	gtk_about_dialog_set_wrap_license (dialog, FALSE);
-	gtk_about_dialog_set_logo (dialog, pix_zoitechat);
+	GdkPixbuf *about_logo;
+
+	about_logo = gdk_pixbuf_new_from_resource_at_scale ("/icons/zoitechat.svg", 48, 48, TRUE, NULL);
+	if (!about_logo && pix_zoitechat)
+		about_logo = gdk_pixbuf_scale_simple (pix_zoitechat, 48, 48, GDK_INTERP_BILINEAR);
+	gtk_about_dialog_set_logo (dialog, about_logo ? about_logo : pix_zoitechat);
+	if (about_logo)
+		g_object_unref (about_logo);
 	gtk_about_dialog_set_copyright (dialog, "\302\251 1998-2010 Peter \305\275elezn\303\275\n\302\251 2009-2014 Berke Viktor\n\302\251 2015-2025 Patrick Griffis\n\302\251 2026 deepend");
 	gtk_about_dialog_set_comments (dialog, comment);
 	actions = gtk_dialog_get_action_area (GTK_DIALOG (dialog));
@@ -1927,13 +1946,13 @@ menu_about (GtkWidget *wid, gpointer sess)
 
 static struct mymenu mymenu[] = {
 	{N_("_ZoiteChat"), 0, 0, M_NEWMENU, MENU_ID_ZOITECHAT, 0, 1},
-	{N_("Network Li_st"), menu_open_server_list, 0, M_MENUITEM, 0, 0, 1},
+	{N_("Network Li_st"), menu_open_server_list, 0, M_MENUITEM, 0, 0, 1, GDK_KEY_s},
 	{0, 0, 0, M_SEP, 0, 0, 0},
 
 	{N_("_New"), 0, 0, M_MENUSUB, 0, 0, 1},
-		{N_("Server Tab"), menu_newserver_tab, 0, M_MENUITEM, 0, 0, 1},
+		{N_("Server Tab"), menu_newserver_tab, 0, M_MENUITEM, 0, 0, 1, GDK_KEY_t},
 		{N_("Channel Tab"), menu_newchannel_tab, 0, M_MENUITEM, 0, 0, 1},
-		{N_("Server Window"), menu_newserver_window, 0, M_MENUITEM, 0, 0, 1},
+		{N_("Server Window"), menu_newserver_window, 0, M_MENUITEM, 0, 0, 1, GDK_KEY_n},
 		{N_("Channel Window"), menu_newchannel_window, 0, M_MENUITEM, 0, 0, 1},
 		{0, 0, 0, M_END, 0, 0, 0},
 	{0, 0, 0, M_SEP, 0, 0, 0},
@@ -1945,13 +1964,13 @@ static struct mymenu mymenu[] = {
 #define CLOSE_OFFSET (13)
 	{0, menu_close, 0, M_MENUITEM, 0, 0, 1},
 	{0, 0, 0, M_SEP, 0, 0, 0},
-	{N_("_Quit"), menu_quit, 0, M_MENUITEM, MENU_ID_QUIT, 0, 1},	/* 15 */
+	{N_("_Quit"), menu_quit, 0, M_MENUITEM, MENU_ID_QUIT, 0, 1, GDK_KEY_q},	/* 15 */
 
 	{N_("_View"), 0, 0, M_NEWMENU, 0, 0, 1},
 #define MENUBAR_OFFSET (17)
-	{N_("_Menu Bar"), menu_bar_toggle_cb, 0, M_MENUTOG, MENU_ID_MENUBAR, 0, 1},
+	{N_("_Menu Bar"), menu_bar_toggle_cb, 0, M_MENUTOG, MENU_ID_MENUBAR, 0, 1, GDK_KEY_F9},
 	{N_("_Topic Bar"), menu_topicbar_toggle, 0, M_MENUTOG, MENU_ID_TOPICBAR, 0, 1},
-	{N_("_User List"), menu_userlist_toggle, 0, M_MENUTOG, MENU_ID_USERLIST, 0, 1},
+	{N_("_User List"), menu_userlist_toggle, 0, M_MENUTOG, MENU_ID_USERLIST, 0, 1, GDK_KEY_F7},
 	{N_("U_ser List Buttons"), menu_ulbuttons_toggle, 0, M_MENUTOG, MENU_ID_ULBUTTONS, 0, 1},
 	{N_("M_ode Buttons"), menu_cmbuttons_toggle, 0, M_MENUTOG, MENU_ID_MODEBUTTONS, 0, 1},
 	{0, 0, 0, M_SEP, 0, 0, 0},
@@ -1968,7 +1987,7 @@ static struct mymenu mymenu[] = {
 		{N_("Both"), menu_metres_both, 0, M_MENURADIO, 0, 0, 1},
 		{0, 0, 0, M_END, 0, 0, 0},	/* 32 */
 	{ 0, 0, 0, M_SEP, 0, 0, 0 },
-	{N_ ("_Fullscreen"), menu_fullscreen_toggle, 0, M_MENUTOG, MENU_ID_FULLSCREEN, 0, 1},
+	{N_ ("_Fullscreen"), menu_fullscreen_toggle, 0, M_MENUTOG, MENU_ID_FULLSCREEN, 0, 1, GDK_KEY_F11},
 
 	{N_("_Server"), 0, 0, M_NEWMENU, 0, 0, 1},
 	{N_("_Disconnect"), menu_disconnect, 0, M_MENUITEM, MENU_ID_DISCONNECT, 0, 1},
@@ -1977,7 +1996,7 @@ static struct mymenu mymenu[] = {
 	{N_("Channel _List"), menu_chanlist, 0, M_MENUITEM, 0, 0, 1},
 	{0, 0, 0, M_SEP, 0, 0, 0},
 #define AWAY_OFFSET (41)
-	{N_("Marked _Away"), menu_away_toggle, 0, M_MENUITEM, MENU_ID_AWAY, 0, 1},
+	{N_("Marked _Away"), menu_away_toggle, 0, M_MENUITEM, MENU_ID_AWAY, 0, 1, GDK_KEY_a},
 
 	{N_("_Usermenu"), 0, 0, M_NEWMENU, MENU_ID_USERMENU, 0, 1},	/* 40 */
 
@@ -2005,191 +2024,25 @@ static struct mymenu mymenu[] = {
 	{N_("_Raw Log"), menu_rawlog, 0, M_MENUITEM, 0, 0, 1},	/* 61 */
 	{N_("_URL Grabber"), url_opengui, 0, M_MENUITEM, 0, 0, 1},
 	{0, 0, 0, M_SEP, 0, 0, 0},
-	{N_("Reset Marker Line"), menu_resetmarker, 0, M_MENUITEM, 0, 0, 1},
-	{N_("Move to Marker Line"), menu_movetomarker, 0, M_MENUITEM, 0, 0, 1},
-	{N_("_Copy Selection"), menu_copy_selection, 0, M_MENUITEM, 0, 0, 1},
+	{N_("Reset Marker Line"), menu_resetmarker, 0, M_MENUITEM, 0, 0, 1, GDK_KEY_m},
+	{N_("Move to Marker Line"), menu_movetomarker, 0, M_MENUITEM, 0, 0, 1, GDK_KEY_M},
+	{N_("_Copy Selection"), menu_copy_selection, 0, M_MENUITEM, 0, 0, 1, GDK_KEY_C},
 	{N_("C_lear Text"), menu_flushbuffer, 0, M_MENUITEM, 0, 0, 1},
 	{N_("Save Text" ELLIPSIS), menu_savebuffer, 0, M_MENUITEM, 0, 0, 1},
 #define SEARCH_OFFSET (70)
 	{N_("Search"), 0, 0, M_MENUSUB, 0, 0, 1},
-		{N_("Search Text" ELLIPSIS), menu_search, 0, M_MENUITEM, 0, 0, 1},
-		{N_("Search Next"   ), menu_search_next, 0, M_MENUITEM, 0, 0, 1},
-		{N_("Search Previous"   ), menu_search_prev, 0, M_MENUITEM, 0, 0, 1},
+		{N_("Search Text" ELLIPSIS), menu_search, 0, M_MENUITEM, 0, 0, 1, GDK_KEY_f},
+		{N_("Search Next"   ), menu_search_next, 0, M_MENUITEM, 0, 0, 1, GDK_KEY_g},
+		{N_("Search Previous"   ), menu_search_prev, 0, M_MENUITEM, 0, 0, 1, GDK_KEY_G},
 		{0, 0, 0, M_END, 0, 0, 0},
 
 	{N_("_Help"), 0, 0, M_NEWMENU, 0, 0, 1},	/* 74 */
-	{N_("_Contents"), menu_docs, 0, M_MENUITEM, 0, 0, 1},
+	{N_("_Contents"), menu_docs, 0, M_MENUITEM, 0, 0, 1, GDK_KEY_F1},
 	{N_("_About"), menu_about, 0, M_MENUITEM, 0, 0, 1},
 
 	{0, 0, 0, M_END, 0, 0, 0},
 };
 
-static const char *
-menu_get_key_action_name (int index)
-{
-	switch (index)
-	{
-	case 1:
-		return "network-list";
-	case 4:
-		return "new-server-tab";
-	case 6:
-		return "new-server-window";
-	case CLOSE_OFFSET:
-		return "close";
-	case 15:
-		return "quit";
-	case MENUBAR_OFFSET:
-		return "menu-toggle";
-	case MENUBAR_OFFSET + 2:
-		return "user-list-toggle";
-	case 34:
-		return "fullscreen-toggle";
-	case AWAY_OFFSET:
-		return "away-toggle";
-	case 65:
-		return "reset-marker";
-	case 66:
-		return "move-marker";
-	case 67:
-		return "copy-selection";
-	case SEARCH_OFFSET + 1:
-		return "search-text";
-	case SEARCH_OFFSET + 2:
-		return "search-next";
-	case SEARCH_OFFSET + 3:
-		return "search-previous";
-	case 75:
-		return "contents";
-	}
-
-	return NULL;
-}
-
-static void
-menu_add_keybinding_accel (GtkWidget *item, GtkAccelGroup *accel_group, const char *name)
-{
-	guint keyval;
-	GdkModifierType mod;
-
-	if (!accel_group || !key_get_menu_accel (name, &keyval, &mod))
-		return;
-
-	if (!strcmp (name, "quit") && !prefs.hex_gui_ctrlq_quit && keyval == GDK_KEY_q && mod == STATE_CTRL)
-		return;
-
-	gtk_widget_add_accelerator (item, "activate", accel_group, keyval, mod, GTK_ACCEL_VISIBLE);
-	g_object_set_data (G_OBJECT (item), "zc-key-accel-key", GUINT_TO_POINTER (keyval));
-	g_object_set_data (G_OBJECT (item), "zc-key-accel-mod", GUINT_TO_POINTER (mod));
-}
-
-static void
-menu_refresh_keybinding_accels (GtkWidget *widget, gpointer data)
-{
-	GtkAccelGroup *accel_group = data;
-	const char *name;
-	guint keyval;
-	GdkModifierType mod;
-	GtkWidget *submenu;
-	GList *children, *list;
-
-	if (GTK_IS_MENU_ITEM (widget))
-	{
-		keyval = GPOINTER_TO_UINT (g_object_get_data (G_OBJECT (widget), "zc-key-accel-key"));
-		mod = GPOINTER_TO_UINT (g_object_get_data (G_OBJECT (widget), "zc-key-accel-mod"));
-		if (keyval != 0)
-		{
-			gtk_widget_remove_accelerator (widget, accel_group, keyval, mod);
-			g_object_set_data (G_OBJECT (widget), "zc-key-accel-key", NULL);
-			g_object_set_data (G_OBJECT (widget), "zc-key-accel-mod", NULL);
-		}
-
-		name = g_object_get_data (G_OBJECT (widget), "zc-key-action");
-		menu_add_keybinding_accel (widget, accel_group, name);
-
-		submenu = gtk_menu_item_get_submenu (GTK_MENU_ITEM (widget));
-		if (submenu)
-			menu_refresh_keybinding_accels (submenu, data);
-	}
-
-	if (GTK_IS_CONTAINER (widget))
-	{
-		children = gtk_container_get_children (GTK_CONTAINER (widget));
-		for (list = children; list; list = g_list_next (list))
-			menu_refresh_keybinding_accels (list->data, data);
-		g_list_free (children);
-	}
-}
-
-void
-menu_update_quit_accel (void)
-{
-	session *sess;
-	GSList *list;
-	GtkAccelGroup *accel_group;
-
-	list = sess_list;
-	while (list)
-	{
-		sess = list->data;
-		if (sess && sess->gui && sess->gui->menu)
-		{
-			accel_group = g_object_get_data (G_OBJECT (sess->gui->menu), "accel");
-			if (accel_group)
-				menu_refresh_keybinding_accels (sess->gui->menu, accel_group);
-		}
-		list = g_slist_next (list);
-	}
-}
-
-gboolean
-menu_key_action (const char *name, guint keyval, GdkModifierType state)
-{
-	if (!name)
-		return FALSE;
-
-	if (!strcmp (name, "network-list"))
-		menu_open_server_list (NULL, NULL);
-	else if (!strcmp (name, "new-server-tab"))
-		menu_newserver_tab (NULL, NULL);
-	else if (!strcmp (name, "new-server-window"))
-		menu_newserver_window (NULL, NULL);
-	else if (!strcmp (name, "close"))
-		menu_close (NULL, NULL);
-	else if (!strcmp (name, "quit"))
-	{
-		if (!prefs.hex_gui_ctrlq_quit && keyval == GDK_KEY_q && (state & (GDK_SHIFT_MASK | GDK_CONTROL_MASK | GDK_MOD1_MASK)) == STATE_CTRL)
-			return FALSE;
-		menu_quit (NULL, NULL);
-	}
-	else if (!strcmp (name, "menu-toggle"))
-		menu_bar_toggle_cb ();
-	else if (!strcmp (name, "user-list-toggle"))
-		menu_userlist_toggle (NULL, NULL);
-	else if (!strcmp (name, "fullscreen-toggle"))
-		menu_fullscreen_toggle (NULL, NULL);
-	else if (!strcmp (name, "away-toggle"))
-		menu_away_toggle (NULL, NULL);
-	else if (!strcmp (name, "reset-marker"))
-		menu_resetmarker (NULL, NULL);
-	else if (!strcmp (name, "move-marker"))
-		menu_movetomarker (NULL, NULL);
-	else if (!strcmp (name, "copy-selection"))
-		menu_copy_selection (NULL, NULL);
-	else if (!strcmp (name, "search-text"))
-		menu_search ();
-	else if (!strcmp (name, "search-next"))
-		menu_search_next (NULL);
-	else if (!strcmp (name, "search-previous"))
-		menu_search_prev (NULL);
-	else if (!strcmp (name, "contents"))
-		menu_docs (NULL, NULL);
-	else
-		return FALSE;
-
-	return TRUE;
-}
-
 void
 menu_set_away (session_gui *gui, int away)
 {
@@ -2463,7 +2316,7 @@ menu_reorder (GtkMenu *menu, GtkWidget *item, int pos)
 	if (pos < 0)	/* position offset from end/bottom */
 	{
 		GList *children = gtk_container_get_children (GTK_CONTAINER (menu));
-		gint length = (gint) g_list_length (children);
+		int length = g_list_length (children);
 
 		g_list_free (children);
 		gtk_menu_reorder_child (menu, item, (length + pos) - 1);
@@ -2535,7 +2388,7 @@ menu_add_sub (GtkWidget *menu, menu_entry *me)
 		if (pos < 0)	/* position offset from end/bottom */
 		{
 			GList *children = gtk_container_get_children (GTK_CONTAINER (menu));
-			gint length = (gint) g_list_length (children);
+			int length = g_list_length (children);
 
 			g_list_free (children);
 			pos = length + pos;
@@ -2795,8 +2648,6 @@ menu_create_main (void *accel_group, int bar, int away, int toplevel,
 		case M_MENUITEM:
 			item = gtk_menu_item_new_with_mnemonic (_(mymenu[i].text));
 normalitem:
-			g_object_set_data (G_OBJECT (item), "zc-key-action", (gpointer) menu_get_key_action_name (i));
-			menu_add_keybinding_accel (item, accel_group, menu_get_key_action_name (i));
 			if (mymenu[i].key != 0 && !(mymenu[i].id == MENU_ID_QUIT && !prefs.hex_gui_ctrlq_quit))
 				gtk_widget_add_accelerator (item, "activate", accel_group,
 									mymenu[i].key,
@@ -2825,8 +2676,6 @@ normalitem:
 		case M_MENUTOG:
 			item = gtk_check_menu_item_new_with_mnemonic (_(mymenu[i].text));
 togitem:
-			g_object_set_data (G_OBJECT (item), "zc-key-action", (gpointer) menu_get_key_action_name (i));
-			menu_add_keybinding_accel (item, accel_group, menu_get_key_action_name (i));
 			/* must avoid callback for Radio buttons */
 			gtk_check_menu_item_set_active (GTK_CHECK_MENU_ITEM (item), mymenu[i].state);
 			/*gtk_check_menu_item_set_active (GTK_CHECK_MENU_ITEM (item),

src/fe-gtk/menu.h

@@ -39,7 +39,6 @@ void menu_bar_toggle (void);
 void menu_add_plugin_items (GtkWidget *menu, char *root, char *target);
 void menu_change_layout (void);
 void menu_update_quit_accel (void);
-gboolean menu_key_action (const char *name, guint keyval, GdkModifierType state);
 
 void menu_set_away (session_gui *gui, int away);
 void menu_set_fullscreen (session_gui *gui, int fullscreen);

src/fe-gtk/meson.build

@@ -50,7 +50,7 @@ zoitechat_gtk_deps = [
 
 gtk_dep = dependency('gtk+-3.0', version: '>= 3.22')
 
-zoitechat_theme_deps = [gtk_dep, zoitechat_common_dep]
+zoitechat_theme_deps = [gtk_dep]
 
 if host_machine.system() != 'windows'
   appindicator_opt = get_option('appindicator')
@@ -117,9 +117,29 @@ if get_option('plugin')
   zoitechat_gtk_sources += 'plugingui.c'
 endif
 
+find_program('magick', required: true)
+
+zoitechat_png_generated = custom_target('zoitechat_resource_png',
+  input: '../../data/icons/zoitechat.svg',
+  output: 'zoitechat.png',
+  command: [find_program('../../data/icons/generate_icons.py'), '@INPUT@', '@OUTPUT@', '--size', '256'],
+)
+
+zoitechat_gresource_conf = configuration_data()
+zoitechat_gresource_conf.set('ZOITECHAT_PNG', 'zoitechat.png')
+zoitechat_gresource_xml = configure_file(
+  input: '../../data/zoitechat.gresource.xml.in',
+  output: 'zoitechat.gresource.xml',
+  configuration: zoitechat_gresource_conf,
+)
+
 resources = gnome.compile_resources('resources',
-  '../../data/zoitechat.gresource.xml',
-  source_dir: '../../data',
+  zoitechat_gresource_xml,
+  source_dir: [
+    meson.current_build_dir(),
+    '../../data',
+  ],
+  dependencies: [zoitechat_png_generated],
   c_name: 'zoitechat',
   extra_args: ['--manual-register']
 )
@@ -241,6 +261,7 @@ test('Theme GTK3 Settings Tests', theme_gtk3_settings_tests,
   timeout: 120,
 )
 
+
 theme_preferences_gtk3_populate_tests = executable('theme_preferences_gtk3_populate_tests',
   'theme/tests/test-theme-preferences-gtk3-populate.c',
   include_directories: [config_h_include],

src/fe-gtk/notifications/notification-freedesktop.c

@@ -56,7 +56,7 @@ notification_backend_show (const char *title, const char *text)
     g_variant_builder_init (&params, G_VARIANT_TYPE ("(susssasa{sv}i)"));
     g_variant_builder_add (&params, "s", "zoitechat"); /* App name */
     g_variant_builder_add (&params, "u", 0); /* ID, 0 means don't replace */
-    g_variant_builder_add (&params, "s", "net.zoite.Zoitechat"); /* App icon */
+    g_variant_builder_add (&params, "s", "io.github.Hexchat"); /* App icon */
     g_variant_builder_add (&params, "s", title);
     g_variant_builder_add (&params, "s", text);
     g_variant_builder_add (&params, "as", NULL); /* Actions */
@@ -65,7 +65,7 @@ notification_backend_show (const char *title, const char *text)
     g_variant_builder_open (&params, G_VARIANT_TYPE ("a{sv}"));
     g_variant_builder_open (&params, G_VARIANT_TYPE ("{sv}"));
     g_variant_builder_add (&params, "s", "desktop-entry");
-    g_variant_builder_add (&params, "v", g_variant_new_string ("net.zoite.Zoitechat"));
+    g_variant_builder_add (&params, "v", g_variant_new_string ("io.github.Hexchat"));
     g_variant_builder_close (&params);
     g_variant_builder_close (&params);
 

src/fe-gtk/plugin-tray.c

@@ -48,9 +48,6 @@ typedef struct _GtkStatusIcon GtkStatusIcon;
 
 #ifndef WIN32
 #include <unistd.h>
-#else
-#include <windows.h>
-#include <gdk/gdkwin32.h>
 #endif
 
 typedef enum	/* current icon status */
@@ -858,7 +855,6 @@ tray_toggle_visibility (gboolean force_hide)
 	static int maximized;
 	static int fullscreen;
 	GtkWindow *win;
-	WinStatus status;
 
 	if (!tray_backend_active)
 		return FALSE;
@@ -874,9 +870,7 @@ tray_toggle_visibility (gboolean force_hide)
 	if (!win)
 		return FALSE;
 
-	status = tray_get_window_status ();
-
-	if (force_hide || status != WS_HIDDEN)
+	if (force_hide || gtk_widget_get_visible (GTK_WIDGET (win)))
 	{
 		if (prefs.hex_gui_tray_away)
 			zoitechat_command (ph, "ALLSERV AWAY");
@@ -896,8 +890,8 @@ tray_toggle_visibility (gboolean force_hide)
 			gtk_window_maximize (win);
 		if (fullscreen)
 			gtk_window_fullscreen (win);
-		gtk_window_deiconify (win);
 		gtk_widget_show (GTK_WIDGET (win));
+		gtk_window_deiconify (win);
 		gtk_window_present (win);
 	}
 
@@ -925,12 +919,9 @@ tray_menu_notify_cb (GObject *tray, GParamSpec *pspec, gpointer user_data)
 	if (tray_backend_active)
 	{
 		if (!tray_backend_is_embedded ())
-		{
-			if (!tray_restore_timer)
 		{
 			tray_restore_timer = g_timeout_add(500, (GSourceFunc)tray_menu_try_restore, NULL);
 		}
-		}
 		else
 		{
 			if (tray_restore_timer)
@@ -945,10 +936,9 @@ tray_menu_notify_cb (GObject *tray, GParamSpec *pspec, gpointer user_data)
 static gboolean
 tray_menu_try_restore (void)
 {
-	tray_restore_timer = 0;
 	tray_cleanup();
 	tray_init();
-	return G_SOURCE_REMOVE;
+	return TRUE;
 }
 
 static void
@@ -1095,119 +1085,6 @@ tray_menu_settings (GtkWidget * wid, gpointer none)
 	setup_open ();
 }
 
-#ifdef WIN32
-#define TRAY_WIN32_HIDE 1
-#define TRAY_WIN32_AWAY 2
-#define TRAY_WIN32_BACK 3
-#define TRAY_WIN32_PREFS 4
-#define TRAY_WIN32_QUIT 5
-
-static WCHAR *
-tray_win32_menu_label (const char *label)
-{
-	char *plain;
-	char *src;
-	char *dst;
-	WCHAR *wide;
-
-	plain = g_strdup (label ? label : "");
-	for (src = plain, dst = plain; *src; src++)
-	{
-		if (*src == '_')
-			continue;
-		*dst++ = *src;
-	}
-	*dst = 0;
-	wide = g_utf8_to_utf16 (plain, -1, NULL, NULL, NULL);
-	g_free (plain);
-
-	return wide;
-}
-
-static void
-tray_win32_append_item (HMENU menu, UINT id, const char *label, gboolean enabled)
-{
-	WCHAR *wide;
-
-	wide = tray_win32_menu_label (label);
-	AppendMenuW (menu, MF_STRING | (enabled ? MF_ENABLED : MF_GRAYED), id, wide);
-	g_free (wide);
-}
-
-static HWND
-tray_win32_get_hwnd (void)
-{
-	GtkWindow *win;
-	GdkWindow *gdk_win;
-
-	win = GTK_WINDOW (zoitechat_get_info (ph, "gtkwin_ptr"));
-	if (!win)
-		return GetActiveWindow ();
-
-	gdk_win = gtk_widget_get_window (GTK_WIDGET (win));
-	if (!gdk_win)
-		return GetActiveWindow ();
-
-	return gdk_win32_window_get_handle (gdk_win);
-}
-
-static void
-tray_win32_menu_cb (void)
-{
-	HMENU menu;
-	POINT point;
-	UINT command;
-	HWND hwnd;
-	int away_status;
-
-	zoitechat_set_context (ph, zoitechat_find_context (ph, NULL, NULL));
-
-	menu = CreatePopupMenu ();
-	if (!menu)
-		return;
-
-	away_status = tray_find_away_status ();
-	tray_win32_append_item (menu, TRAY_WIN32_HIDE,
-		tray_get_window_status () == WS_HIDDEN ? _("_Restore Window") : _("_Hide Window"), TRUE);
-	AppendMenuW (menu, MF_SEPARATOR, 0, NULL);
-	tray_win32_append_item (menu, TRAY_WIN32_AWAY, _("_Away"), away_status != 1);
-	tray_win32_append_item (menu, TRAY_WIN32_BACK, _("_Back"), away_status != 2);
-	AppendMenuW (menu, MF_SEPARATOR, 0, NULL);
-	tray_win32_append_item (menu, TRAY_WIN32_PREFS, _("_Preferences"), TRUE);
-	AppendMenuW (menu, MF_SEPARATOR, 0, NULL);
-	tray_win32_append_item (menu, TRAY_WIN32_QUIT, _("_Quit"), TRUE);
-
-	GetCursorPos (&point);
-	hwnd = tray_win32_get_hwnd ();
-	if (hwnd)
-		SetForegroundWindow (hwnd);
-	command = TrackPopupMenu (menu, TPM_RIGHTBUTTON | TPM_RETURNCMD | TPM_NONOTIFY,
-		point.x, point.y, 0, hwnd, NULL);
-	DestroyMenu (menu);
-
-	switch (command)
-	{
-	case TRAY_WIN32_HIDE:
-		tray_toggle_visibility (FALSE);
-		break;
-	case TRAY_WIN32_AWAY:
-		tray_foreach_server (NULL, "away");
-		break;
-	case TRAY_WIN32_BACK:
-		tray_foreach_server (NULL, "back");
-		break;
-	case TRAY_WIN32_PREFS:
-		tray_menu_settings (NULL, NULL);
-		break;
-	case TRAY_WIN32_QUIT:
-		tray_menu_quit_cb (NULL, NULL);
-		break;
-	default:
-		break;
-	}
-}
-#endif
-
 static void
 tray_menu_populate (GtkWidget *menu)
 {
@@ -1335,15 +1212,6 @@ tray_window_visibility_cb (GtkWidget *widget, gpointer userdata)
 static void
 tray_menu_cb (GtkWidget *widget, guint button, guint time, gpointer userdata)
 {
-#ifdef WIN32
-	(void)widget;
-	(void)button;
-	(void)time;
-	(void)userdata;
-
-	tray_win32_menu_cb ();
-	return;
-#else
 	static GtkWidget *menu;
 
 	(void)button;
@@ -1383,7 +1251,6 @@ tray_menu_cb (GtkWidget *widget, guint button, guint time, gpointer userdata)
 		if (event)
 			gdk_event_free (event);
 	}
-#endif
 }
 #endif
 
@@ -1539,11 +1406,6 @@ tray_cleanup (void)
 void
 tray_apply_setup (void)
 {
-	/* Theme/setup events can be dispatched before the tray plugin has
-	 * been registered; there is nothing to (de)activate yet. */
-	if (!ph)
-		return;
-
 	if (tray_backend_active)
 	{
 		if (!prefs.hex_gui_tray)