theming: respect system theme by default

.github/workflows/manjaro-package-build.yml

@@ -0,0 +1,79 @@
+name: Manjaro Package Build
+
+on:
+  push:
+    branches: [master, main]
+  pull_request:
+    branches: [master, main]
+  workflow_dispatch:
+
+permissions:
+  contents: read
+
+jobs:
+  manjaro-package:
+    runs-on: ubuntu-latest
+    container:
+      image: manjarolinux/base:latest
+
+    steps:
+      - name: Install packaging toolchain
+        run: |
+          set -euxo pipefail
+          pacman -Syu --noconfirm
+          pacman -S --noconfirm --needed \
+            base-devel \
+            git \
+            namcap \
+            meson \
+            ninja \
+            pkgconf \
+            glib2 \
+            glib2-devel \
+            gtk3 \
+            openssl \
+            libcanberra \
+            libayatana-appindicator \
+            iso-codes \
+            lua \
+            perl \
+            python \
+            python-cffi \
+            pciutils
+
+      - name: Checkout repository
+        uses: actions/checkout@v5
+        with:
+          fetch-depth: 0
+          submodules: true
+
+      - name: Build package and generate .SRCINFO (non-root)
+        run: |
+          set -euxo pipefail
+          id -u builder >/dev/null 2>&1 || useradd -m builder
+          chown -R builder:builder "$GITHUB_WORKSPACE"
+          su builder -c "cd '$GITHUB_WORKSPACE/packaging/manjaro' && makepkg --noconfirm --syncdeps --cleanbuild"
+          su builder -c "cd '$GITHUB_WORKSPACE/packaging/manjaro' && makepkg --printsrcinfo > .SRCINFO"
+
+      - name: Lint PKGBUILD and package with namcap
+        run: |
+          set -euxo pipefail
+          cd "$GITHUB_WORKSPACE/packaging/manjaro"
+          namcap PKGBUILD
+          pkg_file="$(find . -maxdepth 1 -type f -name '*.pkg.tar.*' | head -n1)"
+          namcap "$pkg_file"
+
+      - name: Collect artifacts
+        run: |
+          set -euxo pipefail
+          mkdir -p artifacts
+          cp -v "$GITHUB_WORKSPACE"/packaging/manjaro/*.pkg.tar.* artifacts/
+          cp -v "$GITHUB_WORKSPACE"/packaging/manjaro/PKGBUILD artifacts/
+          cp -v "$GITHUB_WORKSPACE"/packaging/manjaro/.SRCINFO artifacts/
+
+      - name: Upload package artifacts
+        uses: actions/upload-artifact@v6
+        with:
+          name: zoitechat-manjaro-package
+          path: artifacts/*
+          if-no-files-found: error

.github/workflows/windows-build.yml

@@ -113,26 +113,6 @@ jobs:
             New-Item -Path $pyDir -Name "${{ matrix.platform }}" -ItemType Junction -Value $pyRoot | Out-Null
           }
 
-      - uses: actions/setup-python@v6
-        with:
-          python-version: '3.8.10'
-          architecture: ${{ matrix.arch }}
-
-      - name: Prepare Python 3.8
-        run: |
-          python -m pip install --upgrade pip
-          python -m pip install cffi
-
-          $pyRoot = $env:pythonLocation
-          if (-not $pyRoot) { $pyRoot = & python -c "import sys; print(sys.prefix)" }
-
-          foreach ($pyDir in @("C:\gtk-build\python-3.8.10", "C:\gtk-build\python-3.8")) {
-            New-Item -Path $pyDir -ItemType Directory -Force | Out-Null
-            $target = Join-Path $pyDir "${{ matrix.platform }}"
-            if (Test-Path $target) { Remove-Item $target -Recurse -Force }
-            New-Item -Path $pyDir -Name "${{ matrix.platform }}" -ItemType Junction -Value $pyRoot | Out-Null
-          }
-
       - name: Build
         run: |
           call "C:\Program Files\Microsoft Visual Studio\2022\Enterprise\Common7\Tools\VsDevCmd.bat"
@@ -144,33 +124,12 @@ jobs:
             exit /b 1
           )
 
-          set "PYTHON38_DIR=C:\gtk-build\python-3.8\${{ matrix.platform }}"
-          if not exist "%PYTHON38_DIR%\libs\python38.lib" (
-            echo Missing %PYTHON38_DIR%\libs\python38.lib
-            dir "%PYTHON38_DIR%\libs"
-            exit /b 1
-          )
-          if not exist "%PYTHON38_DIR%\Lib\site-packages\_cffi_backend.cp38*.pyd" (
-            echo Missing %PYTHON38_DIR%\Lib\site-packages\_cffi_backend.cp38*.pyd
-            exit /b 1
-          )
-
           set "LIB=%PYTHON_DIR%\libs;%LIB%"
           set "INCLUDE=%PYTHON_DIR%\include;%INCLUDE%"
 
           powershell -NoProfile -ExecutionPolicy Bypass -Command "$archiveLib='C:\gtk-build\gtk\x64\release\lib\libarchive.lib'; if (-not (Test-Path $archiveLib)) { $archiveDll = Get-ChildItem 'C:\gtk-build\gtk\x64\release\bin\libarchive*.dll' | Select-Object -First 1; if ($archiveDll) { Push-Location 'C:\gtk-build\gtk\x64\release\lib'; & 'C:\gtk-build\gendef\gendef.exe' $archiveDll.FullName | Out-Null; $archiveDef = Get-ChildItem 'libarchive*.def' | Select-Object -First 1; if ($archiveDef) { & lib /def:$archiveDef.Name /machine:${{ matrix.platform }} /out:libarchive.lib | Out-Null }; Pop-Location } }"
 
           msbuild win32\zoitechat.sln /m /verbosity:minimal /p:Configuration=Release /p:Platform=${{ matrix.platform }}
-          if errorlevel 1 exit /b 1
-
-          if not exist "..\zoitechat-build\${{ matrix.platform }}\rel\plugins\hcpython38.dll" (
-            echo hcpython38.dll was not built
-            exit /b 1
-          )
-          if not exist "..\zoitechat-build\${{ matrix.platform }}\rel\_cffi_backend.cp38*.pyd" (
-            echo _cffi_backend for Python 3.8 was not staged for the installer
-            exit /b 1
-          )
         shell: cmd
 
       - name: Preparing Artifacts

packaging/manjaro/PKGBUILD

@@ -0,0 +1,69 @@
+# Maintainer: ZoiteChat Maintainers <zoitechat@users.noreply.github.com>
+
+pkgname=zoitechat-git
+pkgver=0
+pkgrel=1
+pkgdesc='IRC client for GNOME (ZoiteChat development snapshot)'
+arch=('x86_64')
+url='https://github.com/zoitechat/zoitechat'
+license=('GPL-2.0-or-later')
+depends=(
+  'glib2'
+  'gtk3'
+  'iso-codes'
+  'libayatana-appindicator'
+  'libcanberra'
+  'lua'
+  'openssl'
+  'perl'
+  'python-cffi'
+)
+makedepends=(
+  'git'
+  'meson'
+  'ninja'
+  'pkgconf'
+  'python'
+)
+optdepends=(
+  'pciutils: sysinfo plugin hardware detection details'
+)
+provides=('zoitechat')
+conflicts=('zoitechat')
+
+_repo_root="$(cd "$(dirname "${BASH_SOURCE[0]}")/../.." && pwd)"
+source=("zoitechat::git+file://${_repo_root}")
+sha256sums=('SKIP')
+
+pkgver() {
+  cd "$srcdir/zoitechat"
+
+  if git describe --long --tags --abbrev=7 >/dev/null 2>&1; then
+    git describe --long --tags --abbrev=7 \
+      | sed 's/^v//' \
+      | sed -E 's/([^-]+)-([0-9]+)-g/\1.r\2.g/' \
+      | sed 's/-/./g'
+  else
+    printf '0.r%s.%s\n' \
+      "$(git rev-list --count HEAD)" \
+      "$(git rev-parse --short=7 HEAD)"
+  fi
+}
+
+build() {
+  arch-meson zoitechat build \
+    -Dtext-frontend=false \
+    -Dwith-checksum=true \
+    -Dwith-fishlim=true \
+    -Dwith-lua=lua \
+    -Dwith-perl=perl \
+    -Dwith-python=python3 \
+    -Dwith-sysinfo=true \
+    -Dinstall-plugin-metainfo=true
+
+  meson compile -C build
+}
+
+package() {
+  meson install -C build --destdir "$pkgdir"
+}

plugins/python/generate_plugin.py

@@ -53,16 +53,6 @@ builder.set_source('_zoitechat_embedded', '''
 #include "config.h"
 #include "zoitechat-plugin.h"
 
-#ifdef _WIN32
-#ifndef WIN32_LEAN_AND_MEAN
-#define WIN32_LEAN_AND_MEAN
-#endif
-#ifndef NOMINMAX
-#define NOMINMAX
-#endif
-#include <windows.h>
-#endif
-
 static zoitechat_plugin *ph;
 CFFI_DLLEXPORT int _on_plugin_init(char **, char **, char **, char *, char *);
 CFFI_DLLEXPORT int _on_plugin_deinit(void);
@@ -71,20 +61,6 @@ int zoitechat_plugin_init(zoitechat_plugin *plugin_handle,
                         char **name_out, char **description_out,
                         char **version_out, char *arg)
 {
-#ifdef _WIN32
-    /* CPython cannot be removed from a process once Py_Initialize has run.
-       If the embedded interpreter fails to start (e.g. _cffi_backend is
-       missing), the host responds to our 0 return by g_module_close()ing
-       this plugin, which would also drop the last reference to pythonXY.dll
-       and unload it mid-flight; the leftover process-global state then
-       crashes the process later, e.g. when a server connection spawns the
-       next thread.  Pin this module so FreeLibrary can never unload it. */
-    HMODULE self_handle;
-    GetModuleHandleExW (GET_MODULE_HANDLE_EX_FLAG_PIN |
-                        GET_MODULE_HANDLE_EX_FLAG_FROM_ADDRESS,
-                        (LPCWSTR)&zoitechat_plugin_init, &self_handle);
-#endif
-
     if (ph != NULL)
     {
         puts ("Python plugin already loaded\\n");

plugins/python/python38.vcxproj

@@ -1,64 +0,0 @@
-<?xml version="1.0" encoding="utf-8"?>
-<Project DefaultTargets="Build" ToolsVersion="12.0" xmlns="http://schemas.microsoft.com/developer/msbuild/2003">
-  <PropertyGroup Label="Configuration">
-    <PlatformToolset>v142</PlatformToolset>
-    <ConfigurationType>DynamicLibrary</ConfigurationType>
-  </PropertyGroup>
-  <ItemGroup Label="ProjectConfigurations">
-    <ProjectConfiguration Include="Release|Win32">
-      <Configuration>Release</Configuration>
-      <Platform>Win32</Platform>
-    </ProjectConfiguration>
-    <ProjectConfiguration Include="Release|x64">
-      <Configuration>Release</Configuration>
-      <Platform>x64</Platform>
-    </ProjectConfiguration>
-  </ItemGroup>
-  <PropertyGroup Label="Globals">
-    <ProjectGuid>{D58924D2-1492-4AC3-B058-7A214424EEDC}</ProjectGuid>
-    <Keyword>Win32Proj</Keyword>
-    <RootNamespace>python38</RootNamespace>
-  </PropertyGroup>
-  <Import Project="$(VCTargetsPath)\Microsoft.Cpp.Default.props" />
-  <Import Project="$(VCTargetsPath)\Microsoft.Cpp.props" />
-  <Import Project="$(UserRootDir)\Microsoft.Cpp.$(Platform).user.props" Condition="exists('$(UserRootDir)\Microsoft.Cpp.$(Platform).user.props')" Label="LocalAppDataPlatform" />
-  <Import Project="..\..\win32\zoitechat.props" />
-  <PropertyGroup>
-    <TargetName>$(Python38Output)</TargetName>
-    <OutDir>$(ZoiteChatRel)plugins\</OutDir>
-  </PropertyGroup>
-   <ItemDefinitionGroup Condition="'$(Configuration)|$(Platform)'=='Release|x64'">
-    <ClCompile>
-      <PreprocessorDefinitions>WIN32;_WIN64;_AMD64_;NDEBUG;_WINDOWS;_USRDLL;PYTHON_EXPORTS;Py_NO_LINK_LIB;$(OwnFlags);%(PreprocessorDefinitions)</PreprocessorDefinitions>
-      <UndefinePreprocessorDefinitions>_DEBUG;Py_DEBUG;Py_REF_DEBUG;Py_TRACE_REFS;%(UndefinePreprocessorDefinitions)</UndefinePreprocessorDefinitions>
-      <AdditionalOptions>/U_DEBUG /UPy_DEBUG /UPy_REF_DEBUG /UPy_TRACE_REFS %(AdditionalOptions)</AdditionalOptions>
-      <RuntimeLibrary>MultiThreadedDLL</RuntimeLibrary>
-      <AdditionalIncludeDirectories>$(Glib);$(Python38Path)\include;..\..\src\common;$(ZoiteChatLib);%(AdditionalIncludeDirectories)</AdditionalIncludeDirectories>
-    </ClCompile>
-    <Link>
-      <ModuleDefinitionFile>python.def</ModuleDefinitionFile>
-      <AdditionalDependencies>"$(Python38Lib).lib";$(DepLibs);%(AdditionalDependencies)</AdditionalDependencies>
-      <AdditionalLibraryDirectories>$(DepsRoot)\lib;$(Python38Path)\libs;%(AdditionalLibraryDirectories)</AdditionalLibraryDirectories>
-    </Link>
-    <PreBuildEvent>
-      <Command>"$(Python38Path)\python.exe" generate_plugin.py ..\..\src\common\zoitechat-plugin.h python.py "$(IntDir)python.c"</Command>
-    </PreBuildEvent>
-  </ItemDefinitionGroup>
-  <ItemGroup>
-    <None Include="generate_plugin.py" />
-    <None Include="zoitechat.py" />
-    <None Include="python.def" />
-    <None Include="python.py" />
-    <None Include="xchat.py" />
-    <None Include="hexchat.py" />
-    <None Include="_zoitechat.py" />
-  </ItemGroup>
-  <ItemGroup>
-    <ClCompile Include="$(IntDir)python.c" />
-  </ItemGroup>
-  <Import Project="$(VCTargetsPath)\Microsoft.Cpp.targets" />
-</Project>
-
-
-
-

po/POTFILES

@@ -28,7 +28,6 @@ src/fe-gtk/fe-gtk.c
 src/fe-gtk/fkeys.c
 src/fe-gtk/gtkutil.c
 src/fe-gtk/ignoregui.c
-src/fe-gtk/inline-image.c
 src/fe-gtk/joind.c
 src/fe-gtk/maingui.c
 src/fe-gtk/menu.c

src/common/cfgfiles.c

@@ -564,7 +564,6 @@ const struct prefs vars[] =
 	{"net_proxy_use", P_OFFINT (hex_net_proxy_use), TYPE_INT},
 	{"net_proxy_user", P_OFFSET (hex_net_proxy_user), TYPE_STR},
 	{"net_reconnect_delay", P_OFFINT (hex_net_reconnect_delay), TYPE_INT},
-	{"net_remote_media", P_OFFINT (hex_net_remote_media), TYPE_BOOL},
 	{"net_throttle", P_OFFINT (hex_net_throttle), TYPE_BOOL},
 
 	{"notify_timeout", P_OFFINT (hex_notify_timeout), TYPE_INT},
@@ -777,8 +776,6 @@ load_default_config(void)
 	prefs.hex_gui_hide_menu = 1;
 #endif
 	prefs.hex_gui_ctrlq_quit = 1;
-	/* hex_net_remote_media stays 0: loading remote media can reveal the
-	   user's IP address, so it is strictly opt-in */
 	prefs.hex_gui_input_attr = 1;
 	prefs.hex_gui_input_icon = 1;
 	prefs.hex_gui_input_nick = 1;

src/common/fe.h

@@ -142,7 +142,6 @@ void fe_set_away (server *serv);
 void fe_serverlist_open (session *sess);
 void fe_get_bool (char *title, char *prompt, void *callback, void *userdata);
 void fe_get_str (char *prompt, char *def, void *callback, void *ud);
-void fe_get_password (char *prompt, void *callback, void *ud);
 void fe_get_int (char *prompt, int def, void *callback, void *ud);
 #define FRF_WRITE 1				/* save file */
 #define FRF_MULTIPLE 2			/* multi-select */

src/common/gtk3-theme-service.c

@@ -695,15 +695,10 @@ zoitechat_gtk3_theme_service_discover (void)
 		else
 			user_data_themes = g_build_filename (g_get_user_data_dir (), "themes", NULL);
 	}
-	/* Scan the app's own themes dir first: imported themes get a symlink
-	 * under the XDG data themes dir so GTK can resolve gtk-theme-name, and
-	 * scanning that link first would make the canonical-root dedup keep
-	 * the symlink path - changing the theme's path-derived id and breaking
-	 * the saved gui_gtk3_theme reference on the next start. */
-	add_theme_root (user_roots, seen_user_roots, user_dir);
 	add_theme_root (user_roots, seen_user_roots, user_data_themes);
 	g_free (user_data_themes);
 	add_theme_root (user_roots, seen_user_roots, home_themes);
+	add_theme_root (user_roots, seen_user_roots, user_dir);
 
 	{
 		const char *xdg_data_dirs = g_getenv ("XDG_DATA_DIRS");

src/common/plugin.c

@@ -25,7 +25,6 @@
 
 #ifdef WIN32
 #include <io.h>
-#include <windows.h>
 #else
 #include <unistd.h>
 #endif
@@ -57,36 +56,6 @@ typedef struct session zoitechat_context;
 #endif
 
 #define DEBUG(x) {x;}
-#ifdef WIN32
-
-/* Python >= 3.9 dropped support for Windows versions before 10, so those
- * systems get a Python 3.8 build of the plugin instead.  RtlGetVersion is
- * used because GetVersionEx reports a version capped by the compatibility
- * manifest rather than the real one. */
-static gboolean
-plugin_windows_needs_python38 (void)
-{
-	typedef LONG (WINAPI *rtl_get_version_func) (PRTL_OSVERSIONINFOW);
-	rtl_get_version_func rtl_get_version;
-	RTL_OSVERSIONINFOW version;
-	HMODULE ntdll;
-
-	ntdll = GetModuleHandleW (L"ntdll.dll");
-	if (ntdll == NULL)
-		return FALSE;
-
-	rtl_get_version = (rtl_get_version_func) GetProcAddress (ntdll, "RtlGetVersion");
-	if (rtl_get_version == NULL)
-		return FALSE;
-
-	memset (&version, 0, sizeof (version));
-	version.dwOSVersionInfoSize = sizeof (version);
-	if (rtl_get_version (&version) != 0)
-		return FALSE;
-
-	return version.dwMajorVersion < 10;
-}
-#endif
 
 /* crafted to be an even 32 bytes */
 struct _zoitechat_hook
@@ -522,9 +491,6 @@ plugin_auto_load (session *sess)
 	for_files (lib_dir, "hcfishlim.dll", plugin_auto_load_cb);
 	for_files(lib_dir, "hclua.dll", plugin_auto_load_cb);
 	for_files (lib_dir, "hcperl.dll", plugin_auto_load_cb);
-	if (plugin_windows_needs_python38 ())
-		for_files (lib_dir, "hcpython38.dll", plugin_auto_load_cb);
-	else
 	for_files (lib_dir, "hcpython3.dll", plugin_auto_load_cb);
 	for_files (lib_dir, "hcupd.dll", plugin_auto_load_cb);
 	for_files (lib_dir, "hcsysinfo.dll", plugin_auto_load_cb);

src/common/server.c

@@ -109,58 +109,6 @@ static void server_disconnect (session * sess, int sendquit, int err);
 static int server_cleanup (server * serv);
 static void server_connect (server *serv, char *hostname, int port, int no_login);
 
-typedef struct
-{
-	server *serv;
-	char hostname[128];
-	int port;
-} reconnect_password_prompt;
-
-static gboolean
-server_login_uses_password_sasl (int logintype)
-{
-	return logintype == LOGIN_SASL ||
-		logintype == LOGIN_SASL_SCRAM_SHA_1 ||
-		logintype == LOGIN_SASL_SCRAM_SHA_256 ||
-		logintype == LOGIN_SASL_SCRAM_SHA_512;
-}
-
-static void
-server_reconnect_password_cb (int cancel, char *text, void *userdata)
-{
-	reconnect_password_prompt *prompt = userdata;
-
-	if (!cancel && is_server (prompt->serv) && !prompt->serv->connected && !prompt->serv->connecting && prompt->serv->server_session)
-	{
-		prompt->serv->password[0] = 0;
-		if (text && *text)
-			safe_strcpy (prompt->serv->password, text, sizeof (prompt->serv->password));
-		server_connect (prompt->serv, prompt->hostname, prompt->port, FALSE);
-	}
-
-	g_free (prompt);
-}
-
-static gboolean
-server_prompt_reconnect_password (server *serv)
-{
-	reconnect_password_prompt *prompt;
-	char *msg;
-	ircnet *net = serv->network;
-
-	if (!net || !(net->flags & FLAG_PROMPT_PASSWORD) || !server_login_uses_password_sasl (serv->loginmethod))
-		return FALSE;
-
-	prompt = g_new0 (reconnect_password_prompt, 1);
-	prompt->serv = serv;
-	safe_strcpy (prompt->hostname, serv->hostname, sizeof (prompt->hostname));
-	prompt->port = serv->port;
-	msg = g_strdup_printf (_("Enter SASL password for %s:"), net->name ? net->name : _("this network"));
-	fe_get_password (msg, server_reconnect_password_cb, prompt);
-	g_free (msg);
-	return TRUE;
-}
-
 static void
 write_error (char *message, GError **error)
 {
@@ -786,7 +734,6 @@ timeout_auto_reconnect (server *serv)
 		serv->recondelay_tag = 0;
 		if (!serv->connected && !serv->connecting && serv->server_session)
 		{
-			if (!server_prompt_reconnect_password (serv))
 			server_connect (serv, serv->hostname, serv->port, FALSE);
 		}
 	}

src/common/servlist.c

@@ -439,99 +439,8 @@ servlist_favchan_copy (favchannel *fav)
 	return newfav;
 }
 
-static void servlist_connect_with_password (session *sess, ircnet *net, gboolean join, const char *password);
-
-typedef struct
-{
-	session *sess;
-	ircnet *net;
-	gboolean join;
-} servlist_password_prompt;
-
-static gboolean
-servlist_login_uses_password_sasl (int logintype)
-{
-	return logintype == LOGIN_SASL ||
-		logintype == LOGIN_SASL_SCRAM_SHA_1 ||
-		logintype == LOGIN_SASL_SCRAM_SHA_256 ||
-		logintype == LOGIN_SASL_SCRAM_SHA_512;
-}
-
-static void servlist_prompt_sasl_password (servlist_password_prompt *prompt);
-
-static void
-servlist_connect_without_password_cb (int value, void *userdata)
-{
-	servlist_password_prompt *prompt = userdata;
-
-	if (value)
-	{
-		servlist_connect_with_password (prompt->sess, prompt->net, prompt->join, NULL);
-		g_free (prompt);
-	}
-	else
-	{
-		servlist_prompt_sasl_password (prompt);
-	}
-}
-
-static void
-servlist_connect_password_cb (int cancel, char *text, void *userdata)
-{
-	servlist_password_prompt *prompt = userdata;
-	char *msg;
-
-	if (cancel)
-	{
-		fe_serverlist_open (prompt->sess);
-		g_free (prompt);
-		return;
-	}
-
-	if (text && *text)
-	{
-		servlist_connect_with_password (prompt->sess, prompt->net, prompt->join, text);
-		g_free (prompt);
-		return;
-	}
-
-	msg = g_strdup_printf (_("Continue connecting to %s without a SASL password?"), prompt->net->name ? prompt->net->name : _("this network"));
-	fe_get_bool (_("No SASL password"), msg, servlist_connect_without_password_cb, prompt);
-	g_free (msg);
-}
-
-static void
-servlist_prompt_sasl_password (servlist_password_prompt *prompt)
-{
-	char *msg;
-
-	msg = g_strdup_printf (_("Enter SASL password for %s:"), prompt->net->name ? prompt->net->name : _("this network"));
-	fe_get_password (msg, servlist_connect_password_cb, prompt);
-	g_free (msg);
-}
-
 void
 servlist_connect (session *sess, ircnet *net, gboolean join)
-{
-	int logintype;
-	servlist_password_prompt *prompt;
-
-	logintype = net && net->logintype ? net->logintype : LOGIN_DEFAULT_REAL;
-	if (net && (net->flags & FLAG_PROMPT_PASSWORD) && servlist_login_uses_password_sasl (logintype))
-	{
-		prompt = g_new0 (servlist_password_prompt, 1);
-		prompt->sess = sess;
-		prompt->net = net;
-		prompt->join = join;
-		servlist_prompt_sasl_password (prompt);
-		return;
-	}
-
-	servlist_connect_with_password (sess, net, join, NULL);
-}
-
-static void
-servlist_connect_with_password (session *sess, ircnet *net, gboolean join, const char *password)
 {
 	ircserver *ircserv;
 	GSList *list;
@@ -578,11 +487,7 @@ servlist_connect_with_password (session *sess, ircnet *net, gboolean join, const
 	}
 
 	serv->password[0] = 0;
-	if (password && *password)
+	if ((net->flags & FLAG_USE_KEYRING) && net->name)
-	{
-		safe_strcpy (serv->password, password, sizeof (serv->password));
-	}
-	else if ((net->flags & FLAG_USE_KEYRING) && net->name)
 	{
 		char *stored_pass = secretstore_get_network_password (net->name);
 		if (stored_pass && *stored_pass)

src/common/servlist.h

@@ -63,8 +63,7 @@ extern GSList *network_list;
 #define FLAG_ALLOW_INVALID		32
 #define FLAG_FAVORITE			64
 #define FLAG_USE_KEYRING		128
-#define FLAG_PROMPT_PASSWORD	256
+#define FLAG_COUNT				8
-#define FLAG_COUNT				9
 
 /* Login methods. Use server password by default - if we had a NickServ password, it'd be set to 2 already by servlist_load() */
 #define LOGIN_DEFAULT_REAL		LOGIN_PASS		/* this is to set the default login method for unknown servers */

src/common/text.c

@@ -1695,97 +1695,6 @@ pevent_load (char *filename)
 	return 0;
 }
 
-
-static gboolean
-text_event_uses_color (const char *text, int color)
-{
-	const char *p;
-
-	if (!text || color < 0 || color > 31)
-		return FALSE;
-
-	for (p = text; *p; p++)
-	{
-		int value;
-		int digits;
-
-		if ((unsigned char) *p == 3)
-			p++;
-		else if (*p == '%' && p[1] == 'C')
-			p += 2;
-		else
-			continue;
-
-		if (!g_ascii_isdigit (*p))
-		{
-			p--;
-			continue;
-		}
-
-		value = *p - '0';
-		digits = 1;
-		if (g_ascii_isdigit (p[1]))
-		{
-			value = value * 10 + p[1] - '0';
-			digits = 2;
-		}
-
-		if (value == color)
-			return TRUE;
-
-		p += digits - 1;
-		if (*p == ',' && g_ascii_isdigit (p[1]))
-		{
-			p++;
-			value = *p - '0';
-			if (g_ascii_isdigit (p[1]))
-			{
-				value = value * 10 + p[1] - '0';
-				p++;
-			}
-			if (value == color)
-				return TRUE;
-		}
-	}
-
-	return FALSE;
-}
-
-char **
-text_color_event_names (int color, int *count)
-{
-	GPtrArray *names;
-	int found = 0;
-	int i;
-
-	if (count)
-		*count = 0;
-
-	names = g_ptr_array_new ();
-
-	for (i = 0; i < NUM_XP; i++)
-	{
-		const char *text = pntevts_text[i] ? pntevts_text[i] : te[i].def;
-
-		if (!text_event_uses_color (text, color))
-			continue;
-
-		g_ptr_array_add (names, g_strdup (_(te[i].name)));
-		found++;
-	}
-
-	if (!found)
-	{
-		g_ptr_array_free (names, TRUE);
-		return NULL;
-	}
-
-	g_ptr_array_add (names, NULL);
-	if (count)
-		*count = found;
-	return (char **) g_ptr_array_free (names, FALSE);
-}
-
 static void
 pevent_check_all_loaded (void)
 {

src/common/text.h

@@ -53,7 +53,6 @@ int pevt_build_string (const char *input, char **output, int *max_arg);
 int pevent_load (char *filename);
 void pevent_make_pntevts (void);
 int text_color_of (char *name);
-char **text_color_event_names (int color, int *count);
 void text_emit (int index, session *sess, char *a, char *b, char *c, char *d,
 		time_t timestamp);
 int text_emit_by_name (char *name, session *sess, time_t timestamp,

src/common/zoitechat.h

@@ -204,7 +204,6 @@ struct zoitechatprefs
 	unsigned int hex_net_auto_reconnect;
 	unsigned int hex_net_auto_reconnectonfail;
 	unsigned int hex_net_proxy_auth;
-	unsigned int hex_net_remote_media;
 	unsigned int hex_net_throttle;
 	unsigned int hex_notify_whois_online;
 	unsigned int hex_perl_warnings;

src/fe-gtk/chanview.c

@@ -174,7 +174,7 @@ chanview_apply_theme (chanview *cv)
 	chanview_set_font_desc (cv, font);
 
 	theme_manager_apply_channel_tree_style (w,
-			theme_manager_get_channel_tree_palette_behavior (cv->font_desc));
+			theme_manager_get_channel_tree_palette_behavior (font));
 }
 
 static void
@@ -307,109 +307,6 @@ chanview_set_impl (chanview *cv, int type)
 		cv->func_focus (cv->focused);
 }
 
-void
-chanview_set_sorted (chanview *cv, gboolean sorted)
-{
-	cv->sorted = sorted ? 1 : 0;
-}
-
-void
-chanview_set_use_icons (chanview *cv, gboolean use_icons)
-{
-	cv->use_icons = use_icons ? 1 : 0;
-}
-
-void
-chanview_set_trunc_len (chanview *cv, int trunc_len)
-{
-	cv->trunc_len = trunc_len;
-}
-
-typedef struct
-{
-	chan *ch;
-	int old_pos;
-} chanview_sort_entry;
-
-/* re-sort the session rows below one parent with cb_compare, leaving
- * utility rows (tag != 0) in place; mirrors chanview_insert_sorted() */
-static void
-chanview_resort_children (chanview *cv, GtkTreeIter *parent)
-{
-	GtkTreeModel *model = GTK_TREE_MODEL (cv->store);
-	GtkTreeIter iter;
-	chanview_sort_entry *entries;
-	int *positions;
-	gint *new_order;
-	chan *ch;
-	int n, i, j, count;
-
-	n = gtk_tree_model_iter_n_children (model, parent);
-	if (n < 2)
-		return;
-
-	entries = g_new0 (chanview_sort_entry, n);
-	positions = g_new0 (int, n);
-	new_order = g_new0 (gint, n);
-
-	count = 0;
-	for (i = 0; i < n; i++)
-	{
-		new_order[i] = i;
-		if (!gtk_tree_model_iter_nth_child (model, &iter, parent, i))
-			continue;
-		gtk_tree_model_get (model, &iter, COL_CHAN, &ch, -1);
-		if (ch && ch->tag == 0 && ch->userdata)
-		{
-			entries[count].ch = ch;
-			entries[count].old_pos = i;
-			positions[count] = i;
-			count++;
-		}
-	}
-
-	/* stable insertion sort; tab groups stay small so this is cheap */
-	for (i = 1; i < count; i++)
-	{
-		chanview_sort_entry key = entries[i];
-
-		j = i - 1;
-		while (j >= 0 && cv->cb_compare (entries[j].ch->userdata, key.ch->userdata) > 0)
-		{
-			entries[j + 1] = entries[j];
-			j--;
-		}
-		entries[j + 1] = key;
-	}
-
-	for (i = 0; i < count; i++)
-		new_order[positions[i]] = entries[i].old_pos;
-
-	gtk_tree_store_reorder (cv->store, parent, new_order);
-
-	g_free (entries);
-	g_free (positions);
-	g_free (new_order);
-}
-
-/* top-level rows keep their order (insertion never sorts them either);
- * only the children within each family are sorted */
-void
-chanview_resort (chanview *cv)
-{
-	GtkTreeIter iter;
-
-	if (!cv->cb_compare)
-		return;
-
-	if (gtk_tree_model_get_iter_first (GTK_TREE_MODEL (cv->store), &iter))
-	{
-		do
-			chanview_resort_children (cv, &iter);
-		while (gtk_tree_model_iter_next (GTK_TREE_MODEL (cv->store), &iter));
-	}
-}
-
 static void
 chanview_free_ch (chanview *cv, GtkTreeIter *iter)
 {

src/fe-gtk/chanview.h

@@ -34,10 +34,6 @@ void chanview_set_callbacks (chanview *cv,
 	gboolean (*cb_contextmenu) (chanview *, chan *, int tag, void *userdata, GdkEventButton *),
 	int (*cb_compare) (void *a, void *b));
 void chanview_set_impl (chanview *cv, int type);
-void chanview_set_sorted (chanview *cv, gboolean sorted);
-void chanview_set_use_icons (chanview *cv, gboolean use_icons);
-void chanview_set_trunc_len (chanview *cv, int trunc_len);
-void chanview_resort (chanview *cv);
 chan *chanview_add (chanview *cv, char *name, void *family, void *userdata, gboolean allow_closure, int tag, GdkPixbuf *icon);
 int chanview_get_size (chanview *cv);
 GtkWidget *chanview_get_box (chanview *cv);

src/fe-gtk/fe-gtk.c

@@ -49,7 +49,6 @@
 #include "chanlist.h"
 #include "joind.h"
 #include "xtext.h"
-#include "inline-image.h"
 #include "theme/theme-gtk.h"
 #include "menu.h"
 #include "notifygui.h"
@@ -944,13 +943,7 @@ void
 fe_print_text (struct session *sess, char *text, time_t stamp,
 			   gboolean no_activity)
 {
-	/* image links become a "[view image]" placeholder with a hidden URL */
+	PrintTextRaw (sess->res->buffer, (unsigned char *)text, prefs.hex_text_indent, stamp);
-	char *filtered = inline_image_filter_text (text);
-
-	PrintTextRaw (sess->res->buffer,
-					  (unsigned char *)(filtered ? filtered : text),
-					  prefs.hex_text_indent, stamp);
-	g_free (filtered);
 
 	if (no_activity || !sess->gui->is_tab)
 		return;

src/fe-gtk/fe-gtk.vcxproj

@@ -59,7 +59,6 @@ powershell "Get-Content -Encoding UTF8 '$(ZoiteChatLib)zoitechat.rc.utf8' | Out-
     <ClInclude Include="fkeys.h" />
     <ClInclude Include="gtkutil.h" />
     <ClInclude Include="icon-resolver.h" />
-    <ClInclude Include="inline-image.h" />
     <ClInclude Include="joind.h" />
     <ClInclude Include="maingui.h" />
     <ClInclude Include="preferences-persistence.h" />
@@ -103,7 +102,6 @@ powershell "Get-Content -Encoding UTF8 '$(ZoiteChatLib)zoitechat.rc.utf8' | Out-
     <ClCompile Include="gtkutil.c" />
     <ClCompile Include="icon-resolver.c" />
     <ClCompile Include="ignoregui.c" />
-    <ClCompile Include="inline-image.c" />
     <ClCompile Include="joind.c" />
     <ClCompile Include="maingui.c" />
     <ClCompile Include="menu.c" />

src/fe-gtk/fe-gtk.vcxproj.filters

@@ -45,9 +45,6 @@
     <ClInclude Include="icon-resolver.h">
       <Filter>Header Files</Filter>
     </ClInclude>
-    <ClInclude Include="inline-image.h">
-      <Filter>Header Files</Filter>
-    </ClInclude>
     <ClInclude Include="joind.h">
       <Filter>Header Files</Filter>
     </ClInclude>
@@ -173,9 +170,6 @@
     <ClCompile Include="ignoregui.c">
       <Filter>Source Files</Filter>
     </ClCompile>
-    <ClCompile Include="inline-image.c">
-      <Filter>Source Files</Filter>
-    </ClCompile>
     <ClCompile Include="joind.c">
       <Filter>Source Files</Filter>
     </ClCompile>

src/fe-gtk/gtkutil.c

@@ -527,43 +527,6 @@ gtkutil_destroy (GtkWidget * igad, GtkWidget * dgad)
 	gtk_widget_destroy (dgad);
 }
 
-static void
-gtkutil_place_dialog (GtkWidget *dialog)
-{
-	GList *list;
-	GList *item;
-	GtkWindow *anchor = NULL;
-	gint x;
-	gint y;
-	extern GtkWidget *parent_window;
-
-	list = gtk_window_list_toplevels ();
-	for (item = list; item; item = item->next)
-	{
-		if (item->data != dialog && GTK_IS_WINDOW (item->data) &&
-			gtk_widget_get_visible (GTK_WIDGET (item->data)) &&
-			gtk_window_is_active (GTK_WINDOW (item->data)))
-		{
-			anchor = GTK_WINDOW (item->data);
-			break;
-		}
-	}
-	g_list_free (list);
-
-	if (!anchor && parent_window && parent_window != dialog && GTK_IS_WINDOW (parent_window))
-		anchor = GTK_WINDOW (parent_window);
-
-	if (anchor)
-	{
-		gtk_window_get_position (anchor, &x, &y);
-		gtk_window_move (GTK_WINDOW (dialog), x, y);
-	}
-	else
-	{
-		gtk_window_set_position (GTK_WINDOW (dialog), GTK_WIN_POS_MOUSE);
-	}
-}
-
 static void
 gtkutil_get_str_response (GtkDialog *dialog, gint arg1, gpointer entry)
 {
@@ -577,15 +540,15 @@ gtkutil_get_str_response (GtkDialog *dialog, gint arg1, gpointer entry)
 
 	switch (arg1)
 	{
+	case GTK_RESPONSE_REJECT:
+		callback (TRUE, text, user_data);
+		gtk_widget_destroy (GTK_WIDGET (dialog));
+		break;
 	case GTK_RESPONSE_ACCEPT:
 		callback (FALSE, text, user_data);
-		break;
+		gtk_widget_destroy (GTK_WIDGET (dialog));
-	default:
-		callback (TRUE, text, user_data);
 		break;
 	}
-
-	gtk_widget_destroy (GTK_WIDGET (dialog));
 }
 
 static void
@@ -594,8 +557,8 @@ gtkutil_str_enter (GtkWidget *entry, GtkWidget *dialog)
 	gtk_dialog_response (GTK_DIALOG (dialog), GTK_RESPONSE_ACCEPT);
 }
 
-static void
+void
-gtkutil_get_str (char *msg, char *def, void *callback, void *userdata, gboolean visible)
+fe_get_str (char *msg, char *def, void *callback, void *userdata)
 {
 	GtkWidget *dialog;
 	GtkWidget *entry;
@@ -609,11 +572,18 @@ gtkutil_get_str (char *msg, char *def, void *callback, void *userdata, gboolean
 										NULL);
 	theme_manager_attach_window (dialog);
 
-	if (parent_window && GTK_IS_WINDOW (parent_window))
 	gtk_window_set_transient_for (GTK_WINDOW (dialog), GTK_WINDOW (parent_window));
-	gtkutil_place_dialog (dialog);
 	gtk_box_set_homogeneous (GTK_BOX (gtk_dialog_get_content_area (GTK_DIALOG (dialog))), TRUE);
 
+	if (userdata == (void *)1)	/* nick box is usually on the very bottom, make it centered */
+	{
+		gtk_window_set_position (GTK_WINDOW (dialog), GTK_WIN_POS_CENTER);
+	}
+	else
+	{
+		gtk_window_set_position (GTK_WINDOW (dialog), GTK_WIN_POS_MOUSE);
+	}
+
 	hbox = gtkutil_box_new (GTK_ORIENTATION_HORIZONTAL, TRUE, 0);
 
 	g_object_set_data (G_OBJECT (dialog), "cb", callback);
@@ -622,8 +592,7 @@ gtkutil_get_str (char *msg, char *def, void *callback, void *userdata, gboolean
 	entry = gtk_entry_new ();
 	g_signal_connect (G_OBJECT (entry), "activate",
 						 	G_CALLBACK (gtkutil_str_enter), dialog);
-	gtk_entry_set_text (GTK_ENTRY (entry), def ? def : "");
+	gtk_entry_set_text (GTK_ENTRY (entry), def);
-	gtk_entry_set_visibility (GTK_ENTRY (entry), visible);
 	gtk_box_pack_end (GTK_BOX (hbox), entry, 0, 0, 0);
 
 	label = gtk_label_new (msg);
@@ -637,18 +606,6 @@ gtkutil_get_str (char *msg, char *def, void *callback, void *userdata, gboolean
 	gtk_widget_show_all (dialog);
 }
 
-void
-fe_get_str (char *msg, char *def, void *callback, void *userdata)
-{
-	gtkutil_get_str (msg, def, callback, userdata, TRUE);
-}
-
-void
-fe_get_password (char *msg, void *callback, void *userdata)
-{
-	gtkutil_get_str (msg, "", callback, userdata, FALSE);
-}
-
 static void
 gtkutil_get_number_response (GtkDialog *dialog, gint arg1, gpointer spin)
 {
@@ -684,15 +641,15 @@ gtkutil_get_bool_response (GtkDialog *dialog, gint arg1, gpointer spin)
 
 	switch (arg1)
 	{
+	case GTK_RESPONSE_REJECT:
+		callback (0, user_data);
+		gtk_widget_destroy (GTK_WIDGET (dialog));
+		break;
 	case GTK_RESPONSE_ACCEPT:
 		callback (1, user_data);
-		break;
+		gtk_widget_destroy (GTK_WIDGET (dialog));
-	default:
-		callback (0, user_data);
 		break;
 	}
-
-	gtk_widget_destroy (GTK_WIDGET (dialog));
 }
 
 void
@@ -710,10 +667,9 @@ fe_get_int (char *msg, int def, void *callback, void *userdata)
 										_("_OK"), GTK_RESPONSE_ACCEPT,
 										NULL);
 	theme_manager_attach_window (dialog);
-	if (parent_window && GTK_IS_WINDOW (parent_window))
-		gtk_window_set_transient_for (GTK_WINDOW (dialog), GTK_WINDOW (parent_window));
-	gtkutil_place_dialog (dialog);
 	gtk_box_set_homogeneous (GTK_BOX (gtk_dialog_get_content_area (GTK_DIALOG (dialog))), TRUE);
+	gtk_window_set_position (GTK_WINDOW (dialog), GTK_WIN_POS_MOUSE);
+	gtk_window_set_transient_for (GTK_WINDOW (dialog), GTK_WINDOW (parent_window));
 
 	hbox = gtkutil_box_new (GTK_ORIENTATION_HORIZONTAL, TRUE, 0);
 
@@ -751,10 +707,10 @@ fe_get_bool (char *title, char *prompt, void *callback, void *userdata)
 		_("_Yes"), GTK_RESPONSE_ACCEPT,
 		NULL);
 	theme_manager_attach_window (dialog);
-	if (parent_window && GTK_IS_WINDOW (parent_window))
-		gtk_window_set_transient_for (GTK_WINDOW (dialog), GTK_WINDOW (parent_window));
-	gtkutil_place_dialog (dialog);
 	gtk_box_set_homogeneous (GTK_BOX (gtk_dialog_get_content_area (GTK_DIALOG (dialog))), TRUE);
+	gtk_window_set_position (GTK_WINDOW (dialog), GTK_WIN_POS_MOUSE);
+	gtk_window_set_transient_for (GTK_WINDOW (dialog), GTK_WINDOW (parent_window));
+
 
 	g_object_set_data (G_OBJECT (dialog), "cb", callback);
 	g_object_set_data (G_OBJECT (dialog), "ud", userdata);

src/fe-gtk/inline-image.h

@@ -1,45 +0,0 @@
-/* ZoiteChat
- * Copyright (C) 2026 ZoiteChat contributors.
- *
- * This program is free software; you can redistribute it and/or modify
- * it under the terms of the GNU General Public License as published by
- * the Free Software Foundation; either version 2 of the License, or
- * (at your option) any later version.
- *
- * This program is distributed in the hope that it will be useful,
- * but WITHOUT ANY WARRANTY; without even the implied warranty of
- * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
- * GNU General Public License for more details.
- *
- * You should have received a copy of the GNU General Public License
- * along with this program; if not, write to the Free Software
- * Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301, USA
- */
-
-#ifndef ZOITECHAT_INLINE_IMAGE_H
-#define ZOITECHAT_INLINE_IMAGE_H
-
-#include "xtext.h"
-
-/* does this look like a direct http(s) link to an image file? */
-gboolean inline_image_is_image_url (const char *url);
-
-/* show the image behind 'url' inline below 'ent', or hide it again if it is
- * already shown.  Errors are reported to 'sess'. */
-void inline_image_toggle (session *sess, GtkXText *xtext, textentry *ent,
-								  const char *url);
-
-/* replace image links in a message with a clickable placeholder label that
- * hides the URL.  Returns a newly allocated string, or NULL if the text has
- * no image links (or the feature is off). */
-char *inline_image_filter_text (const char *text);
-
-/* pop up a window with a larger version of the entry's inline image */
-void inline_image_show_viewer (GtkXText *xtext, textentry *ent);
-
-/* can downloads go through the proxy configured for ZoiteChat (or is no
- * proxy configured)?  FALSE means loading media would have to bypass the
- * user's proxy, which is never done. */
-gboolean inline_image_proxy_usable (void);
-
-#endif

src/fe-gtk/maingui.c

@@ -59,7 +59,6 @@
 #include "pixmaps.h"
 #include "plugin-tray.h"
 #include "xtext.h"
-#include "inline-image.h"
 #include "sexy-spell-entry.h"
 #include "gtkutil.h"
 
@@ -68,34 +67,6 @@
 #include <shellapi.h>
 #include <gdk/gdkwin32.h>
 
-/* The shell only minimizes a window from its taskbar button when the
- * window style carries WS_MINIMIZEBOX; without it the click merely
- * deactivates the window (issue #65).  GTK3 older than 3.24.50 can drop
- * the bit from top-level windows (https://gitlab.gnome.org/GNOME/gtk/-/issues/7494),
- * so guarantee it ourselves for session windows. */
-static void
-mg_win32_ensure_minimizable (GdkWindow *gdk_window)
-{
-	HWND hwnd;
-	LONG_PTR window_style;
-
-	if (!gdk_window)
-		return;
-
-	hwnd = gdk_win32_window_get_handle (gdk_window);
-	if (!hwnd)
-		return;
-
-	window_style = GetWindowLongPtr (hwnd, GWL_STYLE);
-	if (!window_style || (window_style & WS_MINIMIZEBOX))
-		return;
-
-	SetWindowLongPtr (hwnd, GWL_STYLE, window_style | WS_MINIMIZEBOX);
-	SetWindowPos (hwnd, NULL, 0, 0, 0, 0,
-	              SWP_FRAMECHANGED | SWP_NOMOVE | SWP_NOSIZE |
-	              SWP_NOZORDER | SWP_NOACTIVATE | SWP_NOOWNERZORDER);
-}
-
 static void
 mg_win32_allow_autohide_taskbar (GtkWindow *window, GdkEventWindowState *event)
 {
@@ -570,18 +541,6 @@ mg_create_tab_colors (void)
         away_list = mg_attr_list_create (&gui_palette[THEME_TOKEN_TAB_AWAY], FALSE);
 }
 
-static PangoAttrList *
-mg_attr_list_for_tab_state (int state)
-{
-        if (state & TAB_STATE_NEW_HILIGHT)
-                return nickseen_list;
-        if (state & TAB_STATE_NEW_MSG)
-                return newmsg_list;
-        if (state & TAB_STATE_NEW_DATA)
-                return newdata_list;
-        return plain_list;
-}
-
 static void
 set_window_urgency (GtkWidget *win, gboolean set)
 {
@@ -727,10 +686,7 @@ mg_set_access_icon (session_gui *gui, GdkPixbuf *pix, gboolean away)
 {
         if (gui->op_xpm)
         {
-                /* no change? (the pref check makes sure a live settings
+                if (pix == gtk_image_get_pixbuf (GTK_IMAGE (gui->op_xpm))) /* no change? */
-                   change can still remove the icon) */
-                if (pix == gtk_image_get_pixbuf (GTK_IMAGE (gui->op_xpm)) &&
-                         prefs.hex_gui_input_icon)
                 {
                         mg_set_myself_away (gui, away);
                         return;
@@ -3612,48 +3568,6 @@ mg_create_topicbar (session *sess, GtkWidget *box)
 	mg_create_chanmodebuttons (gui, bbox);
 }
 
-/* re-apply the multi-line topic and inline mode button preferences to an
- * already built topic bar (see mg_create_topicbar () for the layout) */
-
-static void
-mg_update_topicbar_layout (session_gui *gui)
-{
-	GtkWidget *topic = gui->topic_entry;
-	GtkWidget *vbox = gui->topic_bar;
-	GtkWidget *topic_scroll;
-	GtkWidget *hbox;
-	GtkWidget *mode_hbox;
-	GtkWidget *desired_parent;
-	GtkWidget *current_parent;
-	gboolean wrap;
-
-	if (!topic || !GTK_IS_TEXT_VIEW (topic) || !vbox || !gui->topicbutton_box)
-		return;
-
-	wrap = prefs.hex_gui_topicbar_multiline && !prefs.hex_gui_mode_buttons_inline;
-	gtk_text_view_set_wrap_mode (GTK_TEXT_VIEW (topic),
-		wrap ? GTK_WRAP_WORD_CHAR : GTK_WRAP_NONE);
-
-	topic_scroll = gtk_widget_get_parent (topic);
-	hbox = topic_scroll ? gtk_widget_get_parent (topic_scroll) : NULL;
-	mode_hbox = gtk_widget_get_parent (gui->topicbutton_box);
-
-	if (mode_hbox && hbox)
-	{
-		desired_parent = prefs.hex_gui_mode_buttons_inline ? hbox : vbox;
-		current_parent = gtk_widget_get_parent (mode_hbox);
-		if (current_parent && current_parent != desired_parent)
-		{
-			g_object_ref (mode_hbox);
-			gtk_container_remove (GTK_CONTAINER (current_parent), mode_hbox);
-			gtk_box_pack_start (GTK_BOX (desired_parent), mode_hbox, 0, 0, 0);
-			g_object_unref (mode_hbox);
-		}
-	}
-
-	mg_topicbar_update_height (topic);
-}
-
 /* check if a word is clickable */
 
 static int
@@ -3688,12 +3602,6 @@ mg_word_clicked (GtkWidget *xtext, char *word, GdkEventButton *even)
         {
                 if (word == NULL)
                 {
-                        /* a click on a shown inline image opens the viewer */
-                        textentry *img_ent = gtk_xtext_get_clicked_image_entry (GTK_XTEXT (xtext));
-
-                        if (img_ent)
-                                inline_image_show_viewer (GTK_XTEXT (xtext), img_ent);
-                        else
                         mg_focus (sess);
                         return;
                 }
@@ -3706,20 +3614,6 @@ mg_word_clicked (GtkWidget *xtext, char *word, GdkEventButton *even)
                         case WORD_HOST6:
                         case WORD_HOST:
                                 word[end] = 0;
-                                /* image links toggle an inline preview instead
-                                   of opening the browser */
-                                if (word_type == WORD_URL &&
-                                    prefs.hex_net_remote_media &&
-                                    inline_image_is_image_url (word + start))
-                                {
-                                        textentry *ent = gtk_xtext_get_clicked_entry (GTK_XTEXT (xtext));
-
-                                        if (ent)
-                                        {
-                                                inline_image_toggle (sess, GTK_XTEXT (xtext), ent, word + start);
-                                                break;
-                                        }
-                                }
                                 fe_open_url (word + start);
                         }
                 }
@@ -3748,8 +3642,7 @@ mg_word_clicked (GtkWidget *xtext, char *word, GdkEventButton *even)
         case WORD_HOST:
                 word[end] = 0;
                 word += start;
-                menu_urlmenu_entry (even, word, xtext,
+                menu_urlmenu (even, word);
-                                    gtk_xtext_get_clicked_entry (GTK_XTEXT (xtext)));
                 break;
         case WORD_NICK:
                 word[end] = 0;
@@ -4083,12 +3976,8 @@ mg_create_userlist (session_gui *gui, GtkWidget *box)
         gtk_widget_set_margin_end (gui->namelistinfo, 0);
         gtk_widget_set_hexpand (gui->namelistinfo, TRUE);
         gtk_widget_set_halign (gui->namelistinfo, GTK_ALIGN_FILL);
-        /* always pack it so the preference can be toggled without a
-           restart; visibility is controlled explicitly */
-        gtk_widget_set_no_show_all (gui->namelistinfo, TRUE);
-        gtk_box_pack_start (GTK_BOX (vbox), gui->namelistinfo, 0, 0, 0);
         if (prefs.hex_gui_ulist_count)
-                gtk_widget_show (gui->namelistinfo);
+                gtk_box_pack_start (GTK_BOX (vbox), gui->namelistinfo, 0, 0, 0);
 
         gui->user_tree = ulist = userlist_create (vbox);
 
@@ -4987,11 +4876,7 @@ mg_create_menu (session_gui *gui, GtkWidget *table, int away_state)
                                                                                         gui->menu_item);
         gtk_widget_set_hexpand (gui->menu, TRUE);
         gtk_widget_set_vexpand (gui->menu, FALSE);
-        /* Fill the row: with GTK_ALIGN_START the menu bar stops after its
+        gtk_widget_set_halign (gui->menu, GTK_ALIGN_START);
-         * last item and the rest of the row shows bare window background,
-         * which reads as a two-colored menu bar whenever the theme styles
-         * menubar and window differently. */
-        gtk_widget_set_halign (gui->menu, GTK_ALIGN_FILL);
         gtk_widget_set_valign (gui->menu, GTK_ALIGN_FILL);
         gtk_grid_attach (GTK_GRID (table), gui->menu, 0, 0, 3, 1);
 }
@@ -5100,7 +4985,6 @@ mg_create_topwindow (session *sess)
 #ifdef G_OS_WIN32
 	parent_win = gtk_widget_get_window (win);
 	gdk_window_add_filter (parent_win, mg_win32_filter, NULL);
-	mg_win32_ensure_minimizable (parent_win);
 #endif
 }
 
@@ -5137,18 +5021,6 @@ mg_win32_filter (GdkXEvent *xevent, GdkEvent *event, gpointer data)
 	if (!msg)
 		return GDK_FILTER_CONTINUE;
 
-	if (msg->message == WM_STYLECHANGING && msg->wParam == (WPARAM)GWL_STYLE)
-	{
-		STYLESTRUCT *style = (STYLESTRUCT *)msg->lParam;
-
-		/* Keep the window minimizable from its taskbar button; see
-		 * mg_win32_ensure_minimizable (). */
-		if (style)
-			style->styleNew |= WS_MINIMIZEBOX;
-
-		return GDK_FILTER_CONTINUE;
-	}
-
 	if (msg->message == WM_TIMECHANGE)
 	{
 		_tzset();
@@ -5298,7 +5170,6 @@ mg_create_tabwindow (session *sess)
 #ifdef G_OS_WIN32
 	parent_win = gtk_widget_get_window (win);
 	gdk_window_add_filter (parent_win, mg_win32_filter, NULL);
-	mg_win32_ensure_minimizable (parent_win);
 #endif
 }
 
@@ -5316,10 +5187,6 @@ mg_apply_setup (void)
                 sess = list->data;
                 gtk_xtext_set_time_stamp (sess->res->buffer, prefs.hex_stamp_text);
                 ((xtext_buffer *)sess->res->buffer)->needs_recalc = TRUE;
-                /* the attribute lists were just recreated, so re-apply the
-                   color matching each tab's activity state */
-                if (sess->res->tab)
-                        chan_set_color (sess->res->tab, mg_attr_list_for_tab_state (sess->tab_state));
                 if (!sess->gui->is_tab || !done_main)
                         mg_place_userlist_and_chanview (sess->gui);
                 if (sess->gui->is_tab)
@@ -5362,11 +5229,13 @@ fe_buttons_update (session *sess)
                 gtk_widget_hide (sess->gui->button_box);
 }
 
-/* tab label for a session that has no joined channel: the channel we are
+void
- * waiting to join in parentheses, or "<none>". tbuf must hold CHANLEN+6. */
+fe_clear_channel (session *sess)
+{
+        char tbuf[CHANLEN+6];
+        session_gui *gui = sess->gui;
 
-static void
+        if (sess->gui->is_tab)
-mg_tab_pending_name (session *sess, char *tbuf)
         {
                 if (sess->waitchannel[0])
                 {
@@ -5384,36 +5253,6 @@ mg_tab_pending_name (session *sess, char *tbuf)
                 }
                 else
                         strcpy (tbuf, _("<none>"));
-}
-
-/* re-apply the tab label truncation preference to a session's tab */
-
-static void
-mg_retrunc_tab (session *sess)
-{
-        char tbuf[CHANLEN+6];
-
-        if (!sess->res->tab)
-                return;
-
-        if (sess->channel[0])
-                chan_rename (sess->res->tab, sess->channel, prefs.hex_gui_tab_trunc);
-        else
-        {
-                mg_tab_pending_name (sess, tbuf);
-                chan_rename (sess->res->tab, tbuf, prefs.hex_gui_tab_trunc);
-        }
-}
-
-void
-fe_clear_channel (session *sess)
-{
-        char tbuf[CHANLEN+6];
-        session_gui *gui = sess->gui;
-
-        if (sess->gui->is_tab)
-        {
-                mg_tab_pending_name (sess, tbuf);
                 chan_rename (sess->res->tab, tbuf, prefs.hex_gui_tab_trunc);
         }
 
@@ -5537,110 +5376,6 @@ fe_set_channel (session *sess)
                 chan_rename (sess->res->tab, sess->channel, prefs.hex_gui_tab_trunc);
 }
 
-static void
-mg_apply_live_prefs_to_gui (session_gui *gui, session *sess, const mg_live_prefs *changes)
-{
-        if (changes->meters)
-                mg_update_meters (gui);
-
-        if (changes->ulist_columns && gui->user_tree)
-                userlist_rebuild_columns (gui->user_tree);
-
-        if (changes->ulist_count && gui->namelistinfo)
-        {
-                if (prefs.hex_gui_ulist_count)
-                        gtk_widget_show (gui->namelistinfo);
-                else
-                        gtk_widget_hide (gui->namelistinfo);
-        }
-
-        if (changes->input_box && gui->nick_box)
-        {
-                if (prefs.hex_gui_input_nick)
-                        gtk_widget_show (gui->nick_box);
-                else
-                        gtk_widget_hide (gui->nick_box);
-        }
-
-        /* refresh the access icon; re-filling the user list rows can
-           clear it as a side effect, so restore it here too */
-        if ((changes->input_box || changes->ulist_rows) && sess && is_session (sess))
-        {
-                if (sess->type == SESS_DIALOG)
-                        mg_set_access_icon (gui, NULL, sess->server->is_away);
-                else
-                        mg_set_access_icon (gui, get_user_icon (sess->server, sess->me), sess->server->is_away);
-        }
-
-        if (changes->topic_bar)
-                mg_update_topicbar_layout (gui);
-
-        if (changes->transparency && gui->window)
-                gtk_widget_set_opacity (gui->window, (prefs.hex_gui_transparency / 255.));
-}
-
-/* apply preference changes that used to require a restart. called by
- * setup.c after the new prefs have been committed. */
-
-void
-mg_apply_live_prefs (const mg_live_prefs *changes)
-{
-        GSList *list;
-        session *sess;
-        int done_main = FALSE;
-
-        if (!changes)
-                return;
-
-        /* the tab bar / channel tree lives in the shared tab window */
-        if (mg_gui && mg_gui->chanview)
-        {
-                if (changes->tab_resort)
-                {
-                        chanview_set_sorted (mg_gui->chanview, prefs.hex_gui_tab_sort);
-                        chanview_resort (mg_gui->chanview);
-                }
-                if (changes->tab_trunc)
-                        chanview_set_trunc_len (mg_gui->chanview, prefs.hex_gui_tab_trunc);
-                if (changes->chanview || changes->tab_resort)
-                {
-                        chanview_set_use_icons (mg_gui->chanview,
-                                                                                        prefs.hex_gui_tab_icons && (pix_tree_channel || pix_tree_dialog ||
-                                                                                                                                                                 pix_tree_server || pix_tree_util));
-                        /* rebuild the tab bar / tree widgets from the model */
-                        chanview_set_impl (mg_gui->chanview, prefs.hex_gui_tab_layout);
-                }
-        }
-
-        list = sess_list;
-        while (list)
-        {
-                sess = list->data;
-
-                if (changes->tab_trunc)
-                        mg_retrunc_tab (sess);
-                if (changes->ulist_sort)
-                        userlist_apply_sort (sess);
-                if (changes->ulist_rows)
-                        userlist_refill (sess);
-
-                if (sess->gui->is_tab)
-                {
-                        /* only apply to the shared tab window once, using the
-                           front-most session for session-dependent bits */
-                        if (!done_main)
-                        {
-                                done_main = TRUE;
-                                mg_apply_live_prefs_to_gui (sess->gui, current_tab, changes);
-                        }
-                }
-                else
-                        mg_apply_live_prefs_to_gui (sess->gui, sess, changes);
-
-                list = list->next;
-        }
-}
-
 void
 fe_set_typing (session *sess, const char *nick, const char *state)
 {

src/fe-gtk/maingui.h

@@ -37,24 +37,6 @@ GtkWidget *mg_create_generic_tab (char *name, char *title, int force_toplevel, i
 void mg_set_title (GtkWidget *button, char *title);
 void mg_set_access_icon (session_gui *gui, GdkPixbuf *pix, gboolean away);
 void mg_apply_setup (void);
-
-/* which parts of the GUI need a live rebuild after a preferences change */
-typedef struct
-{
-	unsigned int chanview:1;			/* rebuild the tab bar / channel tree */
-	unsigned int tab_resort:1;		/* re-sort channel tabs */
-	unsigned int tab_trunc:1;			/* re-truncate tab labels */
-	unsigned int ulist_columns:1;	/* rebuild user list columns */
-	unsigned int ulist_rows:1;		/* re-fill user list rows */
-	unsigned int ulist_sort:1;		/* re-apply user list sort order */
-	unsigned int ulist_count:1;		/* user count label visibility */
-	unsigned int meters:1;				/* rebuild lag/throttle meters */
-	unsigned int input_box:1;			/* nick box visibility and access icon */
-	unsigned int topic_bar:1;			/* topic wrap mode and mode button placement */
-	unsigned int transparency:1;	/* main window opacity */
-} mg_live_prefs;
-
-void mg_apply_live_prefs (const mg_live_prefs *changes);
 void mg_apply_session_font_prefs (session_gui *gui);
 void mg_close_sess (session *);
 void mg_tab_close (session *sess);

src/fe-gtk/menu.c

@@ -45,7 +45,6 @@
 #include "../common/util.h"
 #include "../common/text.h"
 #include "xtext.h"
-#include "inline-image.h"
 #include "ascii.h"
 #include "banlist.h"
 #include "chanlist.h"
@@ -1057,40 +1056,8 @@ open_url_cb (GtkWidget *item, char *url)
 	handle_command (current_sess, buf, FALSE);
 }
 
-/* the text entry the open URL menu was created for; the widget pointer is
-   nulled automatically if the widget dies while the menu is up */
-static GtkXText *urlmenu_xtext = NULL;
-static textentry *urlmenu_ent = NULL;
-
-static void
-menu_urlmenu_set_entry (GtkWidget *xtext, textentry *ent)
-{
-	if (urlmenu_xtext)
-		g_object_remove_weak_pointer (G_OBJECT (urlmenu_xtext),
-												(gpointer *) &urlmenu_xtext);
-	urlmenu_xtext = xtext ? GTK_XTEXT (xtext) : NULL;
-	urlmenu_ent = ent;
-	if (urlmenu_xtext)
-		g_object_add_weak_pointer (G_OBJECT (urlmenu_xtext),
-											(gpointer *) &urlmenu_xtext);
-}
-
-static void
-inline_image_menu_cb (GtkWidget *item, char *url)
-{
-	if (urlmenu_xtext == NULL || urlmenu_ent == NULL)
-		return;
-
-	/* the line may have scrolled out of the buffer since the menu opened */
-	if (!gtk_xtext_buffer_contains (urlmenu_xtext, urlmenu_ent))
-		return;
-
-	inline_image_toggle (current_sess, urlmenu_xtext, urlmenu_ent, url);
-}
-
 void
-menu_urlmenu_entry (GdkEventButton *event, char *url, GtkWidget *xtext,
+menu_urlmenu (GdkEventButton *event, char *url)
-						  textentry *ent)
 {
 	GtkWidget *menu;
 	char *tmp, *chop;
@@ -1098,14 +1065,6 @@ menu_urlmenu_entry (GdkEventButton *event, char *url, GtkWidget *xtext,
 	g_free (str_copy);
 	str_copy = g_strdup (url);
 
-	if (xtext == NULL || ent == NULL || !prefs.hex_net_remote_media ||
-		 !inline_image_is_image_url (str_copy))
-	{
-		xtext = NULL;
-		ent = NULL;
-	}
-	menu_urlmenu_set_entry (xtext, ent);
-
 	menu = menu_new ();
 	/* more than 51 chars? Chop it */
 	if (g_utf8_strlen (str_copy, -1) >= 52)
@@ -1128,15 +1087,6 @@ menu_urlmenu_entry (GdkEventButton *event, char *url, GtkWidget *xtext,
 		menu_quick_item_with_callback (open_url_cb, _("Connect"), menu, str_copy);
 	else
 		menu_quick_item_with_callback (open_url_cb, _("Open Link in Browser"), menu, str_copy);
-	if (ent)
-	{
-		const char *shown = gtk_xtext_entry_get_image_url (GTK_XTEXT (xtext), ent);
-
-		menu_quick_item_with_callback (inline_image_menu_cb,
-			shown && strcmp (shown, str_copy) == 0 ?
-				_("Hide Inline Image") : _("Show Image Inline"),
-			menu, str_copy);
-	}
 	menu_quick_item_with_callback (copy_to_clipboard_cb, _("Copy Selected Link"), menu, str_copy);
 	/* custom ones from urlhandlers.conf */
 	menu_create (menu, urlhandler_list, str_copy, TRUE);
@@ -1144,12 +1094,6 @@ menu_urlmenu_entry (GdkEventButton *event, char *url, GtkWidget *xtext,
 	menu_popup (menu, event, NULL);
 }
 
-void
-menu_urlmenu (GdkEventButton *event, char *url)
-{
-	menu_urlmenu_entry (event, url, NULL, NULL);
-}
-
 static void
 menu_chan_cycle (GtkWidget * menu, char *chan)
 {

src/fe-gtk/menu.h

@@ -20,11 +20,8 @@
 #ifndef ZOITECHAT_MENU_H
 #define ZOITECHAT_MENU_H
 
-#include "xtext.h"
-
 GtkWidget *menu_create_main (void *accel_group, int bar, int away, int toplevel, GtkWidget **menu_widgets);
 void menu_urlmenu (GdkEventButton * event, char *url);
-void menu_urlmenu_entry (GdkEventButton *event, char *url, GtkWidget *xtext, textentry *ent);
 void menu_chanmenu (session *sess, GdkEventButton * event, char *chan);
 void menu_addfavoritemenu (server *serv, GtkWidget *menu, char *channel, gboolean istree);
 void menu_addconnectmenu (server *serv, GtkWidget *menu);

src/fe-gtk/meson.build

@@ -23,7 +23,6 @@ zoitechat_gtk_sources = [
   'gtkutil.c',
   'icon-resolver.c',
   'ignoregui.c',
-  'inline-image.c',
   'joind.c',
   'menu.c',
   'maingui.c',
@@ -51,7 +50,7 @@ zoitechat_gtk_deps = [
 
 gtk_dep = dependency('gtk+-3.0', version: '>= 3.22')
 
-zoitechat_theme_deps = [gtk_dep, zoitechat_common_dep]
+zoitechat_theme_deps = [gtk_dep]
 
 if host_machine.system() != 'windows'
   appindicator_opt = get_option('appindicator')
@@ -228,20 +227,6 @@ test('Theme Access Routing Tests', theme_access_tests,
   timeout: 120,
 )
 
-theme_gtk3_settings_tests = executable('theme_gtk3_settings_tests',
-  [
-    'theme/tests/test-theme-gtk3-settings.c',
-    'theme/theme-gtk3.c',
-  ],
-  include_directories: [config_h_include],
-  dependencies: [gtk_dep],
-)
-
-test('Theme GTK3 Settings Tests', theme_gtk3_settings_tests,
-  protocol: 'tap',
-  timeout: 120,
-)
-
 theme_preferences_gtk3_populate_tests = executable('theme_preferences_gtk3_populate_tests',
   'theme/tests/test-theme-preferences-gtk3-populate.c',
   include_directories: [config_h_include],

src/fe-gtk/servlistgui.c

@@ -88,7 +88,6 @@ static GtkWidget *edit_entry_real;
 static GtkWidget *edit_entry_pass;
 static GtkWidget *edit_check_show_pass;
 static GtkWidget *edit_check_use_keyring;
-static GtkWidget *edit_check_ask_pass;
 static GtkWidget *edit_button_encrypt_pass;
 static GtkWidget *edit_button_import_pass;
 static int edit_pass_changed;
@@ -123,11 +122,7 @@ servlist_update_password_tools (ircnet *net)
 		return;
 
 	use_keyring = net && (net->flags & FLAG_USE_KEYRING);
-	if ((net && (net->flags & FLAG_PROMPT_PASSWORD)) ||
+	has_local = net && net->pass && *net->pass && !use_keyring && !edit_pass_changed;
-		(edit_check_ask_pass && gtk_toggle_button_get_active (GTK_TOGGLE_BUTTON (edit_check_ask_pass))))
-		use_keyring = FALSE;
-	has_local = net && net->pass && *net->pass && !use_keyring && !edit_pass_changed &&
-		(!edit_check_ask_pass || !gtk_toggle_button_get_active (GTK_TOGGLE_BUTTON (edit_check_ask_pass)));
 	gtk_widget_set_sensitive (edit_button_encrypt_pass, has_local && !servlist_password_is_encrypted (net->pass));
 	gtk_widget_set_sensitive (edit_button_import_pass, has_local);
 }
@@ -140,17 +135,6 @@ servlist_entry_set_text_silent (GtkWidget *entry, const char *text)
 	g_signal_handlers_unblock_by_func (G_OBJECT (entry), G_CALLBACK (servlist_password_changed_cb), NULL);
 }
 
-static void
-servlist_toggle_ask_pass_cb (GtkToggleButton *toggle, gpointer userdata)
-{
-	gboolean active = gtk_toggle_button_get_active (toggle);
-
-	gtk_widget_set_sensitive (edit_check_use_keyring, !active);
-	gtk_widget_set_sensitive (edit_entry_pass, !active && (!selected_net || selected_net->logintype != LOGIN_SASLEXTERNAL));
-	gtk_widget_set_sensitive (edit_check_show_pass, !active);
-	servlist_update_password_tools (selected_net);
-}
-
 static char *
 servlist_display_password (ircnet *net)
 {
@@ -1277,7 +1261,6 @@ static void
 servlist_edit_update (ircnet *net)
 {
 	gboolean use_keyring;
-	gboolean ask_pass;
 	gboolean keyring_changed;
 	char *password = NULL;
 	servlist_update_from_entry (&net->nick, edit_entry_nick);
@@ -1286,23 +1269,8 @@ servlist_edit_update (ircnet *net)
 	servlist_update_from_entry (&net->real, edit_entry_real);
 	if (net && net->name)
 	{
-		ask_pass = gtk_toggle_button_get_active (GTK_TOGGLE_BUTTON (edit_check_ask_pass));
+		use_keyring = gtk_toggle_button_get_active (GTK_TOGGLE_BUTTON (edit_check_use_keyring));
-		use_keyring = !ask_pass && gtk_toggle_button_get_active (GTK_TOGGLE_BUTTON (edit_check_use_keyring));
 		keyring_changed = !!(net->flags & FLAG_USE_KEYRING) != !!use_keyring;
-		if (ask_pass)
-		{
-			secretstore_delete_network_password (net->name);
-			if (net->pass)
-			{
-				memset (net->pass, 0, strlen (net->pass));
-				g_free (net->pass);
-				net->pass = NULL;
-			}
-			net->flags &= ~FLAG_USE_KEYRING;
-			net->flags |= FLAG_PROMPT_PASSWORD;
-			return;
-		}
-		net->flags &= ~FLAG_PROMPT_PASSWORD;
 		if (!edit_pass_changed && !keyring_changed)
 			return;
 		if (edit_pass_changed)
@@ -1370,7 +1338,6 @@ servlist_edit_close_cb (GtkWidget *button, gpointer userdata)
 	edit_win = NULL;
 	edit_entry_pass = NULL;
 	edit_check_show_pass = NULL;
-	edit_check_ask_pass = NULL;
 	edit_button_encrypt_pass = NULL;
 	edit_button_import_pass = NULL;
 }
@@ -2598,7 +2565,7 @@ servlist_open_edit (GtkWidget *parent, ircnet *net)
 
 
 	/* Checkboxes and entries */
-	table3 = gtkutil_grid_new (19, 2, FALSE);
+	table3 = gtkutil_grid_new (17, 2, FALSE);
 	gtk_box_pack_start (GTK_BOX (vbox5), table3, FALSE, FALSE, 0);
 	gtk_grid_set_row_spacing (GTK_GRID (table3), 2);
 	gtk_grid_set_column_spacing (GTK_GRID (table3), 8);
@@ -2617,43 +2584,34 @@ servlist_open_edit (GtkWidget *parent, ircnet *net)
 #endif
 	servlist_create_check (1, net->flags & FLAG_USE_GLOBAL, table3, 5, 0, _("Use global user information"));
 
-	edit_check_ask_pass = gtk_check_button_new_with_mnemonic (_("Ask for password on connect"));
-	gtk_toggle_button_set_active (GTK_TOGGLE_BUTTON (edit_check_ask_pass), net->flags & FLAG_PROMPT_PASSWORD);
-	servlist_table_attach (table3, edit_check_ask_pass, 0, 2, 6, 7,
-					   FALSE, FALSE,
-					   SERVLIST_ALIGN_START, SERVLIST_ALIGN_CENTER,
-					   SERVLIST_X_PADDING, SERVLIST_Y_PADDING);
-	g_signal_connect (G_OBJECT (edit_check_ask_pass), "toggled",
-				  G_CALLBACK (servlist_toggle_ask_pass_cb), NULL);
-
 	edit_check_use_keyring = gtk_check_button_new_with_mnemonic (_("Use system keyring"));
 	gtk_toggle_button_set_active (GTK_TOGGLE_BUTTON (edit_check_use_keyring), net->flags & FLAG_USE_KEYRING);
-	servlist_table_attach (table3, edit_check_use_keyring, 0, 2, 7, 8,
+	servlist_table_attach (table3, edit_check_use_keyring, 0, 2, 6, 7,
 					   FALSE, FALSE,
 					   SERVLIST_ALIGN_START, SERVLIST_ALIGN_CENTER,
 					   SERVLIST_X_PADDING, SERVLIST_Y_PADDING);
 	g_signal_connect (G_OBJECT (edit_check_use_keyring), "toggled",
 				  G_CALLBACK (servlist_toggle_keyring_cb), NULL);
 
-	edit_entry_nick = servlist_create_entry (table3, _("_Nick name:"), 8, net->nick, &edit_label_nick, 0);
+	edit_entry_nick = servlist_create_entry (table3, _("_Nick name:"), 7, net->nick, &edit_label_nick, 0);
-	edit_entry_nick2 = servlist_create_entry (table3, _("Second choice:"), 9, net->nick2, &edit_label_nick2, 0);
+	edit_entry_nick2 = servlist_create_entry (table3, _("Second choice:"), 8, net->nick2, &edit_label_nick2, 0);
-	edit_entry_real = servlist_create_entry (table3, _("Rea_l name:"), 10, net->real, &edit_label_real, 0);
+	edit_entry_real = servlist_create_entry (table3, _("Rea_l name:"), 9, net->real, &edit_label_real, 0);
-	edit_entry_user = servlist_create_entry (table3, _("_User name:"), 11, net->user, &edit_label_user, 0);
+	edit_entry_user = servlist_create_entry (table3, _("_User name:"), 10, net->user, &edit_label_user, 0);
 
 	label_logintype = gtk_label_new (_("Login method:"));
-	servlist_table_attach (table3, label_logintype, 0, 1, 12, 13,
+	servlist_table_attach (table3, label_logintype, 0, 1, 11, 12,
 						   FALSE, FALSE,
 						   SERVLIST_ALIGN_START, SERVLIST_ALIGN_CENTER,
 						   SERVLIST_X_PADDING, SERVLIST_Y_PADDING);
 	gtk_widget_set_halign (label_logintype, GTK_ALIGN_START);
 	gtk_widget_set_valign (label_logintype, GTK_ALIGN_CENTER);
 	combobox_logintypes = servlist_create_logintypecombo (notebook);
-	servlist_table_attach (table3, combobox_logintypes, 1, 2, 12, 13,
+	servlist_table_attach (table3, combobox_logintypes, 1, 2, 11, 12,
 						   FALSE, FALSE,
 						   SERVLIST_ALIGN_FILL, SERVLIST_ALIGN_FILL,
 						   4, 2);
 
-	edit_entry_pass = servlist_create_entry (table3, _("Password:"), 13, NULL, 0, _("Password used for login. If in doubt, leave blank."));
+	edit_entry_pass = servlist_create_entry (table3, _("Password:"), 12, NULL, 0, _("Password used for login. If in doubt, leave blank."));
 	if (edit_loaded_password)
 	{
 		memset (edit_loaded_password, 0, strlen (edit_loaded_password));
@@ -2686,7 +2644,7 @@ servlist_open_edit (GtkWidget *parent, ircnet *net)
 	if (selected_net && selected_net->logintype == LOGIN_SASLEXTERNAL)
 		gtk_widget_set_sensitive (edit_entry_pass, FALSE);
 	edit_check_show_pass = gtk_check_button_new_with_mnemonic (_("Show password"));
-	servlist_table_attach (table3, edit_check_show_pass, 0, 2, 14, 15,
+	servlist_table_attach (table3, edit_check_show_pass, 0, 2, 13, 14,
 						   FALSE, FALSE,
 						   SERVLIST_ALIGN_START, SERVLIST_ALIGN_CENTER,
 						   4, 2);
@@ -2694,14 +2652,14 @@ servlist_open_edit (GtkWidget *parent, ircnet *net)
 					  G_CALLBACK (servlist_toggle_show_password_cb), edit_entry_pass);
 
 	edit_button_encrypt_pass = gtk_button_new_with_mnemonic (_("Encrypt saved password"));
-	servlist_table_attach (table3, edit_button_encrypt_pass, 0, 1, 15, 16,
+	servlist_table_attach (table3, edit_button_encrypt_pass, 0, 1, 14, 15,
 						   FALSE, FALSE,
 						   SERVLIST_ALIGN_START, SERVLIST_ALIGN_CENTER,
 						   SERVLIST_X_PADDING, SERVLIST_Y_PADDING);
 	g_signal_connect (G_OBJECT (edit_button_encrypt_pass), "clicked",
 					  G_CALLBACK (servlist_encrypt_password_cb), net);
 	edit_button_import_pass = gtk_button_new_with_mnemonic (_("Move password to keyring"));
-	servlist_table_attach (table3, edit_button_import_pass, 1, 2, 15, 16,
+	servlist_table_attach (table3, edit_button_import_pass, 1, 2, 14, 15,
 						   FALSE, FALSE,
 						   SERVLIST_ALIGN_START, SERVLIST_ALIGN_CENTER,
 						   4, 2);
@@ -2709,14 +2667,14 @@ servlist_open_edit (GtkWidget *parent, ircnet *net)
 					  G_CALLBACK (servlist_import_password_cb), net);
 
 	label34 = gtk_label_new (_("Character set:"));
-	servlist_table_attach (table3, label34, 0, 1, 16, 17,
+	servlist_table_attach (table3, label34, 0, 1, 15, 16,
 						   FALSE, FALSE,
 						   SERVLIST_ALIGN_START, SERVLIST_ALIGN_CENTER,
 						   SERVLIST_X_PADDING, SERVLIST_Y_PADDING);
 	gtk_widget_set_halign (label34, GTK_ALIGN_START);
 	gtk_widget_set_valign (label34, GTK_ALIGN_CENTER);
 	comboboxentry_charset = servlist_create_charsetcombo ();
-	servlist_table_attach (table3, comboboxentry_charset, 1, 2, 16, 17,
+	servlist_table_attach (table3, comboboxentry_charset, 1, 2, 15, 16,
 						   FALSE, FALSE,
 						   SERVLIST_ALIGN_FILL, SERVLIST_ALIGN_FILL,
 						   4, 2);
@@ -2742,7 +2700,7 @@ servlist_open_edit (GtkWidget *parent, ircnet *net)
 							G_CALLBACK (servlist_delete_client_cert_cb), net);
 	gtk_box_pack_start (GTK_BOX (hbox_cert_buttons), edit_button_cert_delete, FALSE, FALSE, 0);
 
-	servlist_table_attach (table3, hbox_cert_buttons, 0, 2, 17, 18,
+	servlist_table_attach (table3, hbox_cert_buttons, 0, 2, 16, 17,
 						   FALSE, FALSE,
 						   SERVLIST_ALIGN_START, SERVLIST_ALIGN_CENTER,
 						   SERVLIST_X_PADDING, SERVLIST_Y_PADDING);

src/fe-gtk/setup.c

@@ -673,11 +673,6 @@ static const setting network_settings[] =
         {ST_ENTRY,      N_("Username:"), P_OFFSETNL(hex_net_proxy_user), 0, 0, sizeof prefs.hex_net_proxy_user},
         {ST_ENTRY,      N_("Password:"), P_OFFSETNL(hex_net_proxy_pass), 0, GINT_TO_POINTER(1), sizeof prefs.hex_net_proxy_pass},
 
-        {ST_HEADER,     N_("Remote Media"), 0, 0, 0, 0},
-        {ST_TOGGLE,     N_("Allow loading remote media (inline images) when clicked"),
-                                        P_OFFINTNL(hex_net_remote_media),
-                                        N_("Loading remote media contacts the site hosting it, which can reveal your IP address and that you viewed the message. You are asked for confirmation before each new domain is contacted."), 0, 0},
-
         {ST_END, 0, 0, 0, 0, 0}
 };
 
@@ -1050,30 +1045,28 @@ setup_create_spin (GtkWidget *table, int row, const setting *set)
         return wid;
 }
 
-static guint setup_trans_apply_tag = 0;
-/* the window opacity the dialog opened with, so cancelling can undo the
- * live preview done by the slider */
-static int setup_transparency_snapshot;
-
 static gint
-setup_apply_trans (gpointer userdata)
+setup_apply_trans (int *tag)
 {
         prefs.hex_gui_transparency = setup_prefs.hex_gui_transparency;
-        if (current_sess)
         gtk_widget_set_opacity (current_sess->gui->window,
                                                         (prefs.hex_gui_transparency / 255.));
 
-        setup_trans_apply_tag = 0;
+        *tag = 0;
         return 0;
 }
 
 static void
 setup_hscale_cb (GtkRange *wid, const setting *set)
 {
+        static int tag = 0;
+
         setup_set_int (&setup_prefs, set, (int) gtk_range_get_value (wid));
 
-        if (setup_trans_apply_tag == 0)
+        if (tag == 0)
-                setup_trans_apply_tag = g_idle_add ((GSourceFunc) setup_apply_trans, NULL);
+        {
+                tag = g_idle_add ((GSourceFunc) setup_apply_trans, &tag);
+        }
 }
 
 static void
@@ -1098,8 +1091,7 @@ setup_create_hscale (GtkWidget *table, int row, const setting *set)
 
 #ifndef WIN32 /* Windows always supports this */
         /* Only used for transparency currently */
-        if (current_sess &&
+        if (!gdk_screen_is_composited (gtk_widget_get_screen (current_sess->gui->window)))
-                 !gdk_screen_is_composited (gtk_widget_get_screen (current_sess->gui->window)))
                 gtk_widget_set_sensitive (wid, FALSE);
 #endif
 }
@@ -2301,9 +2293,7 @@ setup_apply (struct zoitechatprefs *pr)
 	ThemeChangedEvent event;
 	struct zoitechatprefs old_prefs = prefs;
 	int old_dark_mode = prefs.hex_gui_dark_mode;
-	mg_live_prefs live_changes;
 
-	memset (&live_changes, 0, sizeof (live_changes));
 
 #define DIFF(a) (pr->a != prefs.a)
 
@@ -2311,49 +2301,40 @@ setup_apply (struct zoitechatprefs *pr)
         if (DIFF (hex_gui_lang))
                 noapply = TRUE;
 #endif
-        /* server tabs are only created when a connection is opened, so
-           existing connections keep their current tabs until a restart;
-           the channel tree indentation is still re-applied below */
-        if (DIFF (hex_gui_tab_server))
-        {
-                noapply = TRUE;
-                live_changes.chanview = TRUE;
-        }
-
         if (DIFF (hex_gui_compact))
-        {
+                noapply = TRUE;
-                live_changes.chanview = TRUE;
+        if (DIFF (hex_gui_input_icon))
-                live_changes.ulist_columns = TRUE;
+                noapply = TRUE;
-        }
+        if (DIFF (hex_gui_input_nick))
-        if (DIFF (hex_gui_input_icon) || DIFF (hex_gui_input_nick))
+                noapply = TRUE;
-                live_changes.input_box = TRUE;
+        if (DIFF (hex_gui_lagometer))
-        if (DIFF (hex_gui_lagometer) || DIFF (hex_gui_throttlemeter))
+                noapply = TRUE;
-                live_changes.meters = TRUE;
+        if (DIFF (hex_gui_mode_buttons_inline))
-        if (DIFF (hex_gui_mode_buttons_inline) || DIFF (hex_gui_topicbar_multiline))
+                noapply = TRUE;
-                live_changes.topic_bar = TRUE;
+        if (DIFF (hex_gui_tab_icons))
-        if (DIFF (hex_gui_tab_icons) || DIFF (hex_gui_tab_closebuttons) ||
+                noapply = TRUE;
-                 DIFF (hex_gui_tab_small))
+        if (DIFF (hex_gui_tab_closebuttons))
-                live_changes.chanview = TRUE;
+                noapply = TRUE;
+        if (DIFF (hex_gui_tab_server))
+                noapply = TRUE;
+        if (DIFF (hex_gui_tab_small))
+                noapply = TRUE;
         if (DIFF (hex_gui_tab_sort))
-                live_changes.tab_resort = TRUE;
+                noapply = TRUE;
         if (DIFF (hex_gui_tab_trunc))
-                live_changes.tab_trunc = TRUE;
+                noapply = TRUE;
+        if (DIFF (hex_gui_throttlemeter))
+                noapply = TRUE;
+        if (DIFF (hex_gui_topicbar_multiline))
+                noapply = TRUE;
         if (DIFF (hex_gui_ulist_count))
-                live_changes.ulist_count = TRUE;
+                noapply = TRUE;
         if (DIFF (hex_gui_ulist_icons))
-                live_changes.ulist_rows = TRUE;
+                noapply = TRUE;
         if (DIFF (hex_gui_ulist_show_hosts))
-        {
+                noapply = TRUE;
-                live_changes.ulist_columns = TRUE;
-                live_changes.ulist_rows = TRUE; /* hostnames may be stale */
-        }
         if (DIFF (hex_gui_ulist_sort))
-                live_changes.ulist_sort = TRUE;
+                noapply = TRUE;
-        /* compare against the pre-dialog value: the slider previews the
-           opacity live on the current window only, so OK still needs to
-           apply it to the other windows */
-        if (pr->hex_gui_transparency != setup_transparency_snapshot)
-                live_changes.transparency = TRUE;
 
         if ((pr->hex_gui_tab_pos == 5 || pr->hex_gui_tab_pos == 6) &&
                  pr->hex_gui_tab_layout == 2 && pr->hex_gui_tab_pos != prefs.hex_gui_tab_pos)
@@ -2397,8 +2378,6 @@ setup_apply (struct zoitechatprefs *pr)
 
 	theme_manager_dispatch_setup_apply (&event);
 
-	mg_apply_live_prefs (&live_changes);
-
         if (noapply)
                 fe_message (_("Some settings were changed that require a"
                                                 " restart to take full effect."), FE_MSG_WARN);
@@ -2431,9 +2410,6 @@ setup_ok_cb (GtkWidget *but, GtkWidget *win)
         if (save_result.success)
         {
                 theme_preferences_stage_commit ();
-                /* the previewed values were accepted, so the close handler
-                   must not revert them */
-                setup_transparency_snapshot = prefs.hex_gui_transparency;
                 gtk_widget_destroy (win);
                 return;
         }
@@ -2496,24 +2472,6 @@ setup_close_cb (GtkWidget *win, GtkWidget **swin)
 {
         *swin = NULL;
 
-        /* drop any pending transparency preview and undo the previewed
-           opacity when the dialog is cancelled; after OK the snapshot
-           was updated so this is a no-op */
-        if (setup_trans_apply_tag)
-        {
-                g_source_remove (setup_trans_apply_tag);
-                setup_trans_apply_tag = 0;
-        }
-        if (prefs.hex_gui_transparency != setup_transparency_snapshot)
-        {
-                mg_live_prefs revert_changes;
-
-                prefs.hex_gui_transparency = setup_transparency_snapshot;
-                memset (&revert_changes, 0, sizeof (revert_changes));
-                revert_changes.transparency = TRUE;
-                mg_apply_live_prefs (&revert_changes);
-        }
-
         theme_preferences_stage_discard ();
 
         if (font_dialog)
@@ -2535,7 +2493,6 @@ setup_open (void)
         memcpy (&setup_prefs, &prefs, sizeof (prefs));
 
         color_change = FALSE;
-        setup_transparency_snapshot = prefs.hex_gui_transparency;
         theme_preferences_stage_begin ();
         setup_window = setup_window_open ();
 

src/fe-gtk/theme/tests/test-theme-access-routing.c

@@ -23,7 +23,6 @@
 #include <math.h>
 
 #include "../theme-access.h"
-#include "../theme-css.h"
 #include "../theme-manager.h"
 #include "../theme-runtime.h"
 #include "../../xtext-color.h"
@@ -55,13 +54,6 @@ setup_apply_real (const ThemeChangedEvent *event)
 	(void) event;
 }
 
-void
-gtkutil_append_font_css (GString *css, const PangoFontDescription *font_desc)
-{
-	(void) css;
-	(void) font_desc;
-}
-
 gboolean
 fe_dark_mode_is_enabled_for (unsigned int mode)
 {
@@ -181,14 +173,6 @@ theme_gtk3_is_active (void)
 	return stub_gtk3_active;
 }
 
-gboolean
-theme_gtk3_lookup_theme_color (const char *name, GdkRGBA *out_color)
-{
-	(void) name;
-	(void) out_color;
-	return FALSE;
-}
-
 static gboolean
 rgba_equal (const GdkRGBA *a, const GdkRGBA *b)
 {
@@ -352,79 +336,6 @@ test_access_xtext_palette_widget_mapping_when_gtk3_active (void)
 	g_object_unref (provider);
 }
 
-static void
-test_access_palette_css_does_not_feed_back_into_sampling (void)
-{
-	GtkWidget *window;
-	GtkWidget *label;
-	GtkCssProvider *theme1;
-	GtkCssProvider *theme2;
-	GdkScreen *screen;
-	XTextColor palette[2] = { 0 };
-	GdkRGBA old_bg;
-	GdkRGBA old_fg;
-	GdkRGBA expected;
-
-	if (!gtk_available)
-	{
-		g_test_message ("GTK display not available");
-		return;
-	}
-
-	reset_stubs ();
-	stub_gtk3_active = TRUE;
-	screen = gdk_screen_get_default ();
-	window = gtk_window_new (GTK_WINDOW_TOPLEVEL);
-	label = gtk_label_new ("mapped");
-	gtk_container_add (GTK_CONTAINER (window), label);
-	gtk_widget_realize (window);
-
-	/* Old GTK3 theme active at screen level. */
-	theme1 = gtk_css_provider_new ();
-	gtk_css_provider_load_from_data (theme1,
-		"label { color: #112233; background-color: #445566; }"
-		"label:selected { color: #778899; background-color: #aabbcc; }",
-		-1, NULL);
-	gtk_style_context_add_provider_for_screen (screen,
-		GTK_STYLE_PROVIDER (theme1), GTK_STYLE_PROVIDER_PRIORITY_USER);
-
-	/* The app paints the sampled theme colors onto the widget, like the
-	 * user list / channel tree / input box palette provider does. */
-	g_assert_true (gdk_rgba_parse (&old_bg, "#445566"));
-	g_assert_true (gdk_rgba_parse (&old_fg, "#112233"));
-	theme_css_apply_palette_widget (label, &old_bg, &old_fg, NULL);
-
-	/* The user switches to a new GTK3 theme. */
-	gtk_style_context_remove_provider_for_screen (screen, GTK_STYLE_PROVIDER (theme1));
-	theme2 = gtk_css_provider_new ();
-	gtk_css_provider_load_from_data (theme2,
-		"label { color: #00ff00; background-color: #ff0000; }"
-		"label:selected { color: #0000ff; background-color: #ffff00; }",
-		-1, NULL);
-	gtk_style_context_add_provider_for_screen (screen,
-		GTK_STYLE_PROVIDER (theme2), GTK_STYLE_PROVIDER_PRIORITY_USER);
-	gtk_style_context_reset_widgets (screen);
-
-	/* Re-sampling must see the new theme, not the palette colors the
-	 * app applied for the old theme. */
-	theme_get_xtext_colors_for_widget (label, palette, G_N_ELEMENTS (palette));
-
-	g_assert_true (stub_last_gtk_map_valid);
-	g_assert_true (gdk_rgba_parse (&expected, "#00ff00"));
-	g_assert_true (rgba_close (&stub_last_gtk_map.text_foreground, &expected));
-	g_assert_true (gdk_rgba_parse (&expected, "#ff0000"));
-	g_assert_true (rgba_close (&stub_last_gtk_map.text_background, &expected));
-
-	/* Sampling must not permanently strip the palette class. */
-	g_assert_true (gtk_style_context_has_class (gtk_widget_get_style_context (label),
-		theme_css_palette_class_name ()));
-
-	gtk_style_context_remove_provider_for_screen (screen, GTK_STYLE_PROVIDER (theme2));
-	gtk_widget_destroy (window);
-	g_object_unref (theme1);
-	g_object_unref (theme2);
-}
-
 static void
 test_access_dark_light_switch_affects_token_consumers (void)
 {
@@ -452,8 +363,6 @@ main (int argc, char **argv)
 	g_test_add_func ("/theme/access/xtext_palette_forwarding", test_access_xtext_palette_forwarding);
 	g_test_add_func ("/theme/access/xtext_palette_widget_mapping_when_gtk3_active",
 			 test_access_xtext_palette_widget_mapping_when_gtk3_active);
-	g_test_add_func ("/theme/access/palette_css_does_not_feed_back_into_sampling",
-			 test_access_palette_css_does_not_feed_back_into_sampling);
 	g_test_add_func ("/theme/access/widget_style_forwarding", test_access_widget_style_forwarding);
 	g_test_add_func ("/theme/access/dark_light_switch_affects_token_consumers",
 			 test_access_dark_light_switch_affects_token_consumers);

src/fe-gtk/theme/tests/test-theme-gtk3-settings.c

@@ -24,7 +24,6 @@
 #include <glib.h>
 #include <glib/gstdio.h>
 #include <gtk/gtk.h>
-#include <gio/gio.h>
 
 #include "../theme-gtk3.h"
 #include "../../../common/gtk3-theme-service.h"
@@ -40,14 +39,11 @@ static char *xdg_data_home;
 static char *theme_parent_root;
 static char *theme_child_root;
 static char *theme_switch_root;
-static char *theme_chrome_root;
-
-static gboolean stub_system_prefers_dark;
 
 gboolean
 theme_policy_system_prefers_dark (void)
 {
-	return stub_system_prefers_dark;
+	return FALSE;
 }
 
 static void
@@ -135,8 +131,6 @@ zoitechat_gtk3_theme_find_by_id (const char *theme_id)
 		return make_theme (theme_id, theme_child_root);
 	if (g_strcmp0 (theme_id, "switch") == 0)
 		return make_theme (theme_id, theme_switch_root);
-	if (g_strcmp0 (theme_id, "chrome") == 0)
-		return make_theme (theme_id, theme_chrome_root);
 	return NULL;
 }
 
@@ -183,11 +177,6 @@ zoitechat_gtk3_theme_build_inheritance_chain (const char *theme_root)
 		g_ptr_array_add (chain, g_strdup (theme_switch_root));
 		return chain;
 	}
-	if (g_strcmp0 (theme_root, theme_chrome_root) == 0)
-	{
-		g_ptr_array_add (chain, g_strdup (theme_chrome_root));
-		return chain;
-	}
 	g_ptr_array_unref (chain);
 	return NULL;
 }
@@ -258,22 +247,6 @@ setup_themes (void)
 		"gtk-enable-animations=false\n"
 		"gtk-cursor-blink-time=444\n");
 
-	theme_chrome_root = g_build_filename (temp_root, "chrome", NULL);
-	g_assert_cmpint (g_mkdir_with_parents (theme_chrome_root, 0700), ==, 0);
-	ensure_css_dir (theme_chrome_root, "gtk-3.24");
-	/* Defines named colors but no window/menubar/menu rules of its own,
-	 * so all chrome styling must come from the backfill provider. */
-	{
-		char *css = g_build_filename (theme_chrome_root, "gtk-3.24", "gtk.css", NULL);
-		write_file (css,
-			"@define-color theme_bg_color #e8f4e8;\n"
-			"@define-color theme_fg_color #102010;\n"
-			"@define-color theme_selected_bg_color #3465a4;\n"
-			"@define-color theme_selected_fg_color #ffffff;\n"
-			"label { color: #102010; }\n");
-		g_free (css);
-	}
-
 	path = g_build_filename (theme_parent_root, "index.theme", NULL);
 	write_file (path, "[Desktop Entry]\nName=parent\n");
 	g_free (path);
@@ -293,13 +266,11 @@ teardown_themes (void)
 	g_free (theme_parent_root);
 	g_free (theme_child_root);
 	g_free (theme_switch_root);
-	g_free (theme_chrome_root);
 	g_free (xdg_data_home);
 	g_free (temp_root);
 	theme_parent_root = NULL;
 	theme_child_root = NULL;
 	theme_switch_root = NULL;
-	theme_chrome_root = NULL;
 	xdg_data_home = NULL;
 	temp_root = NULL;
 }
@@ -372,205 +343,6 @@ test_settings_restored_on_disable_and_switch (void)
 	g_assert_false (theme_gtk3_is_active ());
 }
 
-static void
-test_follow_system_variant_resolves_to_theme_variant (void)
-{
-	GError *error = NULL;
-
-	if (!gtk_available)
-	{
-		g_test_message ("GTK display not available");
-		return;
-	}
-
-	/* An explicitly selected in-app theme must not follow the OS
-	 * light/dark preference: the legacy FOLLOW_SYSTEM variant resolves
-	 * to the variant the theme itself provides, so the window chrome
-	 * (menu bar) stays on the theme even when the system prefers dark. */
-	stub_system_prefers_dark = TRUE;
-	g_assert_true (theme_gtk3_apply ("switch", THEME_GTK3_VARIANT_FOLLOW_SYSTEM, &error));
-	g_assert_no_error (error);
-	g_assert_true (theme_gtk3_is_active ());
-	g_assert_cmpint (theme_gtk3_active_variant (), ==, THEME_GTK3_VARIANT_PREFER_LIGHT);
-	g_assert_false (get_bool_setting ("gtk-application-prefer-dark-theme"));
-
-	stub_system_prefers_dark = FALSE;
-	theme_gtk3_disable ();
-}
-
-static void
-test_menu_bar_follows_active_theme_colors (void)
-{
-	GError *error = NULL;
-	GtkWidget *window;
-	GtkWidget *menubar;
-	GtkStyleContext *context;
-	GdkRGBA bg;
-	GdkRGBA expected;
-
-	if (!gtk_available)
-	{
-		g_test_message ("GTK display not available");
-		return;
-	}
-
-	/* The chrome theme defines no menubar rules; without the backfill
-	 * provider the menu bar would fall through to the base (OS) theme
-	 * and follow the OS dark/light mode instead of the selected theme. */
-	g_assert_true (theme_gtk3_apply ("chrome", THEME_GTK3_VARIANT_PREFER_LIGHT, &error));
-	g_assert_no_error (error);
-
-	window = gtk_window_new (GTK_WINDOW_TOPLEVEL);
-	menubar = gtk_menu_bar_new ();
-	gtk_container_add (GTK_CONTAINER (window), menubar);
-	gtk_widget_show_all (window);
-
-	context = gtk_widget_get_style_context (menubar);
-	G_GNUC_BEGIN_IGNORE_DEPRECATIONS
-	gtk_style_context_get_background_color (context, GTK_STATE_FLAG_NORMAL, &bg);
-	G_GNUC_END_IGNORE_DEPRECATIONS
-	g_assert_true (gdk_rgba_parse (&expected, "#e8f4e8"));
-	g_assert_cmpfloat (ABS (bg.red - expected.red), <, 0.01);
-	g_assert_cmpfloat (ABS (bg.green - expected.green), <, 0.01);
-	g_assert_cmpfloat (ABS (bg.blue - expected.blue), <, 0.01);
-
-	/* The window background must follow the theme too, or the space
-	 * around and beside the menu bar keeps the OS theme's colors. */
-	context = gtk_widget_get_style_context (window);
-	G_GNUC_BEGIN_IGNORE_DEPRECATIONS
-	gtk_style_context_get_background_color (context, GTK_STATE_FLAG_NORMAL, &bg);
-	G_GNUC_END_IGNORE_DEPRECATIONS
-	g_assert_cmpfloat (ABS (bg.red - expected.red), <, 0.01);
-	g_assert_cmpfloat (ABS (bg.green - expected.green), <, 0.01);
-	g_assert_cmpfloat (ABS (bg.blue - expected.blue), <, 0.01);
-
-	gtk_widget_destroy (window);
-	theme_gtk3_disable ();
-}
-
-static void
-test_desktop_color_sync_does_not_leak_into_chrome (void)
-{
-	GError *error = NULL;
-	GtkWidget *window;
-	GtkWidget *menubar;
-	GtkStyleContext *context;
-	GtkCssProvider *desktop_css;
-	GdkScreen *screen;
-	GdkRGBA bg;
-	GdkRGBA expected;
-	GdkRGBA injected;
-
-	if (!gtk_available)
-	{
-		g_test_message ("GTK display not available");
-		return;
-	}
-
-	/* KDE's GTK color-scheme sync (~/.config/gtk-3.0/gtk.css) redefines
-	 * the standard named colors with the OS palette at USER priority.
-	 * The switch theme defines no named colors of its own, so a naive
-	 * @theme_bg_color reference in the chrome backfill would resolve to
-	 * the injected OS dark palette; the backfill must use its neutral
-	 * variant fallback instead. */
-	screen = gdk_screen_get_default ();
-	desktop_css = gtk_css_provider_new ();
-	gtk_css_provider_load_from_data (desktop_css,
-		"@define-color theme_bg_color #1e1e1e;\n"
-		"@define-color theme_fg_color #eeeeee;\n"
-		"menubar { background-color: #1e1e1e; }\n",
-		-1, NULL);
-	gtk_style_context_add_provider_for_screen (screen,
-		GTK_STYLE_PROVIDER (desktop_css), GTK_STYLE_PROVIDER_PRIORITY_USER);
-
-	g_assert_true (theme_gtk3_apply ("switch", THEME_GTK3_VARIANT_PREFER_LIGHT, &error));
-	g_assert_no_error (error);
-
-	{
-		GtkWidget *item;
-		GdkRGBA item_bg;
-
-		window = gtk_window_new (GTK_WINDOW_TOPLEVEL);
-		menubar = gtk_menu_bar_new ();
-		item = gtk_menu_item_new_with_label ("File");
-		gtk_menu_shell_append (GTK_MENU_SHELL (menubar), item);
-		gtk_container_add (GTK_CONTAINER (window), menubar);
-		gtk_widget_show_all (window);
-
-		context = gtk_widget_get_style_context (menubar);
-		G_GNUC_BEGIN_IGNORE_DEPRECATIONS
-		gtk_style_context_get_background_color (context, GTK_STATE_FLAG_NORMAL, &bg);
-		G_GNUC_END_IGNORE_DEPRECATIONS
-		g_assert_true (gdk_rgba_parse (&expected, "#f6f5f4"));
-		g_assert_true (gdk_rgba_parse (&injected, "#1e1e1e"));
-		g_assert_cmpfloat (ABS (bg.red - injected.red), >, 0.1);
-		g_assert_cmpfloat (ABS (bg.red - expected.red), <, 0.01);
-		g_assert_cmpfloat (ABS (bg.green - expected.green), <, 0.01);
-		g_assert_cmpfloat (ABS (bg.blue - expected.blue), <, 0.01);
-
-		/* The menu bar body and the menu items must be one surface. */
-		context = gtk_widget_get_style_context (item);
-		G_GNUC_BEGIN_IGNORE_DEPRECATIONS
-		gtk_style_context_get_background_color (context, GTK_STATE_FLAG_NORMAL, &item_bg);
-		G_GNUC_END_IGNORE_DEPRECATIONS
-		g_assert_cmpfloat (ABS (item_bg.red - bg.red), <, 0.01);
-		g_assert_cmpfloat (ABS (item_bg.green - bg.green), <, 0.01);
-		g_assert_cmpfloat (ABS (item_bg.blue - bg.blue), <, 0.01);
-	}
-
-	gtk_widget_destroy (window);
-	theme_gtk3_disable ();
-	gtk_style_context_remove_provider_for_screen (screen, GTK_STYLE_PROVIDER (desktop_css));
-	g_object_unref (desktop_css);
-}
-
-static void
-test_stale_theme_symlink_is_replaced (void)
-{
-	GError *error = NULL;
-	char *themes_dir;
-	char *link_path;
-	char *target;
-	char *active_theme_name = NULL;
-
-	if (!gtk_available)
-	{
-		g_test_message ("GTK display not available");
-		return;
-	}
-	if (!has_default_seat ())
-	{
-		g_test_message ("No default seat available");
-		return;
-	}
-
-	/* A dangling symlink left behind by a removed theme must not block
-	 * pinning gtk-theme-name to the newly applied theme. */
-	themes_dir = g_build_filename (xdg_data_home, "themes", NULL);
-	g_assert_cmpint (g_mkdir_with_parents (themes_dir, 0700), ==, 0);
-	link_path = g_build_filename (themes_dir, "switch", NULL);
-	g_unlink (link_path);
-	{
-		GFile *link_file = g_file_new_for_path (link_path);
-		g_assert_true (g_file_make_symbolic_link (link_file, "/nonexistent/switch", NULL, NULL));
-		g_object_unref (link_file);
-	}
-
-	g_assert_true (theme_gtk3_apply ("switch", THEME_GTK3_VARIANT_PREFER_LIGHT, &error));
-	g_assert_no_error (error);
-
-	target = g_file_read_link (link_path, NULL);
-	g_assert_cmpstr (target, ==, theme_switch_root);
-	g_object_get (gtk_settings_get_default (), "gtk-theme-name", &active_theme_name, NULL);
-	g_assert_cmpstr (active_theme_name, ==, "switch");
-
-	g_free (active_theme_name);
-	g_free (target);
-	g_free (link_path);
-	g_free (themes_dir);
-	theme_gtk3_disable ();
-}
-
 int
 main (int argc, char **argv)
 {
@@ -582,14 +354,6 @@ main (int argc, char **argv)
 
 	g_test_add_func ("/theme/gtk3/settings_layer_precedence", test_settings_layer_precedence);
 	g_test_add_func ("/theme/gtk3/settings_restored_on_disable_and_switch", test_settings_restored_on_disable_and_switch);
-	g_test_add_func ("/theme/gtk3/follow_system_variant_resolves_to_theme_variant",
-			 test_follow_system_variant_resolves_to_theme_variant);
-	g_test_add_func ("/theme/gtk3/menu_bar_follows_active_theme_colors",
-			 test_menu_bar_follows_active_theme_colors);
-	g_test_add_func ("/theme/gtk3/desktop_color_sync_does_not_leak_into_chrome",
-			 test_desktop_color_sync_does_not_leak_into_chrome);
-	g_test_add_func ("/theme/gtk3/stale_theme_symlink_is_replaced",
-			 test_stale_theme_symlink_is_replaced);
 
 	prefs.hex_gui_gtk3_variant = THEME_GTK3_VARIANT_PREFER_LIGHT;
 

src/fe-gtk/theme/tests/test-theme-gtk3-stub.c

@@ -89,9 +89,3 @@ theme_gtk3_is_active (void)
 {
 	return FALSE;
 }
-
-ThemeGtk3Variant
-theme_gtk3_active_variant (void)
-{
-	return THEME_GTK3_VARIANT_FOLLOW_SYSTEM;
-}

src/fe-gtk/theme/tests/test-theme-preferences-gtk3-populate.c

@@ -33,7 +33,6 @@ InputStyle *input_style;
 
 static gboolean gtk_available;
 static int apply_current_calls;
-static int set_token_color_calls;
 static char applied_theme_id[256];
 static ThemeGtk3Variant applied_variant;
 static gboolean removed_selected;
@@ -71,15 +70,6 @@ load_text_events (void)
 {
 }
 
-char **
-text_color_event_names (int color, int *count)
-{
-        (void)color;
-        if (count)
-                *count = 0;
-        return NULL;
-}
-
 gboolean
 theme_get_color (ThemeSemanticToken token, GdkRGBA *color)
 {
@@ -105,7 +95,6 @@ theme_manager_set_token_color (unsigned int dark_mode, ThemeSemanticToken token,
         (void)dark_mode;
         (void)token;
         (void)color;
-        set_token_color_calls++;
         if (changed)
                 *changed = FALSE;
 }
@@ -421,43 +410,6 @@ test_select_none_resets_theme_and_applies (void)
         gtk_widget_destroy (page);
 }
 
-static void
-test_select_theme_does_not_pin_palette_tokens (void)
-{
-        GtkWidget *page;
-        theme_preferences_ui *ui;
-        struct zoitechatprefs setup_prefs;
-
-        if (!gtk_available)
-        {
-                g_test_message ("GTK display not available");
-                return;
-        }
-
-        memset (&setup_prefs, 0, sizeof (setup_prefs));
-        memset (&prefs, 0, sizeof (prefs));
-        removed_selected = FALSE;
-        apply_current_calls = 0;
-        set_token_color_calls = 0;
-
-        page = theme_preferences_create_page (NULL, &setup_prefs, NULL);
-        ui = g_object_get_data (G_OBJECT (page), "theme-preferences-ui");
-        g_assert_nonnull (ui);
-
-        /* 0 = None, 1 = removed-theme, 2 = fallback-theme */
-        gtk_combo_box_set_active (GTK_COMBO_BOX (ui->gtk3_combo), 2);
-
-        g_assert_cmpstr (prefs.hex_gui_gtk3_theme, ==, "fallback-theme");
-        g_assert_cmpint (apply_current_calls, ==, 1);
-        /* Selecting a GTK3 theme must leave the mapped palette tokens
-         * unpinned so the user list, channel tree and input box keep
-         * resolving their colors from the active theme instead of being
-         * frozen until the next restart. */
-        g_assert_cmpint (set_token_color_calls, ==, 0);
-
-        gtk_widget_destroy (page);
-}
-
 int
 main (int argc, char **argv)
 {
@@ -469,7 +421,5 @@ main (int argc, char **argv)
                          test_unset_theme_keeps_system_default_without_apply);
         g_test_add_func ("/theme/preferences/gtk3_select_none_resets_theme",
                          test_select_none_resets_theme_and_applies);
-        g_test_add_func ("/theme/preferences/gtk3_select_theme_does_not_pin_palette_tokens",
-                         test_select_theme_does_not_pin_palette_tokens);
         return g_test_run ();
 }

src/fe-gtk/theme/theme-access.c

@@ -20,8 +20,6 @@
 
 #include "theme-access.h"
 
-#include "theme-css.h"
-#include "theme-gtk3.h"
 #include "theme-runtime.h"
 
 
@@ -118,17 +116,6 @@ theme_access_lookup_named_color (GtkStyleContext *context, const char *const *na
 {
 	size_t i;
 
-	/* With an in-app GTK3 theme selected, prefer the colors resolved from
-	 * the theme itself: desktop integration CSS (e.g. KDE's color-scheme
-	 * sync) redefines the same named colors with the OS palette in the
-	 * widget cascade, which would drag OS dark/light colors into the
-	 * mapped palette. */
-	for (i = 0; names[i] != NULL; i++)
-	{
-		if (theme_gtk3_lookup_theme_color (names[i], out_color))
-			return TRUE;
-	}
-
 	for (i = 0; names[i] != NULL; i++)
 	{
 		if (gtk_style_context_lookup_color (context, names[i], out_color))
@@ -162,8 +149,6 @@ theme_access_get_gtk_palette_map (GtkWidget *widget, ThemeGtkPaletteMap *out_map
 	static const char *const selected_bg_fallbacks[] = { "theme_selected_bg_color", NULL };
 	static const char *const selected_fg_fallbacks[] = { "theme_selected_fg_color", NULL };
 	GtkStyleContext *context;
-	const char *palette_class;
-	gboolean had_palette_class;
 	GdkRGBA named;
 	GdkRGBA accent;
 
@@ -175,16 +160,6 @@ theme_access_get_gtk_palette_map (GtkWidget *widget, ThemeGtkPaletteMap *out_map
 	if (context == NULL)
 		return FALSE;
 
-	/* The application paints these widgets with fixed colors through the
-	 * zoitechat-palette provider.  Sampling must see the underlying GTK3
-	 * theme, not the colors we applied earlier: otherwise every theme
-	 * change reads back the previous palette and the user list, channel
-	 * tree and input box keep their stale colors until a restart. */
-	palette_class = theme_css_palette_class_name ();
-	had_palette_class = gtk_style_context_has_class (context, palette_class);
-	if (had_palette_class)
-		gtk_style_context_remove_class (context, palette_class);
-
 	theme_access_context_get_color (context, GTK_STATE_FLAG_NORMAL, &out_map->text_foreground);
 	theme_access_resolve_map_background (context, GTK_STATE_FLAG_NORMAL, base_fallbacks,
 					     &out_map->text_background);
@@ -198,10 +173,6 @@ theme_access_get_gtk_palette_map (GtkWidget *widget, ThemeGtkPaletteMap *out_map
 	if (accent.alpha <= 0.0)
 		accent = out_map->selection_background;
 	out_map->accent = accent;
-
-	if (had_palette_class)
-		gtk_style_context_add_class (context, palette_class);
-
 	out_map->enabled = TRUE;
 	return TRUE;
 }

src/fe-gtk/theme/theme-application.c

@@ -56,11 +56,12 @@ theme_application_apply_toplevel_theme (gboolean dark)
 
 	if (theme_gtk3_is_active ())
 	{
-		/* An explicitly selected in-app theme controls its own
+		if (prefs.hex_gui_gtk3_variant == THEME_GTK3_VARIANT_PREFER_DARK)
-		 * variant; the OS light/dark preference must not leak into
+			prefer_dark = TRUE;
-		 * the window chrome (menu bar, dialogs).  The active variant
+		else if (prefs.hex_gui_gtk3_variant == THEME_GTK3_VARIANT_PREFER_LIGHT)
-		 * is always resolved to light or dark. */
+			prefer_dark = FALSE;
-		prefer_dark = theme_gtk3_active_variant () == THEME_GTK3_VARIANT_PREFER_DARK;
+		else
+			prefer_dark = theme_policy_system_prefers_dark ();
 	}
 	else
 	{

src/fe-gtk/theme/theme-css.c

@@ -60,12 +60,6 @@ typedef struct
 static GtkCssProvider *theme_css_input_provider;
 static ThemeCssInputFingerprint theme_css_input_fp;
 
-const char *
-theme_css_palette_class_name (void)
-{
-	return theme_css_selector_palette_class;
-}
-
 void
 theme_css_apply_app_provider (GtkStyleProvider *provider)
 {

src/fe-gtk/theme/theme-css.h

@@ -30,7 +30,6 @@
  * theme_css_apply_widget_provider:
  * Use for widget-local CSS providers attached to a specific widget context.
  */
-const char *theme_css_palette_class_name (void);
 void theme_css_apply_app_provider (GtkStyleProvider *provider);
 void theme_css_remove_app_provider (GtkStyleProvider *provider);
 void theme_css_apply_widget_provider (GtkWidget *widget, GtkStyleProvider *provider);

src/fe-gtk/theme/theme-gtk3.c

@@ -33,60 +33,11 @@
 
 static GPtrArray *theme_gtk3_providers_base;
 static GPtrArray *theme_gtk3_providers_variant;
-static GtkCssProvider *theme_gtk3_chrome_provider;
-static GHashTable *theme_gtk3_theme_colors;
 static GHashTable *theme_gtk3_provider_cache;
 static gboolean theme_gtk3_active;
 static char *theme_gtk3_current_id;
 static ThemeGtk3Variant theme_gtk3_current_variant;
 
-/* Menu bar and menus fall back to the base gtk-theme-name theme (the OS
- * theme) for any property the selected in-app theme's CSS does not define,
- * which mixes OS dark/light colors into the chrome (issue: dark menu bar on
- * a light in-app theme when the OS is in dark mode).  While an in-app theme
- * is active, backfill those widgets with the theme's own named colors.  The
- * provider sits just below the theme providers, so a theme that styles its
- * menus keeps full control. */
-#define THEME_GTK3_CHROME_PRIORITY (GTK_STYLE_PROVIDER_PRIORITY_USER - 1)
-/* Concrete color values are formatted in: desktop integration CSS (e.g.
- * KDE's color-scheme sync in ~/.config/gtk-3.0/gtk.css) redefines the
- * standard named colors with the OS palette at USER priority, so a
- * "@theme_bg_color" reference here would resolve to the OS dark/light
- * colors instead of the selected theme's. */
-static const char theme_gtk3_chrome_css_template[] =
-	".background, .background:backdrop {"
-	" background-color: %s;"
-	" color: %s;"
-	"}"
-	"headerbar, headerbar:backdrop, .titlebar, .titlebar:backdrop {"
-	" background-color: %s;"
-	" background-image: none;"
-	" color: %s;"
-	"}";
-
-/* The menu bar body and the menu items are separate CSS surfaces; desktop
- * integration CSS or a theme can style one but not the other, splitting
- * the menu bar row into two colors.  These rules sit above the theme and
- * the desktop CSS so body and items always render as one surface. */
-#define THEME_GTK3_MENU_UNIFORM_PRIORITY (GTK_STYLE_PROVIDER_PRIORITY_USER + 40)
-static const char theme_gtk3_menu_uniform_template[] =
-	"menubar, menubar:backdrop, menubar > menuitem, menubar > menuitem:backdrop,"
-	"menu, menu:backdrop, .menu, .menu:backdrop, menu > menuitem, menu > menuitem:backdrop {"
-	" background-color: %s;"
-	" background-image: none;"
-	" color: %s;"
-	"}"
-	"menubar > menuitem:hover, menubar > menuitem:selected,"
-	"menu > menuitem:hover, menu > menuitem:selected,"
-	".menu menuitem:hover, .menu menuitem:selected {"
-	" background-color: %s;"
-	" background-image: none;"
-	" color: %s;"
-	"}"
-	"menubar > menuitem:disabled, menu > menuitem:disabled {"
-	" color: alpha(%s, 0.5);"
-	"}";
-
 typedef struct
 {
 	GHashTable *defaults;
@@ -98,7 +49,6 @@ typedef struct
 static ThemeGtk3SettingsState theme_gtk3_settings_state;
 
 static gboolean settings_apply_property (GtkSettings *settings, const char *property_name, const char *raw_value);
-static void theme_gtk3_menu_uniform_apply (const char *bg, const char *fg, const char *sel_bg, const char *sel_fg);
 
 static gboolean
 theme_gtk3_theme_name_is_dark (const char *name)
@@ -449,21 +399,6 @@ settings_theme_link_search_path (const char *theme_root, const char *theme_name)
 	}
 
 	link_path = g_build_filename (themes_root, theme_name, NULL);
-
-	/* A leftover symlink from a removed or relocated theme would satisfy
-	 * the EXISTS check while pointing at the wrong (or no) theme, leaving
-	 * the base gtk-theme-name on the OS theme.  Replace it. */
-	{
-		char *link_target = g_file_read_link (link_path, NULL);
-		if (link_target)
-		{
-			if (g_strcmp0 (link_target, theme_root) != 0 ||
-			    !g_file_test (link_path, G_FILE_TEST_IS_DIR))
-				g_unlink (link_path);
-			g_free (link_target);
-		}
-	}
-
 	if (!g_file_test (link_path, G_FILE_TEST_EXISTS))
 	{
 		GFile *link_file = g_file_new_for_path (link_path);
@@ -822,176 +757,12 @@ settings_apply_from_file (const char *theme_root, const char *css_dir)
 	g_ptr_array_unref (settings_paths);
 }
 
-static gboolean
-theme_gtk3_providers_define_color (const char *name)
-{
-	char *needle = g_strdup_printf ("@define-color %s ", name);
-	gboolean found = FALSE;
-	guint i;
-
-	for (i = 0; !found && theme_gtk3_providers_base && i < theme_gtk3_providers_base->len; i++)
-	{
-		char *dump = gtk_css_provider_to_string (g_ptr_array_index (theme_gtk3_providers_base, i));
-		found = dump && strstr (dump, needle) != NULL;
-		g_free (dump);
-	}
-	for (i = 0; !found && theme_gtk3_providers_variant && i < theme_gtk3_providers_variant->len; i++)
-	{
-		char *dump = gtk_css_provider_to_string (g_ptr_array_index (theme_gtk3_providers_variant, i));
-		found = dump && strstr (dump, needle) != NULL;
-		g_free (dump);
-	}
-
-	g_free (needle);
-	return found;
-}
-
-/* Resolve a named color from the selected theme itself.  The lookup
- * context layers the theme's providers over the screen cascade, so the
- * theme's own @define-color wins; when the theme does not define the
- * name at all, fall back to a neutral palette matching the theme's
- * variant instead of whatever the desktop injected into the cascade. */
-static char *
-theme_gtk3_chrome_resolve_color (GtkStyleContext *lookup, const char *name, const char *fallback)
-{
-	GdkRGBA color;
-
-	if (!theme_gtk3_providers_define_color (name) ||
-	    !gtk_style_context_lookup_color (lookup, name, &color))
-		g_assert (gdk_rgba_parse (&color, fallback));
-
-	if (!theme_gtk3_theme_colors)
-		theme_gtk3_theme_colors = g_hash_table_new_full (g_str_hash, g_str_equal, g_free, g_free);
-	{
-		GdkRGBA *stored = g_new (GdkRGBA, 1);
-		*stored = color;
-		g_hash_table_insert (theme_gtk3_theme_colors, g_strdup (name), stored);
-	}
-
-	return gdk_rgba_to_string (&color);
-}
-
-gboolean
-theme_gtk3_lookup_theme_color (const char *name, GdkRGBA *out_color)
-{
-	GdkRGBA *stored;
-
-	if (!theme_gtk3_active || !theme_gtk3_theme_colors || !name || !out_color)
-		return FALSE;
-
-	stored = g_hash_table_lookup (theme_gtk3_theme_colors, name);
-	if (!stored)
-		return FALSE;
-
-	*out_color = *stored;
-	return TRUE;
-}
-
-static void
-theme_gtk3_chrome_provider_apply (gboolean prefer_dark)
-{
-	GdkScreen *screen = gdk_screen_get_default ();
-	GtkStyleContext *lookup;
-	char *bg;
-	char *fg;
-	char *sel_bg;
-	char *sel_fg;
-	char *css;
-	guint i;
-
-	if (!screen)
-		return;
-
-	lookup = gtk_style_context_new ();
-	for (i = 0; theme_gtk3_providers_base && i < theme_gtk3_providers_base->len; i++)
-		gtk_style_context_add_provider (lookup,
-			GTK_STYLE_PROVIDER (g_ptr_array_index (theme_gtk3_providers_base, i)),
-			GTK_STYLE_PROVIDER_PRIORITY_USER);
-	for (i = 0; theme_gtk3_providers_variant && i < theme_gtk3_providers_variant->len; i++)
-		gtk_style_context_add_provider (lookup,
-			GTK_STYLE_PROVIDER (g_ptr_array_index (theme_gtk3_providers_variant, i)),
-			GTK_STYLE_PROVIDER_PRIORITY_USER);
-
-	if (theme_gtk3_theme_colors)
-		g_hash_table_remove_all (theme_gtk3_theme_colors);
-
-	bg = theme_gtk3_chrome_resolve_color (lookup, "theme_bg_color",
-					      prefer_dark ? "#242424" : "#f6f5f4");
-	fg = theme_gtk3_chrome_resolve_color (lookup, "theme_fg_color",
-					      prefer_dark ? "#eeeeee" : "#2e3436");
-	sel_bg = theme_gtk3_chrome_resolve_color (lookup, "theme_selected_bg_color", "#3584e4");
-	sel_fg = theme_gtk3_chrome_resolve_color (lookup, "theme_selected_fg_color", "#ffffff");
-	/* Not used by the chrome CSS itself, but resolved and stored for the
-	 * mapped-palette sampling fallback (chat area and friends). */
-	g_free (theme_gtk3_chrome_resolve_color (lookup, "theme_base_color",
-						 prefer_dark ? "#1e1e1e" : "#ffffff"));
-	g_object_unref (lookup);
-
-	css = g_strdup_printf (theme_gtk3_chrome_css_template,
-			       bg, fg,
-			       bg, fg);
-
-	if (!theme_gtk3_chrome_provider)
-		theme_gtk3_chrome_provider = gtk_css_provider_new ();
-	gtk_css_provider_load_from_data (theme_gtk3_chrome_provider, css, -1, NULL);
-
-	gtk_style_context_add_provider_for_screen (screen,
-		GTK_STYLE_PROVIDER (theme_gtk3_chrome_provider),
-		THEME_GTK3_CHROME_PRIORITY);
-
-	theme_gtk3_menu_uniform_apply (bg, fg, sel_bg, sel_fg);
-
-	g_free (css);
-	g_free (sel_fg);
-	g_free (sel_bg);
-	g_free (fg);
-	g_free (bg);
-}
-
-static GtkCssProvider *theme_gtk3_menu_uniform_provider;
-
-static void
-theme_gtk3_menu_uniform_apply (const char *bg, const char *fg, const char *sel_bg, const char *sel_fg)
-{
-	GdkScreen *screen = gdk_screen_get_default ();
-	char *css;
-
-	if (!screen)
-		return;
-
-	css = g_strdup_printf (theme_gtk3_menu_uniform_template, bg, fg, sel_bg, sel_fg, fg);
-	if (!theme_gtk3_menu_uniform_provider)
-		theme_gtk3_menu_uniform_provider = gtk_css_provider_new ();
-	gtk_css_provider_load_from_data (theme_gtk3_menu_uniform_provider, css, -1, NULL);
-	gtk_style_context_add_provider_for_screen (screen,
-		GTK_STYLE_PROVIDER (theme_gtk3_menu_uniform_provider),
-		THEME_GTK3_MENU_UNIFORM_PRIORITY);
-	g_free (css);
-}
-
-static void
-theme_gtk3_chrome_provider_remove (void)
-{
-	GdkScreen *screen = gdk_screen_get_default ();
-
-	if (!screen)
-		return;
-
-	if (theme_gtk3_chrome_provider)
-		gtk_style_context_remove_provider_for_screen (screen,
-			GTK_STYLE_PROVIDER (theme_gtk3_chrome_provider));
-	if (theme_gtk3_menu_uniform_provider)
-		gtk_style_context_remove_provider_for_screen (screen,
-			GTK_STYLE_PROVIDER (theme_gtk3_menu_uniform_provider));
-}
-
 static void
 theme_gtk3_remove_provider (void)
 {
 	GdkScreen *screen = gdk_screen_get_default ();
 	guint i;
 
-	theme_gtk3_chrome_provider_remove ();
 	if (screen && theme_gtk3_providers_variant)
 	{
 		for (i = 0; i < theme_gtk3_providers_variant->len; i++)
@@ -1095,7 +866,6 @@ load_css_with_variant (ZoitechatGtk3Theme *theme, ThemeGtk3Variant variant, GErr
 	}
 
 	g_ptr_array_unref (chain);
-	theme_gtk3_chrome_provider_apply (prefer_dark);
 	settings_apply_for_variant (variant);
 	theme_gtk3_reset_widgets ();
 	theme_gtk3_active = TRUE;
@@ -1106,34 +876,23 @@ static gboolean
 theme_gtk3_apply_internal (const char *theme_id, ThemeGtk3Variant variant, gboolean force_reload, GError **error)
 {
 	ZoitechatGtk3Theme *theme;
-	char *previous_id;
+	char *previous_id = g_strdup (theme_gtk3_current_id);
-	ThemeGtk3Variant previous_variant;
+	ThemeGtk3Variant previous_variant = theme_gtk3_current_variant;
-	gboolean had_previous;
+	gboolean had_previous = theme_gtk3_active && previous_id && previous_id[0];
 	gboolean ok;
 
-	theme = zoitechat_gtk3_theme_find_by_id (theme_id);
-	if (!theme)
-		return g_set_error_literal (error, G_FILE_ERROR, G_FILE_ERROR_NOENT, "GTK3 theme not found."), FALSE;
-
-	/* An explicitly selected in-app theme pins the rendering to that
-	 * theme: it must not flip with the OS light/dark preference.  Legacy
-	 * configs still carry FOLLOW_SYSTEM (the pre-inference default), so
-	 * resolve it to the variant the theme itself provides. */
-	if (variant == THEME_GTK3_VARIANT_FOLLOW_SYSTEM)
-		variant = theme_gtk3_infer_variant (theme);
-
 	if (!force_reload &&
 		theme_gtk3_active &&
 		g_strcmp0 (theme_gtk3_current_id, theme_id) == 0 &&
 		theme_gtk3_current_variant == variant)
-	{
-		zoitechat_gtk3_theme_free (theme);
 		return TRUE;
-	}
 
-	previous_id = g_strdup (theme_gtk3_current_id);
+	theme = zoitechat_gtk3_theme_find_by_id (theme_id);
-	previous_variant = theme_gtk3_current_variant;
+	if (!theme)
-	had_previous = theme_gtk3_active && previous_id && previous_id[0];
+	{
+		g_free (previous_id);
+		return g_set_error_literal (error, G_FILE_ERROR, G_FILE_ERROR_NOENT, "GTK3 theme not found."), FALSE;
+	}
 
 	theme_gtk3_remove_provider ();
 	if (force_reload)
@@ -1202,12 +961,6 @@ void
 theme_gtk3_disable (void)
 {
 	theme_gtk3_remove_provider ();
-	g_clear_object (&theme_gtk3_chrome_provider);
-	g_clear_pointer (&theme_gtk3_theme_colors, g_hash_table_destroy);
-	/* Following the system theme: keep the menu bar body and the menu
-	 * items on one surface too, using the system's own colors. */
-	theme_gtk3_menu_uniform_apply ("@theme_bg_color", "@theme_fg_color",
-				       "@theme_selected_bg_color", "@theme_selected_fg_color");
 	g_clear_pointer (&theme_gtk3_current_id, g_free);
 	theme_gtk3_invalidate_provider_cache ();
 	g_clear_pointer (&theme_gtk3_provider_cache, g_hash_table_destroy);
@@ -1237,13 +990,3 @@ theme_gtk3_is_active (void)
 {
 	return theme_gtk3_active;
 }
-
-ThemeGtk3Variant
-theme_gtk3_active_variant (void)
-{
-	/* Always resolved to PREFER_LIGHT or PREFER_DARK while a theme is
-	 * active; FOLLOW_SYSTEM only when no in-app theme is applied. */
-	if (!theme_gtk3_active)
-		return THEME_GTK3_VARIANT_FOLLOW_SYSTEM;
-	return theme_gtk3_current_variant;
-}

src/fe-gtk/theme/theme-gtk3.h

@@ -22,7 +22,6 @@
 #define ZOITECHAT_THEME_GTK3_H
 
 #include <glib.h>
-#include <gdk/gdk.h>
 
 typedef enum
 {
@@ -39,7 +38,5 @@ ThemeGtk3Variant theme_gtk3_variant_for_theme (const char *theme_id);
 void theme_gtk3_invalidate_provider_cache (void);
 void theme_gtk3_disable (void);
 gboolean theme_gtk3_is_active (void);
-ThemeGtk3Variant theme_gtk3_active_variant (void);
-gboolean theme_gtk3_lookup_theme_color (const char *name, GdkRGBA *out_color);
 
 #endif

src/fe-gtk/theme/theme-manager.c

@@ -590,7 +590,11 @@ theme_manager_apply_platform_window_theme (GtkWidget *window)
 
 	context = gtk_widget_get_style_context (window);
 	if (theme_gtk3_is_active ())
-		dark = theme_gtk3_active_variant () == THEME_GTK3_VARIANT_PREFER_DARK;
+	{
+		dark = prefs.hex_gui_gtk3_variant == THEME_GTK3_VARIANT_PREFER_DARK;
+		if (prefs.hex_gui_gtk3_variant == THEME_GTK3_VARIANT_FOLLOW_SYSTEM)
+			dark = theme_policy_system_prefers_dark ();
+	}
 	else
 		dark = theme_policy_is_dark_mode_active (prefs.hex_gui_dark_mode);
 	if (context)

src/fe-gtk/theme/theme-preferences.c

@@ -38,7 +38,6 @@
 #include "theme-runtime.h"
 
 extern void load_text_events (void);
-extern char **text_color_event_names (int color, int *count);
 
 typedef struct
 {
@@ -106,11 +105,6 @@ typedef struct
         gboolean staged_dirty[THEME_TOKEN_COUNT];
         GdkRGBA snapshot[THEME_TOKEN_COUNT];
         GdkRGBA staged[THEME_TOKEN_COUNT];
-        /* the GTK3 theme selection is previewed live from the combo, so
-         * remember what was active when the dialog opened in order to
-         * restore it when the dialog is cancelled */
-        char gtk3_theme_snapshot[sizeof ((struct zoitechatprefs *) 0)->hex_gui_gtk3_theme];
-        int gtk3_variant_snapshot;
 } theme_preferences_stage_state;
 
 static theme_preferences_stage_state theme_preferences_stage;
@@ -209,11 +203,6 @@ theme_preferences_stage_begin (void)
         memset (&theme_preferences_stage, 0, sizeof (theme_preferences_stage));
         theme_preferences_stage.active = TRUE;
 
-        g_strlcpy (theme_preferences_stage.gtk3_theme_snapshot,
-                   prefs.hex_gui_gtk3_theme,
-                   sizeof (theme_preferences_stage.gtk3_theme_snapshot));
-        theme_preferences_stage.gtk3_variant_snapshot = prefs.hex_gui_gtk3_variant;
-
         for (token = THEME_TOKEN_MIRC_0; token < THEME_TOKEN_COUNT; token++)
         {
                 GdkRGBA rgba;
@@ -247,36 +236,12 @@ theme_preferences_stage_commit (void)
         memset (&theme_preferences_stage, 0, sizeof (theme_preferences_stage));
 }
 
-/* undo a live GTK3 theme preview: put the selection that was active when
- * the dialog opened back and re-apply it */
-static void
-theme_preferences_stage_restore_gtk3 (void)
-{
-        if (g_strcmp0 (prefs.hex_gui_gtk3_theme, theme_preferences_stage.gtk3_theme_snapshot) == 0 &&
-            prefs.hex_gui_gtk3_variant == theme_preferences_stage.gtk3_variant_snapshot)
-                return;
-
-        g_strlcpy (prefs.hex_gui_gtk3_theme,
-                   theme_preferences_stage.gtk3_theme_snapshot,
-                   sizeof (prefs.hex_gui_gtk3_theme));
-        prefs.hex_gui_gtk3_variant = theme_preferences_stage.gtk3_variant_snapshot;
-
-        theme_gtk3_apply_current (NULL);
-        theme_manager_dispatch_changed (THEME_CHANGED_REASON_THEME_PACK |
-                                        THEME_CHANGED_REASON_PALETTE |
-                                        THEME_CHANGED_REASON_WIDGET_STYLE |
-                                        THEME_CHANGED_REASON_USERLIST |
-                                        THEME_CHANGED_REASON_MODE);
-}
-
 void
 theme_preferences_stage_discard (void)
 {
         if (!theme_preferences_stage.active)
                 return;
 
-        /* restore the GTK3 theme first so the color snapshot below wins */
-        theme_preferences_stage_restore_gtk3 ();
         theme_preferences_stage_sync_runtime_to_snapshot ();
         memset (&theme_preferences_stage, 0, sizeof (theme_preferences_stage));
 }
@@ -284,9 +249,6 @@ theme_preferences_stage_discard (void)
 static void
 theme_preferences_show_import_error (GtkWidget *button, const char *message);
 
-static void
-theme_preferences_color_set_tooltip (GtkWidget *widget, ThemeSemanticToken token);
-
 static void
 theme_preferences_manager_row_free (gpointer data)
 {
@@ -525,7 +487,6 @@ theme_preferences_color_response_cb (GtkDialog *dialog, gint response_id, gpoint
                                                     data->color_change_flag,
                                                     TRUE);
                 theme_preferences_color_button_apply (data->button, &rgba);
-                theme_preferences_color_set_tooltip (data->button, data->token);
                 theme_preferences_manager_update_preview ((theme_color_manager_ui *) data->manager_ui);
         }
 
@@ -604,113 +565,6 @@ theme_preferences_token_display_name (ThemeSemanticToken token)
         }
 }
 
-static char *
-theme_preferences_color_tooltip_markup (ThemeSemanticToken token)
-{
-        GString *tip;
-        GdkRGBA rgba;
-        char *display;
-        char *hex;
-        char *escaped;
-        char **names;
-        int count = 0;
-
-        if (token < THEME_TOKEN_MIRC_0 || token > THEME_TOKEN_MIRC_31)
-                return NULL;
-
-        if (!theme_preferences_staged_get_color (token, &rgba))
-                return NULL;
-
-        tip = g_string_new (NULL);
-
-        display = theme_preferences_token_display_name (token);
-        hex = theme_preferences_format_hex (&rgba);
-        escaped = g_markup_escape_text (display, -1);
-        g_string_append_printf (tip,
-                                "<span background='%s'>\xe2\x80\x83\xe2\x80\x83</span> <b>%s</b>  <tt><small>%s</small></tt>",
-                                hex, escaped, hex);
-        g_free (escaped);
-        g_free (display);
-
-        names = text_color_event_names (token - THEME_TOKEN_MIRC_0, &count);
-        if (names)
-        {
-                int line_target;
-                int line_len = 0;
-                int i;
-
-                display = g_strdup_printf (ngettext ("Used by %d text event",
-                                                     "Used by %d text events", count), count);
-                escaped = g_markup_escape_text (display, -1);
-                g_string_append_printf (tip,
-                                        "\n<small><span alpha='60%%'>%s</span></small>\n\n<small>",
-                                        escaped);
-                g_free (escaped);
-                g_free (display);
-
-                /* Explicit line breaks keep the tooltip geometry stable;
-                 * heavily-used colors get wider lines so the full list
-                 * stays on screen. */
-                if (count <= 12)
-                        line_target = 44;
-                else if (count <= 40)
-                        line_target = 60;
-                else
-                        line_target = 76;
-
-                for (i = 0; i < count; i++)
-                {
-                        int name_len = (int) g_utf8_strlen (names[i], -1);
-
-                        if (i)
-                        {
-                                if (line_len + name_len + 5 > line_target)
-                                {
-                                        g_string_append_c (tip, '\n');
-                                        line_len = 0;
-                                }
-                                else
-                                {
-                                        g_string_append (tip, "  \xc2\xb7  ");
-                                        line_len += 5;
-                                }
-                        }
-                        escaped = g_markup_escape_text (names[i], -1);
-                        g_string_append (tip, escaped);
-                        line_len += name_len;
-                        g_free (escaped);
-                }
-                g_string_append (tip, "</small>");
-                g_strfreev (names);
-        }
-        else
-        {
-                escaped = g_markup_escape_text (_("Not used by any text events"), -1);
-                g_string_append_printf (tip,
-                                        "\n<small><span alpha='60%%'><i>%s</i></span></small>",
-                                        escaped);
-                g_free (escaped);
-        }
-
-        g_free (hex);
-        return g_string_free (tip, FALSE);
-}
-
-/* Static markup tooltips only: building tooltip widgets from a
- * query-tooltip handler makes GtkTooltip flicker on some setups, so the
- * markup is set once and refreshed whenever the color changes. */
-static void
-theme_preferences_color_set_tooltip (GtkWidget *widget, ThemeSemanticToken token)
-{
-        char *markup = theme_preferences_color_tooltip_markup (token);
-
-        if (!markup)
-                return;
-
-        gtk_widget_set_tooltip_markup (widget, markup);
-        g_free (markup);
-}
-
 static void
 theme_preferences_manager_row_apply (theme_color_manager_row *row, const GdkRGBA *rgba)
 {
@@ -721,7 +575,6 @@ theme_preferences_manager_row_apply (theme_color_manager_row *row, const GdkRGBA
         hex = theme_preferences_format_hex (rgba);
         gtk_entry_set_text (GTK_ENTRY (row->entry), hex);
         g_free (hex);
-        theme_preferences_color_set_tooltip (row->row, row->token);
 }
 
 static void
@@ -1040,8 +893,6 @@ theme_preferences_create_color_manager_dialog (GtkWindow *parent, gboolean *colo
                 if (theme_preferences_staged_get_color (token, &rgba))
                         theme_preferences_manager_row_apply (row, &rgba);
 
-                theme_preferences_color_set_tooltip (list_row, token);
-
                 g_signal_connect (G_OBJECT (button), "clicked",
                                   G_CALLBACK (theme_preferences_manager_pick_cb), row);
                 g_object_set_data (G_OBJECT (button), "zoitechat-theme-color-manager-ui", ui);
@@ -1356,7 +1207,6 @@ theme_preferences_create_color_button (GtkWidget *table,
         g_object_set_data (G_OBJECT (but), "zoitechat-color-box", box);
         g_object_set_data (G_OBJECT (but), "zoitechat-theme-token", GINT_TO_POINTER (token));
         g_object_set_data (G_OBJECT (but), "zoitechat-theme-color-change", color_change_flag);
-        theme_preferences_color_set_tooltip (but, token);
         gtk_grid_attach (GTK_GRID (table), but, col, row, 1, 1);
         g_signal_connect (G_OBJECT (but), "clicked", G_CALLBACK (theme_preferences_color_cb), parent);
         if (theme_preferences_staged_get_color (token, &color))
@@ -1601,6 +1451,7 @@ theme_preferences_gtk3_sync_runtime_palette (theme_preferences_ui *ui)
 {
 	ThemeWidgetStyleValues style_values;
 	GtkWidget *style_source = NULL;
+	gboolean follows_system_theme = prefs.hex_gui_gtk3_theme[0] == '\0';
 
 	if (ui && ui->parent)
 		style_source = GTK_WIDGET (ui->parent);
@@ -1611,16 +1462,34 @@ theme_preferences_gtk3_sync_runtime_palette (theme_preferences_ui *ui)
 
 	theme_get_widget_style_values_for_widget (style_source, &style_values);
 
-	/* Leave the mapped tokens unpinned so the user list, channel tree and
+	if (follows_system_theme)
-	 * input box keep resolving their colors from whatever GTK3 theme is
+	{
-	 * active (system or in-app selected), and only refresh what the
+		/* Following the system GTK3 theme: leave the mapped tokens
-	 * dialog shows.  Pinning theme-derived values here freezes them into
+		 * unpinned so they keep tracking the theme, and only refresh
-	 * the runtime palette (and colors.conf), which left those widgets
+		 * what the dialog shows. */
-	 * with stale colors until the next restart. */
 		theme_preferences_stage_rebase_color (THEME_TOKEN_TEXT_FOREGROUND, &style_values.foreground);
 		theme_preferences_stage_rebase_color (THEME_TOKEN_TEXT_BACKGROUND, &style_values.background);
 		theme_preferences_stage_rebase_color (THEME_TOKEN_SELECTION_FOREGROUND, &style_values.selection_foreground);
 		theme_preferences_stage_rebase_color (THEME_TOKEN_SELECTION_BACKGROUND, &style_values.selection_background);
+		return;
+	}
+
+	theme_preferences_staged_set_color (THEME_TOKEN_TEXT_FOREGROUND,
+	                                    &style_values.foreground,
+	                                    NULL,
+	                                    TRUE);
+	theme_preferences_staged_set_color (THEME_TOKEN_TEXT_BACKGROUND,
+	                                    &style_values.background,
+	                                    NULL,
+	                                    TRUE);
+	theme_preferences_staged_set_color (THEME_TOKEN_SELECTION_FOREGROUND,
+	                                    &style_values.selection_foreground,
+	                                    NULL,
+	                                    TRUE);
+	theme_preferences_staged_set_color (THEME_TOKEN_SELECTION_BACKGROUND,
+	                                    &style_values.selection_background,
+	                                    NULL,
+	                                    TRUE);
 }
 
 static gboolean

src/fe-gtk/userlistgui.c

@@ -796,12 +796,16 @@ userlist_store_color (GtkListStore *store, GtkTreeIter *iter, ThemeSemanticToken
 	}
 }
 
-static void
+GtkListStore *
-userlist_model_set_sort (GtkListStore *store, session *sess)
+userlist_create_model (session *sess)
 {
+	GtkListStore *store;
 	GtkTreeIterCompareFunc cmp_func;
 	GtkSortType sort_type;
 
+	store = gtk_list_store_new (6, GDK_TYPE_PIXBUF, G_TYPE_STRING, G_TYPE_STRING,
+										G_TYPE_STRING, G_TYPE_POINTER, THEME_GTK_COLOR_TYPE);
+
 	switch (prefs.hex_gui_ulist_sort)
 	{
 	case 0:
@@ -821,77 +825,18 @@ userlist_model_set_sort (GtkListStore *store, session *sess)
 		sort_type = GTK_SORT_DESCENDING;
 		break;
 	default:
-		/* No sorting; rows keep their current order and new rows
+		/* No sorting */
-		   go wherever they are inserted */
-		gtk_tree_sortable_set_sort_column_id (GTK_TREE_SORTABLE(store),
-							GTK_TREE_SORTABLE_UNSORTED_SORT_COLUMN_ID, GTK_SORT_ASCENDING);
 		gtk_tree_sortable_set_default_sort_func (GTK_TREE_SORTABLE(store), NULL, NULL, NULL);
-		return;
+		return store;
 	}
 
 	gtk_tree_sortable_set_default_sort_func (GTK_TREE_SORTABLE(store), cmp_func, sess, NULL);
 	gtk_tree_sortable_set_sort_column_id (GTK_TREE_SORTABLE(store),
 						GTK_TREE_SORTABLE_DEFAULT_SORT_COLUMN_ID, sort_type);
-}
-
-GtkListStore *
-userlist_create_model (session *sess)
-{
-	GtkListStore *store;
-
-	store = gtk_list_store_new (6, GDK_TYPE_PIXBUF, G_TYPE_STRING, G_TYPE_STRING,
-										G_TYPE_STRING, G_TYPE_POINTER, THEME_GTK_COLOR_TYPE);
-	userlist_model_set_sort (store, sess);
 
 	return store;
 }
 
-void
-userlist_apply_sort (session *sess)
-{
-	if (!sess->res || !sess->res->user_model)
-		return;
-
-	userlist_model_set_sort (sess->res->user_model, sess);
-}
-
-/* remove and re-insert every row, so per-row content that depends on
- * preferences (mode icons vs. text prefixes, hostnames) is rebuilt */
-void
-userlist_refill (session *sess)
-{
-	GtkTreeModel *model;
-	GtkTreeIter iter;
-	GSList *users = NULL;
-	GSList *it;
-	struct User *user;
-
-	if (!sess->res || !sess->res->user_model)
-		return;
-
-	model = GTK_TREE_MODEL (sess->res->user_model);
-	if (gtk_tree_model_get_iter_first (model, &iter))
-	{
-		do
-		{
-			gtk_tree_model_get (model, &iter, COL_USER, &user, -1);
-			if (user)
-				users = g_slist_prepend (users, user);
-		}
-		while (gtk_tree_model_iter_next (model, &iter));
-	}
-
-	fe_userlist_clear (sess);
-
-	/* fe_userlist_insert() prepends, so inserting in reverse display
-	   order restores the on-screen order for unsorted lists; sorted
-	   models position the rows themselves */
-	for (it = users; it; it = it->next)
-		fe_userlist_insert (sess, it->data, FALSE);
-
-	g_slist_free (users);
-}
-
 static void
 userlist_add_columns (GtkTreeView * treeview)
 {
@@ -961,23 +906,6 @@ userlist_add_columns (GtkTreeView * treeview)
 	}
 }
 
-void
-userlist_rebuild_columns (GtkWidget *treeview)
-{
-	GList *columns;
-	GList *it;
-
-	if (!treeview)
-		return;
-
-	columns = gtk_tree_view_get_columns (GTK_TREE_VIEW (treeview));
-	for (it = columns; it; it = it->next)
-		gtk_tree_view_remove_column (GTK_TREE_VIEW (treeview), it->data);
-	g_list_free (columns);
-
-	userlist_add_columns (GTK_TREE_VIEW (treeview));
-}
-
 static gint
 userlist_click_cb (GtkWidget *widget, GdkEventButton *event, gpointer userdata)
 {

src/fe-gtk/userlistgui.h

@@ -24,9 +24,6 @@ void userlist_set_value (GtkWidget *treeview, gfloat val);
 gfloat userlist_get_value (GtkWidget *treeview);
 GtkWidget *userlist_create (GtkWidget *box);
 GtkListStore *userlist_create_model (session *sess);
-void userlist_apply_sort (session *sess);
-void userlist_refill (session *sess);
-void userlist_rebuild_columns (GtkWidget *treeview);
 void userlist_show (session *sess);
 void userlist_select (session *sess, char *name);
 void fe_userlist_set_typing (session *sess, const char *nick, const char *state);

src/fe-gtk/xtext.c

@@ -92,104 +92,8 @@ struct textentry
 	guchar pad1;
 	guchar pad2;
 	GList *marks;	/* List of found strings */
-	GdkPixbuf *image;	/* inline image shown below the text, or NULL */
-	GdkPixbuf *image_full;	/* larger version for the image viewer */
-	char *image_url;	/* the URL the image was loaded from */
 };
 
-/* inline image display */
-#define XTEXT_IMAGE_PADDING 4
-#define XTEXT_IMAGE_MAX_WIDTH 480
-#define XTEXT_IMAGE_MAX_HEIGHT 360
-#define XTEXT_IMAGE_FULL_MAX_WIDTH 1600
-#define XTEXT_IMAGE_FULL_MAX_HEIGHT 1200
-
-/* an inline image load that has been started but not yet completed;
-   ent/buf/xtext are invalidated (entry removed) when any of them dies */
-typedef struct
-{
-	guint id;
-	GtkXText *xtext;
-	xtext_buffer *buf;
-	textentry *ent;
-	char *url;
-} xtext_image_pending;
-
-static GSList *image_pending_list = NULL;
-static guint image_pending_next_id = 1;
-
-static void
-gtk_xtext_image_pending_forget (gboolean (*match) (xtext_image_pending *, gconstpointer), gconstpointer data)
-{
-	GSList *list = image_pending_list;
-
-	while (list)
-	{
-		GSList *next = list->next;
-		xtext_image_pending *pending = list->data;
-
-		if (match (pending, data))
-		{
-			image_pending_list = g_slist_delete_link (image_pending_list, list);
-			g_free (pending->url);
-			g_free (pending);
-		}
-		list = next;
-	}
-}
-
-static gboolean
-gtk_xtext_image_pending_match_ent (xtext_image_pending *pending, gconstpointer ent)
-{
-	return pending->ent == ent;
-}
-
-static gboolean
-gtk_xtext_image_pending_match_buf (xtext_image_pending *pending, gconstpointer buf)
-{
-	return pending->buf == buf;
-}
-
-static gboolean
-gtk_xtext_image_pending_match_xtext (xtext_image_pending *pending, gconstpointer xtext)
-{
-	return pending->xtext == xtext;
-}
-
-/* number of extra screen lines an entry needs for its inline image */
-
-static int
-gtk_xtext_image_rows (GtkXText *xtext, textentry *ent)
-{
-	if (ent->image == NULL || xtext->fontsize <= 0)
-		return 0;
-
-	return (gdk_pixbuf_get_height (ent->image) + XTEXT_IMAGE_PADDING * 2 +
-			  xtext->fontsize - 1) / xtext->fontsize;
-}
-
-/* free an entry's inline image and drop any pending load aimed at it;
-   must be called whenever a textentry is freed */
-
-static void
-gtk_xtext_ent_free_image (textentry *ent)
-{
-	gtk_xtext_image_pending_forget (gtk_xtext_image_pending_match_ent, ent);
-
-	if (ent->image)
-	{
-		g_object_unref (ent->image);
-		ent->image = NULL;
-	}
-	if (ent->image_full)
-	{
-		g_object_unref (ent->image_full);
-		ent->image_full = NULL;
-	}
-	g_free (ent->image_url);
-	ent->image_url = NULL;
-}
-
 enum
 {
 	WORD_CLICK,
@@ -309,7 +213,6 @@ static gboolean gtk_xtext_search_init (xtext_buffer *buf, const gchar *text, gtk
 static char * gtk_xtext_get_word (GtkXText * xtext, int x, int y, textentry ** ret_ent, int *ret_off, int *ret_len, GSList **slp);
 static gboolean gtk_xtext_word_select_char (const unsigned char *ch);
 static gboolean gtk_xtext_get_word_select_range (GtkXText *xtext, int x, int y, textentry **ret_ent, int *ret_off, int *ret_len);
-static textentry * gtk_xtext_image_hit (GtkXText *xtext, int x, int y);
 
 static inline void
 gtk_xtext_cursor_unref (GdkCursor *cursor)
@@ -1159,8 +1062,6 @@ gtk_xtext_dispose (GObject *object)
 {
 	GtkXText *xtext = GTK_XTEXT (object);
 
-	gtk_xtext_image_pending_forget (gtk_xtext_image_pending_match_xtext, xtext);
-	g_clear_pointer (&xtext->tooltip_url, g_free);
 	gtk_xtext_cleanup (xtext);
 
 	if (G_OBJECT_CLASS (gtk_xtext_parent_class)->dispose)
@@ -1542,7 +1443,7 @@ gtk_xtext_find_x (GtkXText * xtext, int x, textentry * ent, int subline,
 
 	str = ent->str + gtk_xtext_find_subline (xtext, ent, subline);
 	if (str >= ent->str + ent->str_len)
-		return ent->str_len;	/* e.g. the blank rows of an inline image */
+		return 0;
 
 	/* Let user select left a few pixels to grab hidden text e.g. '<' */
 	if (x < indent - xtext->space_width)
@@ -2242,7 +2143,6 @@ gtk_xtext_get_word (GtkXText * xtext, int x, int y, textentry ** ret_ent,
 	int len;
 	int out_of_bounds = 0;
 	int len_to_offset = 0;
-	gboolean has_hidden;
 
 	ent = gtk_xtext_find_char (xtext, x, y, &offset, &out_of_bounds);
 	if (ent == NULL || out_of_bounds || offset < 0 || offset >= ent->str_len)
@@ -2287,15 +2187,10 @@ gtk_xtext_get_word (GtkXText * xtext, int x, int y, textentry ** ret_ent,
 	if (ret_len)
 		*ret_len = len;		/* Length before stripping */
 
-	/* a word with hidden text is a placeholder (e.g. an inline image link
-	   label); its whole visible part acts as the link */
-	has_hidden = memchr (word, ATTR_HIDDEN, len) != NULL;
-
 	word = gtk_xtext_strip_color (word, len, xtext->scratch_buffer, NULL, slp, FALSE);
 
 	/* avoid turning the cursor into a hand for non-url part of the word */
-	if (!has_hidden &&
+	if (xtext->urlcheck_function && xtext->urlcheck_function (GTK_WIDGET (xtext), word))
-		 xtext->urlcheck_function && xtext->urlcheck_function (GTK_WIDGET (xtext), word))
 	{
 		int start, end;
 		url_last (&start, &end);
@@ -2379,43 +2274,12 @@ gtk_xtext_unrender_hilight (GtkXText *xtext)
 	xtext->un_hilight = FALSE;
 }
 
-/* show (or stop showing) the destination URL of a hovered placeholder
-   word as the widget's tooltip */
-
-static void
-gtk_xtext_set_url_tooltip (GtkXText *xtext, const char *url, int url_len)
-{
-	if (url == NULL)
-	{
-		if (xtext->tooltip_url)
-		{
-			g_free (xtext->tooltip_url);
-			xtext->tooltip_url = NULL;
-			gtk_widget_set_tooltip_text (GTK_WIDGET (xtext), NULL);
-			xtext->tooltip_stamp_set = FALSE;
-		}
-		return;
-	}
-
-	if (xtext->tooltip_url &&
-		 strlen (xtext->tooltip_url) == (gsize) url_len &&
-		 memcmp (xtext->tooltip_url, url, url_len) == 0)
-		return;
-
-	g_free (xtext->tooltip_url);
-	xtext->tooltip_url = g_strndup (url, url_len);
-	gtk_widget_set_tooltip_text (GTK_WIDGET (xtext), xtext->tooltip_url);
-	xtext->tooltip_stamp_set = FALSE;
-}
-
 static gboolean
 gtk_xtext_leave_notify (GtkWidget * widget, GdkEventCrossing * event)
 {
 	GtkXText *xtext = GTK_XTEXT (widget);
 	GdkWindow *window = gtk_widget_get_window (widget);
 
-	gtk_xtext_set_url_tooltip (xtext, NULL, 0);
-
 	if (xtext->cursor_hand)
 	{
 		gtk_xtext_unrender_hilight (xtext);
@@ -2479,7 +2343,6 @@ gtk_xtext_get_word_adjust (GtkXText *xtext, int x, int y, textentry **word_ent,
 	GSList *slp = NULL;
 	unsigned char *word;
 	int word_type = 0;
-	gboolean placeholder = FALSE;
 
 	word = gtk_xtext_get_word (xtext, x, y, word_ent, offset, len, &slp);
 	if (word)
@@ -2489,18 +2352,7 @@ gtk_xtext_get_word_adjust (GtkXText *xtext, int x, int y, textentry **word_ent,
 		word_type = xtext->urlcheck_function (GTK_WIDGET (xtext), word);
 		if (word_type > 0)
 		{
-			/* words with hidden text are placeholders (e.g. inline image
+			if (url_last (&laststart, &lastend))
-			   links): hilight the whole word, not just the URL inside it */
-			if (memchr ((*word_ent)->str + *offset, ATTR_HIDDEN, *len))
-			{
-				/* the label hides the real destination, so show the full
-				   URL as a tooltip while hovering */
-				placeholder = TRUE;
-				if (url_last (&laststart, &lastend) && lastend > laststart)
-					gtk_xtext_set_url_tooltip (xtext,
-						(const char *) word + laststart, lastend - laststart);
-			}
-			else if (url_last (&laststart, &lastend))
 			{
 				int cumlen, startadj = 0, endadj = 0;
 				offlen_t *meta;
@@ -2530,9 +2382,6 @@ gtk_xtext_get_word_adjust (GtkXText *xtext, int x, int y, textentry **word_ent,
 	}
 	g_slist_free_full (slp, g_free);
 
-	if (!placeholder)
-		gtk_xtext_set_url_tooltip (xtext, NULL, 0);
-
 	return word_type;
 }
 
@@ -2664,20 +2513,6 @@ gtk_xtext_motion_notify (GtkWidget * widget, GdkEventMotion * event)
 	}
 
 tooltip_check:
-	/* hovering an inline image? it opens the viewer when clicked */
-	if (gtk_xtext_image_hit (xtext, x, y))
-	{
-		if (xtext->hilight_ent)	/* moving here straight from a link */
-			gtk_xtext_leave_notify (widget, NULL);
-		if (!xtext->cursor_hand)
-		{
-			gdk_window_set_cursor (window, xtext->hand_cursor);
-			xtext->cursor_hand = TRUE;
-			xtext->cursor_resize = FALSE;
-		}
-		return FALSE;
-	}
-
 	if (xtext->buffer->time_stamp && xtext->buffer->indent > 0 && x >= 0 && x < xtext->stamp_width)
 	{
 		textentry *ent = gtk_xtext_find_char (xtext, x, y, NULL, NULL);
@@ -2785,46 +2620,6 @@ gtk_xtext_unselect (GtkXText *xtext)
 	xtext->buffer->last_ent_end = NULL;
 }
 
-/* check whether the given widget coordinates hit an entry's inline image;
-   returns the entry if so */
-
-static textentry *
-gtk_xtext_image_hit (GtkXText *xtext, int x, int y)
-{
-	textentry *ent;
-	int line, subline, image_rows, text_rows, rel_y, img_x;
-
-	if (xtext->fontsize <= 0)
-		return NULL;
-
-	/* adjust y value for negative rounding, double to int */
-	if (y < 0)
-		y -= xtext->fontsize;
-
-	line = (y + xtext->pixel_offset) / xtext->fontsize;
-	ent = gtk_xtext_nth (xtext, line + (int) xtext_adj_get_value (xtext->adj),
-								&subline);
-	if (ent == NULL || ent->image == NULL)
-		return NULL;
-
-	image_rows = gtk_xtext_image_rows (xtext, ent);
-	text_rows = ent->subline_count - image_rows;
-	if (subline < text_rows)
-		return NULL;
-
-	img_x = xtext->buffer->indent + XTEXT_IMAGE_PADDING;
-	if (x < img_x || x >= img_x + gdk_pixbuf_get_width (ent->image))
-		return NULL;
-
-	rel_y = (subline - text_rows) * xtext->fontsize +
-		(y + xtext->pixel_offset) - (line * xtext->fontsize) -
-		XTEXT_IMAGE_PADDING;
-	if (rel_y < 0 || rel_y >= gdk_pixbuf_get_height (ent->image))
-		return NULL;
-
-	return ent;
-}
-
 static gboolean
 gtk_xtext_button_release (GtkWidget * widget, GdkEventButton * event)
 {
@@ -2897,15 +2692,8 @@ gtk_xtext_button_release (GtkWidget * widget, GdkEventButton * event)
 
 		if (!gtk_xtext_is_selecting (xtext))
 		{
-			textentry *word_ent = NULL;
+			word = gtk_xtext_get_word (xtext, event_x, event_y, 0, 0, 0, 0);
-
-			word = gtk_xtext_get_word (xtext, event_x, event_y, &word_ent, 0, 0, 0);
-			xtext->clicked_ent = word ? word_ent : NULL;
-			xtext->clicked_image_ent = word ? NULL :
-				gtk_xtext_image_hit (xtext, event_x, event_y);
 			g_signal_emit (G_OBJECT (xtext), xtext_signals[WORD_CLICK], 0, word ? word : NULL, event);
-			xtext->clicked_ent = NULL;
-			xtext->clicked_image_ent = NULL;
 		}
 	}
 
@@ -2932,16 +2720,14 @@ gtk_xtext_button_press (GtkWidget * widget, GdkEventButton * event)
 
 	if (event->button == 3 || event->button == 2) /* right/middle click */
 	{
-		word = gtk_xtext_get_word (xtext, x, y, &ent, 0, 0, 0);
+		word = gtk_xtext_get_word (xtext, x, y, 0, 0, 0, 0);
 		if (word)
 		{
-			xtext->clicked_ent = ent;
 			g_signal_emit (G_OBJECT (xtext), xtext_signals[WORD_CLICK], 0,
 								word, event);
 		} else
 			g_signal_emit (G_OBJECT (xtext), xtext_signals[WORD_CLICK], 0,
 								"", event);
-		xtext->clicked_ent = NULL;
 		return FALSE;
 	}
 
@@ -4319,7 +4105,6 @@ gtk_xtext_render_line (GtkXText * xtext, textentry * ent, int line,
 	unsigned char *str;
 	int indent, taken, entline, len, y, start_subline;
 	int emphasis = 0;
-	int image_rows;
 
 	entline = taken = 0;
 	str = ent->str;
@@ -4390,56 +4175,6 @@ gtk_xtext_render_line (GtkXText * xtext, textentry * ent, int line,
 	}
 	while (str < ent->str + ent->str_len);
 
-	/* draw the inline image on its blank rows below the text.  'subline'
-	   still holds the rows left to skip when the page starts inside the
-	   image area (the text loop above only consumes text sublines). */
-	image_rows = gtk_xtext_image_rows (xtext, ent);
-	if (image_rows > 0)
-	{
-		int skip = MIN (subline, image_rows);
-		int rows = image_rows - skip;
-		int first_row_y = (xtext->fontsize * line) - xtext->pixel_offset;
-		int drawn = 0;
-		gboolean render_image = !xtext->dont_render && !xtext->skip_border_fills &&
-			!xtext->render_hilights_only;
-
-		while (rows > 0 && line < lines_max)
-		{
-			y = (xtext->fontsize * line) + xtext->font->ascent - xtext->pixel_offset;
-			if (render_image)
-			{
-				int bg_x = MAX (0, xtext->clip_x);
-				int bg_w = MIN (win_width + MARGIN, xtext->clip_x2) - bg_x;
-
-				if (bg_w > 0)
-					xtext_draw_bg (xtext, bg_x, y - xtext->font->ascent, bg_w, xtext->fontsize);
-				gtk_xtext_draw_sep (xtext, y - xtext->font->ascent);
-			}
-			line++;
-			taken++;
-			rows--;
-			drawn++;
-		}
-
-		if (drawn > 0 && render_image)
-		{
-			/* this may be the shared draw context, so the clip has to be
-			   undone before anything else is rendered with it */
-			cairo_t *cr = xtext_create_context (xtext);
-			int img_x = xtext->buffer->indent + XTEXT_IMAGE_PADDING;
-			int img_y = first_row_y - (skip * xtext->fontsize) + XTEXT_IMAGE_PADDING;
-
-			cairo_save (cr);
-			cairo_rectangle (cr, 0, first_row_y, win_width + MARGIN,
-								  drawn * xtext->fontsize);
-			cairo_clip (cr);
-			gdk_cairo_set_source_pixbuf (cr, ent->image, img_x, img_y);
-			cairo_paint (cr);
-			cairo_restore (cr);
-			cairo_destroy (cr);
-		}
-	}
-
 	gtk_xtext_draw_marker (xtext, ent, y - xtext->fontsize * (taken + start_subline));
 
 	return taken;
@@ -4598,7 +4333,6 @@ gtk_xtext_lines_taken (xtext_buffer *buf, textentry * ent)
 	unsigned char *str;
 	int indent, len;
 	int win_width;
-	int image_rows, i;
 
 	g_slist_free (ent->sublines);
 	ent->sublines = NULL;
@@ -4608,9 +4342,10 @@ gtk_xtext_lines_taken (xtext_buffer *buf, textentry * ent)
 	if (win_width >= ent->indent + ent->str_width)
 	{
 		ent->sublines = g_slist_append (ent->sublines, GINT_TO_POINTER (ent->str_len));
+		ent->subline_count = 1;
+		return ent->subline_count;
 	}
-	else
+
-	{
 	indent = ent->indent;
 	str = ent->str;
 
@@ -4622,13 +4357,6 @@ gtk_xtext_lines_taken (xtext_buffer *buf, textentry * ent)
 		str += len;
 	}
 	while (str < ent->str + ent->str_len);
-	}
-
-	/* extra blank rows that make room for an attached inline image;
-	   their offset is str_len, i.e. past the end of the text */
-	image_rows = gtk_xtext_image_rows (buf->xtext, ent);
-	for (i = 0; i < image_rows; i++)
-		ent->sublines = g_slist_append (ent->sublines, GINT_TO_POINTER ((gint) ent->str_len));
 
 	ent->subline_count = g_slist_length (ent->sublines);
 	return ent->subline_count;
@@ -5051,8 +4779,6 @@ gtk_xtext_kill_ent (xtext_buffer *buffer, textentry *ent)
 	ent->sublines = NULL;
 	ent->subline_count = 0;
 
-	gtk_xtext_ent_free_image (ent);
-
 	g_free (ent);
 	return visible;
 }
@@ -5190,7 +4916,6 @@ gtk_xtext_clear (xtext_buffer *buf, int lines)
 		while (buf->text_first)
 		{
 			next = buf->text_first->next;
-			gtk_xtext_ent_free_image (buf->text_first);
 			g_free (buf->text_first);
 			buf->text_first = next;
 		}
@@ -5710,9 +5435,6 @@ gtk_xtext_append_entry (xtext_buffer *buf, textentry * ent, time_t stamp)
 	ent->next = NULL;
 	ent->marks = NULL;
 	ent->subline_count = 0;
-	ent->image = NULL;
-	ent->image_full = NULL;
-	ent->image_url = NULL;
 
 	if (ent->indent < MARGIN)
 		ent->indent = MARGIN;	  /* 2 pixels is the left margin */
@@ -6233,260 +5955,13 @@ gtk_xtext_buffer_free (xtext_buffer *buf)
 		gtk_xtext_search_fini (buf);
 	}
 
-	gtk_xtext_image_pending_forget (gtk_xtext_image_pending_match_buf, buf);
-
 	ent = buf->text_first;
 	while (ent)
 	{
 		next = ent->next;
-		gtk_xtext_ent_free_image (ent);
 		g_free (ent);
 		ent = next;
 	}
 
 	g_free (buf);
 }
-
-/* ========================================= */
-/* ========== INLINE IMAGE API ============= */
-/* ========================================= */
-
-/* the entry the last word_click signal was emitted for; only valid while
-   handling that signal */
-
-textentry *
-gtk_xtext_get_clicked_entry (GtkXText *xtext)
-{
-	return xtext->clicked_ent;
-}
-
-/* the entry whose inline image the last word_click signal (with a NULL
-   word) landed on; only valid while handling that signal */
-
-textentry *
-gtk_xtext_get_clicked_image_entry (GtkXText *xtext)
-{
-	return xtext->clicked_image_ent;
-}
-
-/* check that 'ent' is still an entry of the currently shown buffer; used to
-   validate entry pointers that were remembered across main loop iterations */
-
-gboolean
-gtk_xtext_buffer_contains (GtkXText *xtext, textentry *ent)
-{
-	textentry *walk;
-
-	if (ent == NULL)
-		return FALSE;
-
-	for (walk = xtext->buffer->text_first; walk; walk = walk->next)
-	{
-		if (walk == ent)
-			return TRUE;
-	}
-
-	return FALSE;
-}
-
-gboolean
-gtk_xtext_entry_has_image (GtkXText *xtext, textentry *ent)
-{
-	return ent != NULL && ent->image != NULL;
-}
-
-/* the URL of the entry's attached image, or NULL if it has none */
-
-const char *
-gtk_xtext_entry_get_image_url (GtkXText *xtext, textentry *ent)
-{
-	return ent && ent->image ? ent->image_url : NULL;
-}
-
-/* larger version of the entry's attached image, for the viewer */
-
-GdkPixbuf *
-gtk_xtext_entry_get_full_image (GtkXText *xtext, textentry *ent)
-{
-	if (ent == NULL)
-		return NULL;
-	return ent->image_full ? ent->image_full : ent->image;
-}
-
-/* the entry's subline count changed (image attached or removed):
-   redo its layout, fix the scrollbar and redraw */
-
-static void
-gtk_xtext_image_relayout (GtkXText *xtext, xtext_buffer *buf, textentry *ent)
-{
-	buf->num_lines -= ent->subline_count;
-	buf->num_lines += gtk_xtext_lines_taken (buf, ent);
-	buf->pagetop_ent = NULL;
-	dontscroll (buf);
-
-	if (xtext->buffer == buf)
-	{
-		gtk_xtext_adjustment_set (buf, TRUE);
-		if (buf->scrollbar_down)
-			xtext_adj_set_value (xtext->adj,
-				xtext_adj_get_upper (xtext->adj) -
-				xtext_adj_get_page_size (xtext->adj));
-		if (gtk_widget_get_realized (GTK_WIDGET (xtext)))
-			gtk_widget_queue_draw (GTK_WIDGET (xtext));
-	}
-}
-
-/* scale down (never up) to fit within max_width x max_height */
-
-static GdkPixbuf *
-gtk_xtext_image_scale_max (GdkPixbuf *pixbuf, int max_width, int max_height)
-{
-	int width = gdk_pixbuf_get_width (pixbuf);
-	int height = gdk_pixbuf_get_height (pixbuf);
-	int new_width, new_height;
-	double scale;
-
-	if (width < 1 || height < 1)
-		return NULL;
-
-	if (width <= max_width && height <= max_height)
-		return g_object_ref (pixbuf);
-
-	scale = MIN ((double) max_width / width, (double) max_height / height);
-	new_width = MAX (1, (int) (width * scale));
-	new_height = MAX (1, (int) (height * scale));
-
-	return gdk_pixbuf_scale_simple (pixbuf, new_width, new_height,
-											  GDK_INTERP_BILINEAR);
-}
-
-/* scale down (never up) to fit the usual text area */
-
-static GdkPixbuf *
-gtk_xtext_image_scale (xtext_buffer *buf, GdkPixbuf *pixbuf)
-{
-	int max_width = XTEXT_IMAGE_MAX_WIDTH;
-	int avail;
-
-	avail = buf->window_width - buf->indent - MARGIN - XTEXT_IMAGE_PADDING * 2;
-	if (avail >= 64 && avail < max_width)
-		max_width = avail;
-
-	return gtk_xtext_image_scale_max (pixbuf, max_width, XTEXT_IMAGE_MAX_HEIGHT);
-}
-
-/* register an asynchronous image load for 'ent'.  Returns a handle to pass
-   to gtk_xtext_image_load_finish(), or 0 if the entry already has an image
-   or a load underway. */
-
-guint
-gtk_xtext_image_load_begin (GtkXText *xtext, textentry *ent, const char *url)
-{
-	xtext_image_pending *pending;
-	GSList *list;
-
-	if (ent == NULL || ent->image != NULL)
-		return 0;
-
-	for (list = image_pending_list; list; list = list->next)
-	{
-		pending = list->data;
-		if (pending->ent == ent)
-			return 0;
-	}
-
-	pending = g_new0 (xtext_image_pending, 1);
-	pending->id = image_pending_next_id++;
-	if (image_pending_next_id == 0)	/* skip 0 on wrap, it means failure */
-		image_pending_next_id = 1;
-	pending->xtext = xtext;
-	pending->buf = xtext->buffer;
-	pending->ent = ent;
-	pending->url = g_strdup (url);
-	image_pending_list = g_slist_prepend (image_pending_list, pending);
-
-	return pending->id;
-}
-
-/* complete a load started with gtk_xtext_image_load_begin().  pixbuf may be
-   NULL to abandon the load (e.g. download failed).  Returns TRUE if the
-   image was attached, FALSE if it was dropped (failure, or the entry is
-   gone).  The caller keeps ownership of the pixbuf. */
-
-gboolean
-gtk_xtext_image_load_finish (guint handle, GdkPixbuf *pixbuf)
-{
-	xtext_image_pending *pending = NULL;
-	GSList *list;
-	GdkPixbuf *scaled;
-	GtkXText *xtext;
-	xtext_buffer *buf;
-	textentry *ent;
-
-	if (handle == 0)
-		return FALSE;
-
-	for (list = image_pending_list; list; list = list->next)
-	{
-		xtext_image_pending *walk = list->data;
-		if (walk->id == handle)
-		{
-			pending = walk;
-			break;
-		}
-	}
-
-	if (pending == NULL)	/* entry, buffer or widget died meanwhile */
-		return FALSE;
-
-	xtext = pending->xtext;
-	buf = pending->buf;
-	ent = pending->ent;
-	image_pending_list = g_slist_remove (image_pending_list, pending);
-
-	if (pixbuf == NULL || ent->image != NULL)
-	{
-		g_free (pending->url);
-		g_free (pending);
-		return FALSE;
-	}
-
-	scaled = gtk_xtext_image_scale (buf, pixbuf);
-	if (scaled == NULL)
-	{
-		g_free (pending->url);
-		g_free (pending);
-		return FALSE;
-	}
-
-	ent->image = scaled;
-	ent->image_full = gtk_xtext_image_scale_max (pixbuf,
-		XTEXT_IMAGE_FULL_MAX_WIDTH, XTEXT_IMAGE_FULL_MAX_HEIGHT);
-	ent->image_url = pending->url;	/* transferred */
-	g_free (pending);
-	gtk_xtext_image_relayout (xtext, buf, ent);
-
-	return TRUE;
-}
-
-/* remove an entry's inline image again.  Returns FALSE if it had none. */
-
-gboolean
-gtk_xtext_image_remove (GtkXText *xtext, textentry *ent)
-{
-	if (ent == NULL || ent->image == NULL)
-		return FALSE;
-
-	g_object_unref (ent->image);
-	ent->image = NULL;
-	if (ent->image_full)
-	{
-		g_object_unref (ent->image_full);
-		ent->image_full = NULL;
-	}
-	g_free (ent->image_url);
-	ent->image_url = NULL;
-	gtk_xtext_image_relayout (xtext, xtext->buffer, ent);
-
-	return TRUE;
-}

src/fe-gtk/xtext.h

@@ -192,7 +192,6 @@ struct _GtkXText
 	int hilight_end;
 	time_t tooltip_stamp;
 	unsigned int tooltip_stamp_set:1;
-	char *tooltip_url;			  /* URL shown while hovering a placeholder */
 
 	guint16 fontwidth[128];	  /* each char's width, only the ASCII ones */
 
@@ -255,9 +254,6 @@ struct _GtkXText
 	unsigned int force_render:1;
 	unsigned int color_paste:1; /* CTRL was pressed when selection finished */
 
-	textentry *clicked_ent;		  /* entry under the last word_click, or NULL */
-	textentry *clicked_image_ent; /* entry whose inline image was clicked */
-
 	/* settings/prefs */
 	unsigned int auto_indent:1;
 	unsigned int thinline:1;
@@ -313,19 +309,4 @@ void gtk_xtext_buffer_free (xtext_buffer *buf);
 void gtk_xtext_buffer_show (GtkXText *xtext, xtext_buffer *buf, int render);
 void gtk_xtext_copy_selection (GtkXText *xtext);
 
-/* inline image support.  A textentry can have one image attached, which is
- * rendered below its text.  Loading is asynchronous: begin() registers the
- * target entry and returns a handle, finish() attaches the downloaded pixbuf
- * if the entry still exists.  The handle stays valid even if the entry, its
- * buffer or the widget are destroyed in the meantime. */
-textentry *gtk_xtext_get_clicked_entry (GtkXText *xtext);
-textentry *gtk_xtext_get_clicked_image_entry (GtkXText *xtext);
-gboolean gtk_xtext_buffer_contains (GtkXText *xtext, textentry *ent);
-gboolean gtk_xtext_entry_has_image (GtkXText *xtext, textentry *ent);
-const char *gtk_xtext_entry_get_image_url (GtkXText *xtext, textentry *ent);
-GdkPixbuf *gtk_xtext_entry_get_full_image (GtkXText *xtext, textentry *ent);
-guint gtk_xtext_image_load_begin (GtkXText *xtext, textentry *ent, const char *url);
-gboolean gtk_xtext_image_load_finish (guint handle, GdkPixbuf *pixbuf);
-gboolean gtk_xtext_image_remove (GtkXText *xtext, textentry *ent);
-
 #endif

src/fe-text/fe-text.c

@@ -857,10 +857,6 @@ fe_get_str (char *prompt, char *def, void *callback, void *ud)
 {
 }
 void
-fe_get_password (char *prompt, void *callback, void *ud)
-{
-}
-void
 fe_get_int (char *prompt, int def, void *callback, void *ud)
 {
 }

win32/copy/copy.vcxproj

@@ -66,7 +66,6 @@
       <None Include="$(DepsRoot)\bin\*zlib*.dll" />
       <None Include="$(DepsRoot)\bin\*girepository*.dll" Condition="'$(LuaEnabled)'=='true' and '$(LuaLibDir)'!=''" />
       <None Include="$(Python3Path)\Lib\site-packages\_cffi_backend.*.pyd" Condition="'$(Python3Enabled)'=='true'" />
-      <None Include="$(Python38Path)\Lib\site-packages\_cffi_backend.*.pyd" Condition="'$(Python38Enabled)'=='true'" />
 
       <LuaLib Include="$(LuaLibDir)\**\*.dll" Condition="'$(LuaEnabled)'=='true' and '$(LuaLibDir)'!=''" />
       <LuaShare Include="$(LuaShareDir)\*.lua" Condition="'$(LuaEnabled)'=='true' and '$(LuaShareDir)'!=''" />
@@ -78,7 +77,6 @@
       <Gtk3Immodules Include="$(DepsRoot)\lib\gtk-3.0\3.0.0\immodules\**\*" />
       <Gtk3PrintBackends Include="$(DepsRoot)\lib\gtk-3.0\3.0.0\printbackends\**\*" />
       <GSettingsSchemas Include="$(DepsRoot)\share\glib-2.0\schemas\*" />
-      <GioModules Include="$(DepsRoot)\lib\gio\modules\**\*" />
       <GdkPixbufLoaders Include="$(DepsRoot)\lib\gdk-pixbuf-2.0\**\loaders\**\*" />
       <GdkPixbufLoaderCache Include="$(DepsRoot)\lib\gdk-pixbuf-2.0\**\loaders.cache" />
 
@@ -97,7 +95,6 @@
     <Copy SourceFiles="@(GdkPixbufLoaders)" DestinationFiles="@(GdkPixbufLoaders->'$(ZoiteChatRel)\lib\gdk-pixbuf-2.0\%(RecursiveDir)%(Filename)%(Extension)')" />
     <Copy SourceFiles="@(GdkPixbufLoaderCache)" DestinationFiles="@(GdkPixbufLoaderCache->'$(ZoiteChatRel)\lib\gdk-pixbuf-2.0\%(RecursiveDir)%(Filename)%(Extension)')" />
     <Copy SourceFiles="@(GSettingsSchemas)" DestinationFiles="@(GSettingsSchemas->'$(ZoiteChatRel)\share\glib-2.0\schemas\%(Filename)%(Extension)')" />
-    <Copy SourceFiles="@(GioModules)" DestinationFiles="@(GioModules->'$(ZoiteChatRel)\lib\gio\modules\%(RecursiveDir)%(Filename)%(Extension)')" />
     <Copy SourceFiles="@(Share)" DestinationFiles="@(Share->'$(ZoiteChatRel)\share\%(RecursiveDir)%(Filename)%(Extension)')" />
     <Copy SourceFiles="..\..\COPYING" DestinationFolder="$(ZoiteChatRel)\share\doc\zoitechat" />
     <Copy SourceFiles="$(WinSparklePath)\COPYING" DestinationFolder="$(ZoiteChatRel)\share\doc\WinSparkle" />
@@ -108,10 +105,10 @@
     <Copy SourceFiles="@(LuaShare)" DestinationFiles="@(LuaShare->'$(ZoiteChatRel)\share\lua\%(RecursiveDir)%(Filename)%(Extension)')" />
     <Copy SourceFiles="@(LuaLib)" DestinationFiles="@(LuaLib->'$(ZoiteChatRel)\lib\lua\%(RecursiveDir)%(Filename)%(Extension)')" />
     <Copy SourceFiles="@(Typelib)" DestinationFiles="@(Typelib->'$(ZoiteChatRel)\lib\girepository-1.0\%(Filename)%(Extension)')" />
-    <Copy SourceFiles="..\..\plugins\python\xchat.py" DestinationFolder="$(ZoiteChatRel)\python" Condition="'$(Python3Enabled)'=='true' or '$(Python38Enabled)'=='true'" />
+    <Copy SourceFiles="..\..\plugins\python\xchat.py" DestinationFolder="$(ZoiteChatRel)\python" Condition="'$(Python3Enabled)'=='true'" />
-    <Copy SourceFiles="..\..\plugins\python\hexchat.py" DestinationFolder="$(ZoiteChatRel)\python" Condition="'$(Python3Enabled)'=='true' or '$(Python38Enabled)'=='true'" />
+    <Copy SourceFiles="..\..\plugins\python\hexchat.py" DestinationFolder="$(ZoiteChatRel)\python" Condition="'$(Python3Enabled)'=='true'" />
-    <Copy SourceFiles="..\..\plugins\python\zoitechat.py" DestinationFolder="$(ZoiteChatRel)\python" Condition="'$(Python3Enabled)'=='true' or '$(Python38Enabled)'=='true'" />
+    <Copy SourceFiles="..\..\plugins\python\zoitechat.py" DestinationFolder="$(ZoiteChatRel)\python" Condition="'$(Python3Enabled)'=='true'" />
-    <Copy SourceFiles="..\..\plugins\python\_zoitechat.py" DestinationFolder="$(ZoiteChatRel)\python" Condition="'$(Python3Enabled)'=='true' or '$(Python38Enabled)'=='true'" />
+    <Copy SourceFiles="..\..\plugins\python\_zoitechat.py" DestinationFolder="$(ZoiteChatRel)\python" Condition="'$(Python3Enabled)'=='true'" />
 
     <WriteLinesToFile File="$(ZoiteChatRel)portable-mode" Lines="2" Overwrite="true" />
 

win32/installer/zoitechat.iss.tt

@@ -16,7 +16,7 @@ AppUpdatesURL=http://zoitechat.org/downloads.html
 LicenseFile=share\doc\zoitechat\COPYING
 UninstallDisplayIcon={app}\zoitechat.exe
 UninstallDisplayName=ZoiteChat
-DefaultDirName={commonpf64}\ZoiteChat
+DefaultDirName={pf64}\ZoiteChat
 DisableDirPage=no
 DefaultGroupName=ZoiteChat
 AllowNoIcons=yes
@@ -28,11 +28,11 @@ OutputBaseFilename={#APPNAM}-{#APPVER}_x64
 FlatComponentsList=no
 PrivilegesRequired=none
 ShowComponentSizes=no
-CreateUninstallRegKey=not WizardIsTaskSelected('portable')
+CreateUninstallRegKey=not IsTaskSelected('portable')
-Uninstallable=not WizardIsTaskSelected('portable')
+Uninstallable=not IsTaskSelected('portable')
 ArchitecturesAllowed=x64compatible
 ArchitecturesInstallIn64BitMode=x64compatible
-MinVersion=6.1sp1
+MinVersion=6.1
 WizardImageFile={#PROJECTDIR}wizardimage.bmp
 WizardSmallImageFile={#PROJECTDIR}wizardsmallimage.bmp
 SetupIconFile={#PROJECTDIR}..\..\data\icons\zoitechat.ico
@@ -59,7 +59,7 @@ Name: "plugins\upd"; Description: "Update Checker"; Types: normal custom; Flags:
 Name: "langs"; Description: "Language Interfaces"; Types: custom; Flags: disablenouninstallwarning
 Name: "langs\lua"; Description: "Lua (LuaJIT 2.1)"; Types: normal custom; Flags: disablenouninstallwarning
 Name: "langs\perl"; Description: "Perl (Strawberry Perl 5.42.0.1)"; Types: custom; Flags: disablenouninstallwarning
-Name: "langs\python"; Description: "Python (Python 3.14.3, or 3.8.10 before Windows 10)"; Types: custom; Flags: disablenouninstallwarning
+Name: "langs\python"; Description: "Python (Python 3.14.3)"; Types: custom; Flags: disablenouninstallwarning
 Name: "themes"; Description: "GTK3 Themes"; Types: normal minimal custom; Flags: disablenouninstallwarning
 Name: "themes\windows10"; Description: "Windows 10"; Types: normal minimal custom; Flags: disablenouninstallwarning
 Name: "themes\windows10dark"; Description: "Windows 10 Dark"; Types: normal minimal custom; Flags: disablenouninstallwarning
@@ -151,7 +151,6 @@ Source: "tiff.dll"; DestDir: "{app}"; Flags: ignoreversion; Components: libs
 Source: "plugins\hcnotifications-winrt.dll"; DestDir: "{app}\plugins"; Flags: ignoreversion; Components: libs
 
 Source: "lib\enchant\*"; DestDir: "{app}\lib\enchant"; Flags: ignoreversion; Components: libs
-Source: "lib\gio\modules\*"; DestDir: "{app}\lib\gio\modules"; Flags: ignoreversion recursesubdirs; Components: libs
 
 Source: "girepository-2.0-0.dll"; DestDir: "{app}"; Flags: ignoreversion skipifsourcedoesntexist; Components: langs\lua
 Source: "lua51.dll"; DestDir: "{app}"; Flags: ignoreversion skipifsourcedoesntexist; Components: langs\lua
@@ -182,8 +181,7 @@ Source: "plugins\hcperl.dll"; DestDir: "{app}\plugins"; Flags: ignoreversion; Co
 
 Source: "python\*.py"; DestDir: "{app}\python"; Flags: ignoreversion; Components: langs\python
 
-Source: "plugins\hcpython3.dll"; DestDir: "{app}\plugins"; Flags: ignoreversion; Components: langs\python; Check: not NeedsLegacyPython
+Source: "plugins\hcpython3.dll"; DestDir: "{app}\plugins"; Flags: ignoreversion; Components: langs\python
-Source: "plugins\hcpython38.dll"; DestDir: "{app}\plugins"; Flags: ignoreversion skipifsourcedoesntexist; Components: langs\python; Check: NeedsLegacyPython
 Source: "_cffi_backend.cp3*.pyd"; DestDir: "{app}"; Flags: ignoreversion; Components: langs\python
 
 Source: "zoitechat.exe"; DestDir: "{app}"; Flags: ignoreversion; Components: libs
@@ -330,32 +328,6 @@ begin
 		Result := DirExists(ExpandConstant('{localappdata}') + '\enchant\myspell');
 end;
 
-// Python >= 3.9 dropped support for Windows versions before 10;
-// those systems get Python 3.8 and the matching plugin instead.
-function NeedsLegacyPython(): Boolean;
-var
-	Version: TWindowsVersion;
-begin
-	GetWindowsVersionEx(Version);
-	Result := Version.NTPlatform and (Version.Major < 10);
-end;
-
-function PythonURL(): String;
-begin
-	if NeedsLegacyPython() then
-		Result := 'https://www.python.org/ftp/python/3.8.10/python-3.8.10-amd64.exe'
-	else
-		Result := 'https://www.python.org/ftp/python/3.14.3/python-3.14.3-amd64.exe';
-end;
-
-function PythonDLL(): String;
-begin
-	if NeedsLegacyPython() then
-		Result := 'python38.dll'
-	else
-		Result := 'python314.dll';
-end;
-
 /////////////////////////////////////////////////////////////////////
 // Sets up the automatic downloads
 /////////////////////////////////////////////////////////////////////
@@ -373,34 +345,34 @@ begin
   begin
     idpClearFiles;
 
-	if WizardIsComponentSelected('themes\windows10') then
+	if IsComponentSelected('themes\windows10') then
 		idpAddFile('https://dl.zoitechat.zoite.net/themes/GTK3Themes/Windows-10-3.2.1.zip', ExpandConstant('{tmp}\Windows-10-3.2.1.zip'));
 
-	if WizardIsComponentSelected('themes\windows10dark') then
+	if IsComponentSelected('themes\windows10dark') then
 		idpAddFile('https://dl.zoitechat.zoite.net/themes/GTK3Themes/Windows-10-Dark-3.2.1-dark.zip', ExpandConstant('{tmp}\Windows-10-Dark-3.2.1-dark.zip'));
 
-	if not WizardIsTaskSelected('portable') then
+	if not IsTaskSelected('portable') then
 	begin
 
 		REDIST := 'https://aka.ms/vs/17/release/vc_redist.x64.exe';
 		PERL := 'https://github.com/StrawberryPerl/Perl-Dist-Strawberry/releases/download/SP_54201_64bit/strawberry-perl-5.42.0.1-64bit.msi';
-		PY3 := PythonURL();
+		PY3 := 'https://www.python.org/ftp/python/3.14.3/python-3.14.3-amd64.exe';
-		SPELL := 'https://github.com/hexchat/gvsbuild/releases/download/hexchat-2.16.2/HexChat.Spelling.Dictionaries.r2.exe';
+		SPELL := 'https://github.com/zoitechat/gvsbuild/releases/download/zoitechat-2.16.2/ZoiteChat.Spelling.Dictionaries.r2.exe';
 
-		if WizardIsComponentSelected('deps\vcredist2015') and not CheckVCInstall() then
+		if IsComponentSelected('deps\vcredist2015') and not CheckVCInstall() then
 			idpAddFile(REDIST, ExpandConstant('{tmp}\vcredist.exe'));
 
-		if WizardIsComponentSelected('spell') and not CheckSpellInstall() then
+		if IsComponentSelected('spell') and not CheckSpellInstall() then
 			idpAddFile(SPELL, ExpandConstant('{tmp}\spelling-dicts.exe'));
 
 		if not WizardSilent() then
 		begin
-			if WizardIsComponentSelected('langs\perl') and not CheckDLL('perl542.dll') then
+			if IsComponentSelected('langs\perl') and not CheckDLL('perl542.dll') then
 			begin
 				idpAddFile(PERL, ExpandConstant('{tmp}\perl.msi'))
 			end;
 
-			if WizardIsComponentSelected('langs\python') and not CheckDLL(PythonDLL()) then
+			if IsComponentSelected('langs\python') and not CheckDLL('python314.dll') then
                 idpAddFile(PY3, ExpandConstant('{tmp}\python.exe'));
 		end;
 	end;
@@ -425,7 +397,7 @@ begin
 
 	if (CurPageID = wpSelectTasks) then
 		if (WizardForm.TasksList.Checked[1] = True) then
-			if (WizardDirValue() = ExpandConstant('{commonpf64}\ZoiteChat')) then
+			if (WizardDirValue() = ExpandConstant('{pf64}\ZoiteChat')) then
 			begin
 				WizardForm.TasksList.Checked[1] := False
 				MsgBox('Portable mode is only intended for use on portable drives and has been disabled.', mbInformation, MB_OK)
@@ -433,21 +405,21 @@ begin
 
 	if CurPageID = wpReady then
 	begin
-		if WizardIsComponentSelected('themes\windows10') and not FileExists(ExpandConstant('{tmp}\Windows-10-3.2.1.zip')) then
+		if IsComponentSelected('themes\windows10') and not FileExists(ExpandConstant('{tmp}\Windows-10-3.2.1.zip')) then
 		begin
 			MsgBox('Windows 10 GTK3 theme could not be downloaded. Please retry setup and rerun setup.', mbError, MB_OK);
 			Result := False;
 			Exit;
 		end;
 
-		if WizardIsComponentSelected('themes\windows10dark') and not FileExists(ExpandConstant('{tmp}\Windows-10-Dark-3.2.1-dark.zip')) then
+		if IsComponentSelected('themes\windows10dark') and not FileExists(ExpandConstant('{tmp}\Windows-10-Dark-3.2.1-dark.zip')) then
 		begin
 			MsgBox('Windows 10 Dark GTK3 theme could not be downloaded. Please retry setup and rerun setup.', mbError, MB_OK);
 			Result := False;
 			Exit;
 		end;
 
-		if WizardIsComponentSelected('deps\vcredist2015') and not CheckVCInstall() and not FileExists(ExpandConstant('{tmp}\vcredist.exe')) then
+		if IsComponentSelected('deps\vcredist2015') and not CheckVCInstall() and not FileExists(ExpandConstant('{tmp}\vcredist.exe')) then
 		begin
 			MsgBox('Visual C++ Redistributable could not be downloaded. Please retry setup or install it manually and rerun setup.', mbError, MB_OK);
 			Result := False;
@@ -514,7 +486,7 @@ end;
 /////////////////////////////////////////////////////////////////////
 procedure CurStepChanged(CurStep: TSetupStep);
 begin
-	if not (WizardIsTaskSelected('portable')) then
+	if not (IsTaskSelected('portable')) then
 	begin
 		if (CurStep=ssInstall) then
 		begin

win32/zoitechat.props

@@ -8,7 +8,6 @@
 		<YourGendefPath>c:\gtk-build\gendef</YourGendefPath>
 		<YourPerlPath>c:\gtk-build\perl-5.42.0.1</YourPerlPath>
 		<YourPython3Path>c:\gtk-build\python-3.14</YourPython3Path>
-		<YourPython38Path>c:\gtk-build\python-3.8</YourPython38Path>
 		<YourWinSparklePath>c:\gtk-build\WinSparkle</YourWinSparklePath>
 
 		<!-- YOU SHOULDN'T TOUCH ANYTHING BELOW -->
@@ -33,12 +32,6 @@
 		<Python3Enabled Condition="Exists('$(Python3Path)\\python.exe') and Exists('$(Python3Path)\\libs\\$(Python3Lib).lib') and Exists('$(Python3Path)\\Lib\\site-packages\\cffi')">true</Python3Enabled>
 		<Python3Enabled Condition="'$(Python3Enabled)'==''">false</Python3Enabled>
 
-		<Python38Path>$(YourPython38Path)\$(ZoiteChatPlatform)</Python38Path>
-		<Python38Lib>python38</Python38Lib>
-		<Python38Output>hcpython38</Python38Output>
-		<Python38Enabled Condition="Exists('$(Python38Path)\\python.exe') and Exists('$(Python38Path)\\libs\\$(Python38Lib).lib') and Exists('$(Python38Path)\\Lib\\site-packages\\cffi')">true</Python38Enabled>
-		<Python38Enabled Condition="'$(Python38Enabled)'==''">false</Python38Enabled>
-
 		<PerlEnabled Condition="Exists('$(PerlPath)\\bin\\perl.exe') and Exists('$(PerlPath)\\bin\\$(PerlLib).dll') and Exists('$(GendefPath)\\gendef.exe')">true</PerlEnabled>
 		<PerlEnabled Condition="'$(PerlEnabled)'==''">false</PerlEnabled>
 

win32/zoitechat.sln

@@ -60,7 +60,6 @@ EndProject
 Project("{8BC9CEB8-8B4A-11D0-8D11-00A0C91BC942}") = "installer", "installer\installer.vcxproj", "{5A0F4962-E670-4DA2-9E45-52CC47F26E2F}"
 	ProjectSection(ProjectDependencies) = postProject
 		{C2321A03-0BA7-45B3-8740-ABD82B36B0BF} = {C2321A03-0BA7-45B3-8740-ABD82B36B0BF}
-		{D58924D2-1492-4AC3-B058-7A214424EEDC} = {D58924D2-1492-4AC3-B058-7A214424EEDC}
 		{BF0EBC16-68AD-4CD1-864C-5B56836EBE2A} = {BF0EBC16-68AD-4CD1-864C-5B56836EBE2A}
 		{17E4BE39-76F7-4A06-AD21-EFD0C5091F76} = {17E4BE39-76F7-4A06-AD21-EFD0C5091F76}
 		{4C0F3940-2EEE-4646-82F7-6CE75B9A72F4} = {4C0F3940-2EEE-4646-82F7-6CE75B9A72F4}
@@ -81,11 +80,6 @@ Project("{8BC9CEB8-8B4A-11D0-8D11-00A0C91BC942}") = "perl", "..\plugins\perl\per
 		{87554B59-006C-4D94-9714-897B27067BA3} = {87554B59-006C-4D94-9714-897B27067BA3}
 	EndProjectSection
 EndProject
-Project("{8BC9CEB8-8B4A-11D0-8D11-00A0C91BC942}") = "python38", "..\plugins\python\python38.vcxproj", "{D58924D2-1492-4AC3-B058-7A214424EEDC}"
-	ProjectSection(ProjectDependencies) = postProject
-		{87554B59-006C-4D94-9714-897B27067BA3} = {87554B59-006C-4D94-9714-897B27067BA3}
-	EndProjectSection
-EndProject
 Project("{8BC9CEB8-8B4A-11D0-8D11-00A0C91BC942}") = "python3", "..\plugins\python\python3.vcxproj", "{C2321A03-0BA7-45B3-8740-ABD82B36B0BF}"
 	ProjectSection(ProjectDependencies) = postProject
 		{87554B59-006C-4D94-9714-897B27067BA3} = {87554B59-006C-4D94-9714-897B27067BA3}
@@ -133,8 +127,6 @@ Global
 		{D90BC3E3-1341-4849-9354-5F40489D39D1}.Release|x64.Build.0 = Release|x64
 		{C2321A03-0BA7-45B3-8740-ABD82B36B0BF}.Release|x64.ActiveCfg = Release|x64
 		{C2321A03-0BA7-45B3-8740-ABD82B36B0BF}.Release|x64.Build.0 = Release|x64
-		{D58924D2-1492-4AC3-B058-7A214424EEDC}.Release|x64.ActiveCfg = Release|x64
-		{D58924D2-1492-4AC3-B058-7A214424EEDC}.Release|x64.Build.0 = Release|x64
 		{C53145CC-D021-40C9-B97C-0249AB9A43C9}.Release|x64.ActiveCfg = Release|x64
 		{C53145CC-D021-40C9-B97C-0249AB9A43C9}.Release|x64.Build.0 = Release|x64
 		{BF0EBC16-68AD-4CD1-864C-5B56836EBE2A}.Release|x64.ActiveCfg = Release|x64
@@ -159,7 +151,6 @@ Global
 		{5A0F4962-E670-4DA2-9E45-52CC47F26E2F} = {0FD996A7-464F-4981-8380-3DCA3A244A13}
 		{D90BC3E3-1341-4849-9354-5F40489D39D1} = {D237DA6B-BD5F-46C0-8BEA-50E9A1340240}
 		{C2321A03-0BA7-45B3-8740-ABD82B36B0BF} = {D237DA6B-BD5F-46C0-8BEA-50E9A1340240}
-		{D58924D2-1492-4AC3-B058-7A214424EEDC} = {D237DA6B-BD5F-46C0-8BEA-50E9A1340240}
 		{C53145CC-D021-40C9-B97C-0249AB9A43C9} = {561126F4-FA18-45FC-A2BF-8F858F161D6D}
 		{BF0EBC16-68AD-4CD1-864C-5B56836EBE2A} = {021EC1D0-FF67-4700-9AB2-EAABF1159C09}
 		{4C0F3940-2EEE-4646-82F7-6CE75B9A72F4} = {D237DA6B-BD5F-46C0-8BEA-50E9A1340240}