Compare commits

...
Author SHA1 Message Date
deepend-tildeclub aa7e20fee9 Merge pull request #417 from botovq/push-kwovwrnwwuzn
Minor simplification of _SSL_get_cert_info ()
2026-10-12 06:40:46 -07:00
deepend-tildeclub 480b99b1e7 Merge pull request #413 from B4reMetal/hex-color-parsing
feat(xtext): render \x04 hex color codes in chat text
2026-10-12 06:37:19 -07:00
BareMetal 0a4367b1da fix(xtext): move hexcolor_parse to its own file for the standalone xtext tests
master's new xtext_tests target compiles xtext.c on its own with only
GTK linked, so hexcolor_parse cannot live in util.c. Keep it in a
dependency-free hexcolor.c that both test targets compile, and register
it in the Visual Studio project for the Windows build.

Claude-Session: https://claude.ai/code/session_01Jxd4AknGzdAENADWAGHCzx
2026-10-11 23:58:09 -06:00
BareMetal 39daca9d22 feat(xtext): render \x04 hex color codes in chat text 2026-10-11 23:54:08 -06:00
deepend-tildeclub d614e25792 Merge pull request #419 from ZoiteChat/xtext-modernize
modernize rendering and fix scrollback resizing
2026-10-11 22:48:52 -07:00
deepend 30209d0c99 modernize rendering and fix scrollback resizing 2026-10-11 23:02:13 -06:00
Theo Buehler e1c44feb01 Minor simplification of _SSL_get_cert_info ()
Instead of retrieving the AlgorithmIdentifier and then reaching into it
to get the OID, the relevant OID can be obtained directly from the same
function.
2026-10-11 17:45:37 +02:00
deepend 5af8f4ede1 correct echo-message capability negotiation 2026-10-03 19:52:16 -06:00
13 changed files with 1447 additions and 1125 deletions
+2
View File
@@ -43,6 +43,7 @@
<ClInclude Include="typedef.h" />
<ClInclude Include="url.h" />
<ClInclude Include="userlist.h" />
<ClInclude Include="hexcolor.h" />
<ClInclude Include="util.h" />
<ClInclude Include="zoitechat-plugin.h" />
<ClInclude Include="zoitechat.h" />
@@ -79,6 +80,7 @@
<ClCompile Include="tree.c" />
<ClCompile Include="url.c" />
<ClCompile Include="userlist.c" />
<ClCompile Include="hexcolor.c" />
<ClCompile Include="util.c" />
<ClCompile Include="zoitechat.c" />
<ClCompile Include="theme-service.c" />
+6
View File
@@ -98,6 +98,9 @@
<ClInclude Include="userlist.h">
<Filter>Header Files</Filter>
</ClInclude>
<ClInclude Include="hexcolor.h">
<Filter>Header Files</Filter>
</ClInclude>
<ClInclude Include="util.h">
<Filter>Header Files</Filter>
</ClInclude>
@@ -202,6 +205,9 @@
<ClCompile Include="userlist.c">
<Filter>Source Files</Filter>
</ClCompile>
<ClCompile Include="hexcolor.c">
<Filter>Source Files</Filter>
</ClCompile>
<ClCompile Include="util.c">
<Filter>Source Files</Filter>
</ClCompile>
+42
View File
@@ -0,0 +1,42 @@
/* ZoiteChat
* Parsing of \004 (hex color) formatting codes: RRGGBB[,RRGGBB].
* Kept free of other application dependencies so the xtext widget tests can
* compile it on its own.
* Distributed under GPL-2.0-or-later; see COPYING. */
#include "hexcolor.h"
static int
hexcolor_component (const char *s, int avail, guint32 *rgb)
{
int i;
guint32 value = 0;
if (avail < 6)
return FALSE;
for (i = 0; i < 6; i++)
{
if (!g_ascii_isxdigit (s[i]))
return FALSE;
value = (value << 4) | g_ascii_xdigit_value (s[i]);
}
if (rgb)
*rgb = value;
return TRUE;
}
int
hexcolor_parse (const char *s, int avail, guint32 *fg, guint32 *bg, int *has_bg)
{
if (has_bg)
*has_bg = FALSE;
if (!hexcolor_component (s, avail, fg))
return 0;
if (avail >= 7 && s[6] == ',' && hexcolor_component (s + 7, avail - 7, bg))
{
if (has_bg)
*has_bg = TRUE;
return 13;
}
return 6;
}
+16
View File
@@ -0,0 +1,16 @@
/* ZoiteChat
* Parsing of \004 (hex color) formatting codes: RRGGBB[,RRGGBB].
* See https://modern.ircdocs.horse/formatting
* Distributed under GPL-2.0-or-later; see COPYING. */
#ifndef ZOITECHAT_HEXCOLOR_H
#define ZOITECHAT_HEXCOLOR_H
#include <glib.h>
/* Parses the parameters following a \004 byte. Returns the number of bytes
* consumed (6 or 13), or 0 if no valid RRGGBB follows. fg, bg and has_bg
* may be NULL. */
int hexcolor_parse (const char *s, int avail, guint32 *fg, guint32 *bg, int *has_bg);
#endif
+74 -34
View File
@@ -1880,38 +1880,51 @@ inbound_toggle_caps (server *serv, const char *extensions_str, gboolean enable)
char **extensions;
gsize i;
if (!extensions_str)
return;
extensions = g_strsplit (extensions_str, " ", 0);
for (i = 0; extensions[i]; i++)
{
const char *extension = extensions[i];
gboolean cap_enable = enable;
/* ACK prefixes disabled capabilities with '-', unlike CAP DEL. */
if (*extension == '-')
{
cap_enable = FALSE;
extension++;
}
if (!strcmp (extension, "solanum.chat/identify-msg"))
serv->have_idmsg = enable;
serv->have_idmsg = cap_enable;
else if (!strcmp (extension, "multi-prefix"))
serv->have_namesx = enable;
serv->have_namesx = cap_enable;
else if (!strcmp (extension, "account-notify"))
serv->have_accnotify = enable;
serv->have_accnotify = cap_enable;
else if (!strcmp (extension, "extended-join"))
serv->have_extjoin = enable;
serv->have_extjoin = cap_enable;
else if (!strcmp (extension, "userhost-in-names"))
serv->have_uhnames = enable;
serv->have_uhnames = cap_enable;
else if (!strcmp (extension, "server-time")
|| !strcmp (extension, "znc.in/server-time")
|| !strcmp (extension, "znc.in/server-time-iso"))
serv->have_server_time = enable;
serv->have_server_time = cap_enable;
else if (!strcmp (extension, "away-notify"))
serv->have_awaynotify = enable;
serv->have_awaynotify = cap_enable;
else if (!strcmp (extension, "account-tag"))
serv->have_account_tag = enable;
serv->have_account_tag = cap_enable;
else if (!strcmp (extension, "message-tags"))
serv->have_message_tags = enable;
serv->have_message_tags = cap_enable;
else if (!strcmp (extension, "echo-message"))
serv->have_echo_message = enable;
serv->have_echo_message = cap_enable;
else if (!strcmp (extension, "sasl"))
{
serv->have_sasl = enable;
if (enable)
gboolean start_auth = cap_enable && !serv->have_sasl;
serv->have_sasl = cap_enable;
if (start_auth)
{
#ifdef USE_OPENSSL
if (serv->loginmethod == LOGIN_SASLEXTERNAL)
@@ -1962,10 +1975,15 @@ inbound_cap_ack (server *serv, char *nick, char *extensions,
inbound_toggle_caps (serv, extensions, TRUE);
}
static void inbound_request_new_caps (server *serv, const char *extensions_str,
const message_tags_data *tags_data);
void
inbound_cap_new (server *serv, char *nick, char *extensions,
const message_tags_data *tags_data)
{
gboolean sts_upgrade_triggered = FALSE;
if (extensions)
{
char **tokens = g_strsplit (extensions, " ", 0);
@@ -1977,7 +1995,7 @@ inbound_cap_new (server *serv, char *nick, char *extensions,
if (!g_strcmp0 (parts[0], "sts") && parts[1] && parts[1][0])
{
sts_handle_capability (serv, parts[1]);
sts_upgrade_triggered |= sts_handle_capability (serv, parts[1]);
}
g_strfreev (parts);
@@ -1986,38 +2004,22 @@ inbound_cap_new (server *serv, char *nick, char *extensions,
g_strfreev (tokens);
}
EMIT_SIGNAL_TIMESTAMP (XP_TE_CAPACK, serv->server_session, nick, extensions,
EMIT_SIGNAL_TIMESTAMP (XP_TE_CAPLIST, serv->server_session, nick, extensions,
NULL, NULL, 0, tags_data->timestamp);
inbound_toggle_caps (serv, extensions, TRUE);
/* NEW advertises availability; only ACK confirms an enabled capability. */
if (!sts_upgrade_triggered)
inbound_request_new_caps (serv, extensions, tags_data);
}
void
inbound_cap_del (server *serv, char *nick, char *extensions,
const message_tags_data *tags_data)
{
if (extensions)
{
char **tokens = g_strsplit (extensions, " ", 0);
int i;
for (i = 0; tokens[i]; i++)
{
if (!g_strcmp0 (tokens[i], "sts") ||
g_str_has_prefix (tokens[i], "sts="))
{
/* STS cannot be disabled via CAP DEL. */
g_strfreev (tokens);
return;
}
}
g_strfreev (tokens);
}
EMIT_SIGNAL_TIMESTAMP (XP_TE_CAPDEL, serv->server_session, nick, extensions,
NULL, NULL, 0, tags_data->timestamp);
/* STS has no toggle, but must not prevent other capabilities being removed. */
inbound_toggle_caps (serv, extensions, FALSE);
}
@@ -2053,6 +2055,44 @@ static const char * const supported_caps[] = {
"solanum.chat/identify-msg",
};
static void
inbound_request_new_caps (server *serv, const char *extensions_str,
const message_tags_data *tags_data)
{
char **extensions;
gsize i, x;
if (!extensions_str)
return;
extensions = g_strsplit (extensions_str, " ", 0);
for (i = 0; extensions[i]; i++)
{
char *value = strchr (extensions[i], '=');
if (value)
*value = '\0';
}
/* Request each supported capability once, keeping every IRC line bounded.
* SASL is negotiated during login and is not in supported_caps. */
for (x = 0; x < G_N_ELEMENTS (supported_caps); x++)
{
for (i = 0; extensions[i]; i++)
{
if (!strcmp (extensions[i], supported_caps[x]))
{
EMIT_SIGNAL_TIMESTAMP (XP_TE_CAPREQ, serv->server_session,
extensions[i], NULL, NULL, NULL, 0,
tags_data->timestamp);
tcp_sendf (serv, "CAP REQ :%s\r\n", extensions[i]);
break;
}
}
}
g_strfreev (extensions);
}
static int
get_supported_mech (server *serv, const char *list)
{
+16
View File
@@ -25,6 +25,7 @@ common_sources = [
'tree.c',
'url.c',
'userlist.c',
'hexcolor.c',
'util.c'
]
@@ -197,3 +198,18 @@ test('Emoji Data Tests', emoji_data_tests,
protocol: 'tap',
timeout: 120,
)
hexcolor_tests = executable('hexcolor_tests',
[
'tests/test-hexcolor.c',
'hexcolor.c',
'util.c',
],
include_directories: [config_h_include, include_directories('.')],
dependencies: [libgio_dep] + (libssl_dep.found() ? [libssl_dep] : []),
)
test('Hex Color Tests', hexcolor_tests,
protocol: 'tap',
timeout: 120,
)
+3 -3
View File
@@ -155,7 +155,7 @@ _SSL_get_cert_info (struct cert_info *cert_info, SSL * ssl)
{
X509 *peer_cert;
const X509_PUBKEY *key;
X509_ALGOR *algor = NULL;
ASN1_OBJECT *obj = NULL;
EVP_PKEY *peer_pkey;
char notBefore[64];
char notAfter[64];
@@ -174,10 +174,10 @@ _SSL_get_cert_info (struct cert_info *cert_info, SSL * ssl)
broke_oneline (cert_info->issuer, cert_info->issuer_word);
key = X509_get_X509_PUBKEY(peer_cert);
if (!X509_PUBKEY_get0_param(NULL, NULL, 0, &algor, key))
if (!X509_PUBKEY_get0_param(&obj, NULL, NULL, NULL, key))
return 1;
alg = OBJ_obj2nid (algor->algorithm);
alg = OBJ_obj2nid (obj);
#ifndef HAVE_X509_GET_SIGNATURE_NID
sign_alg = OBJ_obj2nid (peer_cert->sig_alg->algorithm);
#else
+117
View File
@@ -0,0 +1,117 @@
/* ZoiteChat
*
* This program is free software; you can redistribute it and/or modify
* it under the terms of the GNU General Public License as published by
* the Free Software Foundation; either version 2 of the License, or
* (at your option) any later version.
*
* This program is distributed in the hope that it will be useful,
* but WITHOUT ANY WARRANTY; without even the implied warranty of
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
* GNU General Public License for more details.
*
* You should have received a copy of the GNU General Public License
* along with this program; if not, write to the Free Software
* Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301, USA
*/
#include <string.h>
#include <glib.h>
#include "../hexcolor.h"
#include "../util.h"
static void
test_parse_foreground (void)
{
guint32 fg = 0, bg = 0xDEAD;
int has_bg = TRUE;
g_assert_cmpint (hexcolor_parse ("FF8800text", 10, &fg, &bg, &has_bg), ==, 6);
g_assert_cmphex (fg, ==, 0xFF8800);
g_assert_false (has_bg);
g_assert_cmphex (bg, ==, 0xDEAD);
}
static void
test_parse_foreground_and_background (void)
{
guint32 fg = 0, bg = 0;
int has_bg = FALSE;
g_assert_cmpint (hexcolor_parse ("112233,a0b0c0x", 14, &fg, &bg, &has_bg), ==, 13);
g_assert_cmphex (fg, ==, 0x112233);
g_assert_cmphex (bg, ==, 0xA0B0C0);
g_assert_true (has_bg);
}
static void
test_parse_bad_background_keeps_foreground (void)
{
guint32 fg = 0;
int has_bg = TRUE;
/* ",12" is plain text after a valid foreground, not a background */
g_assert_cmpint (hexcolor_parse ("112233,12 hi", 12, &fg, NULL, &has_bg), ==, 6);
g_assert_cmphex (fg, ==, 0x112233);
g_assert_false (has_bg);
}
static void
test_parse_bare (void)
{
/* a bare \004 resets colors, like a bare \003 */
g_assert_cmpint (hexcolor_parse (" text", 5, NULL, NULL, NULL), ==, 0);
g_assert_cmpint (hexcolor_parse ("12345G", 6, NULL, NULL, NULL), ==, 0);
g_assert_cmpint (hexcolor_parse ("", 0, NULL, NULL, NULL), ==, 0);
}
static void
test_parse_respects_length (void)
{
g_assert_cmpint (hexcolor_parse ("FF8800", 5, NULL, NULL, NULL), ==, 0);
g_assert_cmpint (hexcolor_parse ("FF8800,112233", 12, NULL, NULL, NULL), ==, 6);
}
static void
assert_stripped (const char *in, int flags, const char *expected)
{
char out[128];
strip_color2 (in, -1, out, flags);
g_assert_cmpstr (out, ==, expected);
}
static void
test_strip (void)
{
assert_stripped ("\004FF8800alice\017: hi", STRIP_ALL, "alice: hi");
assert_stripped ("\004112233,445566bg", STRIP_ALL, "bg");
assert_stripped ("a\004 b", STRIP_ALL, "a b");
assert_stripped ("\004FF8800\00312x", STRIP_ALL, "x");
/* a trailing code with too few digits leaves the rest as text */
assert_stripped ("x\004FF88", STRIP_ALL, "xFF88");
}
static void
test_strip_keeps_hex_without_strip_color (void)
{
assert_stripped ("\004FF8800red\002", STRIP_ATTRIB, "\004FF8800red");
}
int
main (int argc, char *argv[])
{
g_test_init (&argc, &argv, NULL);
g_test_add_func ("/hexcolor/parse/foreground", test_parse_foreground);
g_test_add_func ("/hexcolor/parse/foreground-and-background", test_parse_foreground_and_background);
g_test_add_func ("/hexcolor/parse/bad-background", test_parse_bad_background_keeps_foreground);
g_test_add_func ("/hexcolor/parse/bare", test_parse_bare);
g_test_add_func ("/hexcolor/parse/length", test_parse_respects_length);
g_test_add_func ("/hexcolor/strip/all", test_strip);
g_test_add_func ("/hexcolor/strip/attrib-only", test_strip_keeps_hex_without_strip_color);
return g_test_run ();
}
+9
View File
@@ -47,6 +47,7 @@
#include "zoitechatc.h"
#include <ctype.h>
#include "util.h"
#include "hexcolor.h"
#if defined (__FreeBSD__) || defined (__APPLE__)
#include <sys/sysctl.h>
@@ -330,6 +331,14 @@ strip_color2 (const char *src, int len, char *dst, int flags)
if (!(flags & STRIP_COLOR)) goto pass_char;
rcol = 2;
break;
case '\004': /*ATTR_HEXCOLOR: */
if (!(flags & STRIP_COLOR)) goto pass_char;
{
int skip = hexcolor_parse (src + 1, len, NULL, NULL, NULL);
src += skip;
len -= skip;
}
break;
case HIDDEN_CHAR: /* CL: invisible text (for event formats only) */ /* this takes care of the topic */
if (!(flags & STRIP_HIDDEN)) goto pass_char;
break;
+7
View File
@@ -278,3 +278,10 @@ test('Emoji Font Tests', emoji_font_tests,
protocol: 'tap',
timeout: 120,
)
xtext_tests = executable('xtext_tests',
['tests/test-xtext.c', '../common/hexcolor.c'],
include_directories: [config_h_include],
dependencies: [gtk_dep],
)
test('XText Tests', xtext_tests, protocol: 'tap', timeout: 120)
+597
View File
@@ -0,0 +1,597 @@
/* XText regression tests. Distributed under GPL-2.0-or-later; see COPYING.
* Include the implementation to check layout/selection invariants without
* adding test-only symbols to the widget's public API. Application services
* are stubbed; GTK, Pango, Cairo and the widget itself are exercised normally. */
#include "../xtext.c"
#include <glib/gstdio.h>
struct zoitechatprefs prefs;
void emoji_font_apply (GtkWidget *widget) { }
int url_last (int *start, int *end) { return 0; }
gsize strftime_utf8 (char *dest, gsize size, const char *format, time_t stamp)
{
return strftime (dest, size, format, localtime (&stamp));
}
int xtext_get_stamp_str (time_t stamp, char **out)
{
*out = g_strdup ("[12:34] ");
return strlen (*out);
}
void theme_get_xtext_colors_for_widget (GtkWidget *widget, XTextColor *colors, size_t len)
{
size_t i;
for (i = 0; i < len; i++)
{
colors[i].red = colors[i].green = colors[i].blue = 0.0;
colors[i].alpha = 1.0;
}
colors[XTEXT_FG].red = colors[XTEXT_FG].green = colors[XTEXT_FG].blue = 1.0;
colors[XTEXT_MARK_BG].blue = 1.0;
colors[XTEXT_MARK_FG] = colors[XTEXT_FG];
colors[XTEXT_MARKER].red = 1.0;
}
typedef struct { GtkWidget *window; GtkXText *xtext; } Fixture;
static void drain_events (void)
{
while (g_main_context_iteration (NULL, FALSE)) { }
}
static void fixture_setup (Fixture *f, gconstpointer data)
{
XTextColor colors[XTEXT_COLS];
GtkWidget *scrolled = gtk_scrolled_window_new (NULL, NULL);
theme_get_xtext_colors_for_widget (NULL, colors, G_N_ELEMENTS (colors));
f->window = gtk_window_new (GTK_WINDOW_TOPLEVEL);
gtk_window_set_default_size (GTK_WINDOW (f->window), 640, 360);
f->xtext = GTK_XTEXT (gtk_xtext_new (colors, TRUE));
g_object_ref (f->xtext);
gtk_container_add (GTK_CONTAINER (scrolled), GTK_WIDGET (f->xtext));
gtk_container_add (GTK_CONTAINER (f->window), scrolled);
g_assert_true (gtk_xtext_set_font (f->xtext, "monospace 12"));
gtk_widget_show_all (f->window);
drain_events ();
}
static void fixture_teardown (Fixture *f, gconstpointer data)
{
gtk_widget_destroy (f->window);
g_object_unref (f->xtext);
drain_events ();
g_assert_null (image_pending_list);
}
static void append (Fixture *f, const char *text)
{
gtk_xtext_append (f->xtext->buffer, (guchar *)text, -1, 1234);
}
static cairo_surface_t *snapshot (Fixture *f, gboolean partial)
{
GtkWidget *widget = GTK_WIDGET (f->xtext);
int width = gtk_widget_get_allocated_width (widget);
int height = gtk_widget_get_allocated_height (widget);
cairo_surface_t *surface = cairo_image_surface_create (CAIRO_FORMAT_ARGB32, width, height);
cairo_t *cr = cairo_create (surface);
if (partial)
{
cairo_rectangle (cr, 0, f->xtext->fontsize, width, height - f->xtext->fontsize);
cairo_clip (cr);
}
gtk_widget_draw (widget, cr);
g_assert_cmpint (cairo_status (cr), ==, CAIRO_STATUS_SUCCESS);
cairo_destroy (cr);
cairo_surface_flush (surface);
return surface;
}
static void test_empty_and_bounded_append (Fixture *f, gconstpointer data)
{
const guchar bytes[] = {'a', 'b', 'c'}; /* deliberately no terminating NUL */
append (f, "");
g_assert_cmpstr ((char *)f->xtext->buffer->text_last->str, ==, "");
g_assert_cmpint (f->xtext->buffer->text_last->subline_count, ==, 1);
append (f, "\n");
g_assert_cmpint (f->xtext->buffer->text_last->str_len, ==, 0);
gtk_xtext_append (f->xtext->buffer, (guchar *)bytes, sizeof (bytes), 1234);
g_assert_cmpstr ((char *)f->xtext->buffer->text_last->str, ==, "abc");
gtk_xtext_append_indent (f->xtext->buffer, (guchar *)"", 0, (guchar *)"", 0, 1234);
g_assert_cmpstr ((char *)f->xtext->buffer->text_last->str, ==, " ");
}
static void test_utf8_limits (Fixture *f, gconstpointer data)
{
GString *text = g_string_new (NULL);
int i;
for (i = 0; i < 1500; i++) g_string_append (text, "猫");
gtk_xtext_append (f->xtext->buffer, (guchar *)text->str, text->len, 1234);
g_assert_cmpint (f->xtext->buffer->text_last->str_len, ==, 4095);
g_assert_true (g_utf8_validate ((char *)f->xtext->buffer->text_last->str, -1, NULL));
gtk_xtext_append_indent (f->xtext->buffer, (guchar *)text->str, text->len,
(guchar *)"猫", -1, 1234);
g_assert_cmpint (f->xtext->buffer->text_last->str_len, <=, 4095);
g_assert_true (g_utf8_validate ((char *)f->xtext->buffer->text_last->str, -1, NULL));
gtk_xtext_append (f->xtext->buffer, (guchar *)"hello 猫", 8, 1234);
g_assert_cmpstr ((char *)f->xtext->buffer->text_last->str, ==, "hello ");
gtk_xtext_append (f->xtext->buffer, (guchar *)"ok\xff" "bad", 6, 1234);
g_assert_cmpstr ((char *)f->xtext->buffer->text_last->str, ==, "ok");
g_string_free (text, TRUE);
}
static void test_null_empty_prefix (Fixture *f, gconstpointer data)
{
xtext_buffer *buf = f->xtext->buffer;
/* PrintTextLine passes NULL/0 for indented server text without a tab. */
gtk_xtext_append_indent (buf, NULL, 0, (guchar *)"server notice", -1, 1234);
g_assert_cmpstr ((char *)buf->text_last->str, ==, " server notice");
g_assert_cmpint (buf->text_last->left_len, ==, 0);
g_assert_cmpint (buf->text_last->stamp, ==, 1234);
gtk_xtext_append_indent (buf, (guchar *)"nick", -1, NULL, 0, 1234);
g_assert_cmpstr ((char *)buf->text_last->str, ==, "nick ");
gtk_xtext_append_indent (buf, NULL, 0, NULL, 0, 1234);
g_assert_cmpstr ((char *)buf->text_last->str, ==, " ");
g_assert_cmpint (buf->num_lines, ==, 3);
cairo_surface_destroy (snapshot (f, FALSE));
}
static void test_wrapping (Fixture *f, gconstpointer data)
{
xtext_buffer *buf = f->xtext->buffer;
textentry *ent;
int start = 0, i;
append (f, "猫猫猫猫猫猫猫猫猫猫");
ent = buf->text_last;
/* A character wider than the row must still be kept whole. */
buf->window_width = 3;
gtk_xtext_lines_taken (buf, ent);
g_assert_cmpint (ent->subline_count, ==, 10);
for (i = 0; i < ent->subline_count; i++)
{
int end = gtk_xtext_subline_end (ent, i);
g_assert_cmpint (end, >, start);
g_assert_true (g_utf8_validate ((char *)ent->str + start, end - start, NULL));
start = end;
}
buf->window_width = 120;
gtk_xtext_lines_taken (buf, ent);
g_assert_cmpint (ent->subline_count, >, 1);
buf->window_width = 640;
gtk_xtext_lines_taken (buf, ent);
g_assert_cmpint (ent->subline_count, ==, 1);
}
static void test_font_isolation (Fixture *f, gconstpointer data)
{
Fixture second;
int original = gtk_xtext_text_width (f->xtext, (guchar *)"WWii hello", 10);
fixture_setup (&second, NULL);
g_assert_true (gtk_xtext_set_font (second.xtext, "sans 30"));
g_assert_cmpint (gtk_xtext_text_width (second.xtext, (guchar *)"WWii hello", 10), >, original);
g_assert_cmpint (gtk_xtext_text_width (f->xtext, (guchar *)"WWii hello", 10), ==, original);
fixture_teardown (&second, NULL);
g_assert_cmpint (gtk_xtext_text_width (f->xtext, (guchar *)"WWii hello", 10), ==, original);
}
static void test_wide_metrics (Fixture *f, gconstpointer data)
{
char *text = g_strnfill (4000, 'W');
g_assert_true (gtk_xtext_set_font (f->xtext, "sans 40"));
append (f, text);
g_assert_cmpint (f->xtext->buffer->text_last->str_width, >, 65535);
g_assert_cmpint (f->xtext->buffer->text_last->subline_count, >, 1);
g_free (text);
}
static void test_formatting (Fixture *f, gconstpointer data)
{
const char *formatted = "a\002bold\002 \035italic\035 \00304,02red\017 \037u\037 \036s\036 \026r\026";
char *plain;
GSList *runs = NULL;
int len;
plain = (char *)gtk_xtext_strip_color ((guchar *)formatted, strlen (formatted), NULL, &len, &runs, FALSE);
g_assert_cmpstr (plain, ==, "abold italic red u s r");
g_assert_cmpint (len, ==, strlen (plain));
g_assert_cmpint (((offlen_t *)runs->data)->off, ==, 0);
g_slist_free_full (runs, g_free);
g_free (plain);
plain = (char *)gtk_xtext_strip_color ((guchar *)"a\010secret\010b", 10, NULL, &len, NULL, TRUE);
g_assert_cmpstr (plain, ==, "ab");
g_free (plain);
append (f, formatted);
gtk_xtext_append_indent (f->xtext->buffer, (guchar *)"nick", -1, (guchar *)formatted, -1, 1234);
f->xtext->auto_indent = TRUE;
f->xtext->buffer->time_stamp = TRUE;
f->xtext->buffer->indent = 130;
gtk_xtext_recalc_widths (f->xtext->buffer, FALSE);
cairo_surface_destroy (snapshot (f, FALSE));
g_assert_cmpstr ((char *)f->xtext->buffer->text_last->str, ==,
"nick a\002bold\002 \035italic\035 \00304,02red\017 \037u\037 \036s\036 \026r\026");
}
static void select_entries (Fixture *f, textentry *start, textentry *end)
{
textentry *ent;
for (ent = start; ent; ent = ent->next)
{
ent->mark_start = 0;
ent->mark_end = ent->str_len;
if (ent == end) break;
}
gtk_xtext_selection_render (f->xtext, start, end);
f->xtext->selection_buffer = f->xtext->buffer;
}
static void test_selection_and_clipboard (Fixture *f, gconstpointer data)
{
char *selected;
int len;
append (f, "");
append (f, "\002bold\002 猫");
append (f, "last");
select_entries (f, f->xtext->buffer->text_first, f->xtext->buffer->text_last);
selected = gtk_xtext_selection_get_text (f->xtext, &len);
g_assert_cmpstr (selected, ==, "\nbold 猫\nlast");
g_assert_cmpint (len, ==, strlen (selected));
g_free (selected);
f->xtext->color_paste = TRUE;
f->xtext->mark_stamp = TRUE;
selected = gtk_xtext_selection_get_text (f->xtext, &len);
g_assert_cmpstr (selected, ==, "\n[12:34] \002bold\002 猫\n[12:34] last");
g_free (selected);
f->xtext->color_paste = f->xtext->mark_stamp = FALSE;
gtk_xtext_copy_selection (f->xtext);
selected = gtk_clipboard_wait_for_text (gtk_widget_get_clipboard (GTK_WIDGET (f->xtext), GDK_SELECTION_CLIPBOARD));
g_assert_cmpstr (selected, ==, "\nbold 猫\nlast");
g_free (selected);
selected = gtk_clipboard_wait_for_text (gtk_widget_get_clipboard (GTK_WIDGET (f->xtext), GDK_SELECTION_PRIMARY));
g_assert_cmpstr (selected, ==, "\nbold 猫\nlast");
g_free (selected);
gtk_xtext_unselect (f->xtext);
g_assert_false (gtk_xtext_is_selecting (f->xtext));
}
static void test_search (Fixture *f, gconstpointer data)
{
GError *error = NULL;
textentry *first;
xtext_buffer *buf = f->xtext->buffer;
append (f, "one \002needle\002 then NEEDLE");
first = buf->text_last;
append (f, "second needle");
g_assert_true (gtk_xtext_search (f->xtext, "needle", highlight, &error) == first);
g_assert_no_error (error);
g_assert_cmpint (g_list_length (first->marks), ==, 2);
g_assert_true (gtk_xtext_search (f->xtext, "needle", highlight, &error) == first);
g_assert_true (gtk_xtext_search (f->xtext, "needle", highlight, &error) == buf->text_last);
gtk_xtext_search (f->xtext, "", 0, &error);
g_assert_null (buf->search_found);
g_assert_true (gtk_xtext_search (f->xtext, "needle", backward | case_match, &error) == buf->text_last);
gtk_xtext_search (f->xtext, "n[a-z]+", regexp | case_match, &error);
g_assert_no_error (error);
g_assert_nonnull (buf->search_re);
gtk_xtext_search (f->xtext, "[", regexp, &error);
g_assert_error (error, G_REGEX_ERROR, G_REGEX_ERROR_UNTERMINATED_CHARACTER_CLASS);
g_clear_error (&error);
/* A no-match search must also release its regex/text on clear. */
gtk_xtext_search (f->xtext, "nomatch", regexp, &error);
g_assert_null (buf->search_found);
gtk_xtext_clear (buf, 0);
g_assert_null (buf->search_re);
g_assert_null (buf->search_text);
}
static void test_follow_search (Fixture *f, gconstpointer data)
{
xtext_buffer *buf = f->xtext->buffer;
append (f, "match first");
gtk_xtext_search (f->xtext, "match", 0, NULL);
append (f, "match second");
gtk_xtext_search (f->xtext, NULL, follow, NULL);
g_assert_cmpint (g_list_length (buf->search_found), ==, 2);
GList *current = buf->curmark;
gtk_xtext_search (f->xtext, NULL, 0, NULL);
gtk_xtext_search (f->xtext, NULL, follow, NULL);
g_assert_cmpint (g_list_length (buf->search_found), ==, 2);
g_assert_true (buf->curmark == current);
append (f, "match third");
g_assert_cmpint (g_list_length (buf->search_found), ==, 3);
}
static void test_search_unicode_offsets (Fixture *f, gconstpointer data)
{
xtext_buffer *buf = f->xtext->buffer;
offsets_t mark;
append (f, "İ \002NEEDLE\002 Straße");
gtk_xtext_search (f->xtext, "needle", 0, NULL);
mark.u = GPOINTER_TO_UINT (buf->text_first->marks->data);
g_assert_cmpint (mark.o.start, ==, 4);
/* The established color-offset mapping includes the closing control. */
g_assert_cmpint (mark.o.end, ==, 11);
gtk_xtext_search (f->xtext, "ss", 0, NULL);
mark.u = GPOINTER_TO_UINT (buf->text_first->marks->data);
g_assert_cmpint (mark.o.start, ==, 16);
g_assert_cmpint (mark.o.end, ==, 18);
gtk_xtext_clear (buf, 0);
append (f, "ſ needle");
gtk_xtext_search (f->xtext, "needle", 0, NULL);
mark.u = GPOINTER_TO_UINT (buf->text_first->marks->data);
g_assert_cmpint (mark.o.start, ==, 3);
g_assert_cmpint (mark.o.end, ==, 9);
}
static void test_rawlog_hidden_text (Fixture *f, gconstpointer data)
{
int hidden, visible;
append (f, "a\010secret\010b");
hidden = f->xtext->buffer->text_last->str_width;
f->xtext->ignore_hidden = TRUE;
gtk_xtext_recalc_widths (f->xtext->buffer, TRUE);
visible = f->xtext->buffer->text_last->str_width;
g_assert_cmpint (visible, >, hidden);
g_assert_cmpint (visible, ==, gtk_xtext_text_width (f->xtext, (guchar *)"asecretb", 8));
}
static void test_save (Fixture *f, gconstpointer data)
{
char *path, *saved;
GError *error = NULL;
int fd = g_file_open_tmp ("zoitechat-xtext-XXXXXX", &path, &error);
g_assert_no_error (error);
append (f, "\002bold\002 猫");
append (f, "");
append (f, "last");
gtk_xtext_save (f->xtext, fd);
close (fd);
g_assert_true (g_file_get_contents (path, &saved, NULL, &error));
g_assert_no_error (error);
g_assert_cmpstr (saved, ==, "bold 猫\n\nlast\n");
g_free (saved);
g_unlink (path);
g_free (path);
}
static void test_scrollable_ownership (Fixture *f, gconstpointer data)
{
GtkAdjustment *horizontal = GTK_ADJUSTMENT (gtk_adjustment_new (0, 0, 1, 1, 1, 1));
GtkAdjustment *vertical = GTK_ADJUSTMENT (gtk_adjustment_new (0, 0, 100, 1, 10, 10));
GtkAdjustment *old = g_object_ref (f->xtext->adj);
g_object_set (f->xtext, "hadjustment", horizontal, "vadjustment", vertical, NULL);
g_assert_false (g_object_is_floating (horizontal));
g_assert_false (g_object_is_floating (vertical));
g_assert_true (f->xtext->hadj == horizontal);
g_assert_true (f->xtext->adj == vertical);
/* A replaced adjustment must no longer call into the widget. */
g_assert_cmpuint (g_signal_handler_find (old, G_SIGNAL_MATCH_DATA, 0, 0, NULL, NULL, f->xtext), ==, 0);
g_signal_emit_by_name (f->xtext, "set-scroll-adjustments", horizontal, vertical);
g_assert_true (f->xtext->adj == vertical);
g_object_set (f->xtext, "hadjustment", NULL, "vadjustment", NULL, NULL);
g_assert_true (GTK_IS_ADJUSTMENT (f->xtext->hadj));
g_assert_true (GTK_IS_ADJUSTMENT (f->xtext->adj));
g_object_unref (old);
}
static void test_clear_and_marker (Fixture *f, gconstpointer data)
{
xtext_buffer *buf = f->xtext->buffer;
append (f, "first"); append (f, "second"); append (f, "third");
buf->marker_pos = buf->text_first;
buf->marker_state = MARKER_IS_SET;
gtk_xtext_clear (buf, 1);
g_assert_cmpstr ((char *)buf->text_first->str, ==, "second");
g_assert_cmpint (buf->marker_state, ==, MARKER_RESET_BY_CLEAR);
gtk_xtext_clear (buf, -1);
g_assert_cmpstr ((char *)buf->text_last->str, ==, "second");
select_entries (f, buf->text_first, buf->text_last);
f->xtext->hilight_ent = buf->text_first;
gtk_xtext_clear (buf, 0);
g_assert_null (f->xtext->hilight_ent);
g_assert_null (buf->pagetop_ent);
g_assert_null (buf->last_ent_start);
g_assert_cmpint (buf->num_lines, ==, 0);
g_assert_true (gtk_xtext_is_empty (buf));
append (f, "after clear");
g_assert_cmpint (buf->num_lines, ==, 1);
}
static void test_scrollback_limit (Fixture *f, gconstpointer data)
{
int i;
xtext_buffer *buf = f->xtext->buffer;
gtk_xtext_set_max_lines (f->xtext, 10);
for (i = 0; i < 100; i++) append (f, "line");
g_assert_cmpint (buf->num_lines, ==, 10);
g_assert_null (buf->text_first->prev);
g_assert_null (buf->text_last->next);
g_assert_cmpfloat (gtk_adjustment_get_value (f->xtext->adj), >=, 0);
}
static void test_follow_trim_oversized_entry (Fixture *f, gconstpointer data)
{
char *long_text = g_strnfill (4000, 'W');
gtk_xtext_set_max_lines (f->xtext, 3);
append (f, "needle");
gtk_xtext_search (f->xtext, "W", follow, NULL);
gtk_xtext_clear (f->xtext->buffer, 1);
append (f, long_text);
g_assert_true (gtk_xtext_is_empty (f->xtext->buffer));
g_assert_null (f->xtext->buffer->search_found);
g_free (long_text);
append (f, "after oversized");
gtk_xtext_clear (f->xtext->buffer, G_MININT);
g_assert_true (gtk_xtext_is_empty (f->xtext->buffer));
}
static void test_stress (Fixture *f, gconstpointer data)
{
static const char *tokens[] = {"text ", "猫", "😀", "\002bold\002", "\00304,02red\017", "\010hidden\010", "\037u\037", "\036s\036"};
GRand *random = g_rand_new_with_seed (0x78746578);
xtext_buffer *buf = f->xtext->buffer;
int i;
gtk_xtext_set_max_lines (f->xtext, 80);
for (i = 0; i < 2000; i++)
{
GString *text = g_string_new (NULL);
textentry *ent;
int j, lines = 0;
for (j = 0; j < 30; j++)
g_string_append (text, tokens[g_rand_int_range (random, 0, G_N_ELEMENTS (tokens))]);
if (i % 2)
gtk_xtext_append_indent (buf, (guchar *)"nick", -1, (guchar *)text->str, text->len, 1234);
else
gtk_xtext_append (buf, (guchar *)text->str, text->len, 1234);
g_string_free (text, TRUE);
if (i % 29 == 0) gtk_xtext_search (f->xtext, "text", follow | highlight, NULL);
if (i % 31 == 0) gtk_xtext_clear (buf, 1);
if (i % 37 == 0) gtk_xtext_clear (buf, -1);
if (i % 101 == 0) gtk_xtext_clear (buf, 0);
for (ent = buf->text_first; ent; ent = ent->next)
{
g_assert_true (g_utf8_validate ((char *)ent->str, ent->str_len, NULL));
g_assert_cmpint (ent->subline_count, >, 0);
lines += ent->subline_count;
}
g_assert_cmpint (buf->num_lines, ==, lines);
if (i % 43 == 0) cairo_surface_destroy (snapshot (f, FALSE));
}
g_rand_free (random);
}
static void test_buffers (Fixture *f, gconstpointer data)
{
xtext_buffer *original = f->xtext->buffer;
xtext_buffer *second = gtk_xtext_buffer_new (f->xtext);
append (f, "original");
gtk_xtext_append (second, (guchar *)"alternate", -1, 1234);
gtk_xtext_buffer_show (f->xtext, second, TRUE);
g_assert_true (f->xtext->buffer == second);
cairo_surface_destroy (snapshot (f, FALSE));
gtk_xtext_buffer_show (f->xtext, original, TRUE);
g_assert_cmpstr ((char *)f->xtext->buffer->text_first->str, ==, "original");
gtk_xtext_buffer_free (second);
}
static void test_partial_draw_after_scroll (Fixture *f, gconstpointer data)
{
cairo_surface_t *partial, *full;
int i, stride, height, y;
for (i = 0; i < 80; i++)
{
char *line = g_strdup_printf ("line %d — 猫 \002bold\002", i);
append (f, line);
g_free (line);
}
cairo_surface_destroy (snapshot (f, FALSE));
gtk_adjustment_set_value (f->xtext->adj, 12.5);
partial = snapshot (f, TRUE);
full = snapshot (f, FALSE);
stride = cairo_image_surface_get_stride (full);
height = cairo_image_surface_get_height (full);
for (y = f->xtext->fontsize; y < height; y++)
g_assert_cmpmem (cairo_image_surface_get_data (partial) + y * stride, stride,
cairo_image_surface_get_data (full) + y * stride, stride);
cairo_surface_destroy (partial);
cairo_surface_destroy (full);
}
static void test_image_lifecycle (Fixture *f, gconstpointer data)
{
GdkPixbuf *image = gdk_pixbuf_new (GDK_COLORSPACE_RGB, TRUE, 8, 800, 600);
xtext_buffer *buf = f->xtext->buffer;
textentry *ent;
guint handle;
int before;
gdk_pixbuf_fill (image, 0xff0000ff);
append (f, "image");
ent = buf->text_last;
before = buf->num_lines;
handle = gtk_xtext_image_load_begin (f->xtext, ent, "https://example.invalid/image.png");
g_assert_cmpuint (handle, !=, 0);
g_assert_cmpuint (gtk_xtext_image_load_begin (f->xtext, ent, "duplicate"), ==, 0);
g_assert_true (gtk_xtext_image_load_finish (handle, image));
g_assert_cmpint (buf->num_lines, >, before);
g_assert_true (gtk_xtext_entry_has_image (f->xtext, ent));
g_assert_cmpint (gdk_pixbuf_get_width (ent->image), <=, XTEXT_IMAGE_MAX_WIDTH);
g_assert_true (gtk_xtext_entry_get_full_image (f->xtext, ent) == image);
cairo_surface_destroy (snapshot (f, FALSE));
g_assert_true (gtk_xtext_image_remove (f->xtext, ent));
g_assert_cmpint (buf->num_lines, ==, before);
handle = gtk_xtext_image_load_begin (f->xtext, ent, "late");
gtk_xtext_clear (buf, 0);
g_assert_false (gtk_xtext_image_load_finish (handle, image));
g_assert_false (gtk_xtext_entry_has_image (f->xtext, ent));
g_assert_null (gtk_xtext_entry_get_full_image (f->xtext, ent));
g_object_unref (image);
}
static void test_background (Fixture *f, gconstpointer data)
{
cairo_surface_t *background = cairo_image_surface_create (CAIRO_FORMAT_ARGB32, 32, 32);
cairo_t *cr = cairo_create (background);
cairo_set_source_rgb (cr, 0.2, 0.3, 0.4);
cairo_paint (cr);
cairo_destroy (cr);
gtk_xtext_set_background (f->xtext, background);
cairo_surface_destroy (background);
gtk_xtext_set_background (f->xtext, f->xtext->background_surface);
append (f, "background text");
cairo_surface_destroy (snapshot (f, FALSE));
gtk_xtext_set_background (f->xtext, NULL);
cairo_surface_destroy (snapshot (f, FALSE));
}
static void test_destroy_pending_sources (Fixture *f, gconstpointer data)
{
guint image;
append (f, "pending");
image = gtk_xtext_image_load_begin (f->xtext, f->xtext->buffer->text_last, "late");
f->xtext->io_tag = g_timeout_add (10000, gtk_xtext_adjustment_timeout, f->xtext);
f->xtext->add_io_tag = g_timeout_add (10000, gtk_xtext_render_page_timeout, f->xtext);
f->xtext->scroll_tag = g_timeout_add (10000, gtk_xtext_scrollup_timeout, f->xtext);
gtk_widget_destroy (f->window);
g_assert_cmpint (f->xtext->io_tag, ==, 0);
g_assert_cmpint (f->xtext->add_io_tag, ==, 0);
g_assert_cmpint (f->xtext->scroll_tag, ==, 0);
g_assert_false (gtk_xtext_image_load_finish (image, NULL));
/* GtkWidget destruction must be safe if GObject dispose runs again. */
g_object_run_dispose (G_OBJECT (f->xtext));
f->window = gtk_window_new (GTK_WINDOW_TOPLEVEL);
}
int main (int argc, char **argv)
{
g_test_init (&argc, &argv, NULL);
if (!gtk_init_check (&argc, &argv))
{
g_test_message ("GTK display unavailable; run under Xvfb for widget coverage");
return 77;
}
prefs.hex_gui_mouse_scroll_speed = 10;
#define ADD(name, function) g_test_add ("/xtext/" name, Fixture, NULL, fixture_setup, function, fixture_teardown)
ADD ("append/empty-bounded", test_empty_and_bounded_append);
ADD ("append/utf8-limits", test_utf8_limits);
ADD ("append/null-empty-prefix", test_null_empty_prefix);
ADD ("layout/wrapping", test_wrapping);
ADD ("layout/font-isolation", test_font_isolation);
ADD ("layout/wide-metrics", test_wide_metrics);
ADD ("render/formatting-timestamps", test_formatting);
ADD ("selection/clipboard", test_selection_and_clipboard);
ADD ("search/navigation-regex-clear", test_search);
ADD ("search/follow", test_follow_search);
ADD ("search/unicode-offsets", test_search_unicode_offsets);
ADD ("render/rawlog-hidden", test_rawlog_hidden_text);
ADD ("buffer/save", test_save);
ADD ("lifecycle/scrollable-ownership", test_scrollable_ownership);
ADD ("buffer/clear-marker", test_clear_and_marker);
ADD ("buffer/scrollback-limit", test_scrollback_limit);
ADD ("buffer/follow-trim-oversized", test_follow_trim_oversized_entry);
ADD ("buffer/stress", test_stress);
ADD ("buffer/switch", test_buffers);
ADD ("render/partial-scroll", test_partial_draw_after_scroll);
ADD ("images/lifecycle", test_image_lifecycle);
ADD ("render/background", test_background);
ADD ("lifecycle/pending-sources", test_destroy_pending_sources);
#undef ADD
return g_test_run ();
}
+541 -1076
View File
File diff suppressed because it is too large Load Diff
+5
View File
@@ -38,6 +38,7 @@ GType gtk_xtext_get_type (void);
#define ATTR_BOLD '\002'
#define ATTR_COLOR '\003'
#define ATTR_HEXCOLOR '\004'
#define ATTR_BLINK '\006'
#define ATTR_BEEP '\007'
#define ATTR_HIDDEN '\010'
@@ -57,6 +58,8 @@ GType gtk_xtext_get_type (void);
#define XTEXT_BG 102
#define XTEXT_MARKER 103 /* for marker line */
#define XTEXT_MAX_COLOR 98
#define XTEXT_HEX_FG 200 /* not palette slots: colors from \004RRGGBB */
#define XTEXT_HEX_BG 201
typedef struct textentry textentry;
/*
@@ -181,6 +184,8 @@ struct _GtkXText
int col_fore;
int col_back;
XTextColor hex_fg;
XTextColor hex_bg;
int depth; /* gdk window depth */