fix tls unsupported issue on windows

docs/README.md

@@ -33,53 +33,10 @@ Example:
         that is not visually indented
 ```
 
-## HTML theme
+## Read the Docs theme skin
 
-The `zoitechat` theme inherits Sphinx's built-in `basic` theme. It uses the
-same compact layout, blue navigation, and system fonts as zoitechat.org.
-Appearance starts in System mode on each page. Light and Dark are available
-for the current page; no cookies or browser storage are used.
+The HTML output keeps the existing `basicstrap` Sphinx theme, then applies the
+ZoiteChat main-site skin from `_static/css/zoitechat-docs.css`.
 
-The theme's templates are in `_theme/zoitechat/`. Its readable CSS and
-JavaScript are in `_static/css/zoitechat-docs.css` and
-`_static/js/zoitechat-docs.js`. No minification, JavaScript package manager,
-external fonts, or CDN assets are required.
-
-Navigation URLs, including `zoite_atlas_url`, are configured through
-`html_context` in `conf.py`. The logo
-is `_static/zoitechat-logo.svg`. Standard Sphinx search, indexes, source
-links, anchors, translations, and previous/next links remain available.
-The HTML output also works as locally installed documentation; project-site
-links only access the network when clicked.
-
-Build from the repository root:
-
-```sh
-sphinx-build -b html docs docs/_build/html
-```
-
-Use a clean output directory when switching themes, so stale Basicstrap
-assets from an earlier build are not included in a package.
-
-## Debian packaging
-
-The active theme does not use the bundled Basicstrap, Bootstrap, jQuery,
-jQuery Cookie, Font Awesome, or icon fonts. Its font stack includes DejaVu
-Sans and DejaVu Sans Mono; no font files are bundled by the theme.
-
-Packagers may exclude `docs/_theme/basicstrap/` from the source package.
-The default theme continues to build without that directory. No pre-minified
-third-party assets need to be added or rebuilt for this theme.
-
-Build with the distribution's `python3-sphinx`. After installing the HTML
-into the package staging directory, use `dh_sphinxdoc` (or `dh --with
-sphinxdoc`) to replace Sphinx's standard JavaScript files with system
-symlinks. Include `${sphinxdoc:Depends}` in the package dependencies and
-`${sphinxdoc:Built-Using}` where required for generated assets. The custom
-`zoitechat-docs.js` remains a small, readable project source file.
-
-A built-in theme is still selectable with `-D html_theme=classic` if a
-packager needs a different layout. The old RST content has existing build
-diagnostics; changing the theme does not suppress or alter them.
-
-Shared website chrome is in `_static/css/zoitechat-site.css`, copied from the main site. Keep that readable stylesheet in sync when changing the shared header, navigation, typography, or colours.
+Brand navigation links are set in `conf.py` through `html_context`, and the
+header logo uses `_static/zoitechat-logo.svg`.

docs/_static/css/zoitechat-site.css

@@ -1,526 +0,0 @@
-/* SPDX-License-Identifier: GPL-2.0-or-later */
-/* Shared chrome copied from ZoiteChat/site assets/css/site.css (1df996a). */
-:root {
-    color-scheme: light;
-    --bg: #fff;
-    --surface: #fff;
-    --chrome: #f1f2f3;
-    --chrome2: #e3e5e7;
-    --text: #25282c;
-    --muted: #58616b;
-    --line: #bdc3c9;
-    --soft-line: #dce0e4;
-    --blue: #215a9e;
-    --link: #174f92;
-    --selection: #e6effa;
-    --success: #236741;
-    --code: #f2f4f6;
-    --shadow: none;
-    --mono: Consolas,"Liberation Mono",monospace;
-}
-
-html[data-theme=dark] {
-    color-scheme: dark;
-    --bg: #111416;
-    --surface: #191c1f;
-    --chrome: #25292d;
-    --chrome2: #30353a;
-    --text: #eef0f2;
-    --muted: #b2bbc4;
-    --line: #50575e;
-    --soft-line: #353c43;
-    --blue: #2865a8;
-    --link: #8dc0ff;
-    --selection: #233951;
-    --success: #92d5ab;
-    --code: #111518;
-    --shadow: none;
-}
-
-* {
-    box-sizing: border-box;
-}
-
-body {
-    margin: 0;
-    background: var(--bg);
-    color: var(--text);
-    font: 15px/1.6 system-ui,-apple-system,"Segoe UI",sans-serif;
-}
-
-a {
-    color: var(--link);
-    text-underline-offset: 3px;
-}
-
-a:hover {
-    text-decoration: underline;
-}
-
-button, input, select {
-    font: inherit;
-}
-
-button, summary {
-    cursor: pointer;
-}
-
-img {
-    display: block;
-    max-width: 100%;
-    height: auto;
-}
-
-button, a, input, select, summary {
-    touch-action: manipulation;
-}
-
-:focus-visible {
-    outline: 3px solid var(--link);
-    outline-offset: 3px;
-}
-
-[hidden] {
-    display: none!important;
-}
-
-.sr-only {
-    position: absolute;
-    width: 1px;
-    height: 1px;
-    padding: 0;
-    margin: -1px;
-    overflow: hidden;
-    clip-path: inset(50%);
-    white-space: nowrap;
-    border: 0;
-}
-
-.skip-link {
-    position: absolute;
-    left: 12px;
-    top: -100px;
-    z-index: 10;
-    padding: 10px;
-    background: var(--surface);
-}
-
-.skip-link:focus {
-    top: 12px;
-}
-
-.topbar {
-    display: flex;
-    align-items: center;
-    justify-content: space-between;
-    gap: 20px;
-    padding: 0 0 16px;
-    background: var(--surface);
-    border-bottom: 1px solid var(--line);
-    border: 0;
-}
-
-.brand {
-    display: flex;
-    gap: 12px;
-    align-items: center;
-    color: var(--text);
-    text-decoration: none;
-}
-
-.brand img {
-    width: 38px;
-    height: 42px;
-}
-
-.brand strong {
-    font-size: 28px;
-    letter-spacing: -.8px;
-    font-weight: 650;
-}
-
-.brand small {
-    display: block;
-    font-size: 12px;
-    color: var(--muted);
-    line-height: 1.2;
-}
-
-.appearance {
-    display: flex;
-    align-items: center;
-    gap: 10px;
-    font-size: 11px;
-    color: var(--muted);
-}
-
-select {
-    border: 1px solid var(--line);
-    border-radius: 3px;
-    padding: 5px 8px;
-    background: var(--surface);
-    color: var(--text);
-}
-
-.navigation {
-    display: flex;
-    align-items: center;
-    justify-content: flex-start;
-    gap: 12px;
-    background: var(--chrome);
-    border-bottom: 1px solid var(--line);
-    padding: 0;
-    border: 1px solid var(--line);
-    border-radius: 0;
-}
-
-.nav-links {
-    display: flex;
-    align-items: stretch;
-    flex-wrap: wrap;
-    gap: 0;
-}
-
-.nav-links>a, .nav-menu summary {
-    display: flex;
-    align-items: center;
-    min-height: 36px;
-    padding: 6px 15px;
-    color: var(--text);
-    font-size: 13px;
-    text-decoration: none;
-    border-bottom: 0;
-}
-
-.nav-links>a[aria-current=page] {
-    color: #fff;
-    border-bottom-color: var(--blue);
-    font-weight: 500;
-    background: var(--blue);
-}
-
-.nav-links>a:hover, .nav-menu summary:hover {
-    background: var(--selection);
-}
-
-.nav-menu {
-    position: relative;
-}
-
-.nav-menu summary {
-    list-style: none;
-}
-
-.nav-menu summary::after {
-    content: "⌄";
-    margin-left: 9px;
-}
-
-.nav-menu summary::-webkit-details-marker {
-    display: none;
-}
-
-.nav-menu-panel {
-    position: absolute;
-    right: 0;
-    top: 100%;
-    z-index: 5;
-    min-width: 280px;
-    background: var(--surface);
-    border: 1px solid var(--line);
-    box-shadow: var(--shadow);
-    padding: 5px;
-}
-
-.nav-menu-panel a {
-    display: block;
-    padding: 10px 12px;
-    text-decoration: none;
-}
-
-.nav-menu-panel a:hover {
-    background: var(--selection);
-}
-
-.nav-menu-panel span {
-    display: block;
-    font-size: 12px;
-    color: var(--muted);
-}
-
-.site-main {
-    min-height: 0;
-}
-
-h1, h2, h3, p {
-    margin-top: 0;
-}
-
-h1 {
-    font-size: clamp(30px,3.9vw,46px);
-    line-height: 1.16;
-    letter-spacing: -1.5px;
-    font-weight: 650;
-    margin-bottom: 20px;
-}
-
-h2 {
-    font-size: 20px;
-    line-height: 1.3;
-    letter-spacing: 0;
-    margin-bottom: 12px;
-}
-
-h3 {
-    font-size: 16px;
-    line-height: 1.4;
-}
-
-p {
-    color: var(--text);
-    font-size: 14px;
-    line-height: 1.7;
-    margin-bottom: 15px;
-}
-
-.site-footer {
-    padding: 17px 0;
-    background: var(--surface);
-    border-top: 1px solid var(--line);
-}
-
-.footer-grid {
-    display: flex;
-    align-items: start;
-    justify-content: space-between;
-    gap: 20px;
-}
-
-.footer-copy {
-    font-size: 11px;
-    max-width: 62ch;
-    margin: 0;
-    color: var(--muted);
-}
-
-.footer-links {
-    display: flex;
-    flex-wrap: wrap;
-    gap: 5px 14px;
-    max-width: 400px;
-    font-size: 11px;
-}
-
-@media (max-width:1000px) {
-.navigation {
-        padding: 0 15px;
-    }
-
-.nav-links>a, .nav-menu summary {
-        padding: 8px 10px;
-    }
-}
-
-@media (max-width:650px) {
-.topbar {
-        padding: 13px 16px;
-        gap: 8px;
-    }
-
-.brand strong {
-        font-size: 20px;
-    }
-
-.brand small {
-        font-size: 10px;
-    }
-
-.brand img {
-        width: 28px;
-        height: 31px;
-    }
-
-.appearance {
-        gap: 5px;
-    }
-
-.appearance>span {
-        display: none;
-    }
-
-.appearance select {
-        font-size: 12px;
-        max-width: 98px;
-    }
-
-.navigation {
-        padding: 0 6px;
-    }
-
-.nav-links {
-        gap: 0;
-    }
-
-.nav-links>a, .nav-menu summary {
-        min-height: 44px;
-        padding: 8px;
-        font-size: 12px;
-    }
-
-h1 {
-        font-size: 34px;
-        letter-spacing: -1px;
-    }
-
-.footer-grid {
-        display: grid;
-        gap: 20px;
-    }
-
-.site-footer {
-        padding: 20px 17px;
-    }
-
-.nav-menu-panel {
-        position: fixed;
-        right: 10px;
-        left: 10px;
-        top: auto;
-        min-width: 0;
-    }
-}
-
-@media (prefers-reduced-motion:reduce) {
-* {
-        scroll-behavior: auto!important;
-    }
-}
-
-.appearance select {
-    font-size: 12px;
-    padding: 3px 7px;
-}
-
-.nav-links>a:hover {
-    background: var(--selection);
-    color: var(--link);
-}
-
-h1 {
-    font-size: 28px;
-    font-weight: 600;
-    letter-spacing: -.5px;
-    line-height: 1.3;
-    margin: 0 0 16px;
-    max-width: none;
-}
-
-@media (max-width:1100px) {
-.navigation {
-        padding: 0;
-    }
-}
-
-@media (max-width:800px) {
-.nav-links>a, .nav-menu summary {
-        padding: 6px 10px;
-    }
-}
-
-@media (max-width:600px) {
-.topbar {
-        padding: 0 0 14px;
-    }
-
-.brand strong {
-        font-size: 25px;
-    }
-
-.brand img {
-        width: 32px;
-        height: 36px;
-    }
-
-.nav-links>a, .nav-menu summary {
-        padding: 7px 9px;
-        min-height: 38px;
-        font-size: 12px;
-    }
-
-.footer-grid {
-        display: block;
-    }
-
-.footer-links {
-        margin-top: 10px;
-        max-width: none;
-    }
-
-.site-footer {
-        padding: 14px 0;
-    }
-
-h1 {
-        font-size: 26px;
-    }
-}
-
-@media (prefers-color-scheme: dark) {
-:root:not([data-theme]) {
-        color-scheme: dark;
-        --bg: #111416;
-        --surface: #191c1f;
-        --chrome: #25292d;
-        --chrome2: #30353a;
-        --text: #eef0f2;
-        --muted: #b2bbc4;
-        --line: #50575e;
-        --soft-line: #353c43;
-        --blue: #2865a8;
-        --link: #8dc0ff;
-        --selection: #233951;
-        --success: #92d5ab;
-        --code: #111518;
-        --shadow: none;
-    }
-}
-
-.site-header, .site-main, .site-footer {
-    width: min(1040px, calc(100% - 48px));
-    margin-inline: auto;
-}
-
-.site-header {
-    margin-top: 32px;
-}
-
-.site-main {
-    padding-block: 28px 20px;
-}
-
-.site-header .topbar {
-    padding: 0 0 16px;
-}
-
-.site-header .navigation {
-    padding: 0;
-}
-
-@media (max-width: 600px) {
-.site-header, .site-main, .site-footer {
-        width: calc(100% - 30px);
-    }
-
-.site-header {
-        margin-top: 18px;
-    }
-
-.site-main {
-        padding-top: 23px;
-    }
-}
-
-/* Match the browser's heading defaults used by the main site. */
-h2, h3 { font-weight: bold; }
-h2 { margin-top: .83em; }
-h3 { margin-block: 1em; }

docs/_static/js/zoitechat-docs.js

@@ -1,44 +0,0 @@
-/* SPDX-License-Identifier: GPL-2.0-or-later */
-(() => {
-    'use strict';
-
-    const initialise = () => {
-        const picker = document.getElementById('theme-picker');
-        const preference = window.matchMedia('(prefers-color-scheme: dark)');
-
-        if (picker instanceof HTMLSelectElement) {
-            const applyTheme = () => {
-                const dark = picker.value === 'dark'
-                    || (picker.value === 'system' && preference.matches);
-                document.documentElement.dataset.theme = dark ? 'dark' : 'light';
-                document.querySelectorAll('meta[name="theme-color"]').forEach((meta) => {
-                    meta.setAttribute('content', dark ? '#111416' : '#ffffff');
-                });
-            };
-
-            // Follow the OS on every visit, including browser back/forward navigation.
-            const resetTheme = () => {
-                picker.value = 'system';
-                applyTheme();
-            };
-            picker.addEventListener('change', applyTheme);
-            preference.addEventListener('change', applyTheme);
-            window.addEventListener('pageshow', resetTheme);
-            resetTheme();
-        }
-
-        const navigation = document.getElementById('docs-navigation');
-        const compact = window.matchMedia('(max-width: 760px)');
-        if (navigation instanceof HTMLDetailsElement) {
-            const fitNavigation = () => { navigation.open = !compact.matches; };
-            compact.addEventListener('change', fitNavigation);
-            fitNavigation();
-        }
-    };
-
-    if (document.readyState === 'loading') {
-        document.addEventListener('DOMContentLoaded', initialise, { once: true });
-    } else {
-        initialise();
-    }
-})();

docs/_theme/zoitechat/globaltoc.html

@@ -1,5 +0,0 @@
-{# SPDX-License-Identifier: GPL-2.0-or-later #}
-<nav class="global-toc" aria-label="{{ _('Documentation contents') }}">
-    <h2>{{ _('Contents') }}</h2>
-    {{ toctree(maxdepth=2, collapse=true, includehidden=true, titles_only=true) }}
-</nav>

docs/_theme/zoitechat/layout.html

@@ -1,108 +0,0 @@
-{# SPDX-License-Identifier: GPL-2.0-or-later #}
-{% extends "basic/layout.html" %}
-{% set docs_root = root_doc|default(master_doc) %}
-
-{% block extrahead %}
-    {{ super() }}
-    <meta name="theme-color" content="#ffffff" media="(prefers-color-scheme: light)">
-    <meta name="theme-color" content="#111416" media="(prefers-color-scheme: dark)">
-{% endblock %}
-
-{% block body_tag %}<body id="top">{% endblock %}
-
-{% block header %}
-    <a class="skip-link" href="#main-content">{{ _('Skip to content') }}</a>
-    <header class="site-header">
-        <div class="topbar">
-            <a class="brand" href="{{ pathto(docs_root)|e }}">
-                <img src="{{ logo_url|default(pathto('_static/zoitechat-logo.svg', 1), true)|e }}" alt="" width="38" height="42">
-                <strong>{{ project|e }}</strong>
-            </a>
-            <label class="appearance" for="theme-picker">
-                <span>{{ _('Appearance') }}</span>
-                <select id="theme-picker" aria-label="{{ _('Documentation appearance') }}">
-                    <option value="system" selected>{{ _('System') }}</option>
-                    <option value="light">{{ _('Light') }}</option>
-                    <option value="dark">{{ _('Dark') }}</option>
-                </select>
-            </label>
-        </div>
-        <div class="navigation">
-            <nav class="nav-links" aria-label="{{ _('Primary') }}">
-                <a href="{{ zoite_site_url|e }}">{{ _('Home') }}</a>
-                <a href="{{ zoite_download_url|e }}">{{ _('Downloads') }}</a>
-                <a href="{{ zoite_addons_url|e }}">{{ _('Addons') }}</a>
-                <a href="{{ zoite_announcements_url|e }}">{{ _('Announcements') }}</a>
-                <a href="{{ pathto(docs_root)|e }}" aria-current="page">{{ _('Documentation') }}</a>
-                <a href="{{ zoite_atlas_url|e }}">{{ _('Atlas') }}</a>
-                <a href="{{ zoite_github_url|e }}" target="_blank" rel="noopener">{{ _('GitHub') }}</a>
-                <details class="nav-menu">
-                    <summary>{{ _('IRC support') }}</summary>
-                    <div class="nav-menu-panel" aria-label="{{ _('IRC support channels') }}">
-                        <a href="{{ zoite_irc_url|e }}" target="_blank" rel="noopener"><strong>{{ _('Zoite IRC') }}</strong><span>{{ _('Official support') }} · #zoitechat</span></a>
-                        <a href="{{ libera_irc_url|e }}" target="_blank" rel="noopener"><strong>{{ _('Libera.Chat') }}</strong><span>{{ _('Secondary support') }} · #zoitechat</span></a>
-                    </div>
-                </details>
-            </nav>
-        </div>
-    </header>
-{% endblock %}
-
-{% block relbar1 %}{% endblock %}
-{% block relbar2 %}{% endblock %}
-
-{% block content %}
-    <div class="docs-layout{% if not render_sidebar %} no-sidebar{% endif %}">
-        {% if render_sidebar %}
-            <aside class="docs-sidebar" aria-label="{{ _('Documentation navigation') }}">
-                <details class="docs-navigation" id="docs-navigation" open>
-                    <summary>{{ _('Documentation') }}</summary>
-                    <div class="sidebar-content">
-                        {% for sidebartemplate in sidebars %}
-                            {% include sidebartemplate %}
-                        {% endfor %}
-                    </div>
-                </details>
-            </aside>
-        {% endif %}
-        <main class="docs-content" id="main-content" tabindex="-1">
-            <div class="docs-location">
-                <nav aria-label="{{ _('Breadcrumbs') }}">
-                    <a href="{{ pathto(docs_root)|e }}">{{ _('Documentation') }}</a>
-                    {% for parent in parents %}
-                        <span aria-hidden="true">/</span> <a href="{{ parent.link|e }}">{{ parent.title }}</a>
-                    {% endfor %}
-                    {% if pagename != docs_root %}<span aria-hidden="true">/</span> <span>{{ title|striptags|e }}</span>{% endif %}
-                </nav>
-                <span class="docs-version">{{ release|e }}</span>
-            </div>
-
-            {% block body %}{% endblock %}
-            {% if prev or next %}
-                <nav class="page-relations" aria-label="{{ _('Related pages') }}">
-                    <div>
-                        {% if prev %}<small>{{ _('Previous') }}</small><a href="{{ prev.link|e }}" rel="prev">{{ prev.title }}</a>{% endif %}
-                    </div>
-                    <div>
-                        {% if next %}<small>{{ _('Next') }}</small><a href="{{ next.link|e }}" rel="next">{{ next.title }}</a>{% endif %}
-                    </div>
-                </nav>
-            {% endif %}
-        </main>
-    </div>
-{% endblock %}
-
-{% block footer %}
-    <footer class="site-footer">
-        <div class="footer-grid">
-            <p class="footer-copy">{{ project|e }} {{ _('documentation') }} · {{ release|e }}</p>
-            <nav class="footer-links" aria-label="{{ _('Footer navigation') }}">
-                <a href="{{ pathto(docs_root)|e }}">{{ _('Contents') }}</a>
-                <a href="{{ zoite_atlas_url|e }}">{{ _('Atlas') }}</a>
-                {% if hasdoc('search') %}<a href="{{ pathto('search')|e }}">{{ _('Search') }}</a>{% endif %}
-                {% if hasdoc('genindex') %}<a href="{{ pathto('genindex')|e }}">{{ _('Index') }}</a>{% endif %}
-                <a href="#top">{{ _('Back to top') }}</a>
-            </nav>
-        </div>
-    </footer>
-{% endblock %}

docs/_theme/zoitechat/localtoc.html

@@ -1,7 +0,0 @@
-{# SPDX-License-Identifier: GPL-2.0-or-later #}
-{% if display_toc %}
-    <nav class="local-toc" aria-label="{{ _('On this page') }}">
-        <h2>{{ _('On this page') }}</h2>
-        {{ toc }}
-    </nav>
-{% endif %}

docs/_theme/zoitechat/searchbox.html

@@ -1,10 +0,0 @@
-{# SPDX-License-Identifier: GPL-2.0-or-later #}
-{% if pagename != "search" %}
-    <form class="docs-search" action="{{ pathto('search')|e }}" method="get" role="search">
-        <label for="docs-search-input">{{ _('Search documentation') }}</label>
-        <div class="search-inputs">
-            <input id="docs-search-input" type="search" name="q" placeholder="{{ _('Search documentation') }}" autocomplete="off" spellcheck="false">
-            <button type="submit">{{ _('Search') }}</button>
-        </div>
-    </form>
-{% endif %}

docs/_theme/zoitechat/theme.conf

@@ -1,7 +0,0 @@
-[theme]
-inherit = basic
-stylesheet = basic.css
-pygments_style = sphinx
-sidebars = searchbox.html, globaltoc.html, localtoc.html, sourcelink.html
-
-[options]

docs/conf.py

@@ -99,7 +99,7 @@ trim_footnote_reference_space = True
 
 # The theme to use for HTML and HTML Help pages.  See the documentation for
 # a list of builtin themes.
-html_theme = 'zoitechat'
+html_theme = 'basicstrap'
 
 # Theme options are theme-specific and customize the look and feel of a theme
 # further.  For a list of options available for each theme, see the
@@ -127,16 +127,13 @@ html_context = {
     'zoite_site_url': 'https://zoitechat.org/',
     'zoite_download_url': 'https://zoitechat.org/download.php',
     'zoite_addons_url': 'https://zoitechat.org/addons.php',
-    'zoite_announcements_url': 'https://zoitechat.org/announcements.php',
-    'zoite_github_url': 'https://github.com/ZoiteChat/zoitechat',
-    'zoite_atlas_url': 'https://atlas.zoitechat.org/',
     'zoite_irc_url': 'https://zoite.net/webchat/?join=%23zoitechat',
     'libera_irc_url': 'https://web.libera.chat/#zoitechat',
 }
 
 # The name of an image file (relative to this directory) to place at the top
 # of the sidebar.
-html_logo = '_static/zoitechat-logo.svg'
+html_logo = 'zoitechat-logo.svg'
 
 # The name of an image file (within the static path) to use as favicon of the
 # docs.  This file should be a Windows icon file (.ico) being 16x16 or 32x32
@@ -148,9 +145,8 @@ html_favicon = '_static/favicon.ico'
 # so a file named "default.css" will overwrite the builtin "default.css".
 html_static_path = ['_static']
 
-# Local, readable assets shared by hosted and offline HTML documentation.
-html_css_files = ['css/zoitechat-docs.css', 'css/zoitechat-site.css']
-html_js_files = ['js/zoitechat-docs.js']
+# Main-site visual skin for Read the Docs/Sphinx HTML output.
+html_css_files = ['css/zoitechat-docs.css']
 
 # If not '', a 'Last updated on:' timestamp is inserted at every page bottom,
 # using the given strftime format.

plugins/fishlim/plugin_zoitechat.c

@@ -710,7 +710,6 @@ static int handle_fishlim(char *word[], char *word_eol[], void *userdata) {
     gtk_box_pack_start(GTK_BOX(content), grid, TRUE, TRUE, 0);
 
     fishlim_target_entry = gtk_entry_new();
-    gtk_widget_set_hexpand(fishlim_target_entry, TRUE);
     if (target)
         gtk_entry_set_text(GTK_ENTRY(fishlim_target_entry), target);
     gtk_grid_attach(GTK_GRID(grid), gtk_label_new("Target nick or channel"), 0, 0, 1, 1);
@@ -761,7 +760,6 @@ static int handle_fishlim(char *word[], char *word_eol[], void *userdata) {
     g_signal_connect(view, "row-activated", G_CALLBACK(fishlim_gui_row_activated), NULL);
 
     scroll = gtk_scrolled_window_new(NULL, NULL);
-    gtk_widget_set_hexpand(scroll, TRUE);
     gtk_widget_set_vexpand(scroll, TRUE);
     gtk_container_add(GTK_CONTAINER(scroll), view);
     gtk_grid_attach(GTK_GRID(grid), scroll, 0, 6, 3, 1);

src/common/cfgfiles.c

@@ -430,6 +430,8 @@ const struct prefs vars[] =
 	{"gui_lang", P_OFFINT (hex_gui_lang), TYPE_INT},
 	{"gui_mode_buttons", P_OFFINT (hex_gui_mode_buttons), TYPE_BOOL},
 	{"gui_mode_buttons_inline", P_OFFINT (hex_gui_mode_buttons_inline), TYPE_BOOL},
+	{"gui_onboarding_disable", P_OFFINT (hex_gui_onboarding_disable), TYPE_BOOL},
+	{"gui_onboarding_pending", P_OFFINT (hex_gui_onboarding_pending), TYPE_BOOL},
 	{"gui_pane_divider_position", P_OFFINT (hex_gui_pane_divider_position), TYPE_INT},
 	{"gui_pane_left_size", P_OFFINT (hex_gui_pane_left_size), TYPE_INT},
 	{"gui_pane_right_size", P_OFFINT (hex_gui_pane_right_size), TYPE_INT},
@@ -590,7 +592,6 @@ const struct prefs vars[] =
 	{"gui_gtk3_theme", P_OFFSET (hex_gui_gtk3_theme), TYPE_STR},
 	{"text_indent", P_OFFINT (hex_text_indent), TYPE_BOOL},
 	{"text_max_indent", P_OFFINT (hex_text_max_indent), TYPE_INT},
-	{"text_wrap_align", P_OFFINT (hex_text_wrap_align), TYPE_INT},
 	{"text_max_lines", P_OFFINT (hex_text_max_lines), TYPE_INT},
 	{"text_replay", P_OFFINT (hex_text_replay), TYPE_BOOL},
 	{"text_search_case_match", P_OFFINT (hex_text_search_case_match), TYPE_BOOL},
@@ -882,7 +883,6 @@ load_default_config(void)
 	prefs.hex_net_reconnect_delay = 10;
 	prefs.hex_notify_timeout = 15;
 	prefs.hex_text_max_indent = 256;
-	prefs.hex_text_wrap_align = 0;
 	prefs.hex_text_max_lines = 5000;
 	prefs.hex_url_grabber_limit = 100; 		/* 0 means unlimited */
 

src/common/common.vcxproj

@@ -43,7 +43,6 @@
     <ClInclude Include="typedef.h" />
     <ClInclude Include="url.h" />
     <ClInclude Include="userlist.h" />
-    <ClInclude Include="hexcolor.h" />
     <ClInclude Include="util.h" />
     <ClInclude Include="zoitechat-plugin.h" />
     <ClInclude Include="zoitechat.h" />
@@ -80,7 +79,6 @@
     <ClCompile Include="tree.c" />
     <ClCompile Include="url.c" />
     <ClCompile Include="userlist.c" />
-    <ClCompile Include="hexcolor.c" />
     <ClCompile Include="util.c" />
     <ClCompile Include="zoitechat.c" />
     <ClCompile Include="theme-service.c" />

src/common/common.vcxproj.filters

@@ -98,9 +98,6 @@
     <ClInclude Include="userlist.h">
       <Filter>Header Files</Filter>
     </ClInclude>
-    <ClInclude Include="hexcolor.h">
-      <Filter>Header Files</Filter>
-    </ClInclude>
     <ClInclude Include="util.h">
       <Filter>Header Files</Filter>
     </ClInclude>
@@ -205,9 +202,6 @@
     <ClCompile Include="userlist.c">
       <Filter>Source Files</Filter>
     </ClCompile>
-    <ClCompile Include="hexcolor.c">
-      <Filter>Source Files</Filter>
-    </ClCompile>
     <ClCompile Include="util.c">
       <Filter>Source Files</Filter>
     </ClCompile>

src/common/hexcolor.c

@@ -1,42 +0,0 @@
-/* ZoiteChat
- * Parsing of \004 (hex color) formatting codes: RRGGBB[,RRGGBB].
- * Kept free of other application dependencies so the xtext widget tests can
- * compile it on its own.
- * Distributed under GPL-2.0-or-later; see COPYING. */
-
-#include "hexcolor.h"
-
-static int
-hexcolor_component (const char *s, int avail, guint32 *rgb)
-{
-	int i;
-	guint32 value = 0;
-
-	if (avail < 6)
-		return FALSE;
-	for (i = 0; i < 6; i++)
-	{
-		if (!g_ascii_isxdigit (s[i]))
-			return FALSE;
-		value = (value << 4) | g_ascii_xdigit_value (s[i]);
-	}
-	if (rgb)
-		*rgb = value;
-	return TRUE;
-}
-
-int
-hexcolor_parse (const char *s, int avail, guint32 *fg, guint32 *bg, int *has_bg)
-{
-	if (has_bg)
-		*has_bg = FALSE;
-	if (!hexcolor_component (s, avail, fg))
-		return 0;
-	if (avail >= 7 && s[6] == ',' && hexcolor_component (s + 7, avail - 7, bg))
-	{
-		if (has_bg)
-			*has_bg = TRUE;
-		return 13;
-	}
-	return 6;
-}

src/common/hexcolor.h

@@ -1,16 +0,0 @@
-/* ZoiteChat
- * Parsing of \004 (hex color) formatting codes: RRGGBB[,RRGGBB].
- * See https://modern.ircdocs.horse/formatting
- * Distributed under GPL-2.0-or-later; see COPYING. */
-
-#ifndef ZOITECHAT_HEXCOLOR_H
-#define ZOITECHAT_HEXCOLOR_H
-
-#include <glib.h>
-
-/* Parses the parameters following a \004 byte. Returns the number of bytes
- * consumed (6 or 13), or 0 if no valid RRGGBB follows. fg, bg and has_bg
- * may be NULL. */
-int hexcolor_parse (const char *s, int avail, guint32 *fg, guint32 *bg, int *has_bg);
-
-#endif

src/common/inbound.c

@@ -1880,51 +1880,38 @@ inbound_toggle_caps (server *serv, const char *extensions_str, gboolean enable)
 	char **extensions;
 	gsize i;
 
-	if (!extensions_str)
-		return;
-
 	extensions = g_strsplit (extensions_str, " ", 0);
 
 	for (i = 0; extensions[i]; i++)
 	{
 		const char *extension = extensions[i];
-		gboolean cap_enable = enable;
-
-		/* ACK prefixes disabled capabilities with '-', unlike CAP DEL. */
-		if (*extension == '-')
-		{
-			cap_enable = FALSE;
-			extension++;
-		}
 
 		if (!strcmp (extension, "solanum.chat/identify-msg"))
-			serv->have_idmsg = cap_enable;
+			serv->have_idmsg = enable;
 		else if (!strcmp (extension, "multi-prefix"))
-			serv->have_namesx = cap_enable;
+			serv->have_namesx = enable;
 		else if (!strcmp (extension, "account-notify"))
-			serv->have_accnotify = cap_enable;
+			serv->have_accnotify = enable;
 		else if (!strcmp (extension, "extended-join"))
-			serv->have_extjoin = cap_enable;
+			serv->have_extjoin = enable;
 		else if (!strcmp (extension, "userhost-in-names"))
-			serv->have_uhnames = cap_enable;
+			serv->have_uhnames = enable;
 		else if (!strcmp (extension, "server-time")
 				|| !strcmp (extension, "znc.in/server-time")
 				|| !strcmp (extension, "znc.in/server-time-iso"))
-			serv->have_server_time = cap_enable;
+			serv->have_server_time = enable;
 		else if (!strcmp (extension, "away-notify"))
-			serv->have_awaynotify = cap_enable;
+			serv->have_awaynotify = enable;
 		else if (!strcmp (extension, "account-tag"))
-			serv->have_account_tag = cap_enable;
+			serv->have_account_tag = enable;
 		else if (!strcmp (extension, "message-tags"))
-			serv->have_message_tags = cap_enable;
+			serv->have_message_tags = enable;
 		else if (!strcmp (extension, "echo-message"))
-			serv->have_echo_message = cap_enable;
+			serv->have_echo_message = enable;
 		else if (!strcmp (extension, "sasl"))
 		{
-			gboolean start_auth = cap_enable && !serv->have_sasl;
-
-			serv->have_sasl = cap_enable;
-			if (start_auth)
+			serv->have_sasl = enable;
+			if (enable)
 			{
 #ifdef USE_OPENSSL
 				if (serv->loginmethod == LOGIN_SASLEXTERNAL)
@@ -1975,15 +1962,10 @@ inbound_cap_ack (server *serv, char *nick, char *extensions,
 	inbound_toggle_caps (serv, extensions, TRUE);
 }
 
-static void inbound_request_new_caps (server *serv, const char *extensions_str,
-									 const message_tags_data *tags_data);
-
 void
 inbound_cap_new (server *serv, char *nick, char *extensions,
 					 const message_tags_data *tags_data)
 {
-	gboolean sts_upgrade_triggered = FALSE;
-
 	if (extensions)
 	{
 		char **tokens = g_strsplit (extensions, " ", 0);
@@ -1995,7 +1977,7 @@ inbound_cap_new (server *serv, char *nick, char *extensions,
 
 			if (!g_strcmp0 (parts[0], "sts") && parts[1] && parts[1][0])
 			{
-				sts_upgrade_triggered |= sts_handle_capability (serv, parts[1]);
+				sts_handle_capability (serv, parts[1]);
 			}
 
 			g_strfreev (parts);
@@ -2004,22 +1986,38 @@ inbound_cap_new (server *serv, char *nick, char *extensions,
 		g_strfreev (tokens);
 	}
 
-	EMIT_SIGNAL_TIMESTAMP (XP_TE_CAPLIST, serv->server_session, nick, extensions,
+	EMIT_SIGNAL_TIMESTAMP (XP_TE_CAPACK, serv->server_session, nick, extensions,
 								  NULL, NULL, 0, tags_data->timestamp);
 
-	/* NEW advertises availability; only ACK confirms an enabled capability. */
-	if (!sts_upgrade_triggered)
-		inbound_request_new_caps (serv, extensions, tags_data);
+	inbound_toggle_caps (serv, extensions, TRUE);
 }
 
 void
 inbound_cap_del (server *serv, char *nick, char *extensions,
 					 const message_tags_data *tags_data)
 {
+	if (extensions)
+	{
+		char **tokens = g_strsplit (extensions, " ", 0);
+		int i;
+
+		for (i = 0; tokens[i]; i++)
+		{
+			if (!g_strcmp0 (tokens[i], "sts") ||
+				g_str_has_prefix (tokens[i], "sts="))
+			{
+				/* STS cannot be disabled via CAP DEL. */
+				g_strfreev (tokens);
+				return;
+			}
+		}
+
+		g_strfreev (tokens);
+	}
+
 	EMIT_SIGNAL_TIMESTAMP (XP_TE_CAPDEL, serv->server_session, nick, extensions,
 								  NULL, NULL, 0, tags_data->timestamp);
 
-	/* STS has no toggle, but must not prevent other capabilities being removed. */
 	inbound_toggle_caps (serv, extensions, FALSE);
 }
 
@@ -2055,44 +2053,6 @@ static const char * const supported_caps[] = {
 	"solanum.chat/identify-msg",
 };
 
-static void
-inbound_request_new_caps (server *serv, const char *extensions_str,
-							 const message_tags_data *tags_data)
-{
-	char **extensions;
-	gsize i, x;
-
-	if (!extensions_str)
-		return;
-
-	extensions = g_strsplit (extensions_str, " ", 0);
-	for (i = 0; extensions[i]; i++)
-	{
-		char *value = strchr (extensions[i], '=');
-
-		if (value)
-			*value = '\0';
-	}
-
-	/* Request each supported capability once, keeping every IRC line bounded.
-	 * SASL is negotiated during login and is not in supported_caps. */
-	for (x = 0; x < G_N_ELEMENTS (supported_caps); x++)
-	{
-		for (i = 0; extensions[i]; i++)
-		{
-			if (!strcmp (extensions[i], supported_caps[x]))
-			{
-				EMIT_SIGNAL_TIMESTAMP (XP_TE_CAPREQ, serv->server_session,
-										  extensions[i], NULL, NULL, NULL, 0,
-										  tags_data->timestamp);
-				tcp_sendf (serv, "CAP REQ :%s\r\n", extensions[i]);
-				break;
-			}
-		}
-	}
-	g_strfreev (extensions);
-}
-
 static int
 get_supported_mech (server *serv, const char *list)
 {

src/common/meson.build

@@ -25,7 +25,6 @@ common_sources = [
   'tree.c',
   'url.c',
   'userlist.c',
-  'hexcolor.c',
   'util.c'
 ]
 
@@ -198,18 +197,3 @@ test('Emoji Data Tests', emoji_data_tests,
   protocol: 'tap',
   timeout: 120,
 )
-
-hexcolor_tests = executable('hexcolor_tests',
-  [
-    'tests/test-hexcolor.c',
-    'hexcolor.c',
-    'util.c',
-  ],
-  include_directories: [config_h_include, include_directories('.')],
-  dependencies: [libgio_dep] + (libssl_dep.found() ? [libssl_dep] : []),
-)
-
-test('Hex Color Tests', hexcolor_tests,
-  protocol: 'tap',
-  timeout: 120,
-)

src/common/servlist.c

@@ -191,6 +191,8 @@ struct defaultserver
 	gboolean ssl;
 };
 
+static gboolean servlist_needs_onboarding_flag;
+
 static const struct defaultserver def[] =
 {
 	{"2600net",	0},
@@ -1181,7 +1183,10 @@ servlist_load (void)
 
 	fp = zoitechat_fopen_file ("servlist.conf", "r", 0);
 	if (!fp)
+	{
+		servlist_needs_onboarding_flag = TRUE;
 		return FALSE;
+	}
 
 	while (fgets (buf, sizeof (buf) - 2, fp))
 	{
@@ -1245,6 +1250,7 @@ servlist_load (void)
 			net = servlist_net_add (buf + 2, NULL, FALSE);
 	}
 	fclose (fp);
+	servlist_needs_onboarding_flag = (network_list == NULL);
 
 	return TRUE;
 }
@@ -1253,8 +1259,16 @@ void
 servlist_init (void)
 {
 	if (!network_list)
-		if (!servlist_load ())
+	{
+		if (!servlist_load () || !network_list)
 			servlist_load_defaults ();
+	}
+}
+
+gboolean
+servlist_needs_onboarding (void)
+{
+	return servlist_needs_onboarding_flag;
 }
 
 /* check if a charset is known by Iconv */
@@ -1395,6 +1409,7 @@ servlist_save (void)
 	}
 
 	fclose (fp);
+	servlist_needs_onboarding_flag = FALSE;
 	return TRUE;
 }
 

src/common/servlist.h

@@ -93,6 +93,7 @@ extern GSList *network_list;
 #define IRC_DEFAULT_CHARSET		"UTF-8 (Unicode)"
 
 void servlist_init (void);
+gboolean servlist_needs_onboarding (void);
 int servlist_save (void);
 int servlist_cycle (server *serv);
 void servlist_connect (session *sess, ircnet *net, gboolean join);

src/common/ssl.c

@@ -155,7 +155,7 @@ _SSL_get_cert_info (struct cert_info *cert_info, SSL * ssl)
 {
 	X509 *peer_cert;
 	const X509_PUBKEY *key;
-	ASN1_OBJECT *obj = NULL;
+	X509_ALGOR *algor = NULL;
 	EVP_PKEY *peer_pkey;
 	char notBefore[64];
 	char notAfter[64];
@@ -174,10 +174,10 @@ _SSL_get_cert_info (struct cert_info *cert_info, SSL * ssl)
 	broke_oneline (cert_info->issuer, cert_info->issuer_word);
 
 	key = X509_get_X509_PUBKEY(peer_cert);
-	if (!X509_PUBKEY_get0_param(&obj, NULL, NULL, NULL, key))
+	if (!X509_PUBKEY_get0_param(NULL, NULL, 0, &algor, key))
 		return 1;
 
-	alg = OBJ_obj2nid (obj);
+	alg = OBJ_obj2nid (algor->algorithm);
 #ifndef HAVE_X509_GET_SIGNATURE_NID
 	sign_alg = OBJ_obj2nid (peer_cert->sig_alg->algorithm);
 #else

src/common/tests/test-hexcolor.c

@@ -1,117 +0,0 @@
-/* ZoiteChat
- *
- * This program is free software; you can redistribute it and/or modify
- * it under the terms of the GNU General Public License as published by
- * the Free Software Foundation; either version 2 of the License, or
- * (at your option) any later version.
- *
- * This program is distributed in the hope that it will be useful,
- * but WITHOUT ANY WARRANTY; without even the implied warranty of
- * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
- * GNU General Public License for more details.
- *
- * You should have received a copy of the GNU General Public License
- * along with this program; if not, write to the Free Software
- * Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301, USA
- */
-
-#include <string.h>
-
-#include <glib.h>
-
-#include "../hexcolor.h"
-#include "../util.h"
-
-static void
-test_parse_foreground (void)
-{
-	guint32 fg = 0, bg = 0xDEAD;
-	int has_bg = TRUE;
-
-	g_assert_cmpint (hexcolor_parse ("FF8800text", 10, &fg, &bg, &has_bg), ==, 6);
-	g_assert_cmphex (fg, ==, 0xFF8800);
-	g_assert_false (has_bg);
-	g_assert_cmphex (bg, ==, 0xDEAD);
-}
-
-static void
-test_parse_foreground_and_background (void)
-{
-	guint32 fg = 0, bg = 0;
-	int has_bg = FALSE;
-
-	g_assert_cmpint (hexcolor_parse ("112233,a0b0c0x", 14, &fg, &bg, &has_bg), ==, 13);
-	g_assert_cmphex (fg, ==, 0x112233);
-	g_assert_cmphex (bg, ==, 0xA0B0C0);
-	g_assert_true (has_bg);
-}
-
-static void
-test_parse_bad_background_keeps_foreground (void)
-{
-	guint32 fg = 0;
-	int has_bg = TRUE;
-
-	/* ",12" is plain text after a valid foreground, not a background */
-	g_assert_cmpint (hexcolor_parse ("112233,12 hi", 12, &fg, NULL, &has_bg), ==, 6);
-	g_assert_cmphex (fg, ==, 0x112233);
-	g_assert_false (has_bg);
-}
-
-static void
-test_parse_bare (void)
-{
-	/* a bare \004 resets colors, like a bare \003 */
-	g_assert_cmpint (hexcolor_parse (" text", 5, NULL, NULL, NULL), ==, 0);
-	g_assert_cmpint (hexcolor_parse ("12345G", 6, NULL, NULL, NULL), ==, 0);
-	g_assert_cmpint (hexcolor_parse ("", 0, NULL, NULL, NULL), ==, 0);
-}
-
-static void
-test_parse_respects_length (void)
-{
-	g_assert_cmpint (hexcolor_parse ("FF8800", 5, NULL, NULL, NULL), ==, 0);
-	g_assert_cmpint (hexcolor_parse ("FF8800,112233", 12, NULL, NULL, NULL), ==, 6);
-}
-
-static void
-assert_stripped (const char *in, int flags, const char *expected)
-{
-	char out[128];
-
-	strip_color2 (in, -1, out, flags);
-	g_assert_cmpstr (out, ==, expected);
-}
-
-static void
-test_strip (void)
-{
-	assert_stripped ("\004FF8800alice\017: hi", STRIP_ALL, "alice: hi");
-	assert_stripped ("\004112233,445566bg", STRIP_ALL, "bg");
-	assert_stripped ("a\004 b", STRIP_ALL, "a b");
-	assert_stripped ("\004FF8800\00312x", STRIP_ALL, "x");
-	/* a trailing code with too few digits leaves the rest as text */
-	assert_stripped ("x\004FF88", STRIP_ALL, "xFF88");
-}
-
-static void
-test_strip_keeps_hex_without_strip_color (void)
-{
-	assert_stripped ("\004FF8800red\002", STRIP_ATTRIB, "\004FF8800red");
-}
-
-int
-main (int argc, char *argv[])
-{
-	g_test_init (&argc, &argv, NULL);
-
-	g_test_add_func ("/hexcolor/parse/foreground", test_parse_foreground);
-	g_test_add_func ("/hexcolor/parse/foreground-and-background", test_parse_foreground_and_background);
-	g_test_add_func ("/hexcolor/parse/bad-background", test_parse_bad_background_keeps_foreground);
-	g_test_add_func ("/hexcolor/parse/bare", test_parse_bare);
-	g_test_add_func ("/hexcolor/parse/length", test_parse_respects_length);
-	g_test_add_func ("/hexcolor/strip/all", test_strip);
-	g_test_add_func ("/hexcolor/strip/attrib-only", test_strip_keeps_hex_without_strip_color);
-
-	return g_test_run ();
-}

src/common/util.c

@@ -47,7 +47,6 @@
 #include "zoitechatc.h"
 #include <ctype.h>
 #include "util.h"
-#include "hexcolor.h"
 
 #if defined (__FreeBSD__) || defined (__APPLE__)
 #include <sys/sysctl.h>
@@ -331,14 +330,6 @@ strip_color2 (const char *src, int len, char *dst, int flags)
 				if (!(flags & STRIP_COLOR)) goto pass_char;
 				rcol = 2;
 				break;
-			case '\004':			  /*ATTR_HEXCOLOR: */
-				if (!(flags & STRIP_COLOR)) goto pass_char;
-				{
-					int skip = hexcolor_parse (src + 1, len, NULL, NULL, NULL);
-					src += skip;
-					len -= skip;
-				}
-				break;
 			case HIDDEN_CHAR:	/* CL: invisible text (for event formats only) */	/* this takes care of the topic */
 				if (!(flags & STRIP_HIDDEN)) goto pass_char;
 				break;

src/common/zoitechat.h

@@ -134,6 +134,8 @@ struct zoitechatprefs
 	unsigned int hex_gui_join_dialog;
 	unsigned int hex_gui_mode_buttons;
 	unsigned int hex_gui_mode_buttons_inline;
+	unsigned int hex_gui_onboarding_disable;
+	unsigned int hex_gui_onboarding_pending;
 	unsigned int hex_gui_quit_dialog;
 	/* unsigned int hex_gui_single; */
 	unsigned int hex_gui_slist_fav;
@@ -306,7 +308,6 @@ struct zoitechatprefs
 	int hex_net_reconnect_delay;
 	int hex_notify_timeout;
 	int hex_text_max_indent;
-	int hex_text_wrap_align;
 	int hex_text_max_lines;
 	int hex_url_grabber_limit;
 

src/fe-gtk/ascii.c

@@ -138,7 +138,7 @@ ascii_open (void)
 		{
 			table_pos++;
 			hbox = gtk_box_new (GTK_ORIENTATION_HORIZONTAL, 0);
-			gtk_box_pack_start (GTK_BOX (vbox), hbox, TRUE, TRUE, 0);
+			gtk_container_add (GTK_CONTAINER (vbox), hbox);
 			gtk_widget_show (hbox);
 			i++;
 			continue;
@@ -155,14 +155,14 @@ ascii_open (void)
 								G_CALLBACK (ascii_click), NULL);
 		g_signal_connect (G_OBJECT (but), "enter-notify-event",
 								G_CALLBACK (ascii_enter), label);
-		gtk_box_pack_start (GTK_BOX (hbox), but, TRUE, TRUE, 0);
+		gtk_box_pack_start (GTK_BOX (hbox), but, 0, 0, 0);
 		gtk_widget_show (but);
 
 		table_pos += len;
 	}
 
 	frame = gtk_frame_new ("");
-	gtk_box_pack_start (GTK_BOX (hbox), frame, TRUE, TRUE, 0);
+	gtk_container_add (GTK_CONTAINER (hbox), frame);
 	gtk_container_add (GTK_CONTAINER (frame), label);
 	gtk_widget_show (label);
 	gtk_widget_show (frame);

src/fe-gtk/fkeys.c

@@ -1221,7 +1221,7 @@ key_dialog_load (GtkListStore *store)
 void
 key_dialog_show ()
 {
-	GtkWidget *vbox, *box, *pane, *scroll;
+	GtkWidget *vbox, *box;
 	GtkWidget *view, *xtext, *delete_button;
 	GtkListStore *store;
 	XTextColor xtext_palette[XTEXT_COLS];
@@ -1237,20 +1237,10 @@ key_dialog_show ()
 	key_dialog = mg_create_generic_tab ("editkeys", buf, TRUE, FALSE, key_dialog_close,
 									NULL, 600, 360, &vbox, 0);
 
-	pane = gtk_paned_new (GTK_ORIENTATION_VERTICAL);
-	gtk_box_pack_start (GTK_BOX (vbox), pane, TRUE, TRUE, 0);
-	box = gtkutil_box_new (GTK_ORIENTATION_VERTICAL, FALSE, 0);
-	gtk_paned_pack1 (GTK_PANED (pane), box, TRUE, FALSE);
-	view = key_dialog_treeview_new (box);
-	scroll = gtk_scrolled_window_new (NULL, NULL);
-	gtk_scrolled_window_set_policy (GTK_SCROLLED_WINDOW (scroll),
-	                                GTK_POLICY_NEVER, GTK_POLICY_AUTOMATIC);
-	gtk_scrolled_window_set_min_content_height (GTK_SCROLLED_WINDOW (scroll), 80);
-	gtk_paned_pack2 (GTK_PANED (pane), scroll, TRUE, FALSE);
-	gtk_paned_set_position (GTK_PANED (pane), 220);
+	view = key_dialog_treeview_new (vbox);
 	theme_get_xtext_colors (xtext_palette, XTEXT_COLS);
 	xtext = gtk_xtext_new (xtext_palette, 0);
-	gtk_container_add (GTK_CONTAINER (scroll), xtext);
+	gtk_box_pack_start (GTK_BOX (vbox), xtext, FALSE, TRUE, 2);
 	gtk_xtext_set_font (GTK_XTEXT (xtext), prefs.hex_text_font);
 
 	g_object_set_data (G_OBJECT (key_dialog), "view", view);

src/fe-gtk/gtkutil.c

@@ -641,8 +641,9 @@ gtkutil_get_str (char *msg, char *def, void *callback, void *userdata, gboolean
 	if (parent_window && GTK_IS_WINDOW (parent_window))
 		gtk_window_set_transient_for (GTK_WINDOW (dialog), GTK_WINDOW (parent_window));
 	gtkutil_place_dialog (dialog);
+	gtk_box_set_homogeneous (GTK_BOX (gtk_dialog_get_content_area (GTK_DIALOG (dialog))), TRUE);
 
-	hbox = gtkutil_box_new (GTK_ORIENTATION_HORIZONTAL, FALSE, 6);
+	hbox = gtkutil_box_new (GTK_ORIENTATION_HORIZONTAL, TRUE, 0);
 
 	g_object_set_data (G_OBJECT (dialog), "cb", callback);
 	g_object_set_data (G_OBJECT (dialog), "ud", userdata);
@@ -652,8 +653,7 @@ gtkutil_get_str (char *msg, char *def, void *callback, void *userdata, gboolean
 						 	G_CALLBACK (gtkutil_str_enter), dialog);
 	gtk_entry_set_text (GTK_ENTRY (entry), def ? def : "");
 	gtk_entry_set_visibility (GTK_ENTRY (entry), visible);
-	gtk_widget_set_valign (entry, GTK_ALIGN_CENTER);
-	gtk_box_pack_end (GTK_BOX (hbox), entry, TRUE, TRUE, 0);
+	gtk_box_pack_end (GTK_BOX (hbox), entry, 0, 0, 0);
 
 	label = gtk_label_new (msg);
 	gtk_box_pack_end (GTK_BOX (hbox), label, 0, 0, 0);
@@ -661,8 +661,7 @@ gtkutil_get_str (char *msg, char *def, void *callback, void *userdata, gboolean
 	g_signal_connect (G_OBJECT (dialog), "response",
 						   G_CALLBACK (gtkutil_get_str_response), entry);
 
-	gtk_box_pack_start (GTK_BOX (gtk_dialog_get_content_area (GTK_DIALOG (dialog))),
-	                    hbox, TRUE, TRUE, 0);
+	gtk_container_add (GTK_CONTAINER (gtk_dialog_get_content_area (GTK_DIALOG (dialog))), hbox);
 
 	gtk_widget_show_all (dialog);
 }
@@ -743,8 +742,9 @@ fe_get_int (char *msg, int def, void *callback, void *userdata)
 	if (parent_window && GTK_IS_WINDOW (parent_window))
 		gtk_window_set_transient_for (GTK_WINDOW (dialog), GTK_WINDOW (parent_window));
 	gtkutil_place_dialog (dialog);
+	gtk_box_set_homogeneous (GTK_BOX (gtk_dialog_get_content_area (GTK_DIALOG (dialog))), TRUE);
 
-	hbox = gtkutil_box_new (GTK_ORIENTATION_HORIZONTAL, FALSE, 6);
+	hbox = gtkutil_box_new (GTK_ORIENTATION_HORIZONTAL, TRUE, 0);
 
 	g_object_set_data (G_OBJECT (dialog), "cb", callback);
 	g_object_set_data (G_OBJECT (dialog), "ud", userdata);
@@ -755,8 +755,7 @@ fe_get_int (char *msg, int def, void *callback, void *userdata)
 	gtk_adjustment_set_upper (adj, 1024);
 	gtk_adjustment_set_step_increment (adj, 1);
 	gtk_spin_button_set_value ((GtkSpinButton*)spin, def);
-	gtk_widget_set_valign (spin, GTK_ALIGN_CENTER);
-	gtk_box_pack_end (GTK_BOX (hbox), spin, TRUE, TRUE, 0);
+	gtk_box_pack_end (GTK_BOX (hbox), spin, 0, 0, 0);
 
 	label = gtk_label_new (msg);
 	gtk_box_pack_end (GTK_BOX (hbox), label, 0, 0, 0);
@@ -764,8 +763,7 @@ fe_get_int (char *msg, int def, void *callback, void *userdata)
 	g_signal_connect (G_OBJECT (dialog), "response",
 						   G_CALLBACK (gtkutil_get_number_response), spin);
 
-	gtk_box_pack_start (GTK_BOX (gtk_dialog_get_content_area (GTK_DIALOG (dialog))),
-	                    hbox, TRUE, TRUE, 0);
+	gtk_container_add (GTK_CONTAINER (gtk_dialog_get_content_area (GTK_DIALOG (dialog))), hbox);
 
 	gtk_widget_show_all (dialog);
 }
@@ -785,18 +783,17 @@ fe_get_bool (char *title, char *prompt, void *callback, void *userdata)
 	if (parent_window && GTK_IS_WINDOW (parent_window))
 		gtk_window_set_transient_for (GTK_WINDOW (dialog), GTK_WINDOW (parent_window));
 	gtkutil_place_dialog (dialog);
+	gtk_box_set_homogeneous (GTK_BOX (gtk_dialog_get_content_area (GTK_DIALOG (dialog))), TRUE);
 
 	g_object_set_data (G_OBJECT (dialog), "cb", callback);
 	g_object_set_data (G_OBJECT (dialog), "ud", userdata);
 
 	prompt_label = gtk_label_new (prompt);
-	gtk_label_set_line_wrap (GTK_LABEL (prompt_label), TRUE);
 
 	g_signal_connect (G_OBJECT (dialog), "response",
 		G_CALLBACK (gtkutil_get_bool_response), NULL);
 
-	gtk_box_pack_start (GTK_BOX (gtk_dialog_get_content_area (GTK_DIALOG (dialog))),
-	                    prompt_label, TRUE, TRUE, 0);
+	gtk_container_add (GTK_CONTAINER (gtk_dialog_get_content_area (GTK_DIALOG (dialog))), prompt_label);
 
 	gtk_widget_show_all (dialog);
 }
@@ -888,10 +885,7 @@ gtkutil_window_new (char *title, char *role, int width, int height, int flags)
 	gtk_window_set_wmclass (GTK_WINDOW (win), "ZoiteChat", "zoitechat");
 #endif
 	gtk_window_set_title (GTK_WINDOW (win), title);
-	/* Zero means content-sized to callers; GTK requires -1 for that. */
-	gtk_window_set_default_size (GTK_WINDOW (win),
-	                             width > 0 ? width : -1,
-	                             height > 0 ? height : -1);
+	gtk_window_set_default_size (GTK_WINDOW (win), width, height);
 	gtk_window_set_role (GTK_WINDOW (win), role);
 	if (flags & 1)
 		gtk_window_set_position (GTK_WINDOW (win), GTK_WIN_POS_MOUSE);

src/fe-gtk/inline-image.c

@@ -1848,33 +1848,10 @@ image_viewer_button_press (GtkWidget *widget, GdkEventButton *event,
 	return TRUE;
 }
 
-static gboolean
-image_viewer_draw (GtkWidget *widget, cairo_t *cr, gpointer data)
-{
-	GdkPixbuf *pixbuf = data;
-	int width = gdk_pixbuf_get_width (pixbuf);
-	int height = gdk_pixbuf_get_height (pixbuf);
-	int available_width = gtk_widget_get_allocated_width (widget);
-	int available_height = gtk_widget_get_allocated_height (widget);
-	double scale = MIN ((double) available_width / width,
-	                    (double) available_height / height);
-
-	/* Draw from the original so repeated resizing never degrades the image. */
-	cairo_save (cr);
-	cairo_translate (cr, (available_width - width * scale) / 2,
-	                 (available_height - height * scale) / 2);
-	cairo_scale (cr, scale, scale);
-	gdk_cairo_set_source_pixbuf (cr, pixbuf, 0, 0);
-	cairo_pattern_set_filter (cairo_get_source (cr), CAIRO_FILTER_BILINEAR);
-	cairo_paint (cr);
-	cairo_restore (cr);
-	return FALSE;
-}
-
 void
 inline_image_show_viewer (GtkXText *xtext, textentry *ent)
 {
-	GdkPixbuf *pixbuf;
+	GdkPixbuf *pixbuf, *scaled = NULL;
 	GtkWidget *window, *eventbox, *image, *toplevel;
 	const char *url;
 	int width, height, max_width = 1280, max_height = 960;
@@ -1908,15 +1885,18 @@ inline_image_show_viewer (GtkXText *xtext, textentry *ent)
 		double scale = MIN ((double) max_width / width,
 								  (double) max_height / height);
 
-		width = MAX (1, (int) (width * scale));
-		height = MAX (1, (int) (height * scale));
+		scaled = gdk_pixbuf_scale_simple (pixbuf,
+			MAX (1, (int) (width * scale)), MAX (1, (int) (height * scale)),
+			GDK_INTERP_BILINEAR);
+		if (scaled)
+			pixbuf = scaled;
 	}
 
 	window = gtk_window_new (GTK_WINDOW_TOPLEVEL);
 	url = gtk_xtext_entry_get_image_url (xtext, ent);
 	gtk_window_set_title (GTK_WINDOW (window), url ? url : _("Image"));
 	gtk_window_set_type_hint (GTK_WINDOW (window), GDK_WINDOW_TYPE_HINT_DIALOG);
-	gtk_window_set_default_size (GTK_WINDOW (window), width, height);
+	gtk_window_set_resizable (GTK_WINDOW (window), FALSE);
 
 	toplevel = gtk_widget_get_toplevel (GTK_WIDGET (xtext));
 	if (GTK_IS_WINDOW (toplevel))
@@ -1928,10 +1908,7 @@ inline_image_show_viewer (GtkXText *xtext, textentry *ent)
 	}
 
 	eventbox = gtk_event_box_new ();
-	image = gtk_drawing_area_new ();
-	g_object_set_data_full (G_OBJECT (image), "zoitechat-viewer-image",
-	                        g_object_ref (pixbuf), g_object_unref);
-	g_signal_connect (G_OBJECT (image), "draw", G_CALLBACK (image_viewer_draw), pixbuf);
+	image = gtk_image_new_from_pixbuf (pixbuf);
 	gtk_container_add (GTK_CONTAINER (eventbox), image);
 	gtk_container_add (GTK_CONTAINER (window), eventbox);
 
@@ -1941,4 +1918,7 @@ inline_image_show_viewer (GtkXText *xtext, textentry *ent)
 							G_CALLBACK (image_viewer_button_press), window);
 
 	gtk_widget_show_all (window);
+
+	if (scaled)
+		g_object_unref (scaled);
 }

src/fe-gtk/joind.c

@@ -137,6 +137,7 @@ joind_show_dialog (server *serv)
 	gtk_window_set_position (GTK_WINDOW (dialog1), GTK_WIN_POS_CENTER_ON_PARENT);
 	gtk_window_set_transient_for (GTK_WINDOW(dialog1), GTK_WINDOW(serv->front_session->gui->window));
 	gtk_window_set_modal (GTK_WINDOW (dialog1), TRUE);
+	gtk_window_set_resizable (GTK_WINDOW (dialog1), FALSE);
 
 	dialog_vbox1 = gtk_dialog_get_content_area (GTK_DIALOG (dialog1));
 	gtk_widget_show (dialog_vbox1);

src/fe-gtk/maingui.c

@@ -2330,6 +2330,7 @@ mg_open_quit_dialog (gboolean minimize_button)
         gtk_container_set_border_width (GTK_CONTAINER (dialog), 6);
         gtk_window_set_title (GTK_WINDOW (dialog), _("Quit ZoiteChat?"));
         gtk_window_set_transient_for (GTK_WINDOW (dialog), GTK_WINDOW (parent_window));
+        gtk_window_set_resizable (GTK_WINDOW (dialog), FALSE);
 
         dialog_vbox1 = gtk_dialog_get_content_area (GTK_DIALOG (dialog));
         gtk_widget_show (dialog_vbox1);

src/fe-gtk/menu.c

@@ -1595,16 +1595,16 @@ menu_join (GtkWidget * wid, gpointer none)
 									NULL);
 	theme_manager_attach_window (dialog);
 	content_area = gtk_dialog_get_content_area (GTK_DIALOG (dialog));
+	gtk_box_set_homogeneous (GTK_BOX (content_area), TRUE);
 	gtk_window_set_position (GTK_WINDOW (dialog), GTK_WIN_POS_MOUSE);
-	hbox = gtkutil_box_new (GTK_ORIENTATION_HORIZONTAL, FALSE, 6);
+	hbox = gtkutil_box_new (GTK_ORIENTATION_HORIZONTAL, TRUE, 0);
 
 	entry = gtk_entry_new ();
 	gtk_editable_set_editable (GTK_EDITABLE (entry), FALSE);	/* avoid auto-selection */
 	gtk_entry_set_text (GTK_ENTRY (entry), "#");
 	g_signal_connect (G_OBJECT (entry), "activate",
 						 	G_CALLBACK (menu_join_entry_cb), dialog);
-	gtk_widget_set_valign (entry, GTK_ALIGN_CENTER);
-	gtk_box_pack_end (GTK_BOX (hbox), entry, TRUE, TRUE, 0);
+	gtk_box_pack_end (GTK_BOX (hbox), entry, 0, 0, 0);
 
 	label = gtk_label_new (_("Enter Channel to Join:"));
 	gtk_box_pack_end (GTK_BOX (hbox), label, 0, 0, 0);
@@ -1612,7 +1612,7 @@ menu_join (GtkWidget * wid, gpointer none)
 	g_signal_connect (G_OBJECT (dialog), "response",
 						   G_CALLBACK (menu_join_cb), entry);
 
-	gtk_box_pack_start (GTK_BOX (content_area), hbox, TRUE, TRUE, 0);
+	gtk_container_add (GTK_CONTAINER (content_area), hbox);
 
 	gtk_widget_show_all (dialog);
 

src/fe-gtk/meson.build

@@ -95,6 +95,7 @@ zoitechat_gtk_ldflags = []
 if host_machine.system() == 'windows'
   zoitechat_gtk_sources += 'notifications/notification-windows.c'
   zoitechat_gtk_deps += cc.find_library('dwmapi', required: true)
+  zoitechat_gtk_deps += cc.find_library('winhttp', required: true)
   zoitechat_theme_deps += cc.find_library('dwmapi', required: true)
 
 else
@@ -278,10 +279,3 @@ test('Emoji Font Tests', emoji_font_tests,
   protocol: 'tap',
   timeout: 120,
 )
-
-xtext_tests = executable('xtext_tests',
-  ['tests/test-xtext.c', '../common/hexcolor.c'],
-  include_directories: [config_h_include],
-  dependencies: [gtk_dep],
-)
-test('XText Tests', xtext_tests, protocol: 'tap', timeout: 120)

src/fe-gtk/notifygui.c

@@ -391,39 +391,34 @@ fe_notify_ask (char *nick, char *networks)
 	gtk_container_set_border_width (GTK_CONTAINER (table), 12);
 	gtk_grid_set_row_spacing (GTK_GRID (table), 3);
 	gtk_grid_set_column_spacing (GTK_GRID (table), 8);
-	gtk_box_pack_start (GTK_BOX (gtk_dialog_get_content_area (GTK_DIALOG (dialog))),
-	                    table, TRUE, TRUE, 0);
+	gtk_container_add (GTK_CONTAINER (gtk_dialog_get_content_area (GTK_DIALOG (dialog))), table);
 
 	label = gtk_label_new (msg);
-	gtk_label_set_xalign (GTK_LABEL (label), 0.0f);
-	gtkutil_grid_attach (table, label, 0, 1, 0, 1, GTKUTIL_ATTACH_FILL, 0, 0, 0);
+	gtkutil_grid_attach_defaults (table, label, 0, 1, 0, 1);
 
 	entry = gtk_entry_new ();
 	gtk_entry_set_text (GTK_ENTRY (entry), nick);
 	g_signal_connect (G_OBJECT (entry), "activate",
 						 	G_CALLBACK (notifygui_add_enter), dialog);
-	gtkutil_grid_attach (table, entry, 1, 2, 0, 1,
-	                     GTKUTIL_ATTACH_EXPAND | GTKUTIL_ATTACH_FILL, 0, 0, 0);
+	gtkutil_grid_attach_defaults (table, entry, 1, 2, 0, 1);
 
 	g_signal_connect (G_OBJECT (dialog), "response",
 						   G_CALLBACK (notifygui_add_cb), entry);
 
 	label = gtk_label_new (_("Notify on these networks:"));
-	gtk_label_set_xalign (GTK_LABEL (label), 0.0f);
-	gtkutil_grid_attach (table, label, 0, 1, 2, 3, GTKUTIL_ATTACH_FILL, 0, 0, 0);
+	gtkutil_grid_attach_defaults (table, label, 0, 1, 2, 3);
 
 	wid = gtk_entry_new ();
 	g_object_set_data (G_OBJECT (entry), "net", wid);
 	g_signal_connect (G_OBJECT (wid), "activate",
 						 	G_CALLBACK (notifygui_add_enter), dialog);
 	gtk_entry_set_text (GTK_ENTRY (wid), networks ? networks : "ALL");
-	gtkutil_grid_attach (table, wid, 1, 2, 2, 3,
-	                     GTKUTIL_ATTACH_EXPAND | GTKUTIL_ATTACH_FILL, 0, 0, 0);
+	gtkutil_grid_attach_defaults (table, wid, 1, 2, 2, 3);
 
 	label = gtk_label_new (NULL);
 	g_snprintf (buf, sizeof (buf), "<i><span size=\"smaller\">%s</span></i>", _("Comma separated list of networks is accepted."));
 	gtk_label_set_markup (GTK_LABEL (label), buf);
-	gtkutil_grid_attach (table, label, 1, 2, 3, 4, GTKUTIL_ATTACH_FILL, 0, 0, 0);
+	gtkutil_grid_attach_defaults (table, label, 1, 2, 3, 4);
 
 	gtk_widget_show_all (dialog);
 }

src/fe-gtk/setup.c

@@ -59,8 +59,6 @@ static struct zoitechatprefs setup_prefs;
 static GtkWidget *cancel_button;
 static GtkWidget *font_dialog = NULL;
 static GtkWidget *setup_topicbar_multiline_toggle = NULL;
-static GtkWidget *setup_wrap_align_label = NULL;
-static GtkWidget *setup_wrap_align_combo = NULL;
 
 enum
 {
@@ -159,14 +157,6 @@ static const char *const langsmenu[] =
 };
 #endif
 
-static const char *const wrapalignmenu[] =
-{
-        N_("Start of line (default)"),
-        N_("Prefix (nick name)"),
-        N_("Message"),
-        NULL
-};
-
 static const setting appearance_settings[] =
 {
         {ST_HEADER,     N_("General"),0,0,0},
@@ -182,7 +172,6 @@ static const setting appearance_settings[] =
         {ST_TOGGLR, N_("Indent nick names"), P_OFFINTNL(hex_text_indent), N_("Make nick names right-justified"),0,0},
         {ST_TOGGLE, N_ ("Show marker line"), P_OFFINTNL (hex_text_show_marker), N_ ("Insert a red line after the last read text."), 0, 0},
         {ST_TOGGLE, N_("Keep search position when closing"), P_OFFINTNL(hex_text_search_keep_position), 0, 0, 0},
-        {ST_MENU,   N_("Align wrapped lines under:"), P_OFFINTNL(hex_text_wrap_align), N_("Where wrapped lines start when nick names are not indented"), wrapalignmenu, 0},
 
         {ST_HEADER,     N_("Timestamps"),0,0,0},
         {ST_TOGGLE, N_("Enable timestamps"), P_OFFINTNL(hex_stamp_text),0,0,1},
@@ -659,6 +648,9 @@ static const char *const proxyuse[] =
 
 static const setting network_settings[] =
 {
+        {ST_HEADER,     N_("Startup"), 0, 0, 0, 0},
+        {ST_TOGGLE,     N_("Disable first-run assistant"), P_OFFINTNL(hex_gui_onboarding_disable), 0, 0, 0},
+
         {ST_HEADER,     N_("Your Address"), 0, 0, 0, 0},
         {ST_ENTRY,      N_("Bind to:"), P_OFFSETNL(hex_net_bind_host), 0, 0, sizeof prefs.hex_net_bind_host},
         {ST_LABEL,      N_("Only useful for computers with multiple addresses.")},
@@ -868,20 +860,6 @@ setup_topicbar_inline_toggled_cb (GtkToggleButton *but, gpointer userdata)
                         !gtk_toggle_button_get_active (but));
 }
 
-static void
-setup_text_indent_toggled_cb (GtkToggleButton *but, gpointer userdata)
-{
-        gboolean sens = !gtk_toggle_button_get_active (but);
-
-        (void) userdata;
-
-        /* wrapped line alignment only applies without nick indentation */
-        if (setup_wrap_align_label)
-                gtk_widget_set_sensitive (setup_wrap_align_label, sens);
-        if (setup_wrap_align_combo)
-                gtk_widget_set_sensitive (setup_wrap_align_combo, sens);
-}
-
 static void
 setup_create_toggleR (GtkWidget *tab, int row, const setting *set)
 {
@@ -892,9 +870,6 @@ setup_create_toggleR (GtkWidget *tab, int row, const setting *set)
                                                                                         setup_get_int (&setup_prefs, set));
         g_signal_connect (G_OBJECT (wid), "toggled",
                                                         G_CALLBACK (setup_toggle_cb), (gpointer)set);
-        if (set->offset == STRUCT_OFFSET_INT (struct zoitechatprefs, hex_text_indent))
-                g_signal_connect (G_OBJECT (wid), "toggled",
-                                                        G_CALLBACK (setup_text_indent_toggled_cb), NULL);
         if (set->tooltip)
                 gtk_widget_set_tooltip_text (wid, _(set->tooltip));
         setup_table_attach (tab, wid, 4, 5, row, row + 1, TRUE, FALSE,
@@ -1284,7 +1259,7 @@ setup_create_id_menu (GtkWidget *table, char *label, int row, char *dest)
 static void
 setup_create_menu (GtkWidget *table, int row, const setting *set)
 {
-        GtkWidget *wid, *cbox;
+        GtkWidget *wid, *cbox, *box;
         const char **text = (const char **)set->list;
         int i;
 
@@ -1305,18 +1280,10 @@ setup_create_menu (GtkWidget *table, int row, const setting *set)
         g_signal_connect (G_OBJECT (cbox), "changed",
                                                         G_CALLBACK (setup_menu_cb), (gpointer)set);
 
-        setup_table_attach (table, cbox, 3, 6, row, row + 1, TRUE, FALSE,
+        box = gtkutil_box_new (GTK_ORIENTATION_HORIZONTAL, FALSE, 0);
+        gtk_box_pack_start (GTK_BOX (box), cbox, 0, 0, 0);
+        setup_table_attach (table, box, 3, 4, row, row + 1, TRUE, FALSE,
                             SETUP_ALIGN_FILL, SETUP_ALIGN_FILL, 0, 0);
-
-        if (set->offset == STRUCT_OFFSET_INT (struct zoitechatprefs, hex_text_wrap_align))
-        {
-                setup_wrap_align_label = wid;
-                setup_wrap_align_combo = cbox;
-                g_object_add_weak_pointer (G_OBJECT (wid), (gpointer *)&setup_wrap_align_label);
-                g_object_add_weak_pointer (G_OBJECT (cbox), (gpointer *)&setup_wrap_align_combo);
-                gtk_widget_set_sensitive (wid, !setup_prefs.hex_text_indent);
-                gtk_widget_set_sensitive (cbox, !setup_prefs.hex_text_indent);
-        }
 }
 
 static void
@@ -1999,8 +1966,7 @@ setup_add_page (const char *title, GtkWidget *book, GtkWidget *tab)
 
         sw = GTK_SCROLLED_WINDOW(gtk_scrolled_window_new (NULL, NULL));
         gtk_scrolled_window_set_shadow_type (sw, GTK_SHADOW_IN);
-        gtk_scrolled_window_set_policy (sw, GTK_POLICY_AUTOMATIC, GTK_POLICY_AUTOMATIC);
-        gtk_scrolled_window_set_propagate_natural_width (sw, TRUE);
+        gtk_scrolled_window_set_policy (sw, GTK_POLICY_NEVER, GTK_POLICY_AUTOMATIC);
         gtk_container_add (GTK_CONTAINER (sw), vvbox);
 
         viewport = gtk_bin_get_child (GTK_BIN(sw));
@@ -2044,9 +2010,7 @@ setup_ensure_page_created (int page)
         }
 
         page_widget = setup_page_factories[page] (setup_page_settings[page]);
-        /* Lazy pages must pass the notebook's spare space to their content,
-           particularly the independently scrolling Sounds list. */
-        gtk_box_pack_start (GTK_BOX (container), page_widget, TRUE, TRUE, 0);
+        gtk_container_add (GTK_CONTAINER (container), page_widget);
         gtk_widget_show_all (container);
 }
 
@@ -2224,14 +2188,9 @@ setup_create_tree (GtkWidget *box, GtkWidget *book)
                                                             -1, _("Categories"), renderer, "text", 0, NULL);
         gtk_tree_view_expand_all (GTK_TREE_VIEW (tree));
 
-        frame = gtk_scrolled_window_new (NULL, NULL);
-        gtk_scrolled_window_set_policy (GTK_SCROLLED_WINDOW (frame),
-                                       GTK_POLICY_NEVER, GTK_POLICY_AUTOMATIC);
-        gtk_scrolled_window_set_shadow_type (GTK_SCROLLED_WINDOW (frame), GTK_SHADOW_IN);
-        gtk_scrolled_window_set_propagate_natural_width (GTK_SCROLLED_WINDOW (frame), TRUE);
-        gtk_widget_set_vexpand (frame, TRUE);
+        frame = gtk_frame_new (NULL);
         gtk_container_add (GTK_CONTAINER (frame), tree);
-        gtk_box_pack_start (GTK_BOX (box), frame, FALSE, TRUE, 0);
+        gtk_box_pack_start (GTK_BOX (box), frame, 0, 0, 0);
         gtk_box_reorder_child (GTK_BOX (box), frame, 0);
 
         if (sel_iter)

src/fe-gtk/tests/test-xtext.c

@@ -1,597 +0,0 @@
-/* XText regression tests. Distributed under GPL-2.0-or-later; see COPYING.
- * Include the implementation to check layout/selection invariants without
- * adding test-only symbols to the widget's public API. Application services
- * are stubbed; GTK, Pango, Cairo and the widget itself are exercised normally. */
-#include "../xtext.c"
-#include <glib/gstdio.h>
-
-struct zoitechatprefs prefs;
-
-void emoji_font_apply (GtkWidget *widget) { }
-int url_last (int *start, int *end) { return 0; }
-gsize strftime_utf8 (char *dest, gsize size, const char *format, time_t stamp)
-{
-	return strftime (dest, size, format, localtime (&stamp));
-}
-int xtext_get_stamp_str (time_t stamp, char **out)
-{
-	*out = g_strdup ("[12:34] ");
-	return strlen (*out);
-}
-void theme_get_xtext_colors_for_widget (GtkWidget *widget, XTextColor *colors, size_t len)
-{
-	size_t i;
-	for (i = 0; i < len; i++)
-	{
-		colors[i].red = colors[i].green = colors[i].blue = 0.0;
-		colors[i].alpha = 1.0;
-	}
-	colors[XTEXT_FG].red = colors[XTEXT_FG].green = colors[XTEXT_FG].blue = 1.0;
-	colors[XTEXT_MARK_BG].blue = 1.0;
-	colors[XTEXT_MARK_FG] = colors[XTEXT_FG];
-	colors[XTEXT_MARKER].red = 1.0;
-}
-
-typedef struct { GtkWidget *window; GtkXText *xtext; } Fixture;
-
-static void drain_events (void)
-{
-	while (g_main_context_iteration (NULL, FALSE)) { }
-}
-
-static void fixture_setup (Fixture *f, gconstpointer data)
-{
-	XTextColor colors[XTEXT_COLS];
-	GtkWidget *scrolled = gtk_scrolled_window_new (NULL, NULL);
-	theme_get_xtext_colors_for_widget (NULL, colors, G_N_ELEMENTS (colors));
-	f->window = gtk_window_new (GTK_WINDOW_TOPLEVEL);
-	gtk_window_set_default_size (GTK_WINDOW (f->window), 640, 360);
-	f->xtext = GTK_XTEXT (gtk_xtext_new (colors, TRUE));
-	g_object_ref (f->xtext);
-	gtk_container_add (GTK_CONTAINER (scrolled), GTK_WIDGET (f->xtext));
-	gtk_container_add (GTK_CONTAINER (f->window), scrolled);
-	g_assert_true (gtk_xtext_set_font (f->xtext, "monospace 12"));
-	gtk_widget_show_all (f->window);
-	drain_events ();
-}
-
-static void fixture_teardown (Fixture *f, gconstpointer data)
-{
-	gtk_widget_destroy (f->window);
-	g_object_unref (f->xtext);
-	drain_events ();
-	g_assert_null (image_pending_list);
-}
-
-static void append (Fixture *f, const char *text)
-{
-	gtk_xtext_append (f->xtext->buffer, (guchar *)text, -1, 1234);
-}
-
-static cairo_surface_t *snapshot (Fixture *f, gboolean partial)
-{
-	GtkWidget *widget = GTK_WIDGET (f->xtext);
-	int width = gtk_widget_get_allocated_width (widget);
-	int height = gtk_widget_get_allocated_height (widget);
-	cairo_surface_t *surface = cairo_image_surface_create (CAIRO_FORMAT_ARGB32, width, height);
-	cairo_t *cr = cairo_create (surface);
-	if (partial)
-	{
-		cairo_rectangle (cr, 0, f->xtext->fontsize, width, height - f->xtext->fontsize);
-		cairo_clip (cr);
-	}
-	gtk_widget_draw (widget, cr);
-	g_assert_cmpint (cairo_status (cr), ==, CAIRO_STATUS_SUCCESS);
-	cairo_destroy (cr);
-	cairo_surface_flush (surface);
-	return surface;
-}
-
-static void test_empty_and_bounded_append (Fixture *f, gconstpointer data)
-{
-	const guchar bytes[] = {'a', 'b', 'c'}; /* deliberately no terminating NUL */
-	append (f, "");
-	g_assert_cmpstr ((char *)f->xtext->buffer->text_last->str, ==, "");
-	g_assert_cmpint (f->xtext->buffer->text_last->subline_count, ==, 1);
-	append (f, "\n");
-	g_assert_cmpint (f->xtext->buffer->text_last->str_len, ==, 0);
-	gtk_xtext_append (f->xtext->buffer, (guchar *)bytes, sizeof (bytes), 1234);
-	g_assert_cmpstr ((char *)f->xtext->buffer->text_last->str, ==, "abc");
-	gtk_xtext_append_indent (f->xtext->buffer, (guchar *)"", 0, (guchar *)"", 0, 1234);
-	g_assert_cmpstr ((char *)f->xtext->buffer->text_last->str, ==, " ");
-}
-
-static void test_utf8_limits (Fixture *f, gconstpointer data)
-{
-	GString *text = g_string_new (NULL);
-	int i;
-	for (i = 0; i < 1500; i++) g_string_append (text, "猫");
-	gtk_xtext_append (f->xtext->buffer, (guchar *)text->str, text->len, 1234);
-	g_assert_cmpint (f->xtext->buffer->text_last->str_len, ==, 4095);
-	g_assert_true (g_utf8_validate ((char *)f->xtext->buffer->text_last->str, -1, NULL));
-	gtk_xtext_append_indent (f->xtext->buffer, (guchar *)text->str, text->len,
-		(guchar *)"猫", -1, 1234);
-	g_assert_cmpint (f->xtext->buffer->text_last->str_len, <=, 4095);
-	g_assert_true (g_utf8_validate ((char *)f->xtext->buffer->text_last->str, -1, NULL));
-	gtk_xtext_append (f->xtext->buffer, (guchar *)"hello 猫", 8, 1234);
-	g_assert_cmpstr ((char *)f->xtext->buffer->text_last->str, ==, "hello ");
-	gtk_xtext_append (f->xtext->buffer, (guchar *)"ok\xff" "bad", 6, 1234);
-	g_assert_cmpstr ((char *)f->xtext->buffer->text_last->str, ==, "ok");
-	g_string_free (text, TRUE);
-}
-
-static void test_null_empty_prefix (Fixture *f, gconstpointer data)
-{
-	xtext_buffer *buf = f->xtext->buffer;
-	/* PrintTextLine passes NULL/0 for indented server text without a tab. */
-	gtk_xtext_append_indent (buf, NULL, 0, (guchar *)"server notice", -1, 1234);
-	g_assert_cmpstr ((char *)buf->text_last->str, ==, " server notice");
-	g_assert_cmpint (buf->text_last->left_len, ==, 0);
-	g_assert_cmpint (buf->text_last->stamp, ==, 1234);
-	gtk_xtext_append_indent (buf, (guchar *)"nick", -1, NULL, 0, 1234);
-	g_assert_cmpstr ((char *)buf->text_last->str, ==, "nick ");
-	gtk_xtext_append_indent (buf, NULL, 0, NULL, 0, 1234);
-	g_assert_cmpstr ((char *)buf->text_last->str, ==, " ");
-	g_assert_cmpint (buf->num_lines, ==, 3);
-	cairo_surface_destroy (snapshot (f, FALSE));
-}
-
-static void test_wrapping (Fixture *f, gconstpointer data)
-{
-	xtext_buffer *buf = f->xtext->buffer;
-	textentry *ent;
-	int start = 0, i;
-	append (f, "猫猫猫猫猫猫猫猫猫猫");
-	ent = buf->text_last;
-	/* A character wider than the row must still be kept whole. */
-	buf->window_width = 3;
-	gtk_xtext_lines_taken (buf, ent);
-	g_assert_cmpint (ent->subline_count, ==, 10);
-	for (i = 0; i < ent->subline_count; i++)
-	{
-		int end = gtk_xtext_subline_end (ent, i);
-		g_assert_cmpint (end, >, start);
-		g_assert_true (g_utf8_validate ((char *)ent->str + start, end - start, NULL));
-		start = end;
-	}
-	buf->window_width = 120;
-	gtk_xtext_lines_taken (buf, ent);
-	g_assert_cmpint (ent->subline_count, >, 1);
-	buf->window_width = 640;
-	gtk_xtext_lines_taken (buf, ent);
-	g_assert_cmpint (ent->subline_count, ==, 1);
-}
-
-static void test_font_isolation (Fixture *f, gconstpointer data)
-{
-	Fixture second;
-	int original = gtk_xtext_text_width (f->xtext, (guchar *)"WWii hello", 10);
-	fixture_setup (&second, NULL);
-	g_assert_true (gtk_xtext_set_font (second.xtext, "sans 30"));
-	g_assert_cmpint (gtk_xtext_text_width (second.xtext, (guchar *)"WWii hello", 10), >, original);
-	g_assert_cmpint (gtk_xtext_text_width (f->xtext, (guchar *)"WWii hello", 10), ==, original);
-	fixture_teardown (&second, NULL);
-	g_assert_cmpint (gtk_xtext_text_width (f->xtext, (guchar *)"WWii hello", 10), ==, original);
-}
-
-static void test_wide_metrics (Fixture *f, gconstpointer data)
-{
-	char *text = g_strnfill (4000, 'W');
-	g_assert_true (gtk_xtext_set_font (f->xtext, "sans 40"));
-	append (f, text);
-	g_assert_cmpint (f->xtext->buffer->text_last->str_width, >, 65535);
-	g_assert_cmpint (f->xtext->buffer->text_last->subline_count, >, 1);
-	g_free (text);
-}
-
-static void test_formatting (Fixture *f, gconstpointer data)
-{
-	const char *formatted = "a\002bold\002 \035italic\035 \00304,02red\017 \037u\037 \036s\036 \026r\026";
-	char *plain;
-	GSList *runs = NULL;
-	int len;
-	plain = (char *)gtk_xtext_strip_color ((guchar *)formatted, strlen (formatted), NULL, &len, &runs, FALSE);
-	g_assert_cmpstr (plain, ==, "abold italic red u s r");
-	g_assert_cmpint (len, ==, strlen (plain));
-	g_assert_cmpint (((offlen_t *)runs->data)->off, ==, 0);
-	g_slist_free_full (runs, g_free);
-	g_free (plain);
-	plain = (char *)gtk_xtext_strip_color ((guchar *)"a\010secret\010b", 10, NULL, &len, NULL, TRUE);
-	g_assert_cmpstr (plain, ==, "ab");
-	g_free (plain);
-	append (f, formatted);
-	gtk_xtext_append_indent (f->xtext->buffer, (guchar *)"nick", -1, (guchar *)formatted, -1, 1234);
-	f->xtext->auto_indent = TRUE;
-	f->xtext->buffer->time_stamp = TRUE;
-	f->xtext->buffer->indent = 130;
-	gtk_xtext_recalc_widths (f->xtext->buffer, FALSE);
-	cairo_surface_destroy (snapshot (f, FALSE));
-	g_assert_cmpstr ((char *)f->xtext->buffer->text_last->str, ==,
-		"nick a\002bold\002 \035italic\035 \00304,02red\017 \037u\037 \036s\036 \026r\026");
-}
-
-static void select_entries (Fixture *f, textentry *start, textentry *end)
-{
-	textentry *ent;
-	for (ent = start; ent; ent = ent->next)
-	{
-		ent->mark_start = 0;
-		ent->mark_end = ent->str_len;
-		if (ent == end) break;
-	}
-	gtk_xtext_selection_render (f->xtext, start, end);
-	f->xtext->selection_buffer = f->xtext->buffer;
-}
-
-static void test_selection_and_clipboard (Fixture *f, gconstpointer data)
-{
-	char *selected;
-	int len;
-	append (f, "");
-	append (f, "\002bold\002 猫");
-	append (f, "last");
-	select_entries (f, f->xtext->buffer->text_first, f->xtext->buffer->text_last);
-	selected = gtk_xtext_selection_get_text (f->xtext, &len);
-	g_assert_cmpstr (selected, ==, "\nbold 猫\nlast");
-	g_assert_cmpint (len, ==, strlen (selected));
-	g_free (selected);
-	f->xtext->color_paste = TRUE;
-	f->xtext->mark_stamp = TRUE;
-	selected = gtk_xtext_selection_get_text (f->xtext, &len);
-	g_assert_cmpstr (selected, ==, "\n[12:34] \002bold\002 猫\n[12:34] last");
-	g_free (selected);
-	f->xtext->color_paste = f->xtext->mark_stamp = FALSE;
-	gtk_xtext_copy_selection (f->xtext);
-	selected = gtk_clipboard_wait_for_text (gtk_widget_get_clipboard (GTK_WIDGET (f->xtext), GDK_SELECTION_CLIPBOARD));
-	g_assert_cmpstr (selected, ==, "\nbold 猫\nlast");
-	g_free (selected);
-	selected = gtk_clipboard_wait_for_text (gtk_widget_get_clipboard (GTK_WIDGET (f->xtext), GDK_SELECTION_PRIMARY));
-	g_assert_cmpstr (selected, ==, "\nbold 猫\nlast");
-	g_free (selected);
-	gtk_xtext_unselect (f->xtext);
-	g_assert_false (gtk_xtext_is_selecting (f->xtext));
-}
-
-static void test_search (Fixture *f, gconstpointer data)
-{
-	GError *error = NULL;
-	textentry *first;
-	xtext_buffer *buf = f->xtext->buffer;
-	append (f, "one \002needle\002 then NEEDLE");
-	first = buf->text_last;
-	append (f, "second needle");
-	g_assert_true (gtk_xtext_search (f->xtext, "needle", highlight, &error) == first);
-	g_assert_no_error (error);
-	g_assert_cmpint (g_list_length (first->marks), ==, 2);
-	g_assert_true (gtk_xtext_search (f->xtext, "needle", highlight, &error) == first);
-	g_assert_true (gtk_xtext_search (f->xtext, "needle", highlight, &error) == buf->text_last);
-	gtk_xtext_search (f->xtext, "", 0, &error);
-	g_assert_null (buf->search_found);
-	g_assert_true (gtk_xtext_search (f->xtext, "needle", backward | case_match, &error) == buf->text_last);
-	gtk_xtext_search (f->xtext, "n[a-z]+", regexp | case_match, &error);
-	g_assert_no_error (error);
-	g_assert_nonnull (buf->search_re);
-	gtk_xtext_search (f->xtext, "[", regexp, &error);
-	g_assert_error (error, G_REGEX_ERROR, G_REGEX_ERROR_UNTERMINATED_CHARACTER_CLASS);
-	g_clear_error (&error);
-	/* A no-match search must also release its regex/text on clear. */
-	gtk_xtext_search (f->xtext, "nomatch", regexp, &error);
-	g_assert_null (buf->search_found);
-	gtk_xtext_clear (buf, 0);
-	g_assert_null (buf->search_re);
-	g_assert_null (buf->search_text);
-}
-
-static void test_follow_search (Fixture *f, gconstpointer data)
-{
-	xtext_buffer *buf = f->xtext->buffer;
-	append (f, "match first");
-	gtk_xtext_search (f->xtext, "match", 0, NULL);
-	append (f, "match second");
-	gtk_xtext_search (f->xtext, NULL, follow, NULL);
-	g_assert_cmpint (g_list_length (buf->search_found), ==, 2);
-	GList *current = buf->curmark;
-	gtk_xtext_search (f->xtext, NULL, 0, NULL);
-	gtk_xtext_search (f->xtext, NULL, follow, NULL);
-	g_assert_cmpint (g_list_length (buf->search_found), ==, 2);
-	g_assert_true (buf->curmark == current);
-	append (f, "match third");
-	g_assert_cmpint (g_list_length (buf->search_found), ==, 3);
-}
-
-static void test_search_unicode_offsets (Fixture *f, gconstpointer data)
-{
-	xtext_buffer *buf = f->xtext->buffer;
-	offsets_t mark;
-	append (f, "İ \002NEEDLE\002 Straße");
-	gtk_xtext_search (f->xtext, "needle", 0, NULL);
-	mark.u = GPOINTER_TO_UINT (buf->text_first->marks->data);
-	g_assert_cmpint (mark.o.start, ==, 4);
-	/* The established color-offset mapping includes the closing control. */
-	g_assert_cmpint (mark.o.end, ==, 11);
-	gtk_xtext_search (f->xtext, "ss", 0, NULL);
-	mark.u = GPOINTER_TO_UINT (buf->text_first->marks->data);
-	g_assert_cmpint (mark.o.start, ==, 16);
-	g_assert_cmpint (mark.o.end, ==, 18);
-	gtk_xtext_clear (buf, 0);
-	append (f, "ſ needle");
-	gtk_xtext_search (f->xtext, "needle", 0, NULL);
-	mark.u = GPOINTER_TO_UINT (buf->text_first->marks->data);
-	g_assert_cmpint (mark.o.start, ==, 3);
-	g_assert_cmpint (mark.o.end, ==, 9);
-}
-
-static void test_rawlog_hidden_text (Fixture *f, gconstpointer data)
-{
-	int hidden, visible;
-	append (f, "a\010secret\010b");
-	hidden = f->xtext->buffer->text_last->str_width;
-	f->xtext->ignore_hidden = TRUE;
-	gtk_xtext_recalc_widths (f->xtext->buffer, TRUE);
-	visible = f->xtext->buffer->text_last->str_width;
-	g_assert_cmpint (visible, >, hidden);
-	g_assert_cmpint (visible, ==, gtk_xtext_text_width (f->xtext, (guchar *)"asecretb", 8));
-}
-
-static void test_save (Fixture *f, gconstpointer data)
-{
-	char *path, *saved;
-	GError *error = NULL;
-	int fd = g_file_open_tmp ("zoitechat-xtext-XXXXXX", &path, &error);
-	g_assert_no_error (error);
-	append (f, "\002bold\002 猫");
-	append (f, "");
-	append (f, "last");
-	gtk_xtext_save (f->xtext, fd);
-	close (fd);
-	g_assert_true (g_file_get_contents (path, &saved, NULL, &error));
-	g_assert_no_error (error);
-	g_assert_cmpstr (saved, ==, "bold 猫\n\nlast\n");
-	g_free (saved);
-	g_unlink (path);
-	g_free (path);
-}
-
-static void test_scrollable_ownership (Fixture *f, gconstpointer data)
-{
-	GtkAdjustment *horizontal = GTK_ADJUSTMENT (gtk_adjustment_new (0, 0, 1, 1, 1, 1));
-	GtkAdjustment *vertical = GTK_ADJUSTMENT (gtk_adjustment_new (0, 0, 100, 1, 10, 10));
-	GtkAdjustment *old = g_object_ref (f->xtext->adj);
-	g_object_set (f->xtext, "hadjustment", horizontal, "vadjustment", vertical, NULL);
-	g_assert_false (g_object_is_floating (horizontal));
-	g_assert_false (g_object_is_floating (vertical));
-	g_assert_true (f->xtext->hadj == horizontal);
-	g_assert_true (f->xtext->adj == vertical);
-	/* A replaced adjustment must no longer call into the widget. */
-	g_assert_cmpuint (g_signal_handler_find (old, G_SIGNAL_MATCH_DATA, 0, 0, NULL, NULL, f->xtext), ==, 0);
-	g_signal_emit_by_name (f->xtext, "set-scroll-adjustments", horizontal, vertical);
-	g_assert_true (f->xtext->adj == vertical);
-	g_object_set (f->xtext, "hadjustment", NULL, "vadjustment", NULL, NULL);
-	g_assert_true (GTK_IS_ADJUSTMENT (f->xtext->hadj));
-	g_assert_true (GTK_IS_ADJUSTMENT (f->xtext->adj));
-	g_object_unref (old);
-}
-
-static void test_clear_and_marker (Fixture *f, gconstpointer data)
-{
-	xtext_buffer *buf = f->xtext->buffer;
-	append (f, "first"); append (f, "second"); append (f, "third");
-	buf->marker_pos = buf->text_first;
-	buf->marker_state = MARKER_IS_SET;
-	gtk_xtext_clear (buf, 1);
-	g_assert_cmpstr ((char *)buf->text_first->str, ==, "second");
-	g_assert_cmpint (buf->marker_state, ==, MARKER_RESET_BY_CLEAR);
-	gtk_xtext_clear (buf, -1);
-	g_assert_cmpstr ((char *)buf->text_last->str, ==, "second");
-	select_entries (f, buf->text_first, buf->text_last);
-	f->xtext->hilight_ent = buf->text_first;
-	gtk_xtext_clear (buf, 0);
-	g_assert_null (f->xtext->hilight_ent);
-	g_assert_null (buf->pagetop_ent);
-	g_assert_null (buf->last_ent_start);
-	g_assert_cmpint (buf->num_lines, ==, 0);
-	g_assert_true (gtk_xtext_is_empty (buf));
-	append (f, "after clear");
-	g_assert_cmpint (buf->num_lines, ==, 1);
-}
-
-static void test_scrollback_limit (Fixture *f, gconstpointer data)
-{
-	int i;
-	xtext_buffer *buf = f->xtext->buffer;
-	gtk_xtext_set_max_lines (f->xtext, 10);
-	for (i = 0; i < 100; i++) append (f, "line");
-	g_assert_cmpint (buf->num_lines, ==, 10);
-	g_assert_null (buf->text_first->prev);
-	g_assert_null (buf->text_last->next);
-	g_assert_cmpfloat (gtk_adjustment_get_value (f->xtext->adj), >=, 0);
-}
-
-static void test_follow_trim_oversized_entry (Fixture *f, gconstpointer data)
-{
-	char *long_text = g_strnfill (4000, 'W');
-	gtk_xtext_set_max_lines (f->xtext, 3);
-	append (f, "needle");
-	gtk_xtext_search (f->xtext, "W", follow, NULL);
-	gtk_xtext_clear (f->xtext->buffer, 1);
-	append (f, long_text);
-	g_assert_true (gtk_xtext_is_empty (f->xtext->buffer));
-	g_assert_null (f->xtext->buffer->search_found);
-	g_free (long_text);
-	append (f, "after oversized");
-	gtk_xtext_clear (f->xtext->buffer, G_MININT);
-	g_assert_true (gtk_xtext_is_empty (f->xtext->buffer));
-}
-
-static void test_stress (Fixture *f, gconstpointer data)
-{
-	static const char *tokens[] = {"text ", "猫", "😀", "\002bold\002", "\00304,02red\017", "\010hidden\010", "\037u\037", "\036s\036"};
-	GRand *random = g_rand_new_with_seed (0x78746578);
-	xtext_buffer *buf = f->xtext->buffer;
-	int i;
-	gtk_xtext_set_max_lines (f->xtext, 80);
-	for (i = 0; i < 2000; i++)
-	{
-		GString *text = g_string_new (NULL);
-		textentry *ent;
-		int j, lines = 0;
-		for (j = 0; j < 30; j++)
-			g_string_append (text, tokens[g_rand_int_range (random, 0, G_N_ELEMENTS (tokens))]);
-		if (i % 2)
-			gtk_xtext_append_indent (buf, (guchar *)"nick", -1, (guchar *)text->str, text->len, 1234);
-		else
-			gtk_xtext_append (buf, (guchar *)text->str, text->len, 1234);
-		g_string_free (text, TRUE);
-		if (i % 29 == 0) gtk_xtext_search (f->xtext, "text", follow | highlight, NULL);
-		if (i % 31 == 0) gtk_xtext_clear (buf, 1);
-		if (i % 37 == 0) gtk_xtext_clear (buf, -1);
-		if (i % 101 == 0) gtk_xtext_clear (buf, 0);
-		for (ent = buf->text_first; ent; ent = ent->next)
-		{
-			g_assert_true (g_utf8_validate ((char *)ent->str, ent->str_len, NULL));
-			g_assert_cmpint (ent->subline_count, >, 0);
-			lines += ent->subline_count;
-		}
-		g_assert_cmpint (buf->num_lines, ==, lines);
-		if (i % 43 == 0) cairo_surface_destroy (snapshot (f, FALSE));
-	}
-	g_rand_free (random);
-}
-
-static void test_buffers (Fixture *f, gconstpointer data)
-{
-	xtext_buffer *original = f->xtext->buffer;
-	xtext_buffer *second = gtk_xtext_buffer_new (f->xtext);
-	append (f, "original");
-	gtk_xtext_append (second, (guchar *)"alternate", -1, 1234);
-	gtk_xtext_buffer_show (f->xtext, second, TRUE);
-	g_assert_true (f->xtext->buffer == second);
-	cairo_surface_destroy (snapshot (f, FALSE));
-	gtk_xtext_buffer_show (f->xtext, original, TRUE);
-	g_assert_cmpstr ((char *)f->xtext->buffer->text_first->str, ==, "original");
-	gtk_xtext_buffer_free (second);
-}
-
-static void test_partial_draw_after_scroll (Fixture *f, gconstpointer data)
-{
-	cairo_surface_t *partial, *full;
-	int i, stride, height, y;
-	for (i = 0; i < 80; i++)
-	{
-		char *line = g_strdup_printf ("line %d — 猫 \002bold\002", i);
-		append (f, line);
-		g_free (line);
-	}
-	cairo_surface_destroy (snapshot (f, FALSE));
-	gtk_adjustment_set_value (f->xtext->adj, 12.5);
-	partial = snapshot (f, TRUE);
-	full = snapshot (f, FALSE);
-	stride = cairo_image_surface_get_stride (full);
-	height = cairo_image_surface_get_height (full);
-	for (y = f->xtext->fontsize; y < height; y++)
-		g_assert_cmpmem (cairo_image_surface_get_data (partial) + y * stride, stride,
-			cairo_image_surface_get_data (full) + y * stride, stride);
-	cairo_surface_destroy (partial);
-	cairo_surface_destroy (full);
-}
-
-static void test_image_lifecycle (Fixture *f, gconstpointer data)
-{
-	GdkPixbuf *image = gdk_pixbuf_new (GDK_COLORSPACE_RGB, TRUE, 8, 800, 600);
-	xtext_buffer *buf = f->xtext->buffer;
-	textentry *ent;
-	guint handle;
-	int before;
-	gdk_pixbuf_fill (image, 0xff0000ff);
-	append (f, "image");
-	ent = buf->text_last;
-	before = buf->num_lines;
-	handle = gtk_xtext_image_load_begin (f->xtext, ent, "https://example.invalid/image.png");
-	g_assert_cmpuint (handle, !=, 0);
-	g_assert_cmpuint (gtk_xtext_image_load_begin (f->xtext, ent, "duplicate"), ==, 0);
-	g_assert_true (gtk_xtext_image_load_finish (handle, image));
-	g_assert_cmpint (buf->num_lines, >, before);
-	g_assert_true (gtk_xtext_entry_has_image (f->xtext, ent));
-	g_assert_cmpint (gdk_pixbuf_get_width (ent->image), <=, XTEXT_IMAGE_MAX_WIDTH);
-	g_assert_true (gtk_xtext_entry_get_full_image (f->xtext, ent) == image);
-	cairo_surface_destroy (snapshot (f, FALSE));
-	g_assert_true (gtk_xtext_image_remove (f->xtext, ent));
-	g_assert_cmpint (buf->num_lines, ==, before);
-	handle = gtk_xtext_image_load_begin (f->xtext, ent, "late");
-	gtk_xtext_clear (buf, 0);
-	g_assert_false (gtk_xtext_image_load_finish (handle, image));
-	g_assert_false (gtk_xtext_entry_has_image (f->xtext, ent));
-	g_assert_null (gtk_xtext_entry_get_full_image (f->xtext, ent));
-	g_object_unref (image);
-}
-
-static void test_background (Fixture *f, gconstpointer data)
-{
-	cairo_surface_t *background = cairo_image_surface_create (CAIRO_FORMAT_ARGB32, 32, 32);
-	cairo_t *cr = cairo_create (background);
-	cairo_set_source_rgb (cr, 0.2, 0.3, 0.4);
-	cairo_paint (cr);
-	cairo_destroy (cr);
-	gtk_xtext_set_background (f->xtext, background);
-	cairo_surface_destroy (background);
-	gtk_xtext_set_background (f->xtext, f->xtext->background_surface);
-	append (f, "background text");
-	cairo_surface_destroy (snapshot (f, FALSE));
-	gtk_xtext_set_background (f->xtext, NULL);
-	cairo_surface_destroy (snapshot (f, FALSE));
-}
-
-static void test_destroy_pending_sources (Fixture *f, gconstpointer data)
-{
-	guint image;
-	append (f, "pending");
-	image = gtk_xtext_image_load_begin (f->xtext, f->xtext->buffer->text_last, "late");
-	f->xtext->io_tag = g_timeout_add (10000, gtk_xtext_adjustment_timeout, f->xtext);
-	f->xtext->add_io_tag = g_timeout_add (10000, gtk_xtext_render_page_timeout, f->xtext);
-	f->xtext->scroll_tag = g_timeout_add (10000, gtk_xtext_scrollup_timeout, f->xtext);
-	gtk_widget_destroy (f->window);
-	g_assert_cmpint (f->xtext->io_tag, ==, 0);
-	g_assert_cmpint (f->xtext->add_io_tag, ==, 0);
-	g_assert_cmpint (f->xtext->scroll_tag, ==, 0);
-	g_assert_false (gtk_xtext_image_load_finish (image, NULL));
-	/* GtkWidget destruction must be safe if GObject dispose runs again. */
-	g_object_run_dispose (G_OBJECT (f->xtext));
-	f->window = gtk_window_new (GTK_WINDOW_TOPLEVEL);
-}
-
-int main (int argc, char **argv)
-{
-	g_test_init (&argc, &argv, NULL);
-	if (!gtk_init_check (&argc, &argv))
-	{
-		g_test_message ("GTK display unavailable; run under Xvfb for widget coverage");
-		return 77;
-	}
-	prefs.hex_gui_mouse_scroll_speed = 10;
-#define ADD(name, function) g_test_add ("/xtext/" name, Fixture, NULL, fixture_setup, function, fixture_teardown)
-	ADD ("append/empty-bounded", test_empty_and_bounded_append);
-	ADD ("append/utf8-limits", test_utf8_limits);
-	ADD ("append/null-empty-prefix", test_null_empty_prefix);
-	ADD ("layout/wrapping", test_wrapping);
-	ADD ("layout/font-isolation", test_font_isolation);
-	ADD ("layout/wide-metrics", test_wide_metrics);
-	ADD ("render/formatting-timestamps", test_formatting);
-	ADD ("selection/clipboard", test_selection_and_clipboard);
-	ADD ("search/navigation-regex-clear", test_search);
-	ADD ("search/follow", test_follow_search);
-	ADD ("search/unicode-offsets", test_search_unicode_offsets);
-	ADD ("render/rawlog-hidden", test_rawlog_hidden_text);
-	ADD ("buffer/save", test_save);
-	ADD ("lifecycle/scrollable-ownership", test_scrollable_ownership);
-	ADD ("buffer/clear-marker", test_clear_and_marker);
-	ADD ("buffer/scrollback-limit", test_scrollback_limit);
-	ADD ("buffer/follow-trim-oversized", test_follow_trim_oversized_entry);
-	ADD ("buffer/stress", test_stress);
-	ADD ("buffer/switch", test_buffers);
-	ADD ("render/partial-scroll", test_partial_draw_after_scroll);
-	ADD ("images/lifecycle", test_image_lifecycle);
-	ADD ("render/background", test_background);
-	ADD ("lifecycle/pending-sources", test_destroy_pending_sources);
-#undef ADD
-	return g_test_run ();
-}

src/fe-gtk/textgui.c

@@ -92,7 +92,7 @@ PrintTextLine (xtext_buffer *xtbuf, unsigned char *text, int len, int indent, ti
 			memcpy (new_text, stamp, stamp_size);
 			g_free (stamp);
 			memcpy (new_text + stamp_size, text, len);
-			gtk_xtext_append_wrap (xtbuf, new_text, len + stamp_size, timet, stamp_size);
+			gtk_xtext_append (xtbuf, new_text, len + stamp_size, timet);
 			g_free (new_text);
 		} else
 			gtk_xtext_append (xtbuf, text, len, timet);
@@ -400,6 +400,7 @@ pevent_treeview_new (GtkWidget *box)
 	scroll = gtk_scrolled_window_new (NULL, NULL);
 	gtk_scrolled_window_set_policy (GTK_SCROLLED_WINDOW (scroll), GTK_POLICY_AUTOMATIC, GTK_POLICY_AUTOMATIC);
 	gtk_scrolled_window_set_shadow_type (GTK_SCROLLED_WINDOW (scroll), GTK_SHADOW_IN);
+	gtk_widget_set_size_request (GTK_WIDGET (scroll), -1, 250);
 
 	store = gtk_list_store_new (N_COLUMNS, G_TYPE_STRING, G_TYPE_STRING, G_TYPE_INT);
 	g_return_val_if_fail (store != NULL, NULL);
@@ -436,7 +437,7 @@ pevent_treeview_new (GtkWidget *box)
 	gtk_tree_view_column_set_min_width (col, 100);
 
 	gtk_container_add (GTK_CONTAINER (scroll), view);
-	gtk_paned_pack1 (GTK_PANED (box), scroll, TRUE, FALSE);
+	gtk_container_add (GTK_CONTAINER (box), scroll);
 
 	return view;
 }
@@ -480,7 +481,7 @@ pevent_hlist_treeview_new (GtkWidget *box)
 	gtk_tree_view_column_set_sizing (col, GTK_TREE_VIEW_COLUMN_AUTOSIZE);
 
 	gtk_container_add (GTK_CONTAINER (scroll), view);
-	gtk_paned_pack2 (GTK_PANED (box), scroll, TRUE, FALSE);
+	gtk_container_add (GTK_CONTAINER (box), scroll);
 
 	return view;
 }
@@ -488,7 +489,7 @@ pevent_hlist_treeview_new (GtkWidget *box)
 void
 pevent_dialog_show ()
 {
-	GtkWidget *vbox, *hbox, *wid, *pane, *preview_pane;
+	GtkWidget *vbox, *hbox, *wid, *pane;
 	XTextColor xtext_palette[XTEXT_COLS];
 
 	if (pevent_dialog)
@@ -502,12 +503,8 @@ pevent_dialog_show ()
 											 TRUE, FALSE, pevent_dialog_close, NULL,
 											 600, 455, &vbox, 0);
 
-	preview_pane = gtk_paned_new (GTK_ORIENTATION_VERTICAL);
-	gtk_box_pack_start (GTK_BOX (vbox), preview_pane, TRUE, TRUE, 0);
 	pane = gtk_paned_new (GTK_ORIENTATION_VERTICAL);
-	gtk_paned_pack1 (GTK_PANED (preview_pane), pane, TRUE, FALSE);
-	gtk_paned_set_position (GTK_PANED (pane), 220);
-	gtk_paned_set_position (GTK_PANED (preview_pane), 330);
+	gtk_box_pack_start (GTK_BOX (vbox), pane, TRUE, TRUE, 0);
 	
 	pevent_dialog_list = pevent_treeview_new (pane);
 	pevent_dialog_fill (pevent_dialog_list);
@@ -516,12 +513,12 @@ pevent_dialog_show ()
 
 	wid = gtk_scrolled_window_new (NULL, NULL);
 	gtk_scrolled_window_set_policy (GTK_SCROLLED_WINDOW (wid), GTK_POLICY_NEVER, GTK_POLICY_ALWAYS);
-	gtk_scrolled_window_set_min_content_height (GTK_SCROLLED_WINDOW (wid), 75);
-	gtk_paned_pack2 (GTK_PANED (preview_pane), wid, TRUE, FALSE);
+	gtk_box_pack_start (GTK_BOX (vbox), wid, FALSE, TRUE, 0);
 
 	theme_get_xtext_colors_for_widget (wid, xtext_palette, XTEXT_COLS);
 	pevent_dialog_twid = gtk_xtext_new (xtext_palette, 0);
 	gtk_widget_set_sensitive (pevent_dialog_twid, FALSE);
+	gtk_widget_set_size_request (pevent_dialog_twid, -1, 75);
 	gtk_container_add (GTK_CONTAINER (wid), pevent_dialog_twid);
 	gtk_xtext_set_font (GTK_XTEXT (pevent_dialog_twid), prefs.hex_text_font);
 	g_object_set_data (G_OBJECT (pevent_dialog), "xtext", pevent_dialog_twid);

src/fe-gtk/theme/theme-preferences.c

@@ -1911,7 +1911,6 @@ theme_preferences_create_page (GtkWindow *parent,
                                          G_TYPE_STRING,
                                          G_TYPE_INT);
         ui->gtk3_combo = gtk_combo_box_new_with_model (GTK_TREE_MODEL (gtk3_store));
-        gtk_widget_set_hexpand (ui->gtk3_combo, TRUE);
         g_object_unref (gtk3_store);
         renderer = gtk_cell_renderer_text_new ();
         gtk_cell_layout_pack_start (GTK_CELL_LAYOUT (ui->gtk3_combo), renderer, TRUE);

src/fe-gtk/xtext.h

@@ -38,7 +38,6 @@ GType gtk_xtext_get_type (void);
 
 #define ATTR_BOLD				'\002'
 #define ATTR_COLOR			'\003'
-#define ATTR_HEXCOLOR		'\004'
 #define ATTR_BLINK			'\006'
 #define ATTR_BEEP				'\007'
 #define ATTR_HIDDEN			'\010'
@@ -58,8 +57,6 @@ GType gtk_xtext_get_type (void);
 #define XTEXT_BG 102
 #define XTEXT_MARKER 103	/* for marker line */
 #define XTEXT_MAX_COLOR 98
-#define XTEXT_HEX_FG 200	/* not palette slots: colors from \004RRGGBB */
-#define XTEXT_HEX_BG 201
 typedef struct textentry textentry;
 
 /*
@@ -184,8 +181,6 @@ struct _GtkXText
 
 	int col_fore;
 	int col_back;
-	XTextColor hex_fg;
-	XTextColor hex_bg;
 
 	int depth;						  /* gdk window depth */
 
@@ -281,7 +276,6 @@ struct _GtkXTextClass
 
 GtkWidget *gtk_xtext_new (const XTextColor *palette, int separator);
 void gtk_xtext_append (xtext_buffer *buf, unsigned char *text, int len, time_t stamp);
-void gtk_xtext_append_wrap (xtext_buffer *buf, unsigned char *text, int len, time_t stamp, int stamp_len);
 void gtk_xtext_append_indent (xtext_buffer *buf,
 										unsigned char *left_text, int left_len,
 										unsigned char *right_text, int right_len,