deepend/zoitechat
1
0
Fork 0
mirror of https://github.com/ZoiteChat/zoitechat.git synced 2026-03-10 16:00:18 +00:00
Code Issues Packages Projects Releases Wiki Activity

Reviewed src/fe-gtk/plugingui.c and fixed several crash-prone assumptions in the plugin GUI code path that can surface on Windows during plugin load/unload lifecycle edges:

Browse Source 
Added type guards before using the stored plugin view/model (GTK_IS_TREE_VIEW, GTK_IS_LIST_STORE) so stale or unexpected object data doesn’t get dereferenced.
    Switched plugin list population to always pass non-null strings for name/version/description via plugingui_safe_string, preventing null string propagation into GTK model setters.
    Added an unload guard for empty/null modname before calling unload logic, preventing unsafe calls into plugin teardown paths with invalid identifiers.
This commit is contained in:
deepend
2026-02-15 15:57:19 -07:00
parent 3e59822753
commit 60c05710b1
1 changed files with 15 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

18
src/fe-gtk/plugingui.c
View File

@@ -168,7 +168,13 @@ fe_pluginlist_update (void)
return;
view = g_object_get_data (G_OBJECT (plugin_window), "view");
if (!GTK_IS_TREE_VIEW (view))
return;
store = GTK_LIST_STORE (gtk_tree_view_get_model (view));
if (!GTK_IS_LIST_STORE (store))
return;
gtk_list_store_clear (store);
list = plugin_list;
@@ -178,10 +184,10 @@ fe_pluginlist_update (void)
if (pl && pl->version && pl->version[0] != 0)
{
gtk_list_store_append (store, &iter);
gtk_list_store_set (store, &iter, NAME_COLUMN, pl->name,
VERSION_COLUMN, pl->version,
gtk_list_store_set (store, &iter, NAME_COLUMN, plugingui_safe_string (pl->name),
VERSION_COLUMN, plugingui_safe_string (pl->version),
FILE_COLUMN, pl->filename ? file_part (pl->filename) : "",
DESC_COLUMN, pl->desc,
DESC_COLUMN, plugingui_safe_string (pl->desc),
FILEPATH_COLUMN, plugingui_safe_string (pl->filename), -1);
}
list = list->next;
@@ -242,6 +248,12 @@ plugingui_unload (GtkWidget * wid, gpointer unused)
if (!gtkutil_treeview_get_selected (view, &iter, NAME_COLUMN, &modname,
FILEPATH_COLUMN, &file, -1))
return;
if (!modname || !*modname)
{
g_free (modname);
g_free (file);
return;
}
if (!file || !*file)
{
g_free (modname);