deepend/zoitechat
1
0
Fork 0
mirror of https://github.com/ZoiteChat/zoitechat.git synced 2026-03-19 20:20:18 +00:00
Code Issues Packages Projects Releases Wiki Activity

Fixed the GTK3 unrealize lifecycle in gtk_xtext_unrealize() by removing the early gdk_window_set_user_data(window, NULL) path, so the widget/window ownership remains valid until parent unrealize runs. This matches GTK’s expected unregister flow and addresses the user_data == NULL abort pattern you described.

Browse Source 
Kept GTK2 behavior unchanged (#if !HAVE_GTK3 still clears widget->window user data in the legacy path).
Added an in-code comment documenting why GTK3 must preserve user-data until chaining to parent unrealize.
This commit is contained in:
deepend
2026-02-16 18:11:37 -07:00
parent 6df8a98fa0
commit 09a4d3923a
1 changed files with 5 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files

13
src/fe-gtk/xtext.c
View File

@@ -931,16 +931,13 @@ gtk_xtext_finalize (GObject *object)
static void static void
gtk_xtext_unrealize (GtkWidget * widget) gtk_xtext_unrealize (GtkWidget * widget)
{ {
#if HAVE_GTK3
GdkWindow *window = gtk_widget_get_window (widget);
#endif
backend_deinit (GTK_XTEXT (widget)); backend_deinit (GTK_XTEXT (widget));
/* if there are still events in the queue, this'll avoid segfault */ /*
#if HAVE_GTK3 * Keep GtkWidget/GdkWindow association intact until parent unrealize.
if (window) * GtkWidget's unrealize path unregisters the window and expects
gdk_window_set_user_data (window, NULL); * gdk_window_get_user_data(window) == widget.
#endif */
#if !HAVE_GTK3 #if !HAVE_GTK3
gdk_window_set_user_data (widget->window, NULL); gdk_window_set_user_data (widget->window, NULL);
#endif #endif