funkpower/typikon
1
0
Fork 0
mirror of https://git.pumpin.online/funkpower/typikon.git synced 2026-10-23 03:07:12 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix a crash, a false changelog entry, and three things 1.0 would freeze

Browse Source 
Two adversarial reviews of the release. Both said do not ship, and they were
right twice over.

The seven-day view panicked. elide() cut a title at cut.len() / 2, a byte
index into a string it had counted in characters, and every movable feast
title carries an em dash: at fourteen terminal widths, 80 among them, it
aborted with exit 101 on the README's own headline command. tests/elide.rs now
cuts every title the program can print at every width it can be asked to print
at.

The changelog's first Calendar entry was false. It said a vigil or polyeleos
saint reaches fish in the three lesser fasts; the code gives wine and oil to
every rank but great, and caps the Dormition Fast at wine and oil whatever the
rank. A reader in the Dormition Fast was told this release let a saint bring
fish. docs/versioning.md makes that section a contract, so a wrong entry there
is worse than a wrong comment.

The Python bindings read the config file where the CLI reads the environment
first, so TYPIKON_JURISDICTION moved one and not the other and the two
answered for different churches on the same machine. CI now asserts they
agree, and runs the README example checker, which was standing between the
docs and reality with nothing running it.

Three changes to the surface, made now because after 1.0.0 they are a major
version: binds is null rather than the string none where a church legislates
no binding fast at all; iCalendar UIDs carry the tradition and the discipline,
which two feeds of the same day were sharing while saying different things;
and Date's Julian Day Number is behind an accessor rather than a public field.

fastLabel, emoji and reason are documented as presentation. The fields are
stable, the wording is not, and freezing three human-facing strings for a
major version was not the intent.
This commit is contained in:
funkpower
2026-09-18 13:46:57 -04:00
parent 7970f785c8
commit 83447db964
16 changed files with 259 additions and 47 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/rules/orthodox.rs
+11 -5
View File
@@ -8,11 +8,17 @@
//! life and a law, and the Eastern Catholic churches, which do have law about
//! this, are handled in their own module.
//!
//! A saint of vigil or polyeleos rank lifts the weekday discipline of a fast:
//! to wine and oil inside the Great Fast, as far as fish in the three lesser
//! fasts. That is why the printed calendars mark so many Wednesdays in the
//! Nativity Fast for wine and oil, and it is the rank in the menologion that
//! decides it.
//! A ranked saint lifts the weekday discipline of a fast, and how far depends
//! on both the rank and the season:
//!
//! | | Great Fast | Dormition | Nativity, Apostles |
//! |---|---|---|---|
//! | vigil or polyeleos | wine and oil | wine and oil | wine and oil |
//! | great feast | wine and oil | wine and oil | fish |
//!
//! No saint of any rank brings fish into the Great Fast or the Dormition Fast.
//! That is why the printed calendars mark so many Wednesdays in the Nativity
//! Fast for wine and oil, and it is the rank in the menologion that decides it.
//!
//! Where usages differ, this follows the common published rule and says so in
//! the reason. The known divergences: