mirror of
https://git.pumpin.online/funkpower/typikon.git
synced 2026-10-22 18:57:13 +00:00
fix a crash, a false changelog entry, and three things 1.0 would freeze
Two adversarial reviews of the release. Both said do not ship, and they were right twice over. The seven-day view panicked. elide() cut a title at cut.len() / 2, a byte index into a string it had counted in characters, and every movable feast title carries an em dash: at fourteen terminal widths, 80 among them, it aborted with exit 101 on the README's own headline command. tests/elide.rs now cuts every title the program can print at every width it can be asked to print at. The changelog's first Calendar entry was false. It said a vigil or polyeleos saint reaches fish in the three lesser fasts; the code gives wine and oil to every rank but great, and caps the Dormition Fast at wine and oil whatever the rank. A reader in the Dormition Fast was told this release let a saint bring fish. docs/versioning.md makes that section a contract, so a wrong entry there is worse than a wrong comment. The Python bindings read the config file where the CLI reads the environment first, so TYPIKON_JURISDICTION moved one and not the other and the two answered for different churches on the same machine. CI now asserts they agree, and runs the README example checker, which was standing between the docs and reality with nothing running it. Three changes to the surface, made now because after 1.0.0 they are a major version: binds is null rather than the string none where a church legislates no binding fast at all; iCalendar UIDs carry the tradition and the discipline, which two feeds of the same day were sharing while saying different things; and Date's Julian Day Number is behind an accessor rather than a public field. fastLabel, emoji and reason are documented as presentation. The fields are stable, the wording is not, and freezing three human-facing strings for a major version was not the intent.
This commit is contained in:
@@ -336,7 +336,7 @@ $ typikon -j rocor --date 2026-03-18 --json --indent 2
|
||||
"emoji": "🥬",
|
||||
"reason": "a weekday of the Great Fast",
|
||||
"obligation": "customary",
|
||||
"binds": "none",
|
||||
"binds": null,
|
||||
"pascha": "2026-04-12",
|
||||
"daysToPascha": 25,
|
||||
"julianOffset": 13
|
||||
@@ -443,6 +443,8 @@ It lands in `~/.local/share/typikon/` and is overlaid automatically.
|
||||
named years and its invariants across the two centuries from 1900, 146,000
|
||||
calendar round-trips from 1800 to 2200, the fast on every day that is not open
|
||||
to interpretation, and every jurisdiction over the twenty-one years from 2020.
|
||||
Every title the program can print is cut at every width it can be asked to
|
||||
print at, because that is where it once crashed.
|
||||
|
||||
It is a calendar, not an authority. If it disagrees with the one your parish
|
||||
prints, your parish is right. Please open an issue.
|
||||
|
||||
Reference in New Issue
Block a user