funkpower/catena
1
0
Fork 0
mirror of https://git.pumpin.online/funkpower/catena.git synced 2026-10-23 03:07:13 +00:00
Code Issues Packages Projects Releases Wiki Activity

release: bring binaryen ourselves

Browse Source 
wasm-pack downloads binaryen to get wasm-opt, and that download fails on this
runner while the same URL fetched with curl succeeds. wasm-pack uses a
wasm-opt already on PATH when it finds one, so the archive is fetched here
and put there.

Turning wasm-opt off instead would have been the smaller change and the
wrong one: the metadata in crates/bindings/Cargo.toml names the WebAssembly
features to keep the optimisation rather than skip it, and a release that
silently shipped an unoptimised module would be the first thing anyone
downloaded.
This commit is contained in:
funkpower
2026-09-21 08:30:11 -04:00
parent 699f7bfb1c
commit de6b103e7d
1 changed files with 11 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files
.forgejo/workflows/release.yml
+11
View File
@@ -85,6 +85,17 @@ jobs:
apt-get install -qq -y --no-install-recommends nodejs >/dev/null apt-get install -qq -y --no-install-recommends nodejs >/dev/null
npm install --global --silent npm@^11.15 npm install --global --silent npm@^11.15
curl -sSfL https://rustwasm.github.io/wasm-pack/installer/init.sh | sh curl -sSfL https://rustwasm.github.io/wasm-pack/installer/init.sh | sh
# wasm-pack fetches binaryen itself and that fetch dies on this
# runner, which is how the first release failed. It uses a wasm-opt
# already on PATH when it finds one, so fetch the same archive with
# curl — which works here — and let it find that instead. The
# version is the one wasm-pack asks for; a mismatch only means it
# would download its own again.
binaryen=version_117
curl -sSfL "https://github.com/WebAssembly/binaryen/releases/download/$binaryen/binaryen-$binaryen-x86_64-linux.tar.gz" \
| tar xz -C /tmp
export PATH="/tmp/binaryen-$binaryen/bin:$PATH"
wasm-opt --version
cd crates/bindings/npm cd crates/bindings/npm
# The declarations are hand-written, so nothing but a type checker # The declarations are hand-written, so nothing but a type checker
# would notice them going wrong. build.sh skips the check when tsc # would notice them going wrong. build.sh skips the check when tsc