From 314dfbbd7528b18e79005a41c0c19e7fec954460 Mon Sep 17 00:00:00 2001 From: deepend Date: Mon, 23 Feb 2026 16:11:41 -0700 Subject: [PATCH 1/2] =?UTF-8?q?Fixed=20highlight=20word=20parsing=20so=20U?= =?UTF-8?q?nicode=20symbols=20(including=20emoji=20like=20=F0=9F=90=9C)=20?= =?UTF-8?q?are=20treated=20as=20part=20of=20words=20when=20scanning=20inco?= =?UTF-8?q?ming=20text=20for=20alert=20matches,=20which=20enables=20/Extra?= =?UTF-8?q?=20words=20to=20highlight/=20entries=20containing=20emoji=20to?= =?UTF-8?q?=20work.?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Improved token scanning to use UTF-8-aware character classification (gunichar, g_unichar_isdigit, g_unichar_isalpha) instead of byte-only checks, avoiding split/mis-detection on multibyte characters. --- src/common/inbound.c | 21 ++++++++++++++++----- 1 file changed, 16 insertions(+), 5 deletions(-) diff --git a/src/common/inbound.c b/src/common/inbound.c index adbe6d34..10f5cbc5 100644 --- a/src/common/inbound.c +++ b/src/common/inbound.c @@ -258,6 +258,7 @@ alert_match_text (char *text, char *masks) { unsigned char *p = text; unsigned char endchar; + gunichar ch; int res; if (masks[0] == 0) @@ -265,26 +266,36 @@ alert_match_text (char *text, char *masks) while (1) { - if (*p >= '0' && *p <= '9') + ch = g_utf8_get_char (p); + + if (g_unichar_isdigit (ch) || g_unichar_isalpha (ch)) { - p++; + p += g_utf8_skip [p[0]]; continue; } /* if it's RFC1459 , it can be inside a word */ - switch (*p) + switch (ch) { case '-': case '[': case ']': case '\\': case '`': case '^': case '{': case '}': case '_': case '|': - p++; + p += g_utf8_skip [p[0]]; + continue; + } + + /* Symbols (including emoji) can be part of highlighted words. */ + if (!g_unichar_isspace (ch) && !g_unichar_ispunct (ch) && + !g_unichar_iscntrl (ch)) + { + p += g_utf8_skip [p[0]]; continue; } /* if it's a 0, space or comma, the word has ended. */ if (*p == 0 || *p == ' ' || *p == ',' || /* if it's anything BUT a letter, the word has ended. */ - (!g_unichar_isalpha (g_utf8_get_char (p)))) + (!g_unichar_isalpha (ch))) { endchar = *p; *p = 0; From b7804fd7ebb71f9ea9a5557be027f44a23876e74 Mon Sep 17 00:00:00 2001 From: deepend Date: Tue, 24 Feb 2026 08:35:23 -0700 Subject: [PATCH 2/2] Fixed the right-click nick info refresh flow in fe_userlist_update() so the submenu can keep updating after the first refresh when WHOIS-derived data is still incomplete. It now tracks a needs_refresh condition and reattaches the submenu show callback when required. This ensures user info can continue to refresh as data arrives instead of stopping after one update. --- src/fe-gtk/menu.c | 10 +++++++++- 1 file changed, 9 insertions(+), 1 deletion(-) diff --git a/src/fe-gtk/menu.c b/src/fe-gtk/menu.c index f48dbb55..b94d1762 100644 --- a/src/fe-gtk/menu.c +++ b/src/fe-gtk/menu.c @@ -778,6 +778,7 @@ fe_userlist_update (session *sess, struct User *user) { GList *items, *next; GList *iter; + gboolean needs_refresh; if (!nick_submenu || !str_copy) return; @@ -801,7 +802,14 @@ fe_userlist_update (session *sess, struct User *user) g_list_free (items); /* and re-create them with new info */ - menu_create_nickinfo_menu (user, nick_submenu); + needs_refresh = menu_create_nickinfo_menu (user, nick_submenu) || + !user->hostname || !user->realname || !user->servername; + + if (needs_refresh) + { + g_signal_connect (G_OBJECT (nick_submenu), "show", + G_CALLBACK (menu_nickinfo_cb), sess); + } } void