From e7baf0cba0e023574c3373243b2ad6fff20d1eef Mon Sep 17 00:00:00 2001 From: root Date: Tue, 22 Oct 2019 18:28:26 -0400 Subject: [PATCH] tidy password process - use chpasswd instead of perl's crypt - require password change on first login with chage --- makeuser | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/makeuser b/makeuser index 8f1e5d3..889eceb 100755 --- a/makeuser +++ b/makeuser @@ -32,14 +32,15 @@ case $1 in [[ $# -ne 3 ]] && error_exit "not enough args" if id $1 > /dev/null 2>&1; then - error_exit "user $1 already added" + exit 0 fi echo "adding new user $1" newpw=$(pwgen -1B 10) - pwcrypt=$(perl -e "print crypt('${newpw}', 'sa');") - sudo useradd -m -g 100 -p "$pwcrypt" -s /bin/bash $1 \ + sudo useradd -m -g 100 -s /bin/bash $1 \ || error_exit "couldn't add user" + echo "$1:$newpw" | sudo chpasswd + sudo chage -d 0 $1 echo "sending welcome mail" sed -e "s/newusername/$1/g" -e "s/newpassword/$newpw/" /usr/local/bin/welcome-email.tmpl \