From 6a85c918fcaf73380fb5ba27a67c3a0ca3605d74 Mon Sep 17 00:00:00 2001 From: khuxkm Date: Fri, 21 Sep 2018 14:29:21 -0400 Subject: [PATCH] Fix subprocess.run calls and replace libc crypt with crypt module --- makeuser | 12 +++++------- 1 file changed, 5 insertions(+), 7 deletions(-) diff --git a/makeuser b/makeuser index d8e39fc..81da90e 100755 --- a/makeuser +++ b/makeuser @@ -1,8 +1,6 @@ #!/usr/bin/python3 -import subprocess,argparse,random,string -from ctypes import cdll,c_char_p -libc = cdll.LoadLibrary("libc.so.6") +import subprocess,argparse,random,string,crypt parser = argparse.ArgumentParser(prog="makeuser",description="A user adding script.") parser.add_argument("username",help="Username of user.") @@ -11,8 +9,8 @@ parser.add_argument("key",help="The user's SSH pubkey.") args = parser.parse_args() pw = "".join(random.sample(string.ascii_letters+string.digits,20)) -cr = libc.crypt(pw) +cr = crypt.crypt(pw) -subprocess.run("sudo useradd -m -g 100 -p {} -s /bin/bash {}".format(cr,args.user) -subprocess.run("echo '{}' | sudo tee /home/{}/.ssh/authorized_keys".format(args.key,args.user)) -subprocess.run("sed -e 's/username/{}/' -e 's/password/{}/' email.tmpl | sendmail {} sudoers@tilde.team") +subprocess.run("sudo useradd -m -g 100 -p {} -s /bin/bash {}".format(cr,args.username),shell=True) +subprocess.run("echo '{}' | sudo tee /home/{}/.ssh/authorized_keys".format(args.key,args.username),shell=True) +subprocess.run("sed -e 's/username/{}/' -e 's/password/{}/' email.tmpl | sendmail {} sudoers@tilde.team",shell=True)